[
https://issues.apache.org/jira/browse/OFBIZ-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385518#comment-14385518
]
Pierre Smits edited comment on OFBIZ-6218 at 3/28/15 8:49 PM:
--
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385489#comment-14385489
]
Taher Alkhateeb commented on OFBIZ-6217:
bump. Please apply the corrected patch
[
https://issues.apache.org/jira/browse/OFBIZ-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385518#comment-14385518
]
Pierre Smits commented on OFBIZ-6218:
-
This might be related to something I am
Hi Adrian,
Would you not find it useful especially for those not experienced in data
structures and algorithms not to worry about picking the right implementation
for a list, map, set, tree or any other data structure by defaulting to what
the factory would yield? Furthermore, let's say you
Bump. Committers?
On Fri, 2015-03-27 at 19:33 -0500, Christian Carlow wrote:
Are git patches acceptable?
Hi Christian,
If this kind of patch is easily applyable, it will be accepted. No
problem if the patch is generated from git, svn or other system
(addonmanager for example).
Best Regards
Gil
On 28/03/2015 14:47, Deepak Dixit wrote:
Hi Christian,
You can create git patch using git diff
The git patches are just as easily applied as svn and created similarly
in eclipse. Git allows anyone to create local branches without needing
committer privilege. I just wanted to make sure that the switch
wouldn't prevent patches from being rejected.
On Sat, 2015-03-28 at 15:03 +0100, gil
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taher Alkhateeb updated OFBIZ-6217:
---
Attachment: warnings_patch_2.patch
fix warnings in trunk on java source code
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385241#comment-14385241
]
Taher Alkhateeb commented on OFBIZ-6217:
Hi Adrian,
Updated patch is available
[
https://issues.apache.org/jira/browse/OFBIZ-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385305#comment-14385305
]
Christian Carlow commented on OFBIZ-6175:
-
All events are deleted once the MRP is
The reason different implementations are used is because the
requirements are different. A HashMap is not always the correct Map
implementation to use.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 3/28/2015 11:28 AM, Taher Alkhateeb wrote:
Hi Adrian,
Would you not find it
Hi Christian,
You can create git patch using git diff —no-prefix, It will create patch
similar to svn diff.
I think it should be accepted. We can apply patch using patch -p0 file path
Others opinion ?
Thanks Regards
—
Deepak Dixit
On Mar 28, 2015, at 7:07 PM, Christian Carlow
On 28/03/2015 7:28 AM, Taher Alkhateeb wrote:
Hi Adrian,
Would you not find it useful especially for those not experienced in data
structures and algorithms not to worry about picking the right implementation
for a list, map, set, tree or any other data structure by defaulting to what
the
Arun Patidar created OFBIZ-6222:
---
Summary: Change the field name 'tenantId' to 'userTenantId' from
login page and ContextFilter
Key: OFBIZ-6222
URL: https://issues.apache.org/jira/browse/OFBIZ-6222
[
https://issues.apache.org/jira/browse/OFBIZ-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385174#comment-14385174
]
Adrian Crum commented on OFBIZ-6222:
That is a good idea! We had a similar problem
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taher Alkhateeb updated OFBIZ-6217:
---
Attachment: (was: wrong_suppress_and_voids.patch)
fix warnings in trunk on java source
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taher Alkhateeb updated OFBIZ-6217:
---
Attachment: warnings_patch_2.patch
fix warnings in trunk on java source code
[
https://issues.apache.org/jira/browse/OFBIZ-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385209#comment-14385209
]
Pierre Smits commented on OFBIZ-6175:
-
If the ftl can be replaced with a screen/form
Personally, I am opposed to making simple things like this overly
complicated. It is unlikely the Java collections API will change enough
to warrant a factory for every collection type.
Javolution was used in Java 1.4 to reduce the latency caused by garbage
collection. That is not a problem
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385231#comment-14385231
]
Taher Alkhateeb commented on OFBIZ-6217:
Hi Adrian,
Good catch. The reason I did
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385222#comment-14385222
]
Adrian Crum edited comment on OFBIZ-6217 at 3/28/15 10:34 AM:
--
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385239#comment-14385239
]
Adrian Crum commented on OFBIZ-6217:
Please provide an updated patch.
fix warnings
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385200#comment-14385200
]
Taher Alkhateeb commented on OFBIZ-6217:
I have created a new attachment called
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385200#comment-14385200
]
Taher Alkhateeb edited comment on OFBIZ-6217 at 3/28/15 9:01 AM:
[
https://issues.apache.org/jira/browse/OFBIZ-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385210#comment-14385210
]
Pierre Smits edited comment on OFBIZ-6175 at 3/28/15 9:40 AM:
--
[
https://issues.apache.org/jira/browse/OFBIZ-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385210#comment-14385210
]
Pierre Smits commented on OFBIZ-6175:
-
Where do 'Inventory Planned Events' go when
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum reassigned OFBIZ-6217:
--
Assignee: Adrian Crum
fix warnings in trunk on java source code
Hi All,
The move from javolution to the collections API built in to java proves to be
painful. To avoid such things in the future and to reduce the new keyword
clutter in the code I suggest we create factories for all collections. This way
we we can also enhance the collections in the future
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385222#comment-14385222
]
Adrian Crum commented on OFBIZ-6217:
Taher,
Thank you for working on this! One thing
29 matches
Mail list logo
