Hi Nameet,
I am assuming that you will not just change the entities but everything
like the services and events where necessary to ensure updating this field.
Am I correct in my understanding?
Taher Alkhateeb
On Saturday, 25 June 2016, Jacques Le Roux
wrote:
> +1
[
https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=12983046#comment-12983046
]
Jacques Le Roux edited comment on OFBIZ-1319 at 6/24/16 10:15 PM:
--
[
https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-1319:
---
Summary: Split javascript files to have more generic ones includable in all
screens, and the
[
https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-1319:
---
Description:
>From a David's E. Jones comment on ML :
We should split up javascript files to
+1
Jacques
Le 24/06/2016 à 15:26, Nameet Jain a écrit :
Hello everyone,
Currently in OFBiz, 'changedByUserLoginId' field is missing from status
entities (like: ShipmentStatus). Using this field we can maintain the
history for each status change made by user.
I will recommend here to add
[
https://issues.apache.org/jira/browse/OFBIZ-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-7188.
--
Resolution: Fixed
Fix Version/s: 13.07.04
15.12.01
[
https://issues.apache.org/jira/browse/OFBIZ-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348677#comment-15348677
]
Jacques Le Roux commented on OFBIZ-7358:
Only trunk was concerned (broken by OFBIZ-7170)
> In
[
https://issues.apache.org/jira/browse/OFBIZ-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nameet Jain updated OFBIZ-7602:
---
Attachment: CreateProduct.png
> Hide product sub menus while creating new product
>
[
https://issues.apache.org/jira/browse/OFBIZ-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nameet Jain updated OFBIZ-7602:
---
Priority: Minor (was: Major)
> Hide product sub menus while creating new product
>
Nameet Jain created OFBIZ-7602:
--
Summary: Hide product sub menus while creating new product
Key: OFBIZ-7602
URL: https://issues.apache.org/jira/browse/OFBIZ-7602
Project: OFBiz
Issue Type:
+1, Nameet.
Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Fri, Jun 24, 2016 at 6:56 PM, Nameet Jain
wrote:
> Hello everyone,
>
> Currently in OFBiz, 'changedByUserLoginId'
Rishi Solanki created OFBIZ-7601:
Summary: Enforce noninstantiability to UtilURL class
Key: OFBIZ-7601
URL: https://issues.apache.org/jira/browse/OFBIZ-7601
Project: OFBiz
Issue Type:
[
https://issues.apache.org/jira/browse/OFBIZ-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7590:
-
Attachment: OFBIZ-7590.patch
1. Class is already final.
2. Making below public variable as
[
https://issues.apache.org/jira/browse/OFBIZ-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-7600:
-
Attachment: OFBIZ-7600.patch
Providing patch as per the details mentioned in the ticket.
>
[
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7589:
-
Attachment: (was: OFBIZ-7589.patch)
> Enforce noninstantiability to UtilHttp class
>
[
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7589:
-
Attachment: OFBIZ-7589.patch
> Enforce noninstantiability to UtilHttp class
>
[
https://issues.apache.org/jira/browse/OFBIZ-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki reassigned OFBIZ-7600:
Assignee: Rishi Solanki
> Enforce noninstantiability to UtilPlist class
>
[
https://issues.apache.org/jira/browse/OFBIZ-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7590:
Assignee: Rohit Koushal
> Enforce noninstantiability to UtilIO class
>
Rishi Solanki created OFBIZ-7600:
Summary: Enforce noninstantiability to UtilPlist class
Key: OFBIZ-7600
URL: https://issues.apache.org/jira/browse/OFBIZ-7600
Project: OFBiz
Issue Type:
[
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7589:
-
Attachment: OFBIZ-7589.patch
Thanks [~rishisolankii] for the details. Here is the patch for the
[
https://issues.apache.org/jira/browse/OFBIZ-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348337#comment-15348337
]
Ashish Vijaywargiya edited comment on OFBIZ-7181 at 6/24/16 2:22 PM:
-
[
https://issues.apache.org/jira/browse/OFBIZ-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya closed OFBIZ-7181.
--
Resolution: Fixed
Fix Version/s: 13.07.04
15.12.01
[
https://issues.apache.org/jira/browse/OFBIZ-7347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya closed OFBIZ-7347.
--
Resolution: Fixed
Fix Version/s: 13.07.04
15.12.01
[
https://issues.apache.org/jira/browse/OFBIZ-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya closed OFBIZ-7358.
--
Resolution: Fixed
Fix Version/s: Upcoming Branch
Thanks Aman and Rahul for the
[
https://issues.apache.org/jira/browse/OFBIZ-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7589:
Assignee: Rohit Koushal
> Enforce noninstantiability to UtilHttp class
>
[
https://issues.apache.org/jira/browse/OFBIZ-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7587:
Assignee: Rohit Koushal
> Enforce noninstantiability to UtilFormatOut class
>
[
https://issues.apache.org/jira/browse/OFBIZ-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya closed OFBIZ-7596.
--
Resolution: Fixed
Fix Version/s: 13.07.04
15.12.01
[
https://issues.apache.org/jira/browse/OFBIZ-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya closed OFBIZ-7516.
--
Resolution: Fixed
Fix Version/s: 13.07.04
15.12.01
Ravi Lodhi created OFBIZ-7599:
-
Summary: Entered To Name is not getting stored when creating Party
Invitation
Key: OFBIZ-7599
URL: https://issues.apache.org/jira/browse/OFBIZ-7599
Project: OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya reassigned OFBIZ-7596:
--
Assignee: Ashish Vijaywargiya (was: Ravi Lodhi)
> Error on deleting Party
Thanks all for approval.
Thanks Taher and Deepak for valuable suggestions. I will think on them.
Jacques,
I am bit confused by your reply, could you please elaborate your point.
Regards,
--
Amardeep Singh Jhajj
On Fri, Jun 24, 2016 at 4:17 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com>
[
https://issues.apache.org/jira/browse/OFBIZ-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya closed OFBIZ-7556.
--
Resolution: Fixed
Fix Version/s: 15.12.01
14.12.01
Thanks
[
https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suraj Khurana updated OFBIZ-7598:
-
Attachment: OFBIZ-7598.png
> Empty header row should not render if list to render in file is
Suraj Khurana created OFBIZ-7598:
Summary: Empty header row should not render if list to render in
file is empty
Key: OFBIZ-7598
URL: https://issues.apache.org/jira/browse/OFBIZ-7598
Project: OFBiz
Suraj Khurana created OFBIZ-7597:
Summary: Entity auto services doesn't returns success message
Key: OFBIZ-7597
URL: https://issues.apache.org/jira/browse/OFBIZ-7597
Project: OFBiz
Issue
[
https://issues.apache.org/jira/browse/OFBIZ-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Lodhi updated OFBIZ-7596:
--
Attachment: OFBIZ-7596_trunk.patch
I looked around this issue and found that value="partyInvitationId"
[
https://issues.apache.org/jira/browse/OFBIZ-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil Shah closed OFBIZ-7374.
---
Thanks [~ankush.upadhyay] I have tested the fixes and found them working fine:
Unit Tests:
# Expired the
Yea I think it makes sense.
Thanks
--
Divesh Dutta.
On Fri, Jun 24, 2016 at 6:56 PM, Nameet Jain
wrote:
> Hello everyone,
>
> Currently in OFBiz, 'changedByUserLoginId' field is missing from status
> entities (like: ShipmentStatus). Using this field we can
Ravi Lodhi created OFBIZ-7596:
-
Summary: Error on deleting Party Invitation
Key: OFBIZ-7596
URL: https://issues.apache.org/jira/browse/OFBIZ-7596
Project: OFBiz
Issue Type: Bug
[
https://issues.apache.org/jira/browse/OFBIZ-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya closed OFBIZ-7524.
--
Resolution: Fixed
Fix Version/s: 13.07.04
15.12.01
[
https://issues.apache.org/jira/browse/OFBIZ-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7588:
-
Attachment: OFBIZ-7588.patch
Thanks [~rishisolankii] for the details. Here is the patch for the
[
https://issues.apache.org/jira/browse/OFBIZ-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7588:
Assignee: Rohit Koushal
> Enforce noninstantiability to UtilGenerics class
>
Hello everyone,
Currently in OFBiz, 'changedByUserLoginId' field is missing from status
entities (like: ShipmentStatus). Using this field we can maintain the
history for each status change made by user.
I will recommend here to add 'changedByUserLoginId' field to track the
userlogin detail. Here
[
https://issues.apache.org/jira/browse/OFBIZ-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya closed OFBIZ-6293.
--
Resolution: Fixed
Fix Version/s: 15.12.01
14.12.01
Thanks
[
https://issues.apache.org/jira/browse/OFBIZ-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anuj Jain updated OFBIZ-7584:
-
Attachment: OFBIZ-7584.patch
> Workeffort: Correct all the checkboxes and radio buttons in all the
>
[
https://issues.apache.org/jira/browse/OFBIZ-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348242#comment-15348242
]
Anuj Jain commented on OFBIZ-7584:
--
Hello [~Mohammad K],
Thanks for reporting this improvement, I have
[
https://issues.apache.org/jira/browse/OFBIZ-7252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya closed OFBIZ-7252.
--
Resolution: Fixed
Fix Version/s: 15.12.01
14.12.01
Thanks
Sanjay Yadav created OFBIZ-7595:
---
Summary: Replace references of Entity Engine methods with
EntityQUery methods in various Groovy and Java Files
Key: OFBIZ-7595
URL: https://issues.apache.org/jira/browse/OFBIZ-7595
[
https://issues.apache.org/jira/browse/OFBIZ-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gopal Yadav updated OFBIZ-7188:
---
Attachment: OFBIZ-7188.patch
Hi [~jacques.le.roux],
Thanks for reviewing the patch, I have corrected
[
https://issues.apache.org/jira/browse/OFBIZ-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7540:
Assignee: Rohit Koushal
> Enforce noninstantiability to FileUtil class
>
[
https://issues.apache.org/jira/browse/OFBIZ-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7562:
-
Attachment: OFBIZ-7562.patch
Thanks [~rishisolankii] for the details. Here is the patch for the
[
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankush Upadhyay updated OFBIZ-7518:
---
Attachment: OFBIZ-7518.patch
> Unable to create Product Store Roles from Party manager
>
[
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankush Upadhyay updated OFBIZ-7518:
---
Attachment: (was: OFBIZ-7518.patch)
> Unable to create Product Store Roles from Party
[
https://issues.apache.org/jira/browse/OFBIZ-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7562:
Assignee: Rohit Koushal
> Enforce noninstantiability to UtilDateTime class
>
[
https://issues.apache.org/jira/browse/OFBIZ-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7551:
-
Attachment: OFBIZ-7551.patch
Thanks [~rishisolankii] for the details. Here is the patch for the
[
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348195#comment-15348195
]
Ankush Upadhyay commented on OFBIZ-7518:
Thanks [~soledad] for patch review, yes seca call is more
[
https://issues.apache.org/jira/browse/OFBIZ-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal reassigned OFBIZ-7551:
Assignee: Rohit Koushal
> Enforce noninstantiability to SSLUtil class
>
[
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankush Upadhyay updated OFBIZ-7518:
---
Attachment: (was: RenderPartyAssignedRolesInDropDown.patch)
> Unable to create Product
[
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankush Upadhyay updated OFBIZ-7518:
---
Attachment: (was: EnsureAndCreateProductStoreRole.patch)
> Unable to create Product Store
[
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankush Upadhyay updated OFBIZ-7518:
---
Attachment: OFBIZ-7518.patch
> Unable to create Product Store Roles from Party manager
>
[
https://issues.apache.org/jira/browse/OFBIZ-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-7540:
-
Attachment: OFBIZ-7540.patch
Thanks [~rishisolankii] for the details. Here is the patch for the
Deepak Baghel created OFBIZ-7594:
Summary: Unable to delete a survey in project component
Key: OFBIZ-7594
URL: https://issues.apache.org/jira/browse/OFBIZ-7594
Project: OFBiz
Issue Type: Bug
[
https://issues.apache.org/jira/browse/OFBIZ-7518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankush Upadhyay reassigned OFBIZ-7518:
--
Assignee: Ankush Upadhyay
> Unable to create Product Store Roles from Party manager
>
Amardeep,
I agree with your points, I'd just request that we do that in a branch with a
load of UI tests (good occasion to use Selenium).
Our js code is complex and fragile, I think notably at the global variables in
fieldlookup.js and selectall.js which are maybe hard to avoid.
IMO those
[
https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gopal Yadav updated OFBIZ-7473:
---
Attachment: OFBIZ-7473.patch
Attached patch for this issue, in which I have corrected the location of
[
https://issues.apache.org/jira/browse/OFBIZ-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suraj Khurana updated OFBIZ-7563:
-
Attachment: OFBIZ-7563
Attached patch with proper fix. Increased section top-margin so that it
[
https://issues.apache.org/jira/browse/OFBIZ-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348120#comment-15348120
]
Pranay Pandey commented on OFBIZ-7592:
--
Hi Yash,
There is a best practice of naming patch that you
Rishi Solanki created OFBIZ-7593:
Summary: Enforce noninstantiability to UtilNumber class
Key: OFBIZ-7593
URL: https://issues.apache.org/jira/browse/OFBIZ-7593
Project: OFBiz
Issue Type:
[
https://issues.apache.org/jira/browse/OFBIZ-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pradhan Yash Sharma updated OFBIZ-7592:
---
Attachment: productfeature.patch
Please find patch for the issue.
> Show price
Hi Hans,
I stumbled upon this by chance, not sure how UpdateContentPurposeOperation is
supposed to work.
+
is not correct (misses the value-field attribute)
Thanks
Jacques
Le 24/08/2011 à 04:38, hans...@apache.org a écrit :
Author: hansbak
Date: Wed Aug 24 02:38:54 2011
New
Nameet Jain created OFBIZ-7592:
--
Summary: Show price column in supplier product lookup during PO
creation
Key: OFBIZ-7592
URL: https://issues.apache.org/jira/browse/OFBIZ-7592
Project: OFBiz
Rishi Solanki created OFBIZ-7591:
Summary: Enforce noninstantiability to UtilJavaParse class
Key: OFBIZ-7591
URL: https://issues.apache.org/jira/browse/OFBIZ-7591
Project: OFBiz
Issue Type:
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348054#comment-15348054
]
Divesh Dutta commented on OFBIZ-6576:
-
[~Peter Arnold] we can create a separate ticket for this
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348052#comment-15348052
]
Divesh Dutta commented on OFBIZ-6576:
-
Dear [~Peter Arnold] ,
You are right in terms of business
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divesh Dutta updated OFBIZ-6576:
Comment: was deleted
(was: Dear [~Peter Arnold] ,
You are right in terms of business definitions
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348053#comment-15348053
]
Divesh Dutta commented on OFBIZ-6576:
-
Dear [~Peter Arnold] ,
You are right in terms of business
Rishi Solanki created OFBIZ-7590:
Summary: Enforce noninstantiability to UtilIO class
Key: OFBIZ-7590
URL: https://issues.apache.org/jira/browse/OFBIZ-7590
Project: OFBiz
Issue Type:
Very good idea Amardeep. Big +1.
--
Kind Regards
Ashish Vijaywargiya
HotWax Systems - est. 1997
https://www.linkedin.com/in/ashishvijaywargiya1
On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:
> Hello everyone,
>
> Currently, OFBiz javascript
+1.
Rishi Solanki
Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
On Fri, Jun 24, 2016 at 2:13 PM, Divesh Dutta <
divesh.du...@hotwaxsystems.com> wrote:
> +1 Amardeep.
>
>
> Thanks
> --
> Divesh Dutta.
>
> On Fri, Jun 24,
Rishi Solanki created OFBIZ-7589:
Summary: Enforce noninstantiability to UtilHttp class
Key: OFBIZ-7589
URL: https://issues.apache.org/jira/browse/OFBIZ-7589
Project: OFBiz
Issue Type:
[
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348021#comment-15348021
]
Jacques Le Roux commented on OFBIZ-7576:
Yes both CAN be done, but replacing the bshInterpreter
[
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348019#comment-15348019
]
Jacques Le Roux commented on OFBIZ-7061:
Fixed at revision: 1750050 .It was the only case like
[
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348006#comment-15348006
]
Deepak Dixit edited comment on OFBIZ-7576 at 6/24/16 8:45 AM:
--
We can use
Rishi Solanki created OFBIZ-7588:
Summary: Enforce noninstantiability to UtilGenerics class
Key: OFBIZ-7588
URL: https://issues.apache.org/jira/browse/OFBIZ-7588
Project: OFBiz
Issue Type:
[
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348006#comment-15348006
]
Deepak Dixit commented on OFBIZ-7576:
-
We can use groovyShell instead of bshInterpreter, and than can
+1 Amardeep.
Thanks
--
Divesh Dutta.
On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:
> Hello everyone,
>
> Currently, OFBiz javascript code (except third party libraries) is not
> written with the best practices which can cause following
[
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348000#comment-15348000
]
Jacques Le Roux commented on OFBIZ-7576:
Yes, but the code would still be awful :/ It's not for
[
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347996#comment-15347996
]
Divesh Dutta commented on OFBIZ-7576:
-
Thanks [~jacques.le.roux] for committing this patch . If you
Rishi Solanki created OFBIZ-7587:
Summary: Enforce noninstantiability to UtilFormatOut class
Key: OFBIZ-7587
URL: https://issues.apache.org/jira/browse/OFBIZ-7587
Project: OFBiz
Issue Type:
[
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347993#comment-15347993
]
Jacques Le Roux commented on OFBIZ-7576:
Wait... because of Jira stubbornly not refreshing (I
Hi Amardeep,
I agree with you current js code is not written as per the best practice.
Here are some inputs from my side.
Please see comments inline:
On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:
> Hello everyone,
>
> Currently, OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347988#comment-15347988
]
Swapnil M Mane commented on OFBIZ-7061:
---
Thanks [~jacques.le.roux]!
> Autocompletion for Compound
Team,
We have started pushing changes into trunk, in case anyone would like to
review then we are keeping it very simple;
- For any class we have an sub ticket with class name.
- On the ticket description we are posting the changes needs to be done,
then discuss and finalize the changes.
- Upload
+1 for the recommendation Amardeep.
Best regards,
Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/
On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:
> Hello everyone,
>
> Currently, OFBiz javascript code (except third party libraries)
[
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347972#comment-15347972
]
Deepak Dixit commented on OFBIZ-7576:
-
Hi [~jacques.le.roux],
I think we can replace the
[
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347964#comment-15347964
]
Jacques Le Roux commented on OFBIZ-7061:
Thanks Swapnil,
Actually this was lost earlier in
[
https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Montalbano Florian updated OFBIZ-7576:
--
Attachment: OFBIZ-7576_proposition.patch
Hi,
I was wondering the difference between the
and +1 for your recommendations
On Friday, 24 June 2016, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:
> Hello everyone,
>
> Currently, OFBiz javascript code (except third party libraries) is not
> written with the best practices which can cause following problems -
>
> 1.
Hi Amardeep,
In my opinion, the absolute best thing you can do for JavaScript is to run
it through jslint. If you are serious about the work, I would suggest you
take all the JavaScript files and snippets inside FTL files and run them
inside jslint and fix the issues one by one. That would
+1 for 1 option (yes, I'm lazy). Of course people preferring the std groovy
snippet could continue to use it :p
Jacques
Le 24/06/2016 à 09:14, Nicolas Malin a écrit :
Le 24/06/2016 09:00, jler...@apache.org a écrit :
+
This commit is fine and when I read it, I ask myself if
1 - 100 of 110 matches
Mail list logo