Thank you Sharan and Deepak :)
- Best Regards,
Swapnil
On Fri, Mar 31, 2017 at 1:41 PM, Sharan Foga wrote:
> Thanks Deepak! You beat me to it :-)
>
> Thanks
> Sharan
>
> On 31/03/17 10:08, Deepak Dixit wrote:
>
>> +1 Swapnil
>>
>> Done
>>
>>
>> Thanks & Regards
>> --
>> Deepak Dixit
>> www.hot
Things got diluted then
https://lists.apache.org/list.html?dev@ofbiz.apache.org:gte=5y:815651
It's hard to review long patches, for instance have a look at
https://issues.apache.org/jira/browse/OFBIZ-9254
In this case it might look simple, but it's kinda hypnotic. Looking always at
the same pa
+1
Jacques
Le 31/03/2017 à 22:26, Michael Brohl a écrit :
Taher,
I fully agree, I've already filed a Jira:
https://issues.apache.org/jira/browse/OFBIZ-9292
Cheers,
Michael
Am 31.03.17 um 22:23 schrieb Taher Alkhateeb:
Indeed, copy and paste pattern is where I got mixed up. This whole bl
Taher,
I fully agree, I've already filed a Jira:
https://issues.apache.org/jira/browse/OFBIZ-9292
Cheers,
Michael
Am 31.03.17 um 22:23 schrieb Taher Alkhateeb:
Indeed, copy and paste pattern is where I got mixed up. This whole block at
the top (the first try / catch) needs to be refactored
BTW, this groovy implementation is a good argument for RTC. This code
should have never been committed.
Regards,
Michael
Am 31.03.17 um 20:00 schrieb Michael Brohl:
Hi Jacques,
I think this is a functional change because you not only print the
exception to the error log but you also put it
Indeed, copy and paste pattern is where I got mixed up. This whole block at
the top (the first try / catch) needs to be refactored. Either it was
copied from below or vice versa. Also I think the script needs to be
refactored, the logic is kind of all over the place for validation and
transaction m
BTW I forgot to thank you for your review.
Jacques
Le 31/03/2017 à 21:17, Jacques Le Roux a écrit :
Hi Michael,
Le 31/03/2017 à 20:00, Michael Brohl a écrit :
Hi Jacques,
I think this is a functional change because you not only print the exception to the error log but you also put it in the
BTW I forgot to thank you for your review. I think you mixed the new snippet
with the one above from where I C/P.
Jacques
Le 31/03/2017 à 21:16, Jacques Le Roux a écrit :
Le 31/03/2017 à 19:16, Taher Alkhateeb a écrit :
I'm not sure why you're using a fixed name instead of the field name
fet
Ah I totally forgot to mention that this also removes the swallowed exception that we had in ModelFormAction and ModelTreeAction, but not in
ModelActionUtil from where I extracted the method
It's now consistent and if ever, for a very unlikely reason, the exception is
thrown, people will know a
Hi Michael,
Le 31/03/2017 à 20:00, Michael Brohl a écrit :
Hi Jacques,
I think this is a functional change because you not only print the exception to the error log but you also put it in the errorMsgList. In this way,
the error is printed to the user interface. This might not be intended becau
Le 31/03/2017 à 19:16, Taher Alkhateeb a écrit :
I'm not sure why you're using a fixed name instead of the field name
fetching mechanism, especially that this is a loop.
VIEW_SIZE is a well known name for OFBiz developers and Michael is right we
don't need to show a such error in UI. I see no l
Hi Jacques,
I think this is a functional change because you not only print the
exception to the error log but you also put it in the errorMsgList. In
this way, the error is printed to the user interface. This might not be
intended because the VIEW_SIZE controls the number of entries in the
be
I'm not sure why you're using a fixed name instead of the field name
fetching mechanism, especially that this is a loop.
Also, I'm not sure the entire try / catch block is necessary. What test
made you believe you need to hard code the field in here?
On Fri, Mar 31, 2017 at 8:00 PM, wrote:
> Au
The Buildbot has detected a new failure on builder ofbiz-branch14 while
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-branch14/builds/356
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler sch
The Buildbot has detected a new failure on builder ofbiz-branch15 while
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-branch15/builds/321
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler sch
Thanks Deepak! You beat me to it :-)
Thanks
Sharan
On 31/03/17 10:08, Deepak Dixit wrote:
+1 Swapnil
Done
Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
On Fri, Mar 31, 2017 at 1:32 PM, Swapnil Mane wrote:
Hello team,
OFBiz Chat Room (HipChat) (https://apache.hipchat.com/chat/ro
Hi Sharan.
I beat you ;)
done at r#r1789628
Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
On Fri, Mar 31, 2017 at 1:36 PM, Sharan Foga wrote:
> Hi Swapnil
>
> Yes you're right, that link needs changing to the one you specified. I'll
> see if I can do it now (unless someone beats me to
+1 Swapnil
Done
Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
On Fri, Mar 31, 2017 at 1:32 PM, Swapnil Mane wrote:
> Hello team,
>
> OFBiz Chat Room (HipChat) (https://apache.hipchat.com/chat/room/2814115)
> link provided on the site http://ofbiz.apache.org/ is of OFBiz chat room
> i
Hi Swapnil
Yes you're right, that link needs changing to the one you specified.
I'll see if I can do it now (unless someone beats me to it!)
Thanks
Sharan
On 31/03/17 10:02, Swapnil Mane wrote:
Hello team,
OFBiz Chat Room (HipChat) (https://apache.hipchat.com/chat/room/2814115)
link provide
Hello team,
OFBiz Chat Room (HipChat) (https://apache.hipchat.com/chat/room/2814115)
link provided on the site http://ofbiz.apache.org/ is of OFBiz chat room
i.e. (only the member of this room are able to see the chats)
So, should we add guest access link their i.e. https://www.hipchat.com/
g4vOa
20 matches
Mail list logo
