Re: Quantity UOM in Supplier Product

2017-08-14 Thread pierre
Hi all, We made something very similar. We use this information of purchasing orders until the reception. I am going to supply a patch and more details of what we made in the course of September (at present I am on holidays) Is there Jira to propose a patch? Many thanks Pierre On

Re: Request for enhance entity:SystemProperty.

2017-08-14 Thread Wai
Since entity:UserPreference provides a reference to entity:UserLogin, it seems a good fit for what I need. You implied that a party-based preference would be more appropriate. What would be the advantage of a party-based version. If I were to use a party-based version then I would have to create

Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

2017-08-14 Thread Nicolas Malin
done :) Le 14/08/2017 à 23:10, Jacques Le Roux a écrit : I guess just a mention of the commit, and its reason, in OFBIZ-9577 should be enough Thanks Jacques Le 14/08/2017 à 20:33, Nicolas Malin a écrit : Not really, I detect it effectively during some trying related to the OFBIZ-9577but

Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

2017-08-14 Thread Jacques Le Roux
I guess just a mention of the commit, and its reason, in OFBIZ-9577 should be enough Thanks Jacques Le 14/08/2017 à 20:33, Nicolas Malin a écrit : Not really, I detect it effectively during some trying related to the OFBIZ-9577but actually I didn't detect any problem with that in the

Re: [Proposal] - Leverage the CMS capability for Product Store's Email

2017-08-14 Thread Nicolas Malin
Hello Swapnil, in line Le 14/08/2017 à 04:35, Swapnil Mane a écrit : Thank you Nicolas for your inputs and interest. I highly appreciate it. Based on my understanding, please see my comments inline and let me know if you have further inputs. On Fri, Aug 11, 2017 at 3:10 PM, Nicolas Malin

Re: Permission service not on the same transaction

2017-08-14 Thread Nicolas Malin
Hi Jacques, All is present on the issue OFBIZ-7113 But I think the patch doesn't up to date. It contains big change, I will review quietly if you think it would be a good improvement Nicolas Le 12/08/2017 à 10:23, Jacques Le Roux a écrit :

Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

2017-08-14 Thread Nicolas Malin
Not really, I detect it effectively during some trying related to the OFBIZ-9577but actually I didn't detect any problem with that in the framework. So I corrected it because it's a easy framework error. If you think it's interesting to open an issue, I can do that Nicolas Le 14/08/2017 à

Re: [DISCUSSION] Improving our Monthly Blog Post Template

2017-08-14 Thread Michael Brohl
Hi Sharan, that sounds perfect :-) Regards, Michael Am 14.08.17 um 18:10 schrieb Sharan Foga: Hi Michael I've taken a quick look around on the blog admin settings menu and it looks like we could create a new theme by importing a custom stylesheet. I can ask Kenneth (who has been helping

Re: svn commit: r1805011 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model/ModelFormField.java

2017-08-14 Thread Jacques Le Roux
Ha got it OFBIZ-9577 Jacques Le 14/08/2017 à 19:38, Jacques Le Roux a écrit : Good catch Nicolas, Should there not be a related Jira? Thanks Jacques Le 14/08/2017 à 17:47, nma...@apache.org a écrit : Author: nmalin Date: Mon Aug 14 15:47:36 2017 New Revision: 1805011 URL:

Re: Request for enhance entity:SystemProperty.

2017-08-14 Thread Wai
The confusion was my original posting containing 2 separate items. 1) request to add readWriteType and valueType into entity:SystemProperty. 2) A question about user specific properties. This reply addresses item#1. I request to add 2 fields called readWriteType (formerly called accessType) and

Re: [DISCUSSION] Improving our Monthly Blog Post Template

2017-08-14 Thread Sharan Foga
Hi Michael I've taken a quick look around on the blog admin settings menu and it looks like we could create a new theme by importing a custom stylesheet. I can ask Kenneth (who has been helping with the layout of the new website) about it to see if there is any formatting we can easily pick

Re: Rule to deprecated a service

2017-08-14 Thread Jacques Le Roux
Thanks Nicolas :) It's with mine at least and I guess Jacopo's, Scott's and Deepak's, right guys? W/o answers I will soon consider the status quo a consensus ans will write the rules in wiki Jacques Le 14/08/2017 à 14:51, Nicolas Malin a écrit : Le 14/08/2017 à 07:48, Deepak Dixit a écrit

Re: [DISCUSSION] Improving our Monthly Blog Post Template

2017-08-14 Thread Jacques Le Roux
+1 for those ideas Jacques Le 14/08/2017 à 17:44, Michael Brohl a écrit : Hi Sharan, yes, it's time for an update. I think the current templates' font is much too small to have a good reading experience. The Carbondata theme has the same problem, the Nifi theme looks better but I think

Re: [DISCUSSION] Improving our Monthly Blog Post Template

2017-08-14 Thread Michael Brohl
Hi Sharan, yes, it's time for an update. I think the current templates' font is much too small to have a good reading experience. The Carbondata theme has the same problem, the Nifi theme looks better but I think there is room for improvement also. I have no clue how to change or alter the

Re: [DISCUSSION] Improving our Monthly Blog Post Template

2017-08-14 Thread Pranay Pandey
Hi Sharan, Yes, these are looking clean. We should definitely experiment. I would say, if we can have a blog template having similar look and feel as of our new website theme, that would be awesome. Thoughts? Best regards, Pranay Pandey On Mon, Aug 14, 2017 at 8:56 PM, Sharan Foga

Re: [DISCUSSION] Improving our Monthly Blog Post Template

2017-08-14 Thread Swapnil Mane
Firstly, thank you Sharan and team for taking care of this. +1 for improving the look and feel, we should update the blog template. - Best Regards, Swapnil M Mane www.hotwaxsystems.com www.hotwax.co On Mon, Aug 14, 2017 at 8:56 PM, Sharan Foga wrote: > Hi All > > I

[DISCUSSION] Improving our Monthly Blog Post Template

2017-08-14 Thread Sharan Foga
Hi All I received some feedback about improving the look and feel of our currently monthly blog posts. We currently use the standard ASF default template but we could change the template or update it to give it a more modern look. A couple projects seem to have already started using

Re: Keep deleteProductionRunRoutingTask?

2017-08-14 Thread Jacques Le Roux
Thanks Gil, Inline Le 14/08/2017 à 15:50, gil portenseigne a écrit : Hi Jacques, In my opinion when I read deleteWorkEffort i'm expecting an entity-auto service, that will remove my workEffort entry from database. +1 In this case it's removing the workEffort and all related entity, so i

Re: svn commit: r1804859 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apac he/ofbiz/accounting/payment/GiftCertificateServices.java

2017-08-14 Thread Jacques Le Roux
Thanks Gil, Got it now :) BTW what do you think about my 1st comment at https://issues.apache.org/jira/browse/OFBIZ-9572 Jacques Le 14/08/2017 à 16:30, gil portenseigne a écrit : Hello Jacques, The reason why no assignment is good here, is that the assignment value will never be used,

Re: svn commit: r1804859 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/GiftCertificateServices.java

2017-08-14 Thread gil portenseigne
Hello Jacques, The reason why no assignment is good here, is that the assignment value will never be used, since the value is always overwritten with another assignment before it is used. It's the same with : String refNum = null; lines : 228 and 305. Gil On 12/08/2017 09:59,

Re: Keep deleteProductionRunRoutingTask?

2017-08-14 Thread gil portenseigne
Hi Jacques, In my opinion when I read deleteWorkEffort i'm expecting an entity-auto service, that will remove my workEffort entry from database. In this case it's removing the workEffort and all related entity, so i propose to rename the service to removeWorkEffortAndRelated. This service

Re: Request for enhance entity:SystemProperty.

2017-08-14 Thread gil portenseigne
Hello Wai, To try to better understand your examples, i will reformulate : * A user can access a functionality using an oauth2 settings that is configured only by an administrator ? But the concerned user can view it. The way i would implement that is using *security group* granting

Re: Request for enhance entity:SystemProperty.

2017-08-14 Thread Nicolas Malin
Hello Wai, My apologies, I read, reread your response but I didn't understand your example :( Maybe I wrong but I already have the feel in your problematic isn't only a technical problem and I'm more in favor the anaylse more UserPreference, with party relation instead of change a low brick

Re: Remove ByteWrapper class

2017-08-14 Thread Nicolas Malin
deprecated before apache integration :) so +1 Le 13/08/2017 à 16:44, Jacques Le Roux a écrit : Hi, Here is a comment from David in 2007 in the ByteWrapper class * @deprecated * NOTE DEJ20071022: deprecating this because we want to save the byte[] directly instead of inside a serialized *

Re: GLOBAL_PREFERENCES

2017-08-14 Thread Nicolas Malin
+1 GLOBAL_PREFERENCES is used by the framework so it should be present on the low level. Nicolas Le 13/08/2017 à 17:20, Jacques Le Roux a écrit : Hi, Do we really need a redundancy in party for GLOBAL_PREFERENCES ? We have this line twice in party and common description="Global

Re: Rule to deprecated a service

2017-08-14 Thread Nicolas Malin
Le 14/08/2017 à 07:48, Deepak Dixit a écrit : Thank Jacques, The code that has been deprecated before December 2014 will be released in the releases of the 14.12 branch: in this way users will be notified about deprecated methods/code. I am also on same page . We tag code deprecated as a

Re: Rule to deprecated a service

2017-08-14 Thread Jacques Le Roux
Thanks Deepak, You said > We tag code deprecated as a part of release and these code will be removed from next release. I agree this is the process once we have removed all deprecated stuff. But there still are older stuff pending. So we need 1st to remove all what is deprecated to simply

Re: [FYI] Let's encrypt certificate renewal failed

2017-08-14 Thread Jacques Le Roux
Thanks Richard, I'll speak about it with the ASF infra team Jacques Le 14/08/2017 à 13:29, Richard Siddall a écrit : Jacques, Sorry, that was the README.md on the GetSSL project, https://github.com/srvrco/getssl/blob/master/README.md, which is what GitHub displays when you go to

Re: [FYI] Let's encrypt certificate renewal failed

2017-08-14 Thread Richard Siddall
Jacques, Sorry, that was the README.md on the GetSSL project, https://github.com/srvrco/getssl/blob/master/README.md, which is what GitHub displays when you go to https://github.com/srvrco/getssl. There are tons of Let's Encrypt clients out there. The infra team may not have looked at

Re: Quantity UOM in Supplier Product

2017-08-14 Thread Vaibhav Jain
Hello Scott, Thank you very much for your continuous efforts on this discussion.Please check comments inline On Mon, Aug 14, 2017 at 11:50 AM, Scott Gray wrote: > Hi Vaibhav, > > Comments inline. > > Regards > Scott > > On 11 August 2017 at 02:55, Vaibhav Jain

buildbot success in on ofbiz-trunk-framework-plugins

2017-08-14 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/338 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build

buildbot exception in on ofbiz-trunk-framework-plugins

2017-08-14 Thread buildbot
The Buildbot has detected a build exception on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/337 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build

Re: svn commit: r1804864 - /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apac he/ofbiz/accounting/payment/GiftCertificateServices.java

2017-08-14 Thread Jacques Le Roux
Hi Michael, All, Actually I think a better use of ZERO is possible. See my 1st comment at https://issues.apache.org/jira/browse/OFBIZ-9572 I believe the case we have in GiftCertificateServices class (no use of setScale() like below) and in few other classes is simply cargo cult w/o use of

Re: Quantity UOM in Supplier Product

2017-08-14 Thread Jacques Le Roux
Thanks Scott, Inline too Le 14/08/2017 à 08:20, Scott Gray a écrit : Hi Vaibhav, Comments inline. Regards Scott On 11 August 2017 at 02:55, Vaibhav Jain wrote: Thank you so much Scott for sharing these details, indeed they are really helpful. Kindly see

Re: [FYI] Let's encrypt certificate renewal failed

2017-08-14 Thread Jacques Le Roux
Thanks Richard, That's interesting. Which README are you speaking about ? I guess the infra team is aware, but maybe we could push in this direction... Jacques Le 13/08/2017 à 17:03, Richard Siddall a écrit : I have been using GetSSL (https://github.com/srvrco/getssl) instead of the old

Re: [FYI] Let's encrypt certificate renewal failed

2017-08-14 Thread Jacques Le Roux
Yes thanks Pierre, Actually Chris did it then (On Fri, Aug 4, 2017 at 4:29 PM). Maybe we will need to ask again in 3 months. It's the 2nd time I do that. I simply ask for help in HipChat Infra room. Jacques Le 14/08/2017 à 09:21, Pierre Smits a écrit : Hey Jacques, It seems to be correct

Re: [Proposal] - Leverage the CMS capability for Product Store's Email

2017-08-14 Thread Pranay Pandey
Good idea +1. Best regards, Pranay Pandey www.hotwaxsystems.com www.hotwax.co On Fri, Aug 11, 2017 at 11:31 AM, Swapnil Mane < swapnil.m...@hotwaxsystems.com> wrote: > Hello Devs, > > While looking into the support of email templates for Product Store, we > found it is managed by screens. > >

Re: [FYI] Let's encrypt certificate renewal failed

2017-08-14 Thread Pierre Smits
Hey Jacques, It seems to be correct again for: - https://demo-trunk.ofbiz.apache.org - https://demo-stable.ofbiz.apache.org - https;//demo-old.ofbiz.apache.org The expiration date is now: Nov 2nd, 2017 Best regards, Pierre Smits ORRTIZ.COM OFBiz based

Re: Quantity UOM in Supplier Product

2017-08-14 Thread Scott Gray
Hi Vaibhav, Comments inline. Regards Scott On 11 August 2017 at 02:55, Vaibhav Jain wrote: > Thank you so much Scott for sharing these details, indeed they are really > helpful. > Kindly see my comments inline. > > > On Thu, Aug 10, 2017 at 3:22 PM, Scott Gray