Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/of biz/order/order/OrderReadHelper.java

Yes thanks Michael, I agree with Scott about rather throwing an exception Jacques Le 04/09/2017 à 21:28, Michael Brohl a écrit : Hi Jacques, I think directly returning the result inside the catch block changes the logic of the code (the adjustments are not added). Please have another

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReadHelper.java

Definitely changes the behavior, but the behavior wasn't good before (and still isn't good now). If we can't return an accurate order item sub-total then we should be throwing an exception IMO. This is often why we can't just bulk fix the issues reported by static analysis tools, because the fix

Re: svn commit: r1807045 - /ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbi z/common/CommonEvents.java

I'll contribute a patch. Thanks. -- Sent from: http://ofbiz.135035.n4.nabble.com/OFBiz-Dev-f165671.html

Re: svn commit: r1807240 - /ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReadHelper.java

Hi Jacques, I think directly returning the result inside the catch block changes the logic of the code (the adjustments are not added). Please have another look. Thanks, Michael Am 04.09.17 um 17:12 schrieb jler...@apache.org: Author: jleroux Date: Mon Sep 4 15:12:23 2017 New Revision:

Re: svn commit: r1807045 - /ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbi z/common/CommonEvents.java

Hi Wai (I suppose :)) Do you want to contribute your changes? Else you can do that on your custom project w/o needing to change in OOTB. Jacques Le 04/09/2017 à 15:01, bzb.of...@gmail.com a écrit : I'm deriving from CommonEvents.java and creating a new method that calls

Re: svn commit: r1807045 - /ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbi z/common/CommonEvents.java

I'm deriving from CommonEvents.java and creating a new method that calls CommonEvent.writeJSONtoResponse(). Unfortunately, CommonEvent.writeJSONtoResponse() is private. Hence, I could not compile. I believe that methods that should not be accessible from other classes should at least allow

Re: Importance of programming in our community

Nice write-up Taher. Yes, your thoughts are making sense to me. I would like to add one more point from my side is, using DSL make learning curve steeper for the newbies to the framework. Thanks and Regards -- Pritam Kute On Mon, Sep 4, 2017 at 3:50 PM, Taher Alkhateeb

Re: Extending a form which uses auto-fields-service

Before I open a Jira for that, please raise a hand if you know this problem is somehow solved Thanks Jacques Le 27/06/2010 à 11:00, Ravindra Mandre a écrit : Yes , you are right but the problem is not of position, the problem is that , when I use the tag then fields are arranged in the way

Importance of programming in our community

Hello everyone, I've been thinking for a few weeks about this topic, so I thought I'd just share my thoughts here. OFBiz has great DSL, it is a blessing, it makes things easier OFBiz has great DSL, it is a curse, it makes things sloppy I think OFBiz is unique and it's rare to find software

Re: Packing using backorder reservations?

Thanks Jacques. I did know that :( . On 4 September 2017 at 18:52, Jacques Le Roux wrote: > Hi Paul, > > I did not review yet, but by and large you should rather refer to > ofbiz-framework > > https://github.com/apache/ofbiz-framework/blob/trunk/applica >

Re: Packing using backorder reservations?

Hi Paul, I did not review yet, but by and large you should rather refer to ofbiz-framework https://github.com/apache/ofbiz-framework/blob/trunk/applications/product/src/main/java/org/apache/ofbiz/shipment/packing/PackingSession.java#L132 ;) Jacques Le 04/09/2017 à 08:58, Paul Foxworthy a

Packing using backorder reservations?

Hi all, Please have a look at the code at https://github.com/apache/ofbiz/blob/trunk/applications/product/src/main/java/org/apache/ofbiz/shipment/packing/PackingSession.java#L132 I have been testing a situation where there are three serialized items in stock, and three on back order. So there

Re: svn commit: r1807045 - /ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbi z/common/CommonEvents.java

Wai has asked about this discussion, let's wait to see what he has to say Jacques Le 04/09/2017 à 08:22, Taher Alkhateeb a écrit : It's not a matter of impact, it's a matter of principle. You don't leave code in a worse state for no valid reason. People are working very hard to refactor the

Re: svn commit: r1807045 - /ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbi z/common/CommonEvents.java

It's not a matter of impact, it's a matter of principle. You don't leave code in a worse state for no valid reason. People are working very hard to refactor the code to decrease the entropy, not increase it. On Sep 3, 2017 3:45 PM, "Jacques Le Roux" wrote: Reverted

Re: svn commit: r1806907 - /ofbiz/site/.htaccess

A right Deepak, my bad, I need to eat more vegetables :) Thank you for the clarification. On Sep 4, 2017 8:58 AM, "Deepak Dixit" wrote: Hi Taher, I think you are saying different thing, Here redirect rule is for old url those are not exists in current site.