Re: Alternative UI using Vaadin as ofbiz user interface

2017-09-29 Thread Nicolas Malin
Hi Hans, If it's too complicate for you to migrate your current works on the common-theme structure, please open an issue with your current patch I will check if it's possible to support it by common-theme or if the framework need some improvement to realize that. Cheers, Nicolas Le

Re: Rule to deprecated a service

2017-09-29 Thread Nicolas Malin
Thanks for the work Jacques. Nicolas Le 29/09/2017 à 09:49, Jacques Le Roux a écrit : Done at https://s.apache.org/12Uq Jacques Le 14/08/2017 à 18:05, Jacques Le Roux a écrit : Thanks Nicolas :) It's with mine at least and I guess Jacopo's, Scott's and Deepak's, right guys? W/o

Re: All roleType entities should maintain lifespan

2017-09-29 Thread Nicolas Malin
Add lifespan to PartyRole seems to me just to complex perhaps impossible. If you want indicate (as example) that a party is a customer from / to with a lifespan on PartyRole they missing the information customer from who ? PartyRole is a technical entity as functional entity (it's border line

Re: Security group permission association must have date range

2017-09-29 Thread Nicolas Malin
No objection on this +1 Nicolas Le 28/09/2017 à 10:05, Suraj Khurana a écrit : Hello, There might be many scenarios in the real business that you need to maintain specific permission to a specific group for some specified time only. Like at the time of business expansion, permission related

Re: Security group permission association must have date range

2017-09-29 Thread Aditya Sharma
+1 Thanks and Regards, *Aditya Sharma* | Enterprise Software Engineer HotWax Systems On Fri, Sep 29, 2017 at 2:38 PM, Devanshu Vyas wrote: > +1 Suraj. > > Thanks & Regards, >

Re: Security group permission association must have date range

2017-09-29 Thread Devanshu Vyas
+1 Suraj. Thanks & Regards, Devanshu Vyas. On Fri, Sep 29, 2017 at 2:34 PM, Vaibhav Jain < vaibhav.j...@hotwaxsystems.com> wrote: > +1 Suraj > > Vaibhav Jain > Hotwax Systems, > vaibhav.j...@hotwaxsystems.com > > On Thu, Sep 28, 2017 at 1:35 PM, Suraj Khurana < >

Re: Security group permission association must have date range

2017-09-29 Thread Vaibhav Jain
+1 Suraj Vaibhav Jain Hotwax Systems, vaibhav.j...@hotwaxsystems.com On Thu, Sep 28, 2017 at 1:35 PM, Suraj Khurana < suraj.khur...@hotwaxsystems.com> wrote: > Hello, > > There might be many scenarios in the real business that you need to > maintain specific permission to a specific group for

Missing/Incomplete View Order Image Feature

2017-09-29 Thread Devanshu Vyas
Hello Devs, I found (View Image) buttons on order view page on demo instance , and I was curious to find no such UI in the application to associate an image to order. I explored the button history and tried to find

Re: svn commit: r1810056 [1/2] - in /ofbiz: ofbiz-framework/trunk/build.gradle tools/security/dependency-check/dependency-check-report.html

2017-09-29 Thread Jacques Le Roux
Ha sorry, These are unsuccessful WIP Just noticed it also on my side while reviewing (again) my last commits, removed at r1810062 Jacques Le 29/09/2017 à 09:32, Taher Alkhateeb a écrit : Why did you apply the jdeps and codenarc plugins? Why did you add commented out code? What's this all

Re: All roleType entities should maintain lifespan

2017-09-29 Thread Scott Gray
Hi Suraj, I still haven't seen an example of a useful use case for adding from/thruDate fields to the PartyRole table. Did you have anything in mind that it might help with? I'd honestly prefer to remove it rather than expand it. Regards Scott On 29 September 2017 at 20:41, Suraj Khurana <

Re: Rule to deprecated a service

2017-09-29 Thread Jacques Le Roux
Done at https://s.apache.org/12Uq Jacques Le 14/08/2017 à 18:05, Jacques Le Roux a écrit : Thanks Nicolas :) It's with mine at least and I guess Jacopo's, Scott's and Deepak's, right guys? W/o answers I will soon consider the status quo a consensus ans will write the rules in wiki Jacques

All roleType entities should maintain lifespan

2017-09-29 Thread Suraj Khurana
Hello, There has been already a discussion under OFBIZ-5959 regarding this. I would like to bring this point again into attention and would like to suggest that we should introduce lifespan to all such entities. Also, PartyRole FK constraint

Re: svn commit: r1810056 [1/2] - in /ofbiz: ofbiz-framework/trunk/build.gradle tools/security/dependency-check/dependency-check-report.html

2017-09-29 Thread Taher Alkhateeb
Why did you apply the jdeps and codenarc plugins? Why did you add commented out code? What's this all about? On Fri, Sep 29, 2017 at 9:59 AM, wrote: > Author: jleroux > Date: Fri Sep 29 06:59:45 2017 > New Revision: 1810056 > > URL: