Re: Sending mail from Ofbiz does not work

2018-02-15 Thread Jacques Le Roux
This could be a solution for this specific problem if we get a consensus.  OFBIZ-7754 is related To summarize: the problem is, because of OFBIZ-7112, if you use the same seeds than in 13.07 you will get nothing which can even be more confusing. That's why we have values in SystemProperty, this

Re: MD5 removing?

2018-02-15 Thread Paul Foxworthy
Thanks Jacques. I bet it is the OpenSSL syntax which is documented here: https://www.openssl.org/docs/man1.0.2/apps/ciphers.html . Cheers Paul Foxworthy On 16 February 2018 at 01:43, Jacques Le Roux wrote: > Done with OFBIZ-10223 > > Jacques > > > > Le

Re: MD5 removing?

2018-02-15 Thread Jacques Le Roux
Done with OFBIZ-10223 Jacques Le 15/02/2018 à 15:32, Jacques Le Roux a écrit : Thanks Paul, It did not occur to me that the ! in MD5 was to prevent the use of MD5 :) I must say that the syntax is not explained in Tomcat doc (or at least I could not find it, even Googling everywhere)

Re: MD5 removing?

2018-02-15 Thread Jacques Le Roux
Thanks Paul, It did not occur to me that the ! in MD5 was to prevent the use of MD5 :) I must say that the syntax is not explained in Tomcat doc (or at least I could not find it, even Googling everywhere) Anyway I tried

Re: svn commit: r1824294 - in /ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility: facility/CountFacilityInventoryByProduct.groovy facility/ViewFacilityInventoryByProduct.groovy s

2018-02-15 Thread Michael Brohl
Hi Jacques, do you think that it is appropriate to present the user an error message to check the log? Normal users won't have access to the log in a productive environment I guess. The message should contain a qualified information what was wrong. The message is also not translated by

Re: Rat flag for failure or success

2018-02-15 Thread Jacques Le Roux
Thanks Jochen, I'll have a look on how to use that in Buildbot Jacques Le 15/02/2018 à 11:23, Jochen Wiedmann a écrit : See numUnapprovedLicenses on http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html, On Thu, Feb 15, 2018 at 11:19 AM, Jacques Le Roux

Re: svn commit: r1824260 - in /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control: ExternalLoginKeysManager.java LoginWorker.java

2018-02-15 Thread Jacques Le Roux
Ok done Jacques Le 15/02/2018 à 08:48, Jacques Le Roux a écrit : Hi Michael, Actually these were commits I recently (1 week ago in r1823324) put to myself to quickly check. I could give this information in the commit log, would it help you? What would you use for action done, improvement?

Re: Rat flag for failure or success

2018-02-15 Thread Jochen Wiedmann
See numUnapprovedLicenses on http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html, On Thu, Feb 15, 2018 at 11:19 AM, Jacques Le Roux wrote: > Hi, > > I recently had this discussion in the infra HipChat room > > [10:03 AM] Jacques Le Roux: Dear Infra team

Rat flag for failure or success

2018-02-15 Thread Jacques Le Roux
Hi, I recently had this discussion in the infra HipChat room [10:03 AM] Jacques Le Roux: Dear Infra team :) We use RAT and have this report https://ci.apache.org/projects/ofbiz/rat-output.html I was wondering if there is a way in RAT to get an alert when the status change from "ALL OK" to an

Re: svn commit: r1824260 - in /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control: ExternalLoginKeysManager.java LoginWorker.java

2018-02-15 Thread Michael Brohl
Hi Jacques, if unsure, I would always use Improved:. As Scott mentioned earlier, each commit should be at least an improvement to the codebase. Thanks, Michael Am 15.02.18 um 08:48 schrieb Jacques Le Roux: Hi Michael, Actually these were commits I recently (1 week ago in r1823324) put to