Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-22 Thread Taher Alkhateeb
Not only is this commit unnecessary, but also breaks one of the best features in Object Oriented Programming -- polymorphism -- for no value that I can see anywhere at all. Also by saying we depend fully on Tomcat and we should write code that further enforces that idea instead of making our archi

Re: Welcome Paul Foxworthy as a new PMC member

2018-03-22 Thread Paul Foxworthy
On 22 March 2018 at 16:27, Jacques Le Roux wrote: > Though it's not the official page, you might want to change > > https://cwiki.apache.org/confluence/display/OFBIZ/Apache+ > OFBiz+PMC+Members+and+Committers Yes, a good idea. I've done that now. Thanks Jacques. -- Coherent Software Australi

Re: How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC ?

2018-03-22 Thread Rajesh Mallah
As per https://cwiki.apache.org/confluence/display/OFBIZ/Using+XMLRPC+with+Flex+client In OFBiz the limitations are simple types. GenericValue object will > convert to Maps and be supported as Structs in XMLRPC, besides that > you should limit your parameters to simple types (string, double, > in

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-22 Thread Scott Gray
Something else must be wrong Jacques, I can't understand what you're saying in the ticket description or in your reply above but I do know the following: OFBiz is perfectly capable of knowing that org.apache.catalina.connector.RequestFacade implements the javax.servlet.http.HttpServletRequest and i

How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC ?

2018-03-22 Thread Rajesh Mallah
Hi , I had been using XMLRPC regularly for invoking OFBiz functions and getting results. However with below function calculateProductPrice I am facing problem in passing the "product" param . I am getting the error below: Service: calculateProductPrice faultString:Type check failed for field [ca

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-22 Thread Jacques Le Roux
Michael, I commited http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679 Where I added a wrapper. Then for "Tomcat SSO" (OFBIZ-10047) James committed http://svn.apache.

Re: Documentation commits (.adoc file type)

2018-03-22 Thread Michael Brohl
Done in r1827510 Michael Am 22.03.18 um 10:46 schrieb Jacques Le Roux: Le 22/03/2018 à 10:31, Jacques Le Roux a écrit : So all should be OK after that. Michael, For educational purpose, I still let you complete ofbiz/tools/rat-excludes.txt Thanks Jacques smime.p7s Description: S/M

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-22 Thread Michael Brohl
Mmhhh, Jacques, I think this is problematic because it ties a special implementation for Tomcat to the service. I didn't see this anywhere else. The issue (https://issues.apache.org/jira/browse/OFBIZ-10304) is a bit unclear and I don't get the purpose of this change. Can you please explain

Re: Documentation commits (.adoc file type)

2018-03-22 Thread Jacques Le Roux
Le 22/03/2018 à 10:31, Jacques Le Roux a écrit : So all should be OK after that. Michael, For educational purpose, I still let you complete ofbiz/tools/rat-excludes.txt Thanks Jacques

Re: Documentation commits (.adoc file type)

2018-03-22 Thread Jacques Le Roux
Yikes, forgot to update in Eclipse so there was actually nothing missing after Gil's commit. I'll force the damned BUildBot ! Jacques Le 22/03/2018 à 10:31, Jacques Le Roux a écrit : Michael , I fixed the framework with r1827457 https://ci.apache.org/builders/ofbizTrunkFramework and it was

Re: svn commit: r1827470 - /ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests .groovy

2018-03-22 Thread Jacques Le Roux
I guess you mean replace by .adoc files? Jacques Le 22/03/2018 à 10:32, Taher Alkhateeb a écrit : Just a note to all the documentation team, I think we should probably delete most README files anyway. The manual should be comprehensive and incorporate whatever is documented in these README fi

Re: svn commit: r1827470 - /ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy

2018-03-22 Thread Taher Alkhateeb
Just a note to all the documentation team, I think we should probably delete most README files anyway. The manual should be comprehensive and incorporate whatever is documented in these README files On Thu, Mar 22, 2018 at 11:54 AM, wrote: > Author: pgil > Date: Thu Mar 22 08:54:00 2018 > New Re

Re: Documentation commits (.adoc file type)

2018-03-22 Thread Jacques Le Roux
Michael , I fixed the framework with r1827457 https://ci.apache.org/builders/ofbizTrunkFramework and it was the reason why Buildbot did not trigger RAT. It only triggers on successful trunk framework commits: https://ci.apache.org/builders/ofbizTrunkFrameworkRat Gill just improved r1827457 an

Re: svn commit: r1827457 - /ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests .groovy

2018-03-22 Thread Jacques Le Roux
You'r right, thanks Gil Jacques Le 22/03/2018 à 08:48, gil portenseigne a écrit : Indeed, thanks Jacques for the fix. I'll just complete it renaming the zipName to README.adoc.zip :), not a big deal but for consistency it's better. Gil On 22/03/2018 06:30, jler...@apache.org wrote: Autho

Re: svn commit: r1827457 - /ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy

2018-03-22 Thread gil portenseigne
Indeed, thanks Jacques for the fix. I'll just complete it renaming the zipName to README.adoc.zip :), not a big deal but for consistency it's better. Gil On 22/03/2018 06:30, jler...@apache.org wrote: Author: jleroux Date: Thu Mar 22 05:30:39 2018 New Revision: 1827457 URL: http://svn.apac