Re: Deprecate properties in favour of SystemProperties

If there's an ongoing discussion on the dev list then I don't think it's a good idea to try to move it to jira until there's some consensus on the path forward. Regards Scott On 4 April 2018 at 10:14, Taher Alkhateeb wrote: > I am a little lost in this JIRA and

Re: why some fields are set to enable-audit-log true by default?

It would be good to leave it on somewhere in the system like the example entities maybe On Wed, 4 Apr 2018, 22:13 Jacques Le Roux, wrote: > Le 04/04/2018 à 12:07, Taher Alkhateeb a écrit : > > I'm not sure about the field in the entity component though! it > >

Re: why some fields are set to enable-audit-log true by default?

Le 04/04/2018 à 12:07, Taher Alkhateeb a écrit : I'm not sure about the field in the entity component though! it might be needed in some unit tests? Yes Jacques

Re: Deprecate properties in favour of SystemProperties

I am a little lost in this JIRA and cannot follow the discussion. Can you please point to what you want to review with others exactly? On Wed, Apr 4, 2018 at 9:46 AM, Jacques Le Roux wrote: > Le 03/04/2018 à 09:16, Jacques Le Roux a écrit : >> >> I suggest to

Re: svn commit: r1815412 - in /ofbiz: ofbiz-framework/trunk/NOTICE ofbiz-framework/trunk/themes/rainbowstone/README.md tools/rat-excludes.txt

Hi Jacques, On Thu, Nov 16, 2017 at 6:54 AM, wrote: > Author: jleroux > Date: Thu Nov 16 05:54:23 2017 > New Revision: 1815412 > > URL: http://svn.apache.org/viewvc?rev=1815412=rev > Log: > No functional change. > > With this fix, about the Quicksand Google font licensed

Re: why some fields are set to enable-audit-log true by default?

+1 to their removal. A quick grep lists the fields which have that flag. I'm not sure about the field in the entity component though! it might be needed in some unit tests? framework/entity/entitydef/entitymodel_test.xml: applications/datamodel/entitydef/order-entitymodel.xml:

Re: why some fields are set to enable-audit-log true by default?

Hi, Thanks Nicolas to point to this issue. I also think that this attribute should be used only for technical purpose, not for functional purposes. Pierre On 04/04/2018 08:54, Jacques Le Roux wrote: Hi, Moving this discussion from user ML I agree Nicolas, I see no reasons to OOTB enable

Re: Adding new invoice template

Hi, On 25/02/2018 10:07, Nicolas Malin wrote: * add a legal notice, in french we have mandatory to set some specific text on the invoice, I have the idea to implement a new PartyContentType (INVOICE_LEGAL_NOTICE or something like that) to indicate what the text we need to use for a company I

Re: why some fields are set to enable-audit-log true by default?

Hi, Moving this discussion from user ML I agree Nicolas, I see no reasons to OOTB enable audit log in any of the fields which currently supports it. Not sure if we need to go with extending entities. Note: the only entities concerned are OrderItem, OrderItemShipGroup, ReturnItem Jacques

Re: Deprecate properties in favour of SystemProperties

Le 03/04/2018 à 09:16, Jacques Le Roux a écrit : I suggest to continue the discussion at https://issues.apache.org/jira/browse/OFBIZ-7112 where I have completed my proposition Since there were some more comments after is al link to my comment with my completed my proposition