Please help yourself: http://ofbiz.apache.org/mailing-lists.html
Jacques
Le 30/08/2018 à 22:24, Kev2600 a écrit :
Unsubscribe
On Thu, Aug 30, 2018 at 7:04 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
Thanks Nicolas,
I'll wait a bit more for opinions and if we mostly agree
Unsubscribe
On Thu, Aug 30, 2018 at 7:04 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> Thanks Nicolas,
>
> I'll wait a bit more for opinions and if we mostly agree will being to
> write a draft.
>
> Not a hurry, but of course all opinions, and especially ideas even if in
> draft
Hi Nicolas,
Thanks for your feedback, much appreciated. I know it's not something easy to
review and even less to test.
About the names, I see no problems to change them. I used them to try to clarify what they do. Actually for the js functions I initially used names
close to what you
I forgot to reply :), after sharing with my coworkers, It's would b
interesting for us to works on this parts.
So I will start a POC just to see if we go on a good way.
Nicolas
On 25/08/2018 13:35, Nicolas Malin wrote:
On 24/08/2018 09:16, Taher Alkhateeb wrote:
Furthermore, I'm not sure we
Globally (after Taher remarks :) ) I found the code clear. Instead of my
comment about the jwt generation [1] on issue OFBIZ-9833 [2] I haven't
other technical remarks that can help to improve this.
Now on naming vision I suggest simple naming like this :
setUserLoginIdInJwtToken -> loadJWT()
Thanks Nicolas,
I'll wait a bit more for opinions and if we mostly agree will being to write a
draft.
Not a hurry, but of course all opinions, and especially ideas even if in draft
form , are welcome!
Jacques
Le 30/08/2018 à 11:20, Nicolas Malin a écrit :
Hi Jacques,
I agree with the
Hi Jacques,
I agree with the main Michael's idea and yours to load it as best practice.
Now I'm not the better man to rewrite a formulation. But if no
inspiration here I can try a first prose
Nicolas
On 27/08/2018 10:15, Jacques Le Roux wrote:
Hi Michael, All,
First, thank you Michael
