Re: svn commit: r1845418 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.ja

2018-11-01 Thread Jacques Le Roux
Right, and there is enough information in the link provided in the top of the method Done in trunk, R17 and R16 Jacques Le 01/11/2018 à 13:01, Taher Alkhateeb a écrit : it is usually not good practice to add commented-out code to the code base. I recommend removing it. I also think the

Re: svn commit: r1845418 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.ja

2018-11-01 Thread Taher Alkhateeb
it is usually not good practice to add commented-out code to the code base. I recommend removing it. I also think the comments might benefit from better formatting and structuring instead of this sporadic "//" sprinkled all over the place On Thu, Nov 1, 2018 at 12:36 PM wrote: > > Author: jleroux

Re: Cookie Consent In E-Coomerce

2018-11-01 Thread Deepak Nigam
Thanks, Benjamin, Jacques. Definitely, we will move forward only after studying OFBiz cookies in depth. I just put initial thought came to my mind. On Wed, Oct 31, 2018 at 9:03 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Deepak, Benjamin, > > We are indeed only