Re: svn commit: r1845572 - in /ofbiz/ofbiz-framework/trunk/framework/webtools: config/ src/main/java/org/apache/ofbiz/webtools/ webapp/webtools/WEB-INF/ widget/

2018-11-09 Thread Aditya Sharma
Hi Rishi, I think you missed the import with a wildcard in UtilCacheEvents.java. >+import java.util.*; Though I think it may have been slipped in due to IDE. Using the wildcard may clutter local namespace with all the classes of util package. Thanks and Regards, *Aditya Sharma* | Enterprise

Re: "Stash" in svn

2018-11-09 Thread Pierre Smits
We should move our repos to git to attract a wider audience. Best regards, Pierre Smits *Apache Trafodion , Vice President* *Apache Directory , PMC Member* Apache Incubator , committer *Apache OFBiz

"Stash" in svn

2018-11-09 Thread Jacques Le Roux
Hi, If you miss Git "Stash" in svn, there is now Shelving and Checkpointing https://cwiki.apache.org/confluence/display/SVN/Shelving+and+Checkpointing+Dev Jacques

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-09 Thread Jacques Le Roux
Le 09/11/2018 à 11:45, Jacques Le Roux a écrit : GroovyBaseScript.groovy (unused OOTB, it seems we should get rid of) I only made a search on the complete name, but this is injected with groovy.properties using the @BaseScript annotation It was introduced by Jacopo and relates to Groovy DSL:

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-09 Thread Jacques Le Roux
Here are the Groovy files in base not in groovyScript folder if-script.groovy (unused OOTB, it seems we should get rid of) GroovyInit.groovy (I see indeed no reasons to have in config, that's history) There are 2 other exceptions in framework (not in applications, nor plugins):

Re: svn commit: r1846159 [1/2] - in /ofbiz/tools: ./ wiki-files/ wiki-files/birt/

2018-11-09 Thread Mathieu Lirzin
Jacques Le Roux writes: > Le 08/11/2018 à 23:26, Mathieu Lirzin a écrit : >> Even if IME a majority of links are already broken in the Wiki (which is >> part of the reason why I am strongly convinced that Wikis as a main >> documentation are a bad idea), I would suggest replacing the page >>

Re: "rememberMe" is not used

2018-11-09 Thread Jacques Le Roux
Done at r1846221 Jacques Le 03/11/2018 à 11:37, jler...@apache.org a écrit : While working on OFBIZ-10635 I noticed this block of code in LoginEvents::storeLogin     if ("Y".equals(request.getParameter("rememberMe"))) {     setUsername(request, response);     } It was added

Re: svn commit: r1846159 [1/2] - in /ofbiz/tools: ./ wiki-files/ wiki-files/birt/

2018-11-09 Thread Jacques Le Roux
Le 08/11/2018 à 23:26, Mathieu Lirzin a écrit : Even if IME a majority of links are already broken in the Wiki (which is part of the reason why I am strongly convinced that Wikis as a main documentation are a bad idea), I would suggest replacing the page content with a link to the web version of