Re: buildbot failure in on ofbizBranch16

2019-04-28 Thread Swapnil M Mane
Hi team, All the tests are passed on my local. The commit 1858322 [1] should not be responsible for buildbot failure. [1] https://github.com/apache/ofbiz/commit/e29cf094893c1abb160f5ebac2d09f62d2290ef9 - Best Regards, Swapnil M Mane, ofbiz.apache.org On Sun, Apr 28, 2019 at 7:25 PM wrote:

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-28 Thread Jacques Le Roux
Actually I rarely use integration tests independently. Most of the time I simply use a batch file which does: C:\projectsASF\ofbiz>type test.bat gup cleanAll eclipse loadAll testIntegration C:\projectsASF\ofbiz>type gup.bat svn up cd plugins svn up cd .. gradlew  %* C:\projectsASF\ofbiz> In

Re: Manufacturer Support In Promotion Engine

2019-04-28 Thread Pierre Smits
I would consider to talk about supplier promotions, because it can also involve wholesale suppliers. I am inclined to agree with the latest posting by Swapnil. Whether a supplier promotion is passed to customers is a commercial ( decision, and may be subject to the agreement between the internal

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-28 Thread Pierre Smits
Hi Jacques, What are you suggesting? More duplicates? Or having all test data loaded before any test starts? Best regards, Pierre Smits *Apache Trafodion , Vice President* *Apache Directory , PMC Member* Apache Incubator

Re: Manufacturer Support In Promotion Engine

2019-04-28 Thread Swapnil Shah
It should be nice add. However i would have more more liked to have it supported in the form of Price Rule as well (if it isn't already). Many a times the mark down or mark up by manufacturers are not necessarily meant to be propogated as adjustment on top of the existing price to the end

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-28 Thread Jacques Le Roux
Yes you are right Pierre, it's not a worry when it's only for test, missed that Jacques Le 28/04/2019 à 09:52, Pierre Smits a écrit : Hi Jacques, all, Currently, we can't avoid having duplicates in test data when we load such data just before the execution a test-suite/test-case. We should

Re: Confusing implementation of the quickAdd feature of e-commerce

2019-04-28 Thread Vivek Bisen
Thanks @Rishi Solanki for your recommendation, As recommended, I have changed the template and added the patch for the same. Please have a look and let me know in case of any concerns. Thanks in advance !! On Sat, Apr 27, 2019 at 10:37 PM Rishi Solanki wrote: > Dear Pawan, > In general

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-28 Thread Pierre Smits
Hi Jacques, all, Currently, we can't avoid having duplicates in test data when we load such data just before the execution a test-suite/test-case. We should not concern ourselves to much with this. After all it is just data for test, and reloading a few duplicates should not be regarded as a