Re: checkstyle improvements

2020-02-19 Thread Pierre Smits
You are correct about me not answering your questions here, as it would add to an already deteriorating S/N ratio regarding the subject of this thread. Met vriendelijke groet, Pierre Smits *Proud* *contributor* (but unfortunately without privileges)* of* Apache OFBiz ,

Re: checkstyle improvements

2020-02-19 Thread Michael Brohl
Yetus has nothing to do with your copy & paste work so responsibility is on your side. You did not answer any of my questions to understand the values you see in the *concrete* example. Michael Am 19.02.20 um 18:36 schrieb Pierre Smits: As always: with good intentions often comes bad

Re: checkstyle improvements

2020-02-19 Thread Pierre Smits
As always: with good intentions often comes bad execution... You shouldn't have had to post that from the ticket as people can follow the reference. Unless you want to drive home the point you're trying to make about the S/N ratio. As for 3rd party tools used, whatever/wherever/whenever, I am

Re: checkstyle improvements

2020-02-19 Thread Michael Brohl
Your copy comments from yetus have a very bad signal/noise ratio [1]. Let's see for https://issues.apache.org/jira/browse/OFBIZ-10001: === +1 overall                                _ / ___| _   _  ___ ___ ___  ___ ___| | \___ \| | | |/ __/ __/ _ \/ __/ __| |  ___) | |_| | (_| (_|  __/\__

Re: checkstyle improvements

2020-02-19 Thread Pierre Smits
What you find cluttering, I regards as helpful to: - fellow contributors - our (potential) adopters - anyone else working on an OFBiz implementation Met vriendelijke groet, Pierre Smits *Proud* *contributor* (but without privileges)* of* Apache OFBiz , since

Re: checkstyle improvements

2020-02-19 Thread Michael Brohl
No, I did not say or mean anything like that. Not sure where you get that from. Please read again, thanks, Michael Am 19.02.20 um 15:51 schrieb Pierre Smits: Michael, You mean like: - *stop* posting comments to tickets to help fellow contributors and the adopters of our product

Re: checkstyle improvements

2020-02-19 Thread Pierre Smits
Michael, You mean like: - *stop* posting comments to tickets to help fellow contributors and the adopters of our product looking to these contributions to help them decide whether or not to invest in an adoption/implementation of (or looking for guidance on issues they experience

Re: checkstyle improvements

2020-02-19 Thread Michael Brohl
+1 Gil Pierre, can you please stop cluttering the issues with the copy/pasted yetus artifacts from your local environment? At least until we decided to use it and have a setup on the official infrastructure. Thanks, Michael Am 14.02.20 um 16:34 schrieb Gil Portenseigne: Hello Pierre,