Re: [jira] [Commented] (OFBIZ-10231) Convert ProductServices.xml mini lang to groovy

2020-03-05 Thread Jacques Le Roux
Le 05/03/2020 à 14:26, Nicolas Malin a écrit : Kelvin it's the nickname for Elvis ? Ah(?), OK Jacques

Re: OFBIZ-4035: change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander

2020-03-05 Thread Mathieu Lirzin
Daniel Watford writes: > We already have a +1 from James. Can I count on your vote, Mathieu? :) You have a +0 on my side. As I already said I support the testing effort because OFBiz need people caring about writing maintainable tests and I found legitimate to introduce an extra mocking

Re: [jira] [Commented] (OFBIZ-10231) Convert ProductServices.xml mini lang to groovy

2020-03-05 Thread Nicolas Malin
^^ Kelvin syntax. Kelvin it's the nickname for Elvis ? Nicolas On 28/02/2020 21:08, Jacques Le Roux wrote: > Le 28/02/2020 à 17:49, ASF subversion and git services (Jira) a écrit : >> use kelvin syntax > > Hi Nicolas, Gil, > > Could you explain why you refer to Kelvin Syntax? pEpkey.asc

Re: OFBIZ-4035: change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander

2020-03-05 Thread Jacques Le Roux
Le 05/03/2020 à 14:18, Jacques Le Roux a écrit : Le 05/03/2020 à 12:07, Daniel Watford a écrit : In summary, I'm asking the community to accept introduction of a new mocking library to support a longer term piece of refactoring work. Committers! Bring me your +1 and lets get these PRs merged

Re: OFBIZ-4035: change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander

2020-03-05 Thread Jacques Le Roux
Le 05/03/2020 à 12:07, Daniel Watford a écrit : In summary, I'm asking the community to accept introduction of a new mocking library to support a longer term piece of refactoring work. Committers! Bring me your +1 and lets get these PRs merged :) I'm actually focused on something else, but I

Re: OFBIZ-4035: change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander

2020-03-05 Thread Daniel Watford
Hi Mathieu, Apologies if gmail mess up email quoting. On Thu, 5 Mar 2020 at 10:33, Mathieu Lirzin wrote: > > PS: Votes in regards code modification in a community with PMC members > that basically disagree on everything else than “We are an awesome > community” is not a solution to anything

Re: OFBIZ-4035: change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander

2020-03-05 Thread Mathieu Lirzin
Daniel Watford writes: > Yes I agree that mocking of static methods is an indicator of refactoring > needed. > > There are always exceptions to every rule, but in this case with > MacroFormRenderer longer than > 3000 lines in R18 and its role is to map from ModelFormField instances to > string