Re: Github PR template

2020-05-31 Thread Suraj Khurana
Thanks Jacques. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, May 31, 2020 at 1:21 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Done also in R17 and R18, it can still be improved if necessary > > I removed a

Re: IMPROVEMENT: Checkstyle formatting issues

2020-05-31 Thread Jacques Le Roux
Hi Suraj, I tend to agree, most of the time the history can be rebuild with blame using lines around, or even looking into commits. Jacques Le 30/05/2020 à 18:25, Suraj Khurana a écrit : Hello Devs, Hope you are doing good !! Currently, there are many checkstyle issues in code base which

Re: Github PR template

2020-05-31 Thread Jacques Le Roux
Done also in R17 and R18, it can still be improved if necessary I removed a "ecomify-OFBIZ-11468_Convert_ShipmentReceiptServices-squashed" branch that I pushed by mistake in ofbiz-framework.git Jacques Le 31/05/2020 à 05:55, Aditya Sharma a écrit : +1 Thanks and Regards, Aditya Sharma On