Re: svn commit: r1798086 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java

2022-12-04 Thread Deepak Dixit
I am working on some performance related thing, while reviewing code I found the code snippet where eli closed explicitly, That's why I landed up on this commit. Please feel free to revert this commit, We can also remove explicitly eli.close call from handleOutput(), else will get unnecessary

Re: CI github failed : Java 11 or java 17

2022-12-04 Thread Jacques Le Roux
Le 02/12/2022 à 11:23, Jacques Le Roux a écrit : Hi Eugen, Actually I can live with changing java_home by hand instead of using a batch file, not a bid deal. It was only a typo somewhere, RAM disk switching still works \o/ On this subject (RAM vs SSD) for those interested:

Re: svn commit: r1798086 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/finder/ListFinder.java

2022-12-04 Thread Jacques Le Roux
Hi Deepak, You are right, I missed to conclude what I said at the end of the commit comment ("I have to check the whole thing"). So did not see that the called handleOutput() closes the eli var, well spotted. Now if we look at both r1797097