Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-06-22 Thread Jacques Le Roux
I think this will never happen, let's see... Le 27/05/2020 à 09:16, Jacques Le Roux a écrit : I created INFRA-20331 for that Jacques Le 23/05/2020 à 11:34, Pierre Smits a écrit : Thanks Jacques, forellen staking care of thuis. Op za 23 mei 2020 11:28 schreef Jacques Le Roux <

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-27 Thread Jacques Le Roux
I created INFRA-20331 for that Jacques Le 23/05/2020 à 11:34, Pierre Smits a écrit : Thanks Jacques, forellen staking care of thuis. Op za 23 mei 2020 11:28 schreef Jacques Le Roux < jacques.le.r...@les7arts.com>: Actually we have also this information nicely coming to ofbiz-*@

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-23 Thread Pierre Smits
Thanks Jacques, forellen staking care of thuis. Op za 23 mei 2020 11:28 schreef Jacques Le Roux < jacques.le.r...@les7arts.com>: > Actually we have also this information nicely coming to ofbiz-*@ > noreply.github.com > > So we don't need the ugly couples (added then removed) at >

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-23 Thread Jacques Le Roux
Actually we have also this information nicely coming to ofbiz-*@noreply.github.com So we don't need the ugly couples (added then removed) at notificati...@ofbiz.apache.org If nobody disagree I'll see if Infra can do something about that in a week... Jacques Le 20/05/2020 à 20:24, Pierre

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-20 Thread Pierre Smits
It happened to me a few times that a PR didn't pass the quality gates of SonarCloud. And it helped me to correct the situation on a next push RE: BTW is a PR pushable if the SonarCloud tests don't pass? SonarCloud tests are done AFTER the PR is created. Then it checks on every commit coming in

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-20 Thread Jacques Le Roux
For me both are useless, I have never seen a SonarCloud Quality Gate not passing and this information is visible on the PR before pushing it BTW is a PR pushable if the SonarCloud tests don't  pass? I could filter them, but by experience I tend to privilege cutting at root. Because maintainer

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-20 Thread Pawan Verma
Hi Pierre, For me, this one is good --> Kudos, SonarCloud Quality Gate passed! This one seems to be useless --> sonarcloud[bot] removed a comment on pull request -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open source experts* http://www.hotwaxsystems.com

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-20 Thread Pierre Smits
Just curious, but what do we want to get into the ml from github? If infra needs to be involved for modifications, then we better have lost of action items ready. Mvg Pierre Op wo 20 mei 2020 19:13 schreef Pawan Verma : > Hey Jacques, Pierre > > Yes, I also feel it's useless and annoying. IMO

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-20 Thread Pawan Verma
Hey Jacques, Pierre Yes, I also feel it's useless and annoying. IMO If we can mute this notification, it would be a great thing. -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open source experts* http://www.hotwaxsystems.com On Wed, May 20, 2020 at 9:39 PM

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-20 Thread Pierre Smits
Not an issue. At least here, as I filter those out in my mail client. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion , Vice President* *Apache Directory

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-20 Thread Jacques Le Roux
Hi All, Do we have to suffer the comment then removed all time? It uselessly clutters the email boxes, isn't? Thanks Jacques Le 20/05/2020 à 14:31, GitBox a écrit : sonarcloud[bot] removed a comment on pull request #117: URL: