Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Deepak Dixit
It would be good if we add validation at UI level instead of doing changes in core services. Based on the context rules may be different in different cases. On Tue, Sep 4, 2018 at 2:44 AM, Taher Alkhateeb wrote: > Julien makes a good point. This is too specific and context sensitive to > apply

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Taher Alkhateeb
Julien makes a good point. This is too specific and context sensitive to apply across the board. On Mon, Sep 3, 2018, 4:28 PM Julien NICOLAS wrote: > Hello > > I've already implemented this kind of things and if you want to be > exhaustive, you have to do it at least in service AND in UI. > >

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Girish Vasmatkar
I am all for having validations at the UI level, at least. Apart from Date, there are other fields that need some basic validations. Showing error/waring on tabbing out is one of the simplest forms for validation we can put on certain fields. +1 for this change. On Mon, Sep 3, 2018 at 10:24 PM

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Jacques Le Roux
Interesting idea, but please Richard subscribe to the dev ML, your email has been moderated Thanks Jacques Le 03/09/2018 à 15:59, Richard a écrit : Some systems warn or block depending on the user's role.  A "bookkeeper" might not be able to enter incorrect data, while an administrator may

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Richard
Some systems warn or block depending on the user's role. A "bookkeeper" might not be able to enter incorrect data, while an administrator may just receive a warning. Jacques Le Roux wrote: One thing we could do is not block but warn the user, easy, simple Jacques Le 03/09/2018 à 15:28,

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Jacques Le Roux
One thing we could do is not block but warn the user, easy, simple Jacques Le 03/09/2018 à 15:28, Julien NICOLAS a écrit : Hello I've already implemented this kind of things and if you want to be exhaustive, you have to do it at least in service AND in UI. However, it really depend on use

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Sanjay Yadav
+1 Jacques. I will say with consistency, field level validation is also very important. It will restrict the user to enter incorrect data into the system. Best Regards, *Sanjay Yadav* | Manager, Enterprise Quality Assurance HotWax Commerce by HotWax Systems

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Julien NICOLAS
Hello I've already implemented this kind of things and if you want to be exhaustive, you have to do it at least in service AND in UI. However, it really depend on use cases that it depend on the customer tastes. When it depend on customer tastes, I prefer to keep it open in the framework /

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Jacques Le Roux
By root I mean the point where things begin. And for entering data for end users it all start in UI. If you can stop things at this level, you don't have to worry for sequel. That's what I mean by "root in UI". Maybe "seed in UI" would have been a better image :) It would be more to prevent

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Taher Alkhateeb
I don't know what it means by the root in UI, but we are arriving at a complex topic: Validation. Validation is something that can happen on many levels like: - entity definition level - entity-auto level - service level - UI level - route level Each one of those has advantages and

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Jacques Le Roux
It's only about checking at the root in UI when entering data and not let things go as long as the value is not correct Jacques Le 03/09/2018 à 13:08, Taher Alkhateeb a écrit : Well, it depends on where the cross checks happen. Are you talking about UI? entity-auto? somewhere else? On Mon,

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread Taher Alkhateeb
Well, it depends on where the cross checks happen. Are you talking about UI? entity-auto? somewhere else? On Mon, Sep 3, 2018 at 11:52 AM deepak nigam wrote: > > +1. > > Thanks for the putting this forward. Please count me in for this effort. > > > Thanks & Regards > -- > Deepak Nigam > HotWax

Re: [QUESTION] Should we not check fields consistency?

2018-09-03 Thread deepak nigam
+1. Thanks for the putting this forward. Please count me in for this effort. Thanks & Regards -- Deepak Nigam HotWax Systems Pvt. Ltd. On Mon, Sep 3, 2018 at 2:06 PM Jacques Le Roux wrote: > Hi, > > I have always found that not having dates cross-checks in OFBiz is a minus. > > For instance

[QUESTION] Should we not check fields consistency?

2018-09-03 Thread Jacques Le Roux
Hi, I have always found that not having dates cross-checks in OFBiz is a minus. For instance while creating/editing an order we can enter * an anti-dated shipping date (eg 2018-08-1 entered today) * The recently added reserved date can be after the shipping date * etc. (not only dates but