[
https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869362#comment-13869362
]
Gareth Carter commented on OFBIZ-5409:
--
Excellent. Well done Jacques. I think the
[
https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863431#comment-13863431
]
Jacques Le Roux commented on OFBIZ-5409:
While creating a new patch, I stumbled
[
https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855502#comment-13855502
]
Gareth Carter commented on OFBIZ-5409:
--
The list of attributes was bad practise on my
[
https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13854885#comment-13854885
]
Jacques Le Roux commented on OFBIZ-5409:
BTW Gareth, I guess you collected the
[
https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846217#comment-13846217
]
Jacques Le Roux commented on OFBIZ-5409:
You mean all attributes or, I guess, only
[
https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845799#comment-13845799
]
Jacques Le Roux commented on OFBIZ-5409:
I agree with Adrian for the static field.
[
https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845877#comment-13845877
]
Adrian Crum commented on OFBIZ-5409:
Returning attributes is ABSOLUTELY a security
[
https://issues.apache.org/jira/browse/OFBIZ-5409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834734#comment-13834734
]
Adrian Crum commented on OFBIZ-5409:
It might be better to make the array a static
