[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361674#comment-15361674
]
Divesh Dutta commented on OFBIZ-6576:
-
Thanks [~ankush.upadhyay] for your patch and thanks
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348054#comment-15348054
]
Divesh Dutta commented on OFBIZ-6576:
-
[~Peter Arnold] we can create a separate ticket for this
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348052#comment-15348052
]
Divesh Dutta commented on OFBIZ-6576:
-
Dear [~Peter Arnold] ,
You are right in terms of business
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348053#comment-15348053
]
Divesh Dutta commented on OFBIZ-6576:
-
Dear [~Peter Arnold] ,
You are right in terms of business
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347151#comment-15347151
]
Peter Arnold commented on OFBIZ-6576:
-
Dear Paul and Divesh,
I agree with Pauls explanation of the
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347109#comment-15347109
]
Peter Arnold commented on OFBIZ-6576:
-
Dear Ankush and Divesh;
thank you for the suggestions and the
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343967#comment-15343967
]
Jacques Le Roux commented on OFBIZ-6576:
Ah yes good point, too used to it :D
> Pricing error in
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343962#comment-15343962
]
Ankush Upadhyay commented on OFBIZ-6576:
I have updated patch with null check improvements.
>
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343939#comment-15343939
]
Divesh Dutta commented on OFBIZ-6576:
-
Thanks Ankush for the improvement. One more minor thing, we are
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343930#comment-15343930
]
Jacques Le Roux commented on OFBIZ-6576:
I agree with Divesh, +1 for Ankush's patch!
> Pricing
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343908#comment-15343908
]
Ankush Upadhyay commented on OFBIZ-6576:
Thanks for the patch review and suggestion, I have
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343832#comment-15343832
]
Divesh Dutta commented on OFBIZ-6576:
-
Hi [~paul_foxworthy] , I agree that SALES_TAX and VAT_TAX are
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343818#comment-15343818
]
Divesh Dutta commented on OFBIZ-6576:
-
Your solutions looks good to me that when we don't have price
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343736#comment-15343736
]
Paul Foxworthy commented on OFBIZ-6576:
---
Hi all,
See this discussion from 2011:
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343728#comment-15343728
]
Ankush Upadhyay commented on OFBIZ-6576:
Thanks [~Peter Arnold] for reporting the issue and
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342285#comment-15342285
]
Peter Arnold commented on OFBIZ-6576:
-
Issue is caused by the code further below in
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704594#comment-14704594
]
Jacques Le Roux commented on OFBIZ-6576:
Thanks Sharan!
Pricing error in Variant
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702919#comment-14702919
]
Sharan Foga commented on OFBIZ-6576:
Hi Jacques - I will run a test on 12.04 and let
18 matches
Mail list logo