[ https://issues.apache.org/jira/browse/OFBIZ-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Forrest Rae updated OFBIZ-6888: ------------------------------- Attachment: OFBIZ-6888.patch Patch to fix issue. > GroovyEngine.serviceInvoker masks Groovy script exceptions in some cases > ------------------------------------------------------------------------ > > Key: OFBIZ-6888 > URL: https://issues.apache.org/jira/browse/OFBIZ-6888 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 > Reporter: Forrest Rae > Labels: errorhandling > Attachments: OFBIZ-6888.patch > > > If GroovyEngine.serviceInvoker catches an exception in a Groovy script, it > would mask the exception in some cases. An exception's detailMessage can be > null. If it is null, the exception won't be properly returned and logged, > and that will make spotting problems very difficult. This was the case for > me while trying to track down a problem with a > java.util.ConcurrentModificationException error in a Groovy script. I > suspect that this choice to mask exceptions and only return the message has > cause bugs to not be spotted. > Disabling this for now in favor of returning a proper exception. > GroovyEngine.serviceInvoker() should throw GenericServiceException if error, > rather than returning ServiceUtil.returnError(e.getMessage()) -- This message was sent by Atlassian JIRA (v6.3.4#6332)