Re: Does ‘StartupControlPanel#loadStartupLoaders’ really require introspection?

2018-11-02 Thread Mathieu Lirzin
Hello, Mathieu Lirzin writes: > I will be looking into deleting the startup loaders API. As a citizen of the *Start-Up Nation* [1], I am proud to announce that the startup loader abstraction has finally been concretized! :-) I have opened OFBIZ-10638 [2] for review. Thanks. [1]

Re: Does ‘StartupControlPanel#loadStartupLoaders’ really require introspection?

2018-10-28 Thread Mathieu Lirzin
Hello Taher, Taher Alkhateeb writes: > This is code which I refactored from a very messy startup code, and > yes you are right, we don't need java reflection, and we do not even > need a startup loader in the first place. The code could be much > simpler. > > We used to have 2 startup loaders,

Re: Does ‘StartupControlPanel#loadStartupLoaders’ really require introspection?

2018-10-27 Thread Taher Alkhateeb
Hi Mathieu, This is code which I refactored from a very messy startup code, and yes you are right, we don't need java reflection, and we do not even need a startup loader in the first place. The code could be much simpler. We used to have 2 startup loaders, the existing one, and also a loader

Does ‘StartupControlPanel#loadStartupLoaders’ really require introspection?

2018-10-21 Thread Mathieu Lirzin
Hello, I have a question regarding the ‘org.apache.ofbiz.base.start.StartupControlPanel#loadStartupLoaders()’ current implementation: --8<---cut here---start->8--- private static void loadStartupLoaders(Config config, List loaders,