Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-12 Thread Rishi Solanki
Yes! Thank you Arun for bringing/reporting this and summarize. Agree with you on we may need to update the existing entities/data as per convention. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-12 Thread Arun Patidar
Thanks Michael and Rishi for your feedback. If we follow the proper convention with TypeId and entity name then there is no issue. But the case is that there is some inconsistency in existing entities. We will have to fix some of the existing entities as per convention. -- Thanks & Regards ---

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-12 Thread Rishi Solanki
Thanks Michael, I'm also in favor of using id and description fields suggest the entity name. Existing model is capable to to resolve the reported issue if we follow the conventions. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-10 Thread Michael Brohl
-1 from my side, I think we can solve this by convention instead of introducing a new field. Thanks, Michael Am 01.09.17 um 15:53 schrieb Vaibhav Jain: +1 for introducing new attribute "tableName". Vaibhav Jain Hotwax Systems, vaibhav.j...@hotwaxsystems.com On Fri, Sep 1, 2017 at 5:16

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-10 Thread Michael Brohl
Hi Arun, thanks for reporting this. I think we should keep the convention and fix the metioned types. Introducing a new field to specify the detail table should not be necessary. Thanks, Michael Am 01.09.17 um 13:18 schrieb Arun Patidar: Hello All, 'hasTable' field of 'Type' entities is

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-09 Thread Arun Patidar
Here is ticket for tracking this: https://issues.apache.org/jira/browse/OFBIZ-9696 -- Thanks & Regards --- Arun Patidar Manager, Enterprise Software Development HotWax Systems Pvt Ltd. www.hotwaxsystems.com On Tue, Sep 5, 2017 at 6:25 PM, Jacques Le Roux < jacques.le.r...@les7arts.com>

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-05 Thread Jacques Le Roux
Le 05/09/2017 à 14:39, Arun Patidar a écrit : Hello Jacques, Problems with ShipmentGatewayConfigType and PaymentGatewayConfigType entities are: - 'hasTable' field values is set to N for these entities - 'typeId' field values do not give direction about detail entity name Thanks Arun, Yes

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-05 Thread Arun Patidar
Hello Jacques, Problems with ShipmentGatewayConfigType and PaymentGatewayConfigType entities are: - 'hasTable' field values is set to N for these entities - 'typeId' field values do not give direction about detail entity name -- Thanks & Regards --- Arun Patidar Manager, Enterprise Software

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Vaibhav Jain
+1 for introducing new attribute "tableName". Vaibhav Jain Hotwax Systems, vaibhav.j...@hotwaxsystems.com On Fri, Sep 1, 2017 at 5:16 PM, Rishi Solanki wrote: > I'm not sure this one is best practice or not, but it should be follow. We > should try to name the type

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Rishi Solanki
Here is the part related to this thread, from the document shared. "If a table is associated with a given EntityType instance that has the same name as the entityTypeId field value then the hasTable field should have the value 'Y', otherwise it should have the value 'N'. A description field is

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Rishi Solanki
Thanks Jacques! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Sep 1, 2017 at 5:46 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > It's described here

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Jacques Le Roux
It's described here https://cwiki.apache.org/confluence/display/OFBIZ/General+Entity+Overview#GeneralEntityOverview-ExtensibilityPattern What is the problem with ShipmentGatewayConfigType and PaymentGatewayConfigType (did not check)? Jacques Le 01/09/2017 à 13:18, Arun Patidar a écrit :

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Rishi Solanki
I'm not sure this one is best practice or not, but it should be follow. We should try to name the type same as entity name. Other examples; - PartyTpe >> PERSON and PARTY_GROUP - PaymentMethodType >> CREDIT_CARD, FIN_ACCOUNT, EFT_ACCOUNT, GIFT_CARD etc. IMO, best practice is to have the hasTable

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Taher Alkhateeb
Hmmm maybe a solution that enforces naming conventions is something like the following - if hasTable is defined, the entity engine automatically creates the table using the convention of id - if someone wants to intentionally change the table name, they can set an override field like tableName.

Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Arun Patidar
Hello All, 'hasTable' field of 'Type' entities is used to give an idea that detail entity exists or not. We generally get the name of detail entity on the basis of typeId field value. For example : ContactMechType,contactMechTypeId = "POSTAL_ADDRESS" then we go to PostalAddress for detail.