Inconsistent (?) use of Lucene versions

2012-08-17 Thread Jacopo Cappellato
Hi all, while reviewing the OFBiz code that implements the integration with Lucene I have noticed some inconsistent usage of the Lucene Version: some code sets the version to 30, 34, 35 while the current version we are using in OFBiz is 35 (aka Lucene 3.5); is this done intentionally or it is

Re: Inconsistent (?) use of Lucene versions

2012-08-17 Thread Mirko Vogelsmeier
:Inconsistent (?) use of Lucene versions Hi all, while reviewing the OFBiz code that implements the integration with Lucene I have noticed some inconsistent usage of the Lucene Version: some code sets the version to 30, 34, 35 while the current version we are using in OFBiz is 35 (aka Lucene 3.5

Re: Inconsistent (?) use of Lucene versions

2012-08-17 Thread Erwan de FERRIERES
Le 17/08/2012 17:00, Jacopo Cappellato a écrit : Hi all, while reviewing the OFBiz code that implements the integration with Lucene I have noticed some inconsistent usage of the Lucene Version: some code sets the version to 30, 34, 35 while the current version we are using in OFBiz is 35

Re: Inconsistent (?) use of Lucene versions

2012-08-17 Thread Erwan de FERRIERES
Le 17/08/2012 17:11, Mirko Vogelsmeier a écrit : Hi Jacopo, +1 to that change. I would go even further to prevent these inconsistencies in later updates and move the groovy-Code to the java-Sources to get propper compiling errors. Also there are already a couple of newer Lucene Versions out

Re: Inconsistent (?) use of Lucene versions

2012-08-17 Thread Jacopo Cappellato
Mirko, Erwan, thank you for your feedback. I have committed my code changes with rev. 1374328 Jacopo On Aug 17, 2012, at 5:30 PM, Erwan de FERRIERES wrote: Le 17/08/2012 17:11, Mirko Vogelsmeier a écrit : Hi Jacopo, +1 to that change. I would go even further to prevent these