Re: Missing Method Implementations in OrderChangeHelper

2017-08-11 Thread Kyra Pritzel-Hentley
Hello Jacques, thank you for your reply. I have created a new JIRA-ticket dedicated to removing deprecated code since the one you referred me to seemed to be specifically for code that is commented out. The ticket can be found here: https://issues.apache.org/jira/browse/OFBIZ-9569

Re: Missing Method Implementations in OrderChangeHelper

2017-08-04 Thread Jacques Le Roux
Hi Kyra, Actually it was an error to remove this comment (thanks Deepak!) at r1758006 https://s.apache.org/neiF. I wonder if other alike comments were not wrongly removed... But anyway I think it's clear those 2 methods (releaseInitialOrderHold and abortOrderProcessing) are no longer needed

Re: Missing Method Implementations in OrderChangeHelper

2017-08-04 Thread Kyra Pritzel-Hentley
Hello Deepak, thank you for this information. I understand now that there used to be an implementation that is now deprecated. Would it not make sense to comment on these methods so that who ever else may stumble upon them knows that nothing is wrong? In the newest trunk, nothing indicates

Re: Missing Method Implementations in OrderChangeHelper

2017-08-03 Thread Deepak Nigam
Hi Kyra, It seems that these changes are intentional, you can also check the comment inside the code itself: "NOTE DEJ20080609 commenting out this code because the old OFBiz Workflow Engine is being deprecated and this was only for that get the delegator from the dispatcher" For more

Missing Method Implementations in OrderChangeHelper

2017-08-03 Thread Kyra Pritzel-Hentley
Hello OFBiz Enthusiasts, I am working to rid OFBiz of Bugs using the help of a code analysis tool called FindBugs. With this, I find all kinds of peculiar code in the OFBiz project. This JIRA ticket describes further details about this effort: https://issues.apache.org/jira/browse/OFBIZ-9450