Re: OFBiz JSON Classes

2014-01-06 Thread Jacques Le Roux
I stumbled upon this and I wonder also why those files (like ParseException.java) are duplicated in framework/sql/build/gen-src/javacc/org/ofbiz/sql and framework/base/build/gen-src/javacc/org/ofbiz/base/json/ Adam, could you enlight us? Jacques On Sunday, October 20, 2013 4:28 PM

Re: OFBiz JSON Classes

2014-01-06 Thread Adam Heath
Because that's how javacc works, it takes effort to keep it from not generating those files. And, those aren't the same classes, btw. The fix for this would require changing javacc to allow for a different exception to be thrown by the generated methods; this would then mean a shared class

Re: OFBiz JSON Classes

2014-01-06 Thread David E. Jones
Why have our own stuff at all? There are good JSON parsers and generators around, one of the best for automatic type conversions and such being the one built into Groovy (JsonSlurper, JsonBuilder, JsonOutput, etc). -David On Oct 20, 2013, at 8:28 AM, Adrian Crum

OFBiz JSON Classes

2013-10-20 Thread Adrian Crum
Does anyone know why we are using a JJ compiler to generate the JSON classes in framework/base? It seems to me we could start off with compiler-generated code, then improve it by hand. -- Adrian Crum Sandglass Software www.sandglass-software.com