Re: Purchase Order Cancel status

2017-10-11 Thread Jacques Le Roux
Le 09/10/2017 à 11:10, Arun Patidar a écrit : IMO, we should keep SO and PO consistent in this workflow. Also, there is less chance to add item after canceling all item. To keep order status sync with items, we should cancel the order if all items have been canceled. Agreed, better to create

Re: Purchase Order Cancel status

2017-10-10 Thread Renuka Srishti
To make SO and PO flow consistent and to maintain order header status with its item status. Removed the condition, patch attached in OFBIZ-9838 Thanks Renuka Srishti On Mon, Oct 9, 2017 at 3:20 PM, Suraj Khurana <

Re: Purchase Order Cancel status

2017-10-09 Thread Suraj Khurana
Thanks Renuka for bringing this into notice. I also agree with Arun's point -- Best Regards, *Suraj Khurana* | Sr. Enterprise Software Engineer *HotWax Commerce * by *HotWax Systems* Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 On Mon, Oct 9, 2017 at 3:13 PM, Jacques Le

Re: Purchase Order Cancel status

2017-10-09 Thread Jacques Le Roux
Hi Renuka, It seems to have slipped in with http://svn.apache.org/viewvc?view=revision=1026520 I see no reason to keep it Jacques Le 05/10/2017 à 15:47, Renuka Srishti a écrit : Hello Devs, This is reference to http://markmail.org/message/wggbvdumrndpkxrj In

Re: Purchase Order Cancel status

2017-10-09 Thread Arun Patidar
IMO, we should keep SO and PO consistent in this workflow. Also, there is less chance to add item after canceling all item. To keep order status sync with items, we should cancel the order if all items have been canceled. -- Thanks & Regards --- Arun Patidar Manager, Enterprise Software

Re: Purchase Order Cancel status

2017-10-09 Thread Renuka Srishti
Hii Mohammad, I agree with your points. I think we should wait for other's reply too, then we can conclude the implementation. Thanks Renuka Srishti On Fri, Oct 6, 2017 at 7:34 PM, Mohammad Kathawala < mohammad.kathaw...@hotwaxsystems.com> wrote: > Hi, > > IMO, if all the items of the order

Re: Purchase Order Cancel status

2017-10-06 Thread Mohammad Kathawala
Hi, IMO, if all the items of the order need to be canceled then the user should/would directly cancel the order rather than canceling all the items individually. This will automatically cancel all the items and the order at header level. Despite this, still, if the user cancels all the items

Re: Purchase Order Cancel status

2017-10-06 Thread Ratnesh Upadhyay
Hi Renuka, I would also prefer to remove this condition as it's not making sense to keep order in created status when all the order items get canceled. Thanks!! Regards, Ratnesh Upadhyay HotWax Systems | www.hotwaxsystems.com On Fri, Oct 6, 2017 at 12:52 PM, Deepak Dixit <

Re: Purchase Order Cancel status

2017-10-06 Thread Deepak Dixit
Hi Renuka, I see no reason to keen this condition. we can remove this. As I know there is no business scenario around this. If all order item cancelled than order should be cancel either its Sales or Purchase order. Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Thu,

Purchase Order Cancel status

2017-10-05 Thread Renuka Srishti
Hello Devs, This is reference to http://markmail.org/message/wggbvdumrndpkxrj In "applications/order/src/org/ofbiz/order/order/OrderServices.java", under "checkItemStatus" service, there is one check for all item cancelled: if (!"PURCHASE_ORDER".equals(orderTypeId)) { newStatus =