Jacopo,
Ok I reverted this change and we try to meet your request. The name of
the 'control' servlet is not available where this code is used. Now we
have clean code but there is an error in the system (not sure what is
better)
Do you have a suggestion how we could change this patch so it
Hans,
please provide more details about the error you are seeing, how to recreate it
and also how the applications are currently using the urlPrefix env variable
and me or someone else will help you to find a good way to solve the problem.
Thanks,
Jacopo
On Mar 8, 2012, at 4:28 AM, Hans
Hey Hans, (and all OFBiz committers in general)
I would like to stress the importance to address reviews on commits (especially
if they come from committers, like me, because we have veto on commits) asap
by improving the code or reverting it.
Actually the etiquette when a committer complains
Jacopo,
in general i honor all comments although it can take some time, also
this one it is comming
Regards,
Hans
On 03/05/2012 05:57 PM, Jacopo Cappellato wrote:
Hey Hans, (and all OFBiz committers in general)
I would like to stress the importance to address reviews on commits
Thank Hans,
from now on please revert the commit until you find time to commit a better
version.
Regards,
Jacopo
On Mar 5, 2012, at 12:01 PM, Hans Bakker wrote:
Jacopo,
in general i honor all comments although it can take some time, also this one
it is comming
Regards,
Hans
Maybe then sending back a word saying that it's a WIP would help ;o)
Jacques
From: Hans Bakker mailingl...@antwebsystems.com
Jacopo,
in general i honor all comments although it can take some time, also this one
it is comming
Regards,
Hans
On 03/05/2012 05:57 PM, Jacopo Cappellato
Yes,
*reverting* and then sending a word back that an improved version is in
progress would also be fine.
Jacopo
On Mar 5, 2012, at 12:10 PM, Jacques Le Roux wrote:
Maybe then sending back a word saying that it's a WIP would help ;o)
Jacques
I agree about reverting when someone specially ask about it, moreover it's easy
to do, easier/quicker than fixing which can be done
later. So I see no reasons to not do it (anyway Hans just did it :o)
I wanted also to emphasize that often miscommunication is the root of problems. It's just
Hi Hans,
I don't like the assumption about the string control: this is a configurable
value (in web.xml) and we should not have it hardcoded in our code.
I know there are already few examples of this bad pattern and in fact we should
work and fix them as well.
Jacopo
On Feb 29, 2012, at
