Re: Single line statements - checkstyle

2020-07-29 Thread Suraj Khurana
Thanks everyone. This was done a few days ago. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Jul 18, 2020 at 1:56 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 14/07/2020 à 10:15, Jacques Le Roux a écrit : > > My conclusion is that could be discussed

Re: Single line statements - checkstyle

2020-07-18 Thread Jacques Le Roux
Le 14/07/2020 à 10:15, Jacques Le Roux a écrit : My conclusion is that could be discussed again and I for one I'm not against changing this rule for 2 reasons: 1.      We can't use our current formatter to do it right 2.      With a single line statement there are less chances to confuse and

Re: Single line statements - checkstyle

2020-07-14 Thread Jacques Le Roux
Hi Suraj, We discussed this in the past (I can't find it yet) and we concluded that we should not allow that. It's in contradiction with "Code Conventions for the Java^TM Programming Language": https://www.oracle.com/java/technologies/javase/codeconventions-statements.html#449 Hence with our

Re: Single line statements - checkstyle

2020-07-13 Thread Pritam Kute
Looks good to me. Kind Regards, -- Pritam Kute On Mon, Jul 13, 2020 at 9:04 PM Suraj Khurana wrote: > Hello team, > > I have created a ticket https://issues.apache.org/jira/browse/OFBIZ-11886 > to allow single line statements during checkstyle, I hope we are fine with > this. > > For this, we

Single line statements - checkstyle

2020-07-13 Thread Suraj Khurana
Hello team, I have created a ticket https://issues.apache.org/jira/browse/OFBIZ-11886 to allow single line statements during checkstyle, I hope we are fine with this. For this, we need to add a module to allow single line statements: == == Let me know your