Re: svn commit: r1171093 - in /ofbiz/trunk/applications: accounting/servicedef/ order/src/org/ofbiz/order/order/ product/script/org/ofbiz/shipment/issuance/ product/script/org/ofbiz/shipment/receipt/

2011-09-22 Thread Scott Gray
Thanks for taking another look at it Hans, and you're probably right that the owner by itself probably isn't the best way to solve the problem. In general, neither of the products you mention below are sales/purchase shipments but I guess you are using those shipment types for them. Have you

Re: svn commit: r1171093 - in /ofbiz/trunk/applications: accounting/servicedef/ order/src/org/ofbiz/order/order/ product/script/org/ofbiz/shipment/issuance/ product/script/org/ofbiz/shipment/receipt/

2011-09-19 Thread Hans Bakker
Hi Scott, We looked into your comment, but found that inventoryitem owner is not always affecting accounting: 1. service product: foreign owner: no account update 2. rental product: is owner: also no accounting update we are following however your remark to generalize: for both product types

Re: svn commit: r1171093 - in /ofbiz/trunk/applications: accounting/servicedef/ order/src/org/ofbiz/order/order/ product/script/org/ofbiz/shipment/issuance/ product/script/org/ofbiz/shipment/receipt/

2011-09-16 Thread Scott Gray
Hi Hans, IMO it would probably be more robust to let the service execute and then check who the owner of the inventoryItem is before creating the transactions instead of checking the productTypeId. This would cover a much larger range of receipt and issuances in the future and really is the

Re: svn commit: r1171093 - in /ofbiz/trunk/applications: accounting/servicedef/ order/src/org/ofbiz/order/order/ product/script/org/ofbiz/shipment/issuance/ product/script/org/ofbiz/shipment/receipt/

2011-09-16 Thread Hans Bakker
valuable comment...will look into it. On Fri, 2011-09-16 at 22:14 +1200, Scott Gray wrote: Hi Hans, IMO it would probably be more robust to let the service execute and then check who the owner of the inventoryItem is before creating the transactions instead of checking the productTypeId.

Re: svn commit: r1171093 - in /ofbiz/trunk/applications: accounting/servicedef/ order/src/org/ofbiz/order/order/ product/script/org/ofbiz/shipment/issuance/ product/script/org/ofbiz/shipment/receipt/

2011-09-15 Thread Paul Foxworthy
Hi Hans, If you're working in the ItemIssuance area, you might want to look at https://issues.apache.org/jira/browse/OFBIZ-4386 . I reckon there's a nasty bug there, and the Jira issue has a unit test to demonstrate it and a patch. Since your change is for service products, I doubt there's any

Re: svn commit: r1171093 - in /ofbiz/trunk/applications: accounting/servicedef/ order/src/org/ofbiz/order/order/ product/script/org/ofbiz/shipment/issuance/ product/script/org/ofbiz/shipment/receipt/

2011-09-15 Thread Hans Bakker
I see Jacques is working on your issue. The changes we made are for the specific product type only, so i do not expect a conflict here. Regards, Hans On Thu, 2011-09-15 at 19:24 -0700, Paul Foxworthy wrote: Hi Hans, If you're working in the ItemIssuance area, you might want to look at