Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2012-04-05 Thread Jacopo Cappellato
Hans, could you please fix the Java code in order to be in line with our formatting conventions? Thanks, Jacopo On Dec 19, 2011, at 7:40 AM, hans...@apache.org wrote: Author: hansbak Date: Mon Dec 19 06:40:18 2011 New Revision: 1220622 URL:

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2012-04-05 Thread Hans Bakker
Sure jacopo, hope i found the code not according the agreed conventions? in r1309775 Regards, Hans On 04/05/2012 05:48 PM, Jacopo Cappellato wrote: Hans, could you please fix the Java code in order to be in line with our formatting conventions? Thanks, Jacopo On Dec 19, 2011, at 7:40

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Adrian Crum
This commit is throwing a lot of exceptions during data loading. See the buildbot report. -Adrian On 12/19/2011 6:40 AM, hans...@apache.org wrote: Author: hansbak Date: Mon Dec 19 06:40:18 2011 New Revision: 1220622 URL: http://svn.apache.org/viewvc?rev=1220622view=rev Log: new producttype:

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Jacopo Cappellato
Yep, the problem was the line: -ProductFeatureCategory productFeatureCategoryId=IMAGE description=Image/ +ProductFeatureCategory productFeatureCategoryI=IMAGE description=Image/ I have fixed it. Even without reviewing this big commit, this kind of errors (that imply that very few tests

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Adrian Crum
I agree that it is troubling. The designs are questionable as well. -Adrian On 12/19/2011 8:38 AM, Jacopo Cappellato wrote: Yep, the problem was the line: -ProductFeatureCategory productFeatureCategoryId=IMAGE description=Image/ +ProductFeatureCategory productFeatureCategoryI=IMAGE

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Hans Bakker
Hi Jacopo, thanks for helping me, it is good try to work together instead of personally accusing people. With the amount of commits we produce here at Antwebsystems, it can once in a while go wrong and have errors. I am setting up a Jenkins automated test system in our company to improve on

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Bilgin Ibryam
On 19 December 2011 14:14, Hans Bakker mailingl...@antwebsystems.com wrote: Hi Jacopo, Hello Hans, thanks for helping me, it is good try to work together instead of personally accusing people. With the amount of commits we produce here at Antwebsystems, it can once in a while go wrong and

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Scott Gray
On 19/12/2011, at 7:14 AM, Hans Bakker wrote: Hi Jacopo, thanks for helping me, it is good try to work together instead of personally accusing people. With the amount of commits we produce here at Antwebsystems, it can once in a while go wrong and have errors. I am setting up a Jenkins