Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ special

Hi Jinghai, I have started a separate thread with some design notes, see the thread "Ideas about OFBiz servlet filters". We can discuss this topic there. Thanks, Jacopo On Fri, Sep 9, 2016 at 4:32 AM, Shi Jinghai wrote: > I agree completely. I'll work on them this

Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ special

I agree completely. I'll work on them this weekend. -邮件原件- 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] 发送时间: 2016年9月8日 21:14 收件人: dev@ofbiz.apache.org 主题: Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/

Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ special

On Tue, Sep 6, 2016 at 12:10 PM, Shi Jinghai wrote: > Hi Jacopo, > > I cleaned OFBizSolrContextFilter.java and submitted in rev. 1759401. > Please check if it's required to do a further refactoring. > > Kind Regards, > > Shi Jinghai > > Thank you, Jinghai. I still see a lot

Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ special

Hi Jacopo, I cleaned OFBizSolrContextFilter.java and submitted in rev. 1759401. Please check if it's required to do a further refactoring. Kind Regards, Shi Jinghai -邮件原件- 发件人: Shi Jinghai [mailto:huaru...@hotmail.com] 发送时间: 2016年9月6日 13:43 收件人: dev@ofbiz.apache.org 主题: Re: svn

Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ special

Hi Jacopo, Let me clean the OFBizSolrContextFilter now. Kind Regards, Shi Jinghai -邮件原件- 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com] 发送时间: 2016年9月5日 22:20 收件人: dev@ofbiz.apache.org 主题: Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/

Re: svn commit: r1700119 [1/26] - in /ofbiz/trunk: ./ runtime/indexes/ specialpurpose/ specialpurpose/solr/ specialpurpose/solr/conf/ specialpurpose/solr/config/ specialpurpose/solr/entitydef/ special

Hi Jinghai, I have noticed that when you have committed the Solr component you have created a class named OFBizSolrContextFilter.java that is mostly the copy of ContextFilter: as a consequence the logic implemented in its utility methods has been duplicated. I didn't check, but it is possible