Re: svn commit: r1747540 - in /ofbiz/trunk/applications: order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java product/config/promotext.properties

Thanks Pierre. I have logged Jira ticket for promotext.properties migration - https://issues.apache.org/jira/browse/OFBIZ-7297 . -- Thanks & Regards, Mridul Pathak Senior Manager HotWax Systems http://www.hotwaxsystems.com > On Jun 10, 2016, at

Re: svn commit: r1747540 - in /ofbiz/trunk/applications: order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java product/config/promotext.properties

Hi Mridul, Thanks for spotting that. Yes, such kind of descriptions should be in *Labels.xml files. I wonder how many more we have residing not in there. When I have a moment to spare the coming days I will do an investigation and create the proper JIRAs and such. Best regards, Pierre Smits

Re: svn commit: r1747540 - in /ofbiz/trunk/applications: order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java product/config/promotext.properties

Hi Pierre, Thanks for noticing. On looking into it further I have found that promotext.properties file is used only in ProductPromoWorker.makeAutoDescription() method and was implemented way back when UI Labels were managed in *.properties files. So, in fact promotext.properties should be moved

Re: svn commit: r1747540 - in /ofbiz/trunk/applications: order/src/org/ofbiz/order/shoppingcart/product/ProductPromoWorker.java product/config/promotext.properties

UtilProperties.getMessage won't fly in a multi-tenant setup Best regards, Pierre On Thursday, June 9, 2016, wrote: > Author: mridulpathak > Date: Thu Jun 9 11:58:22 2016 > New Revision: 1747540 > > URL: http://svn.apache.org/viewvc?rev=1747540=rev > Log: >