Re: svn commit: r1824807 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/LoginWorker.java

2018-02-20 Thread Jacques Le Roux
I reverted it with r1824889 It was put in with r1811430 and it was my bad to no see that when it was automatically merged I must agree I'm too much committed. And last day was a misery for me. Jacques Le 20/02/2018 à 05:09, Scott Gray a écrit : Jacques, as a first step, please consider not

Re: svn commit: r1824807 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/LoginWorker.java

2018-02-19 Thread Scott Gray
Jacques, as a first step, please consider not using "no functional change" any longer. It used to be that it was simply used for basic formatting fixes, but now that I look closer, I notice you've had a trend going for a while now that you're using it for anything you consider to be minor. Example

Re: svn commit: r1824807 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/LoginWorker.java

2018-02-19 Thread Michael Brohl
Jacques, I won't correct you commit messages. This is a repeating issue. From now on, we will just not include those commits in the blog dev details. Am 19.02.18 um 22:07 schrieb Jacques Le Roux: Please Michael, I had a very rude day, we are a team, if you fill it needs a log change please

Re: svn commit: r1824807 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/LoginWorker.java

2018-02-19 Thread Jacques Le Roux
Please Michael, I had a very rude day, we are a team, if you fill it needs a log change please do Thanks Jacques Le 19/02/2018 à 20:59, Michael Brohl a écrit : So this is a bugfix and should read "Fixed: ..." *sigh* Am 19.02.18 um 20:43 schrieb jler...@apache.org: Author: jleroux Date: