Re: svn commit: r1838320 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/seed/OrderSeedData.xml datamodel/data/seed/ProductSeedData.xml order/src/main/java/org/apache/ofbiz/order/shoppi

I assist Michael's response On 19/08/2018 11:28, Michael Brohl wrote: If you have additional requirements, you are encouraged to provide solutions or concepts for them. Be positive, be happy I added just, if you not understand an improvement because comment or example are too poor, help

Re: svn commit: r1838320 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/seed/OrderSeedData.xml datamodel/data/seed/ProductSeedData.xml order/src/main/java/org/apache/ofbiz/order/shoppi

I have not the time to dig into the specific details right now so will just give my thoughts on the process in general because of the citations: 1. we have to distinguish between (a) completely new functionality or major refactorings and (b) the enhancement of functionality which is already

Re: svn commit: r1838320 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/seed/OrderSeedData.xml datamodel/data/seed/ProductSeedData.xml order/src/main/java/org/apache/ofbiz/order/shoppi

Please read the comment in the related ticket [1] https://issues.apache.org/jira/browse/OFBIZ-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584721#comment-16584721 Best regards, Pierre Smits Apache Trafodion , Vice President Apache

Re: svn commit: r1838320 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/seed/OrderSeedData.xml datamodel/data/seed/ProductSeedData.xml order/src/main/java/org/apache/ofbiz/order/shoppi

How do these citations relate to Suraj‘s work? Please provide arguments in your own words if you think someone‘s work has flaws and should be reverted. Thanks, Michael > Am 18.08.2018 um 13:54 schrieb Pierre Smits : > > As Michael recently pointed out in another thread: > > {quote} > > *If

Re: svn commit: r1838320 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/seed/OrderSeedData.xml datamodel/data/seed/ProductSeedData.xml order/src/main/java/org/apache/ofbiz/order/shoppi

As Michael recently pointed out in another thread: {quote} *If it does break anything or introduces functionality which is not working completely, we should revert.* {quote} And: {quote} *We are struggling with half baked, incomplete or buggy code in several areas which often shows up a long

Re: svn commit: r1838320 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/seed/OrderSeedData.xml datamodel/data/seed/ProductSeedData.xml order/src/main/java/org/apache/ofbiz/order/shoppi

Hi Pierre, This is not a new patch, this is updated version of two years old patch which has been already reviewed if you follow comments on ticket. We need to add updated patch as well since many file path have been changed and we have data files refactoring as well. HTH. -- Best Regards, Suraj

Re: svn commit: r1838320 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/seed/OrderSeedData.xml datamodel/data/seed/ProductSeedData.xml order/src/main/java/org/apache/ofbiz/order/shoppi

Hi Suraj, Please revert! Within 10 minutes you posted a new patch and committed it to trunk and closed the issue. It is customary to follow the 72 hr delay rule to allow the community to review the changes and assess the impact. Best regards, Pierre Smits Apache Trafodion