Nice one, thanks Swapnil!
Regards
Scott
On Thu, 21 Mar 2019, 01:25 Swapnil M Mane, wrote:
> Done with the suggested changes Scott.
>
> trunk at rev 1855898
> release18.12 at rev 1855899
> release17.12 at rev 1855900
> release16.11 at rev 1855901
>
> Thanks again for valuable inputs.
>
> - Best
Done with the suggested changes Scott.
trunk at rev 1855898
release18.12 at rev 1855899
release17.12 at rev 1855900
release16.11 at rev 1855901
Thanks again for valuable inputs.
- Best Regards,
Swapnil M Mane,
ofbiz.apache.org
On Fri, Mar 15, 2019 at 9:52 AM Swapnil M Mane
wrote:
> Makes pe
Makes perfect sense, thanks so much for the input Scott.
I will do the suggested changes.
- Best Regards,
Swapnil M Mane,
ofbiz.apache.org
On Fri, Mar 15, 2019 at 5:36 AM Scott Gray
wrote:
> Hi Swapnil,
>
> A minor thing, but I wonder if it would be better to move this check
> underneath nod
Hi Swapnil,
A minor thing, but I wonder if it would be better to move this check
underneath node.getTextContent()? If we assume that most nodes will
contain text then it might be more efficient to do a null check after
retrieving nodeValue.
e.g.
Node node = (Node) obj;
String nodeValue = node.g
