Re: svn commit: r1864832 - in /ofbiz/ofbiz-framework/trunk: applications/accounting/config/ applications/order/template/order/ applications/order/widget/ordermgr/ framework/base/src/main/java/org/apac

Nicolas Malin writes: > On 8/10/19 12:07 AM, Mathieu Lirzin wrote: > >> Here are a few inline comments regarding the code. >> >> Maybe I overlooked some good reason justifying some design decision you >> made, so if you want to discuss more about the suggestions I proposed, >> we can do some

Re: svn commit: r1864832 - in /ofbiz/ofbiz-framework/trunk: applications/accounting/config/ applications/order/template/order/ applications/order/widget/ordermgr/ framework/base/src/main/java/org/apac

On 8/10/19 12:07 AM, Mathieu Lirzin wrote: Hello Nicolas, Hi man, Here are a few inline comments regarding the code. Maybe I overlooked some good reason justifying some design decision you made, so if you want to discuss more about the suggestions I proposed, we can do some pair programming

Re: svn commit: r1864832 - in /ofbiz/ofbiz-framework/trunk: applications/accounting/config/ applications/order/template/order/ applications/order/widget/ordermgr/ framework/base/src/main/java/org/apac

Hello Nicolas, Here are a few inline comments regarding the code. Maybe I overlooked some good reason justifying some design decision you made, so if you want to discuss more about the suggestions I proposed, we can do some pair programming next week. nma...@apache.org writes: > Author: nmalin