Re: why some fields are set to enable-audit-log true by default?

2018-04-05 Thread Jacques Le Roux
Le 05/04/2018 à 13:25, Jacques Le Roux a écrit : Le 05/04/2018 à 11:49, Taher Alkhateeb a écrit : Hmm, I see no problem in example being a plugin. Just because it's a plugin doesn't mean it lost its value or purpose (to give people examples). So sounds good by me to add such fields to the

Re: why some fields are set to enable-audit-log true by default?

2018-04-05 Thread Jacques Le Roux
Le 05/04/2018 à 11:49, Taher Alkhateeb a écrit : Hmm, I see no problem in example being a plugin. Just because it's a plugin doesn't mean it lost its value or purpose (to give people examples). So sounds good by me to add such fields to the example component. Just that people using OFBiz

Re: why some fields are set to enable-audit-log true by default?

2018-04-05 Thread Taher Alkhateeb
Hmm, I see no problem in example being a plugin. Just because it's a plugin doesn't mean it lost its value or purpose (to give people examples). So sounds good by me to add such fields to the example component. In fact, I would suggest that not only add them, but show the users how to view the

Re: why some fields are set to enable-audit-log true by default?

2018-04-05 Thread Jacques Le Roux
I'm not sure about Example component, it's now a plugin... Maybe having an example in Entity component for the test is enough? Also there is the auto-completion from XSD But anyway not against Example component Jacques Le 05/04/2018 à 11:36, Rishi Solanki a écrit : +1 for removal. +1 to

Re: why some fields are set to enable-audit-log true by default?

2018-04-05 Thread Rishi Solanki
+1 for removal. +1 to Scott for having an example in the system ... Example entities seems right place as mentioned. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Apr 5, 2018 at 5:38

Re: why some fields are set to enable-audit-log true by default?

2018-04-04 Thread Scott Gray
It would be good to leave it on somewhere in the system like the example entities maybe On Wed, 4 Apr 2018, 22:13 Jacques Le Roux, wrote: > Le 04/04/2018 à 12:07, Taher Alkhateeb a écrit : > > I'm not sure about the field in the entity component though! it > >

Re: why some fields are set to enable-audit-log true by default?

2018-04-04 Thread Jacques Le Roux
Le 04/04/2018 à 12:07, Taher Alkhateeb a écrit : I'm not sure about the field in the entity component though! it might be needed in some unit tests? Yes Jacques

Re: why some fields are set to enable-audit-log true by default?

2018-04-04 Thread Taher Alkhateeb
+1 to their removal. A quick grep lists the fields which have that flag. I'm not sure about the field in the entity component though! it might be needed in some unit tests? framework/entity/entitydef/entitymodel_test.xml: applications/datamodel/entitydef/order-entitymodel.xml:

Re: why some fields are set to enable-audit-log true by default?

2018-04-04 Thread pierre.gaudin
Hi, Thanks Nicolas to point to this issue. I also think that this attribute should be used only for technical purpose, not for functional purposes. Pierre On 04/04/2018 08:54, Jacques Le Roux wrote: Hi, Moving this discussion from user ML I agree Nicolas, I see no reasons to OOTB enable

Re: why some fields are set to enable-audit-log true by default?

2018-04-04 Thread Jacques Le Roux
Hi, Moving this discussion from user ML I agree Nicolas, I see no reasons to OOTB enable audit log in any of the fields which currently supports it. Not sure if we need to go with extending entities. Note: the only entities concerned are OrderItem, OrderItemShipGroup, ReturnItem Jacques