[jira] [Commented] (OFBIZ-7705) Remove Google Checkout component from specialpurpose as it was discontinued

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360869#comment-15360869
 ] 

Deepak Dixit commented on OFBIZ-7705:
-

I think we can simply remove this from code instead of adding it to attic. 
Google checkout support totally discontinued by Google since 5/20/13, so IMO 
there is no sense to moving this to attic.

{quote}
 An update to Google Checkout for merchants
5/20/13
Today, we’re letting web merchants know that in six months, Google Checkout 
will be retired as we transition to Google Wallet 
{quote}

{quote}
What this means for Checkout merchants Merchants can continue to accept 
payments using Google Checkout until November 20, 2013.
{quote}

> Remove Google Checkout component from specialpurpose as it was discontinued
> ---
>
> Key: OFBIZ-7705
> URL: https://issues.apache.org/jira/browse/OFBIZ-7705
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/googleCheckout
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ravi Lodhi
>
> As we all know that Google Checkout was discontinued on November 20, 2013. I 
> think we should remove this component.
> Some references-
> http://googlecommerce.blogspot.in/2013/05/an-update-to-google-checkout-for.html
> https://en.wikipedia.org/wiki/Google_Checkout
> Let me know what other community members think.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7705) Remove Google Checkout component from specialpurpose as it was discontinued

[Ravi Lodhi (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360866#comment-15360866
 ] 

Ravi Lodhi commented on OFBIZ-7705:
---

Google Base service is also discontinued by google. So I think it should also 
go in Attic. I have
created a ticket OFBIZ-7727 for this.

> Remove Google Checkout component from specialpurpose as it was discontinued
> ---
>
> Key: OFBIZ-7705
> URL: https://issues.apache.org/jira/browse/OFBIZ-7705
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/googleCheckout
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ravi Lodhi
>
> As we all know that Google Checkout was discontinued on November 20, 2013. I 
> think we should remove this component.
> Some references-
> http://googlecommerce.blogspot.in/2013/05/an-update-to-google-checkout-for.html
> https://en.wikipedia.org/wiki/Google_Checkout
> Let me know what other community members think.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7727) Remove Google Base component from specialpurpose as it is discontinued

[Ravi Lodhi (JIRA)]

Ravi Lodhi created OFBIZ-7727:
-

 Summary: Remove Google Base component from specialpurpose as it is 
discontinued
 Key: OFBIZ-7727
 URL: https://issues.apache.org/jira/browse/OFBIZ-7727
 Project: OFBiz
  Issue Type: Improvement
  Components: specialpurpose/googlebase
Affects Versions: Trunk
Reporter: Ravi Lodhi
Assignee: Ravi Lodhi


Google Base service is discontinued. So I think this should also go in Attic 
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Attic

Some References:
https://en.wikipedia.org/wiki/Google_Base
https://en.wikipedia.org/wiki/Category:Discontinued_Google_services
http://googlebase.blogspot.in/2009/09/introducing-google-merchant-center.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: http://www.brains-info.com/

[james yong]

I did not find any reference to OFBiz in the website brains-info.com.


Jacques Le Roux wrote
> Hi Chinese committers,
> 
> Could one of you check that http://www.brains-info.com/ is really related
> to OFBiz?
> 
> It's referenced from
> https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+User+List
> 
> Thanks
> 
> Jacques





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/http-www-brains-info-com-tp4687388p4687401.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

[jira] [Assigned] (OFBIZ-7715) Enforce noninstantiability to SqlJdbcUtil class

[Rohit Koushal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal reassigned OFBIZ-7715:


Assignee: Rohit Koushal

> Enforce noninstantiability to SqlJdbcUtil class
> ---
>
> Key: OFBIZ-7715
> URL: https://issues.apache.org/jira/browse/OFBIZ-7715
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Rohit Koushal
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final int CHAR_BUFFER_SIZE = 4096;
> {code}
> - Make the following protected variable as private and move it and static 
> block to top of class.
> {code}
> protected static Map fieldTypeMap = new HashMap Integer>();
> static {
> fieldTypeMap.put("java.lang.String", 1);
> fieldTypeMap.put("String", 1);
> fieldTypeMap.put("java.sql.Timestamp", 2);
> fieldTypeMap.put("Timestamp", 2);
> fieldTypeMap.put("java.sql.Time", 3);
> fieldTypeMap.put("Time", 3);
> fieldTypeMap.put("java.sql.Date", 4);
> fieldTypeMap.put("Date", 4);
> fieldTypeMap.put("java.lang.Integer", 5);
> fieldTypeMap.put("Integer", 5);
> fieldTypeMap.put("java.lang.Long", 6);
> fieldTypeMap.put("Long", 6);
> fieldTypeMap.put("java.lang.Float", 7);
> fieldTypeMap.put("Float", 7);
> fieldTypeMap.put("java.lang.Double", 8);
> fieldTypeMap.put("Double", 8);
> fieldTypeMap.put("java.math.BigDecimal", 9);
> fieldTypeMap.put("BigDecimal", 9);
> fieldTypeMap.put("java.lang.Boolean", 10);
> fieldTypeMap.put("Boolean", 10);
> fieldTypeMap.put("java.lang.Object", 11);
> fieldTypeMap.put("Object", 11);
> fieldTypeMap.put("java.sql.Blob", 12);
> fieldTypeMap.put("Blob", 12);
> fieldTypeMap.put("byte[]", 12);
> fieldTypeMap.put("java.nio.ByteBuffer", 12);
> fieldTypeMap.put("java.nio.HeapByteBuffer", 12);
> fieldTypeMap.put("java.sql.Clob", 13);
> fieldTypeMap.put("Clob", 13);
> fieldTypeMap.put("java.util.Date", 14);
> // all of these treated as Collection
> fieldTypeMap.put("java.util.ArrayList", 15);
> fieldTypeMap.put("java.util.HashSet", 15);
> fieldTypeMap.put("java.util.LinkedHashSet", 15);
> fieldTypeMap.put("java.util.LinkedList", 15);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-5130) getProductCost causes stack overflow if product has mutual variants

[Divesh Dutta (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360847#comment-15360847
 ] 

Divesh Dutta commented on OFBIZ-5130:
-

[~dagrawal] please give your inputs on real world use case of mutual variants . 
If we do not get your inputs in next few days then I will discard this ticket. 

> getProductCost causes stack overflow if product has mutual variants
> ---
>
> Key: OFBIZ-5130
> URL: https://issues.apache.org/jira/browse/OFBIZ-5130
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Deepak Agarwal
>Assignee: Divesh Dutta
>  Labels: crash
> Attachments: OFBiz-5130.patch
>
>
> Cost of product A = 0
> Cost of product B = 0
> B is variant of A and A is variant of B.
> Now getProductCost causes a never ending recursive loop. This causes jvm to 
> exit (prior to Jdk1.6_34, atleast in my knowledge) without any crash dump.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7726) Add UI labels for success / eror messages in Accounting component.

[Tanmay Muley (JIRA)]

Tanmay Muley created OFBIZ-7726:
---

 Summary: Add UI labels for success / eror messages in Accounting 
component.
 Key: OFBIZ-7726
 URL: https://issues.apache.org/jira/browse/OFBIZ-7726
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Trunk
Reporter: Tanmay Muley
Assignee: Tanmay Muley
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7695) Add UI labels for success / eror messages in java and groovy files

[Tanmay Muley (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tanmay Muley reassigned OFBIZ-7695:
---

Assignee: Tanmay Muley

> Add UI labels for success / eror messages in java and groovy files
> --
>
> Key: OFBIZ-7695
> URL: https://issues.apache.org/jira/browse/OFBIZ-7695
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Tanmay Muley
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7717) Enforce noninstantiability to EntityTypeUtil class

[Rahul Singh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Singh updated OFBIZ-7717:
---
Attachment: OFBIZ-7717.patch

> Enforce noninstantiability to EntityTypeUtil class
> --
>
> Key: OFBIZ-7717
> URL: https://issues.apache.org/jira/browse/OFBIZ-7717
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-7717.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7717) Enforce noninstantiability to EntityTypeUtil class

[Rahul Singh (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360818#comment-15360818
 ] 

Rahul Singh commented on OFBIZ-7717:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description.

> Enforce noninstantiability to EntityTypeUtil class
> --
>
> Key: OFBIZ-7717
> URL: https://issues.apache.org/jira/browse/OFBIZ-7717
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7682) Define and add new entity for 'Check' as Payment Method

[Swapnil Shah (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360806#comment-15360806
 ] 

Swapnil Shah commented on OFBIZ-7682:
-

Yes, In fact i have checked with few clients using EFT very frequently and they 
have already customized it by extending 'Branch Code'. I have create OFBIZ-7725 
for it now.  

> Define and add new entity for 'Check' as Payment Method
> ---
>
> Key: OFBIZ-7682
> URL: https://issues.apache.org/jira/browse/OFBIZ-7682
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7682.patch
>
>
> Based on the concluded requirement on OFBIZ-6899. Let's define Check as new 
> entity as follows (somewhat on similar lines as EFT_ACCOUNT) so as to store 
> all relevant details related to Check used as payment method for any party.
> PAYMENT_METHOD_ID (PK & FK with PAYMENT_METHOD)
> BANK_NAME
> ROUTING_NUMBER
> ACCOUNT_TYPE
> ACCOUNT_NUMBER
> NAME_ON_ACCOUNT
> COMPANY_NAME_ON_ACCOUNT
> CONTACT_MECH_ID (FK with CONTACT_MECH & POSTAL_ADDRESS)
> LAST_UPDATED_STAMP
> LAST_UPDATED_TX_STAMP
> CREATED_STAMP
> CREATED_TX_STAMP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7725) Extend EftAccount entity with 'branchCode' and provide necessary support in code and UI

[Swapnil Shah (JIRA)]

Swapnil Shah created OFBIZ-7725:
---

 Summary: Extend EftAccount entity with 'branchCode' and provide 
necessary support in code and UI
 Key: OFBIZ-7725
 URL: https://issues.apache.org/jira/browse/OFBIZ-7725
 Project: OFBiz
  Issue Type: New Feature
  Components: accounting
Affects Versions: 14.12.01, 15.12.01
Reporter: Swapnil Shah
Assignee: Swapnil Shah


Let's extend EftAccount by adding 'BranchCode' that could indicate the branch 
code of the Bank through which Eft Account is linked, It could be allowed to 
optionally set for any existing and new EftAccount in Ofbiz system.

Let's ask for 'Branch Code' with other details while Eft Account is being 
added/edited from UI (e..g Party >> Profile etc.).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

[Michael Brohl (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360695#comment-15360695
 ] 

Michael Brohl commented on OFBIZ-7534:
--

Lucene and solr jars are added to the list and compiled ok.

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, 
> gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7627) Workeffort Agreement Appls redirect to wrong page and also gives error

[Mridul Pathak (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mridul Pathak reassigned OFBIZ-7627:


Assignee: Mridul Pathak

> Workeffort Agreement Appls redirect to wrong page and also gives error
> --
>
> Key: OFBIZ-7627
> URL: https://issues.apache.org/jira/browse/OFBIZ-7627
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Ankit Joshi
>Assignee: Mridul Pathak
> Attachments: AgreementRedirectError.png, OFBIZ-7627.patch
>
>
> Steps to regenerate -
> 1) Navigate to Workeffort -> Workeffort
> 2) Search existing work efforts from Find Work Effort screen and go to its 
> detail page.
> 3) Click on Agreement Appls tab to add / view work effort agreement applics.
> 4) Add agreement applics for work effort if does not found any.
> 5) Select AgreementId listed there to view the Agreement detail page.
> Expected : It should redirect to Agreement detail page.
> Actual :  It redirects to List Agreements page and also page got broken.
> Here is the reference link -
> https://ofbiz-vm.apache.org:8443/workeffort/control/EditAgreementWorkEffortApplics?workEffortId=TASK_COST



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7609) Work Effort keywords are not listing

[Mridul Pathak (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mridul Pathak reassigned OFBIZ-7609:


Assignee: Mridul Pathak

> Work Effort keywords are not listing 
> -
>
> Key: OFBIZ-7609
> URL: https://issues.apache.org/jira/browse/OFBIZ-7609
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Ankit Joshi
>Assignee: Mridul Pathak
> Attachments: OFBIZ-7609.patch
>
>
> Steps to regenerate- 
> 1) Navigate to Workeffort -> Workeffort
> 2) Search existing work efforts from Find Work Effort screen and go to its 
> detail page.
> 3) Click on Keywords tab to add Work Effort Keywords.
> 4) Add single or multiple keywords for the work effort.
> Expected : Work Effort keywords should be added and listed there.
> Actual : Work Effort keywords are added but not displayed there.
> Here is the reference link -
> https://ofbiz-vm.apache.org:8443/workeffort/control/EditWorkEffortKeywords?workEffortId=TASK_COST



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

[Michael Brohl (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360553#comment-15360553
 ] 

Michael Brohl commented on OFBIZ-7534:
--

Ok, I have tested the tomcat/catalina and entity libs. They compile ok.

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, 
> gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

http://www.brains-info.com/

[Jacques Le Roux]

Hi Chinese committers,

Could one of you check that http://www.brains-info.com/ is really related to 
OFBiz?

It's referenced from 
https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+User+List

Thanks

Jacques

[jira] [Commented] (OFBIZ-4956) "auth" should be true for all the request url used for Application components.

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360512#comment-15360512
 ] 

Jacques Le Roux commented on OFBIZ-4956:


Thanks for the reminder Ashish.

> "auth" should be true for all the request url used for Application components.
> --
>
> Key: OFBIZ-4956
> URL: https://issues.apache.org/jira/browse/OFBIZ-4956
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Release 
> Branch 13.07, Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-4956-Release-10.04.patch, 
> OFBIZ-4956-Release-11.04.patch, OFBIZ-4956.patch
>
>
> Currently there are some url present in application components with 
> auth="false". So anyone can hit this urls and can access any resources 
> without authorization. 
> For Example - 
> https://demo-trunk.ofbiz.apache.org:8443/content/control/ViewSimpleContent?dataResourceId=GZ-DIG
> Currently, the above url does not need authorization (you can access any 
> resource by changing the dataResourceId). I think all the url should be 
> secure with auth="true" and https="true" in all the application components. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7723) Use grunt-md2html to integrate our README.MD from repo to Confluence

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7723:
---
Issue Type: Sub-task  (was: Task)
Parent: OFBIZ-7534

> Use grunt-md2html to integrate our README.MD from repo to Confluence
> 
>
> Key: OFBIZ-7723
> URL: https://issues.apache.org/jira/browse/OFBIZ-7723
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> See INFRA-12200 for details



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7724) System allows to change status from cancel to empty for return

[Ankush Upadhyay (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-7724:
---
Attachment: OFBIZ-7724.patch

> System allows to change status from cancel to empty for return 
> ---
>
> Key: OFBIZ-7724
> URL: https://issues.apache.org/jira/browse/OFBIZ-7724
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, order
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-7724.patch
>
>
> Steps to replicate:
> 1. Create Return from Order Manager.
> 2. Changes status to cancelled to empty.
> Actually Result:
> System throws FreeMarker template error and system does not honour 
> allow-empty flag to display or hide empty option in drop-down.
> Expected: System should not show throw free marker template error or even it 
> should not display empty status as this is not a valid status change.
> Also system should honour allow-empty flag to render empty value in drop-down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7724) System allows to change status from cancel to empty for return

[Ankush Upadhyay (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-7724:
---
Component/s: framework

> System allows to change status from cancel to empty for return 
> ---
>
> Key: OFBIZ-7724
> URL: https://issues.apache.org/jira/browse/OFBIZ-7724
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, order
>Affects Versions: Upcoming Branch
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
>
> Steps to replicate:
> 1. Create Return from Order Manager.
> 2. Changes status to cancelled to empty.
> Actually Result:
> System throws FreeMarker template error and system does not honour 
> allow-empty flag to display or hide empty option in drop-down.
> Expected: System should not show throw free marker template error or even it 
> should not display empty status as this is not a valid status change.
> Also system should honour allow-empty flag to render empty value in drop-down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7724) System allows to change status from cancel to empty for return

[Ankush Upadhyay (JIRA)]

Ankush Upadhyay created OFBIZ-7724:
--

 Summary: System allows to change status from cancel to empty for 
return 
 Key: OFBIZ-7724
 URL: https://issues.apache.org/jira/browse/OFBIZ-7724
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Upcoming Branch
Reporter: Ankush Upadhyay
Assignee: Ankush Upadhyay


Steps to replicate:
1. Create Return from Order Manager.
2. Changes status to cancelled to empty.

Actually Result:
System throws FreeMarker template error and system does not honour allow-empty 
flag to display or hide empty option in drop-down.

Expected: System should not show throw free marker template error or even it 
should not display empty status as this is not a valid status change.
Also system should honour allow-empty flag to render empty value in drop-down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7723) Use grunt-md2html to integrate our README.MD from repo to Confluence

[Jacques Le Roux (JIRA)]

Jacques Le Roux created OFBIZ-7723:
--

 Summary: Use grunt-md2html to integrate our README.MD from repo to 
Confluence
 Key: OFBIZ-7723
 URL: https://issues.apache.org/jira/browse/OFBIZ-7723
 Project: OFBiz
  Issue Type: Task
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Jacques Le Roux
Priority: Minor
 Fix For: Upcoming Branch


See INFRA-12200 for details



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-4467) Improve auto-fields-entity (select include field and auto drop-down)

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360503#comment-15360503
 ] 

Jacques Le Roux commented on OFBIZ-4467:


I reviewed the current patch, +1

> Improve auto-fields-entity (select include field and auto drop-down)
> 
>
> Key: OFBIZ-4467
> URL: https://issues.apache.org/jira/browse/OFBIZ-4467
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Screen Widget Redesign, Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-4467-example.patch, OFBIZ-4467-example.patch, 
> OFBIZ-4467.patch, OFBIZ-4467.patch, OFBIZ-4467.patch, OFBIZ-4467.png
>
>
> Hi
> Here are two improvments to complete the element 'auto-fields-entity' of 
> forms.
> The first one consists in adding one fields allowing to select which fields 
> are include in the form (same way as what is made on the definitions of 
> service):
> For example:
>  default-field-type="display"/>
> => To display only the primary key fields of the Example entity
>  default-field-type="edit">
> => To display only the non primary key fields of the Example entity
> 
> => To exclude one precise fields of an entity
> The second one consists in including for fields with relation a drop-down or 
> a display entity  according to EntityType
> Any comments are welcome



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-4467) Improve auto-fields-entity (select include field and auto drop-down)

[Nicolas Malin (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360495#comment-15360495
 ] 

Nicolas Malin commented on OFBIZ-4467:
--

Ok Ashish I will do it ;)

> Improve auto-fields-entity (select include field and auto drop-down)
> 
>
> Key: OFBIZ-4467
> URL: https://issues.apache.org/jira/browse/OFBIZ-4467
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Screen Widget Redesign, Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-4467-example.patch, OFBIZ-4467-example.patch, 
> OFBIZ-4467.patch, OFBIZ-4467.patch, OFBIZ-4467.patch, OFBIZ-4467.png
>
>
> Hi
> Here are two improvments to complete the element 'auto-fields-entity' of 
> forms.
> The first one consists in adding one fields allowing to select which fields 
> are include in the form (same way as what is made on the definitions of 
> service):
> For example:
>  default-field-type="display"/>
> => To display only the primary key fields of the Example entity
>  default-field-type="edit">
> => To display only the non primary key fields of the Example entity
> 
> => To exclude one precise fields of an entity
> The second one consists in including for fields with relation a drop-down or 
> a display entity  according to EntityType
> Any comments are welcome



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

[Gil Portenseigne (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360484#comment-15360484
 ] 

Gil Portenseigne edited comment on OFBIZ-7534 at 7/3/16 9:38 AM:
-

All help is welcome, we need to find a get the correct jcenter URL ( 
bintray.com/bintray/jcenter ) for each jar mentionned in the post. The goal is 
to replace the jar in OFBiz by the corresponding remote one.

For that purpose we created a framacalc to store the references for each jar : 
https://framacalc.org/OFBizRemoteJarList

Feel free to edit it to add the corresponding remote you found and for each be 
sure to get the right lib, if uncertain : 
# delete the local lib
# download the remote lib to the same location
# compile
 
The syntax to follow is :
Syntax: '::'
Example: 'org.apache.commons:commons-dbcp2:2.1.1'



was (Author: gil portenseigne):
All help is welcome, we need to find a get the correct jcenter URL ( 
bintray.com/bintray/jcenter ) for each jar mentionned in the post. The goal is 
to replace the jar in OFBiz by the corresponding remote one.

For that purpose we created a framacalc to store the references for each jar : 
https://framacalc.org/OFBizRemoteJarList

Feel free to edit it to add the corresponding remote you found and for each be 
sure to get the right lib, if uncertain : 
# delete the local lib
# download the remote lib to the same location
# compile
 


> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, 
> gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

[Gil Portenseigne (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360484#comment-15360484
 ] 

Gil Portenseigne commented on OFBIZ-7534:
-

All help is welcome, we need to find a get the correct jcenter URL ( 
bintray.com/bintray/jcenter ) for each jar mentionned in the post. The goal is 
to replace the jar in OFBiz by the corresponding remote one.

For that purpose we created a framacalc to store the references for each jar : 
https://framacalc.org/OFBizRemoteJarList

Feel free to edit it to add the corresponding remote you found and for each be 
sure to get the right lib, if uncertain : 
# delete the local lib
# download the remote lib to the same location
# compile
 


> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, 
> gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Important Changes to Trunk and Use of Ant & Gradle

[Taher Alkhateeb]

Hello Everyone,

I am very happy and thrilled to announce that OFBiz now has a skeleton for
a plug-in system without any changes to the code base :)

How did we design it
--
- Add all the components defined in framework/component-load.xml as gradle
subprojects
- Add all the components defined in applications/component-load.xml as
gradle subprojects
- Add all the components defined in specialcomponents/component-load.xml as
gradle subprojects
- Add the start component as a gradle subproject
- Add all the components in /hot-deploy as gradle subprojects
- Each subproject can _optionally_ have a build.gradle script
- If a directory exists in framework, applications or specialpurpose but is
not defined in component-load.xml, then it will be considered a dead
folder, it will not even compile and it will not be part of OFBiz and your
IDE will ignore it.

What are the benefits
---
- Each subproject can declare its own library dependencies in its own
build.gradle away from the framework
- Compilation, running, and testing is centralized at the master build
script, making the subproject build scripts very small
- It is very easy now to "turn on" or "turn off" a plugin with a build
script that simply removes/adds it to component-load.xml!
- We can now design a full plug-in API and can design a full eco-system
around OFBiz.
- If we decide to, we do not _have to_ compile and test everything, we can
offload the maintenance of plugins to specialized teams, or even to third
parties.

So, maximum benefits without any code changes (except for may 30-40 lines
in the build scripts). I have a few ideas for a full API design in the
future (another thread perhaps) for these plugins (in gradle). The API
could contain tasks like:
- installPlugin
- activatePlugin
- deactivatePlugin
- uninstallPlugin
- etc ...

The latest patch in https://issues.apache.org/jira/browse/OFBIZ-7534 has
everything that I described above with all tests passing. Try it and enjoy.
Just comment-out any component in component-load.xml and observe how it
does not exist anymore :)



On Mon, Jun 27, 2016 at 6:30 PM, Taher Alkhateeb  wrote:

> Hey Everyone,
>
> I am exhausted, but I have a working patch in
> https://issues.apache.org/jira/browse/OFBIZ-7534
>
> This patch introduces gradle with all tests passing. I have also added a
> new README.md file which documents how to use this system. I think you will
> find the README.md file valuable for guidance on how to use and test. This
> is a big patch and requires a LOT of testing, so I need everyone to jump on
> board and help please.
>
> Oh, and I have a little rant
>
> == rant begins ==
> The classpath issues I faced with OFBiz are really horrible, and the
> design of the code base around classpaths is one of the worst I've even
> seen in my life. I cannot even fathom why we seperate classpaths for
> components and use this weird custom classloader. It took me so much time
> and thinking in delivering this patch just because of this damn issue
> == rant ends ==
>
> The executable is huge if you type ps ax|grep java. This is because of the
> unfortunately large and complex classpath. I will clean that up slowly as
> we progress.
>
> I look forward to your help and feedback.
>
> Taher Alkhateeb
>
> On Thu, Jun 23, 2016 at 6:23 PM, Taher Alkhateeb <
> slidingfilame...@gmail.com> wrote:
>
>> Hey Guys,
>>
>> I've attached a text file in
>> https://issues.apache.org/jira/browse/OFBIZ-7534
>>
>> This text file shows the old ant commands and how I implemented them
>> (most of them anyway) in Gradle. Please review it and provide your feedback:
>>
>> - Does it look correct?
>> - Are the parameters corrects?
>> - Are there any important missing tasks?
>> - Do you want to provide shorter versions for some of the tasks?
>>
>> Note, I only created two real short commands for OFBiz server commands:
>> loadDemo and testInteg. These exist because the most common command in
>> OFBiz would be ./gradlew cleanAll loadDemo testInteg
>>
>> I look forward to your feedback.
>>
>> Taher Alkhateeb
>>
>> On Wed, Jun 22, 2016 at 11:12 PM, Taher Alkhateeb <
>> slidingfilame...@gmail.com> wrote:
>>
>>> Hi Jacques,
>>>
>>> Thank you for the explanation. OK, between your feedback and the votes
>>> from other members, I'll keep them. Working on integration in gradle ...
>>>
>>> Cheers
>>>
>>> Taher Alkhateeb
>>>
>>> On Wed, Jun 22, 2016 at 11:08 PM, Jacques Le Roux <
>>> jacques.le.r...@les7arts.com> wrote:
>>>
 Hi Taher,

 Inline...

 Le 22/06/2016 à 16:23, Taher Alkhateeb a écrit :

> Hi Michael Jacques and everyone,
>
> So I also want to confirm that you really need the following tasks:
>
> - build-dev
> - build-production
> - build-qa
> - build-test
> - revert-dev
>

 I introduced those for a custom project and improved it in the
 following project I worked on. So 

[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system

[Taher Alkhateeb (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Taher Alkhateeb updated OFBIZ-7534:
---
Attachment: OFBIZ-7534.patch

In addition to everything mentioned in the previous patches, this patch 
introduces a skeleton for an OFBiz plug-in system.

How did we design it
--
- Add all the components defined in framework/component-load.xml as gradle 
subprojects
- Add all the components defined in applications/component-load.xml as gradle 
subprojects
- Add all the components defined in specialcomponents/component-load.xml as 
gradle subprojects
- Add the start component as a gradle subproject
- Add all the components in /hot-deploy as gradle subprojects
- Each subproject can _optionally_ have a build.gradle script
- If a directory exists in framework, applications or specialpurpose but is not 
defined in component-load.xml, then it will be considered a dead folder, it 
will not even compile and it will not be part of OFBiz and your IDE will ignore 
it.

What are the benefits
---
- Each subproject can declare its own library dependencies in its own 
build.gradle away from the framework
- Compilation, running, and testing is centralized at the master build script, 
making the subproject build scripts very small
- It is very easy now to "turn on" or "turn off" a plugin with a build script 
that simply removes/adds it to component-load.xml!
- We can now design a full plug-in API and can design a full eco-system around 
OFBiz.
- If we decide to, we do not _have to_ compile and test everything, we can 
offload the maintenance of plugins to specialized teams, or even to third 
parties.

> Migrate OFBiz from Apache Ant to Gradle build system
> 
>
> Key: OFBIZ-7534
> URL: https://issues.apache.org/jira/browse/OFBIZ-7534
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: ant, build-tools, gradle
> Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, 
> OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, build.gradle, 
> gradle-wrapper.jar
>
>
> This is a major refactoring task referring to the [email 
> thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle]
>  in which the community voted for the switch after a proposal from the PMC
> The purpose of this JIRA is to achieve the following objectives
> - Fully implement a working compiling system in Gradle that passes all tests
> - Remove all ant and maven build scripts from the system
> - update the documentation of the system to reflect these changes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-4467) Improve auto-fields-entity (select include field and auto drop-down)

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-4467:
--

Assignee: Nicolas Malin  (was: Ashish Vijaywargiya)

Hello Nicolas,

Please take this issue further and conclude things. Thanks!

> Improve auto-fields-entity (select include field and auto drop-down)
> 
>
> Key: OFBIZ-4467
> URL: https://issues.apache.org/jira/browse/OFBIZ-4467
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Screen Widget Redesign, Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-4467-example.patch, OFBIZ-4467-example.patch, 
> OFBIZ-4467.patch, OFBIZ-4467.patch, OFBIZ-4467.patch, OFBIZ-4467.png
>
>
> Hi
> Here are two improvments to complete the element 'auto-fields-entity' of 
> forms.
> The first one consists in adding one fields allowing to select which fields 
> are include in the form (same way as what is made on the definitions of 
> service):
> For example:
>  default-field-type="display"/>
> => To display only the primary key fields of the Example entity
>  default-field-type="edit">
> => To display only the non primary key fields of the Example entity
> 
> => To exclude one precise fields of an entity
> The second one consists in including for fields with relation a drop-down or 
> a display entity  according to EntityType
> Any comments are welcome



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-5027) Product Facility record should be created in case of its no record when calling setLastInventoryCount service as EECA.

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-5027:
--

Assignee: Amardeep Singh Jhajj  (was: Ashish Vijaywargiya)

Hello Amardeep,

Please take this issue further and conclude things. Please feel free to assign 
it back to me as you are done with this or take Pranay's help in committing the 
changes.

Thanks!

> Product Facility record should be created in case of its no record when 
> calling setLastInventoryCount service as EECA.
> --
>
> Key: OFBIZ-5027
> URL: https://issues.apache.org/jira/browse/OFBIZ-5027
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
>Priority: Minor
> Attachments: OFBIZ-5027-Release-10.04.patch, 
> OFBIZ-5027-Release-11.04.patch, OFBIZ-5027-trunk.patch
>
>
> Currently, ProductFacility record is updated by setLastInventoryCount service 
> when create-store-remove operation performed on InventoryItemDetail entity 
> (by EECA). 
> This service is called to update lastInventoryCount field in ProductFacility 
> and this field  helps us for checking product in-stock/out-of-stock.
> This service helps only when ProductFacility will already present. Suppose, 
> if catalog manager forgot to setup facility or deleted it at
> https://demo-trunk.ofbiz.apache.org:8443/catalog/control/EditProductFacilities?productId=WG-9943-B3
> and just setup Inventory during product setup then setLastInventoryCount 
> service would not be helpful.
> So in my opinion, here ProductFacility should be first created in case of its 
> no record when updating lastInventoryCount in ProductFacility.
> I am attaching patch for the same here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-4956) "auth" should be true for all the request url used for Application components.

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-4956:
--

Assignee: Amardeep Singh Jhajj  (was: Ashish Vijaywargiya)

Hello Amardeep,

Please take this issue further and conclude things. Once you are done with 
finalization then please feel free to assign this issue back to me or take 
Pranay's help in committing the changes to trunk. 

Thanks!  

> "auth" should be true for all the request url used for Application components.
> --
>
> Key: OFBIZ-4956
> URL: https://issues.apache.org/jira/browse/OFBIZ-4956
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Release 
> Branch 13.07, Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-4956-Release-10.04.patch, 
> OFBIZ-4956-Release-11.04.patch, OFBIZ-4956.patch
>
>
> Currently there are some url present in application components with 
> auth="false". So anyone can hit this urls and can access any resources 
> without authorization. 
> For Example - 
> https://demo-trunk.ofbiz.apache.org:8443/content/control/ViewSimpleContent?dataResourceId=GZ-DIG
> Currently, the above url does not need authorization (you can access any 
> resource by changing the dataResourceId). I think all the url should be 
> secure with auth="true" and https="true" in all the application components. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-5438) Virtual feature selection and selected variant price inconsistencies

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-5438:
--

Assignee: Mridul Pathak  (was: Ashish Vijaywargiya)

Hello Mridul,

Please take this issue further and conclude things. Thanks!

> Virtual feature selection and selected variant price inconsistencies
> 
>
> Key: OFBIZ-5438
> URL: https://issues.apache.org/jira/browse/OFBIZ-5438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Reporter: Christian Carlow
>Assignee: Mridul Pathak
>Priority: Minor
>
> To reproduce this issue:
> 1.  Create a sales order for DemoCustCompany
> 2.  Add WG-9944 to the cart
> 3.  Select Black (notice +$4.30) and 4-Wheels and click "Add to Cart"
> 4.  Click the check mark for the WG-9944 variant item that was added to the 
> cart and then click the "Remove Selected" button
> 5.  Navigate to the WG-9944 product features page
> 6.  Click feature 9000 to edit the Black Color feature
> 7.  Update the feature price from 4.3 to 1.3
> 8.  Add WG-9944 to the cart again by selecting the Black (notice now +$1.30) 
> and 4-Wheel feature options
> After step 9, notice that the item price is actually calculated using the 
> previous feature default price value even though the new feature price is 
> listed with the option.  
> A similar problem occurs if the virtual product default price is changed.  
> The feature selection page shows the updated virtual product price but once 
> the features are selected, the default price of the variant product which was 
> set when the variant was initially created is still set to the previous 
> default price that existed before the variant default price was changed.
> Maybe some logic should exist to check that the selected features prices add 
> up to the variant default price value and if they do not, then the previous 
> variant default price thruDate should be set and a new default price 
> consistent with the feature price sum created.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-5130) getProductCost causes stack overflow if product has mutual variants

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-5130:
--

Assignee: Divesh Dutta  (was: Ashish Vijaywargiya)

Hello Divesh,

Please take this issue further and conclude things. Thanks!

> getProductCost causes stack overflow if product has mutual variants
> ---
>
> Key: OFBIZ-5130
> URL: https://issues.apache.org/jira/browse/OFBIZ-5130
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Deepak Agarwal
>Assignee: Divesh Dutta
>  Labels: crash
> Attachments: OFBiz-5130.patch
>
>
> Cost of product A = 0
> Cost of product B = 0
> B is variant of A and A is variant of B.
> Now getProductCost causes a never ending recursive loop. This causes jvm to 
> exit (prior to Jdk1.6_34, atleast in my knowledge) without any crash dump.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7004) Allow to accept CDATA

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360456#comment-15360456
 ] 

Jacques Le Roux commented on OFBIZ-7004:


I agree could you provide a short example, or is there one already? (sorry a 
bit overbooked following HW great effort :D)

> Allow  to accept CDATA
> -
>
> Key: OFBIZ-7004
> URL: https://issues.apache.org/jira/browse/OFBIZ-7004
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-7004.patch, OFBIZ-7004.patch
>
>
> Currently, html-template tag accepts a location attribute.
> Propose that the html-template tag also accepts CDATA content.
> OFBiz will look for CDATA content if the location attribute is empty.
>   
> The advantage is that we need not create a .ftl file whenever we add some 
> html contents into the screen widget.
> I need some opinions before starting work on this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360453#comment-15360453
 ] 

Jacques Le Roux commented on OFBIZ-7061:


Thanks for the good work James :)

> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061-minilang-schema.patch, OFBIZ-7061.patch, 
> OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7258) Duplicate product feature groups associated with a category when duplicating category and selected option to duplicate feature

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7258.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks Ravi for the contribution. Your changes are committed at following 
revision. Thanks Rishi for your valuable comment.

trunk - r1751130.

> Duplicate product feature groups associated with a category when duplicating 
> category and selected option to duplicate feature
> --
>
> Key: OFBIZ-7258
> URL: https://issues.apache.org/jira/browse/OFBIZ-7258
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7258.patch
>
>
> Problem Area:
> 1) Go to Catalog -> Categories
> 2) Find a category for which feature groups and feature categories are added.
> 3) Duplicate that category and check the option to duplicate feature.
> 4) Right now only features from product feature categories get duplicated not 
> the feature associated with feature group.
> We should duplicate features from feature group as well when duplicating 
> category.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7193) Checks --> Print (PDF) should be open in a new window

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7193.
--
   Resolution: Fixed
Fix Version/s: 15.12.01
   14.12.01

Thanks Harsh for the contribution. Your changes are committed at following 
revisions.

trunk - r1751127
R15.12 - r1751128
R14.12 - r1751129

> Checks --> Print (PDF) should be open in a new window
> -
>
> Key: OFBIZ-7193
> URL: https://issues.apache.org/jira/browse/OFBIZ-7193
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Harsh Vijaywargiya
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7193.patch
>
>
> Go to Accounting Manager --> Organization GL Settings 
> Click on Accounting --> Checks
> In Checks To Print click on button Print (PDF)
> PDF gets open in same window.
> To have the UI consistency it should be open in new window.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7513) alt-target tag is not working as expected in Form Widget

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7513.
--
   Resolution: Fixed
Fix Version/s: 15.12.01
   14.12.01

Thanks Pritam for the contribution. Your changes are committed at following 
revisions.

trunk - r1751124
R15.12 - r1751125
R14.12 - r1751126

Thanks Montalbano and Jacques for participating in discussion.

> alt-target tag is not working as expected in Form Widget
> 
>
> Key: OFBIZ-7513
> URL: https://issues.apache.org/jira/browse/OFBIZ-7513
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Ashish Vijaywargiya
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7513-Trunk.patch
>
>
> While working on the issue OFBIZ-7252, I found one problem in Form Widgets. 
> When we use  attribute in child form, the system should consider 
> overridden  in child form. This is default expected behaviour. 
> But in this case, it is always considering the  of the parent 
> form.
> For example:
> {code}
> 
>   
>   
> 
> {code}
> {code}
> 
>   
> 
> {code}
> In above example, expectation is 'executeChildTarget' target should get 
> executed but actually 'executeParentTarget' is getting executed.
> When we looked into framework level code of Form Widgets, we got the 
> following code snippets:
> ModelForm.java (Line: 380-388)
> {code}
> ArrayList altTargets = new ArrayList();
> if (parentModel != null) {
> altTargets.addAll(parentModel.altTargets);
> }
> for (Element altTargetElement : UtilXml.childElementList(formElement, 
> "alt-target")) {
> altTargets.add(new AltTarget(altTargetElement));
> }
> altTargets.trimToSize();
> this.altTargets = Collections.unmodifiableList(altTargets);
> {code}
> Here we can see that all alt-targets present in parent form are added to the 
> list first and then all alt-targets present in child form are added.
> This causes a problem as method getTarget() of ModelForm.java (Line: 
> 1352-1384) returns the first element in the list as alt-target.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-6421) Unable to create New Communication from LEAD in SFA

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-6421.
--
   Resolution: Fixed
Fix Version/s: 15.12.01
   14.12.01

Thanks Kian for creating the issue. Thanks Harsh for providing the patch. Your 
changes are committed at following revisions.

trunk - r1751121
R15.12 - r1751122
R14.12 - r1751123

> Unable to create New Communication from LEAD in SFA
> ---
>
> Key: OFBIZ-6421
> URL: https://issues.apache.org/jira/browse/OFBIZ-6421
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: 13.07.01
>Reporter: Kian Yen Mah
>Assignee: Ashish Vijaywargiya
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6421.patch
>
>
> Select Lead in SFA. Click COMMUNICATIONS. Click NEW COMMUNICATION. Click SAVE.
> The Following Errors Occurred:
> Exception thrown while performing entity find: [GenericDelegator.findOne] 
> Passed primary key is not a valid primary key: 
> [GenericEntity:CommunicationEventWorkEff][communicationEventId,10010(java.lang.String)]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7599) Entered To Name is not getting stored when creating Party Invitation

[Ashish Vijaywargiya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-7599.
--
   Resolution: Fixed
Fix Version/s: 15.12.01
   14.12.01

Thanks Ravi for the contribution. Your changes are committed at following 
revisions.

trunk - r1751118
R15.12 - r1751119
R14.12 - r1751120

> Entered To Name is not getting stored when creating Party Invitation
> 
>
> Key: OFBIZ-7599
> URL: https://issues.apache.org/jira/browse/OFBIZ-7599
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-7599_trunk.patch
>
>
> Steps to regenerate:
> 1) Go to party component.
> 2) Go to Invitation screen.
> 3) Create an invitation with the To Name field filled. 
> Name (firstName, middleName, lastName) from Person entity is saved instead of 
> entered To Name.
> Code snippet from "createPartyInvitation" service used to create party 
> invitation.
> {code}
> 
>  auto-field-map="false">
>  from-field="parameters.partyId"/>
> 
> 
> 
> {code}
> Possible solution:
> 1) Remove "To Name" field from the Create form.
> OR
> 2) Remove that code snippet from the service which is setting toName.
> OR
> 3) Neither remove field from the form nor code snippet. If the toName is not 
> passed from the UI then only used code snippet to set toName.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

buildbot success in on ofbiz-branch15

[buildbot]

The Buildbot has detected a restored build on builder ofbiz-branch15 while 
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-branch15/builds/204

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: orcus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz15-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/branches/release15.12] 1751117
Blamelist: ashish

Build succeeded!

Sincerely,
 -The Buildbot

buildbot success in on ofbiz-trunk

[buildbot]

The Buildbot has detected a restored build on builder ofbiz-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk/builds/972

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: orcus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1751116
Blamelist: ashish

Build succeeded!

Sincerely,
 -The Buildbot

[jira] [Commented] (OFBIZ-7004) Allow to accept CDATA

[james yong (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360424#comment-15360424
 ] 

james yong commented on OFBIZ-7004:
---

in my opinion, this feature is good for spot testing.

> Allow  to accept CDATA
> -
>
> Key: OFBIZ-7004
> URL: https://issues.apache.org/jira/browse/OFBIZ-7004
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-7004.patch, OFBIZ-7004.patch
>
>
> Currently, html-template tag accepts a location attribute.
> Propose that the html-template tag also accepts CDATA content.
> OFBiz will look for CDATA content if the location attribute is empty.
>   
> The advantage is that we need not create a .ftl file whenever we add some 
> html contents into the screen widget.
> I need some opinions before starting work on this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)