Re: Proposal to rename specialpurpose to plugins

2017-01-09 Thread Gavin Mabie 
+1 to rename as plugins

On Mon, Jan 9, 2017 at 12:23 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks for the update Nicolas
>
> Jacques
>
>
>
> Le 09/01/2017 à 11:04, Nicolas Malin a écrit :
>
>> +1 to change specialpurpose.
>>
>> For remove hot-deploy, I prefer wait to have a good namespace management
>> to identify correctly the origin of each plugin.
>>
>> I work with Jacques on the https://issues.apache.org/jira
>> /browse/OFBIZ-6919 but I take to much time to finish this task, so I
>> think you can realize the migration as you want ;)
>>
>> Nicolas
>>
>> Le 03/01/2017 à 10:37, Taher Alkhateeb a écrit :
>>
>>> Sure Jacques, I'll wait for you and this thread is under discussion
>>> anyway
>>>
>>> On Tue, Jan 3, 2017 at 12:32 PM, Jacques Le Roux <
>>> jacques.le.r...@les7arts.com> wrote:
>>>
>>> Taher,

 Could you please just wait 1 day or 2, maybe more?

 I'm currently working on https://issues.apache.org/jira
 /browse/OFBIZ-6919
 and its subtasks (a new one is ready but not created). and would prefer
 to
 apply these patch before yours because it's a huge thing and mixing both
 will not help.

 Thanks

 Jacques



 Le 02/01/2017 à 19:34, Jacques Le Roux a écrit :

 +1
>
> Jacques
>
>
> Le 02/01/2017 à 17:45, Taher Alkhateeb a écrit :
>
> Hello Everyone,
>>
>> In reference to earlier discussions and threads on the above subject,
>> I
>> am
>> hereby proposing renaming the directory "specialpurpose" to
>> "plugins". I
>> have patch ready with all tests passing.
>>
>> Ref discussion:
>> https://lists.apache.org/thread.html/9bb4fba6ec56bd52a5bc55e
>> 44ba1672f088ec33eeb8a1af4d16fd6d2@%3Cdev.ofbiz.apache.org%3E
>>
>> Cheers,
>>
>> Taher Alkhateeb
>>
>>
>>
>
>>
>>
>

Re: Inconsistent String Comparisons

2017-01-09 Thread Pranay Pandey 
+1 Devanshu.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Mon, Jan 9, 2017 at 2:52 PM, Devanshu Vyas 
wrote:

> Hello Devs,
>
> I found an inconsistency in the code for string comparison
> *statusId.equals("PRUN_COMPLETED")* whereas it should be written as
> *"PRUN_COMPLETED".equals(statusId)*
> cause the former can throw NullPointerException if the variable found to be
> NULL.
>
> This code pattern can be found at several places and if you all agree with
> this I can provide a patch for correcting code.
>
> Let me know your thoughts.
>
> Thanks & Regards,
> Devanshu Vyas.
>

Re: Proposal to rename specialpurpose to plugins

2017-01-09 Thread Jacques Le Roux 

Thanks for the update Nicolas

Jacques


Le 09/01/2017 à 11:04, Nicolas Malin a écrit :

+1 to change specialpurpose.

For remove hot-deploy, I prefer wait to have a good namespace management to 
identify correctly the origin of each plugin.

I work with Jacques on the https://issues.apache.org/jira/browse/OFBIZ-6919 but I take to much time to finish this task, so I think you can realize 
the migration as you want ;)


Nicolas

Le 03/01/2017 à 10:37, Taher Alkhateeb a écrit :

Sure Jacques, I'll wait for you and this thread is under discussion anyway

On Tue, Jan 3, 2017 at 12:32 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Taher,

Could you please just wait 1 day or 2, maybe more?

I'm currently working on https://issues.apache.org/jira/browse/OFBIZ-6919
and its subtasks (a new one is ready but not created). and would prefer to
apply these patch before yours because it's a huge thing and mixing both
will not help.

Thanks

Jacques



Le 02/01/2017 à 19:34, Jacques Le Roux a écrit :


+1

Jacques


Le 02/01/2017 à 17:45, Taher Alkhateeb a écrit :


Hello Everyone,

In reference to earlier discussions and threads on the above subject, I
am
hereby proposing renaming the directory "specialpurpose" to "plugins". I
have patch ready with all tests passing.

Ref discussion:
https://lists.apache.org/thread.html/9bb4fba6ec56bd52a5bc55e
44ba1672f088ec33eeb8a1af4d16fd6d2@%3Cdev.ofbiz.apache.org%3E

Cheers,

Taher Alkhateeb

Re: Inconsistent String Comparisons

2017-01-09 Thread Swapnil Mane 
+1 Devanshu.


- Best Regards,
Swapnil M Mane

On Mon, Jan 9, 2017 at 2:52 PM, Devanshu Vyas 
wrote:

> Hello Devs,
>
> I found an inconsistency in the code for string comparison
> *statusId.equals("PRUN_COMPLETED")* whereas it should be written as
> *"PRUN_COMPLETED".equals(statusId)*
> cause the former can throw NullPointerException if the variable found to be
> NULL.
>
> This code pattern can be found at several places and if you all agree with
> this I can provide a patch for correcting code.
>
> Let me know your thoughts.
>
> Thanks & Regards,
> Devanshu Vyas.
>

Re: Proposal to rename specialpurpose to plugins

2017-01-09 Thread Nicolas Malin 

+1 to change specialpurpose.

For remove hot-deploy, I prefer wait to have a good namespace management 
to identify correctly the origin of each plugin.


I work with Jacques on the 
https://issues.apache.org/jira/browse/OFBIZ-6919 but I take to much time 
to finish this task, so I think you can realize the migration as you want ;)


Nicolas

Le 03/01/2017 à 10:37, Taher Alkhateeb a écrit :

Sure Jacques, I'll wait for you and this thread is under discussion anyway

On Tue, Jan 3, 2017 at 12:32 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Taher,

Could you please just wait 1 day or 2, maybe more?

I'm currently working on https://issues.apache.org/jira/browse/OFBIZ-6919
and its subtasks (a new one is ready but not created). and would prefer to
apply these patch before yours because it's a huge thing and mixing both
will not help.

Thanks

Jacques



Le 02/01/2017 à 19:34, Jacques Le Roux a écrit :


+1

Jacques


Le 02/01/2017 à 17:45, Taher Alkhateeb a écrit :


Hello Everyone,

In reference to earlier discussions and threads on the above subject, I
am
hereby proposing renaming the directory "specialpurpose" to "plugins". I
have patch ready with all tests passing.

Ref discussion:
https://lists.apache.org/thread.html/9bb4fba6ec56bd52a5bc55e
44ba1672f088ec33eeb8a1af4d16fd6d2@%3Cdev.ofbiz.apache.org%3E

Cheers,

Taher Alkhateeb

Re: Inconsistent String Comparisons

2017-01-09 Thread Michael Brohl 

+1

Regards,

Michael

Am 09.01.17 um 10:27 schrieb Nicolas Malin:

Hello Devanshu,

Yes your welcome to submit a patch :)

Nicolas

Le 09/01/2017 à 10:22, Devanshu Vyas a écrit :

Hello Devs,

I found an inconsistency in the code for string comparison
*statusId.equals("PRUN_COMPLETED")* whereas it should be written as
*"PRUN_COMPLETED".equals(statusId)*
cause the former can throw NullPointerException if the variable found 
to be

NULL.

This code pattern can be found at several places and if you all agree 
with

this I can provide a patch for correcting code.

Let me know your thoughts.

Thanks & Regards,
Devanshu Vyas.








smime.p7s
Description: S/MIME Cryptographic Signature

Re: Inconsistent String Comparisons

2017-01-09 Thread Nicolas Malin 

Hello Devanshu,

Yes your welcome to submit a patch :)

Nicolas

Le 09/01/2017 à 10:22, Devanshu Vyas a écrit :

Hello Devs,

I found an inconsistency in the code for string comparison
*statusId.equals("PRUN_COMPLETED")* whereas it should be written as
*"PRUN_COMPLETED".equals(statusId)*
cause the former can throw NullPointerException if the variable found to be
NULL.

This code pattern can be found at several places and if you all agree with
this I can provide a patch for correcting code.

Let me know your thoughts.

Thanks & Regards,
Devanshu Vyas.

Inconsistent String Comparisons

2017-01-09 Thread Devanshu Vyas 
Hello Devs,

I found an inconsistency in the code for string comparison
*statusId.equals("PRUN_COMPLETED")* whereas it should be written as
*"PRUN_COMPLETED".equals(statusId)*
cause the former can throw NullPointerException if the variable found to be
NULL.

This code pattern can be found at several places and if you all agree with
this I can provide a patch for correcting code.

Let me know your thoughts.

Thanks & Regards,
Devanshu Vyas.