Re: Next step to migrate OFBiz from Subversion (SVN) to Git

2019-05-08 Thread Swapnil M Mane 
Thank you Deepak for your comments, I am also inline with this.
The document [1] contains the information of switching version control from
SVN to Git (with existing contribution flow).


[1] https://cwiki.apache.org/confluence/x/Xg-HBg


- Best Regards,
Swapnil M Mane,
ofbiz.apache.org



On Wed, May 8, 2019 at 12:22 PM Deepak Dixit  wrote:

> Thanks you Swapnil for your effort,
>
> I agree with Mathieu, as a first step we have to focus on switching
> version control from svn to git (with existing contribution flow),
>  once it has done we can discuss the contribution flow using GitHub
> feature.
>
> Kind Regards,
> Deepak Dixit
> DIRECTOR OF PRODUCT ENGINEERING
> mobile: +91 9826754548
> email: deepak.di...@hotwax.co
> *www.hotwax.co *
>
>
> On Wed, May 1, 2019 at 7:14 PM Swapnil M Mane 
> wrote:
>
>> Hi team,
>>
>> Thanks so much everyone for participating in the discussion [1] to migrate
>> OFBiz from Subversion (SVN) to Git version control system.
>>
>> As we have concluded to move our source repository from SVN to Git.
>> Based on our previous discussions [1], here is the document [2] which can
>> help us to strategies our migration.
>>
>> This document contain all the relevant topics which need to consider
>> before, during and after migration to Git.
>>
>>1. Code Repository
>>2. Workflow
>>   1. Small Features / Bug Fixes
>>   2. Large Features
>>3. Buildbot configuration with Git (Build Scripts)
>>4. Revert workflow
>>   1. Revert Pull Request
>>   2. Revert a commit
>>5. Backport the fixes
>>6. Release management
>>7. Equivalent of svn:auto-props properties
>>8. Update the website, wiki documents and references
>>
>> The workflow in document is suggested by Taher in thread [1], and based on
>> my experience with Git, I have added respective the points in the above
>> sections.
>>
>> I have added some task in document which needs to done, confluence provide
>> use feature to assign the task in the document itself.
>> Example, I have assigned two tasks to me under "Update the website, wiki
>> documents and references" section. We can use this feature distribute our
>> tasks.
>>
>> I request everyone to please have a look into this document and kindly
>> share your thoughts.
>> Also, feel free to update the document.
>>
>>
>> [1]
>>
>> https://lists.apache.org/thread.html/9f89b2a24ff427dffaf71294fc20306994fd1c19a6b24e64c4b06d71@1431423796@%3Cdev.ofbiz.apache.org%3E
>> [2] https://cwiki.apache.org/confluence/x/Xg-HBg
>>
>>
>> - Best Regards,
>> Swapnil M Mane,
>> ofbiz.apache.org
>>
>

Re: Missing or not used image in site

2019-05-08 Thread Jacques Le Roux 

Actually I guess you mean to check if imgRounded is used or not.

It's not, so we can remove the 3 imgRounded css blocks right?

Thanks

Jacques (still a newb in css :D)

Le 08/05/2019 à 09:28, Jacques Le Roux a écrit :

Hi Suraj,

Yep, saw that but still unsure what to do :)

Jacques

Le 08/05/2019 à 09:19, Suraj Khurana a écrit :

Hello Jacques,

I think rev#1787742 might help.
If they are removed after that (Need to check), we can remove this code
occurrence as well.

--
Kind Regards,
Suraj Khurana







On Wed, May 8, 2019 at 12:43 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Hi,

While checking links of the site I found that this block in
/site/css/layout.css

.imgRounded {
  -moz-border-radius:50%;
  -webkit-border-radius:50%;
  border-radius:50%;
  height:220px;
  width:220px;
  overflow:hidden;
  background-image:url('../images/team/pic3.jpg') no-repeat center #555;
}

uses images/team/pic3.jpg. Both images/team/ and pic3.jpg don't exist.

Not sure what to do with that

Thanks

Jacques

Re: Missing or not used image in site

2019-05-08 Thread Jacques Le Roux 

Hi Suraj,

Yep, saw that but still unsure what to do :)

Jacques

Le 08/05/2019 à 09:19, Suraj Khurana a écrit :

Hello Jacques,

I think rev#1787742 might help.
If they are removed after that (Need to check), we can remove this code
occurrence as well.

--
Kind Regards,
Suraj Khurana







On Wed, May 8, 2019 at 12:43 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Hi,

While checking links of the site I found that this block in
/site/css/layout.css

.imgRounded {
  -moz-border-radius:50%;
  -webkit-border-radius:50%;
  border-radius:50%;
  height:220px;
  width:220px;
  overflow:hidden;
  background-image:url('../images/team/pic3.jpg') no-repeat center #555;
}

uses images/team/pic3.jpg. Both images/team/ and pic3.jpg don't exist.

Not sure what to do with that

Thanks

Jacques

Re: Missing or not used image in site

2019-05-08 Thread Suraj Khurana 
Hello Jacques,

I think rev#1787742 might help.
If they are removed after that (Need to check), we can remove this code
occurrence as well.

--
Kind Regards,
Suraj Khurana







On Wed, May 8, 2019 at 12:43 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> While checking links of the site I found that this block in
> /site/css/layout.css
>
> .imgRounded {
>  -moz-border-radius:50%;
>  -webkit-border-radius:50%;
>  border-radius:50%;
>  height:220px;
>  width:220px;
>  overflow:hidden;
>  background-image:url('../images/team/pic3.jpg') no-repeat center #555;
> }
>
> uses images/team/pic3.jpg. Both images/team/ and pic3.jpg don't exist.
>
> Not sure what to do with that
>
> Thanks
>
> Jacques
>
>

Missing or not used image in site

2019-05-08 Thread Jacques Le Roux 

Hi,

While checking links of the site I found that this block in /site/css/layout.css

.imgRounded {
    -moz-border-radius:50%;
    -webkit-border-radius:50%;
    border-radius:50%;
    height:220px;
    width:220px;
    overflow:hidden;
    background-image:url('../images/team/pic3.jpg') no-repeat center #555;
}

uses images/team/pic3.jpg. Both images/team/ and pic3.jpg don't exist.

Not sure what to do with that

Thanks

Jacques

Re: Next step to migrate OFBiz from Subversion (SVN) to Git

2019-05-08 Thread Deepak Dixit 
Thanks you Swapnil for your effort,

I agree with Mathieu, as a first step we have to focus on switching version
control from svn to git (with existing contribution flow),
 once it has done we can discuss the contribution flow using GitHub
feature.

Kind Regards,
Deepak Dixit
DIRECTOR OF PRODUCT ENGINEERING
mobile: +91 9826754548
email: deepak.di...@hotwax.co
*www.hotwax.co *


On Wed, May 1, 2019 at 7:14 PM Swapnil M Mane 
wrote:

> Hi team,
>
> Thanks so much everyone for participating in the discussion [1] to migrate
> OFBiz from Subversion (SVN) to Git version control system.
>
> As we have concluded to move our source repository from SVN to Git.
> Based on our previous discussions [1], here is the document [2] which can
> help us to strategies our migration.
>
> This document contain all the relevant topics which need to consider
> before, during and after migration to Git.
>
>1. Code Repository
>2. Workflow
>   1. Small Features / Bug Fixes
>   2. Large Features
>3. Buildbot configuration with Git (Build Scripts)
>4. Revert workflow
>   1. Revert Pull Request
>   2. Revert a commit
>5. Backport the fixes
>6. Release management
>7. Equivalent of svn:auto-props properties
>8. Update the website, wiki documents and references
>
> The workflow in document is suggested by Taher in thread [1], and based on
> my experience with Git, I have added respective the points in the above
> sections.
>
> I have added some task in document which needs to done, confluence provide
> use feature to assign the task in the document itself.
> Example, I have assigned two tasks to me under "Update the website, wiki
> documents and references" section. We can use this feature distribute our
> tasks.
>
> I request everyone to please have a look into this document and kindly
> share your thoughts.
> Also, feel free to update the document.
>
>
> [1]
>
> https://lists.apache.org/thread.html/9f89b2a24ff427dffaf71294fc20306994fd1c19a6b24e64c4b06d71@1431423796@%3Cdev.ofbiz.apache.org%3E
> [2] https://cwiki.apache.org/confluence/x/Xg-HBg
>
>
> - Best Regards,
> Swapnil M Mane,
> ofbiz.apache.org
>