[jira] Commented: (OFBIZ-2227) If CC capture fails while packing order, Packer is notified and sets the package aside for CSR to handle.

2009-03-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679534#action_12679534 ] Jacques Le Roux commented on OFBIZ-2227: Should we not close this issue ? If CC

[jira] Commented: (OFBIZ-1235) Create the theme for the form widget

2009-03-06 Thread WeizhanGuo (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679543#action_12679543 ] WeizhanGuo commented on OFBIZ-1235: --- ok, waiting for Jacopo... Create the theme for the

[jira] Commented: (OFBIZ-2227) If CC capture fails while packing order, Packer is notified and sets the package aside for CSR to handle.

2009-03-06 Thread Pranay Pandey (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679565#action_12679565 ] Pranay Pandey commented on OFBIZ-2227: -- Jacques, Here the issue is there, as while

Re: how to write a test case

2009-03-06 Thread Vikas Mayur
On Mar 5, 2009, at 9:14 PM, Adam Heath wrote: Vikas Mayur wrote: I appreciate your efforts in the recent commits to clean up test case and its relative code. I am happy now people are getting off sleep and want to contribute to this important part of the OFBiz. So just you know, almost

[jira] Commented: (OFBIZ-2228) When a virtual product is modified, its variants aren't modified

2009-03-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679578#action_12679578 ] Jacques Le Roux commented on OFBIZ-2228: Eric, Your (modified) patch is in trunk

[jira] Commented: (OFBIZ-2227) If CC capture fails while packing order, Packer is notified and sets the package aside for CSR to handle.

2009-03-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679579#action_12679579 ] Jacques Le Roux commented on OFBIZ-2227: Ha yes, sorry from David's comment I

[jira] Commented: (OFBIZ-2227) If CC capture fails while packing order, Packer is notified and sets the package aside for CSR to handle.

2009-03-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679580#action_12679580 ] Jacques Le Roux commented on OFBIZ-2227: Pranay, Actually I did not read enough of

[jira] Commented: (OFBIZ-2227) If CC capture fails while packing order, Packer is notified and sets the package aside for CSR to handle.

2009-03-06 Thread Parul Bhagat (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679605#action_12679605 ] Parul Bhagat commented on OFBIZ-2227: - By tracing the code it can be seen that

[jira] Commented: (OFBIZ-2186) OutOfMemory provoked by Cache overflow

2009-03-06 Thread Philippe Mouawad (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679609#action_12679609 ] Philippe Mouawad commented on OFBIZ-2186: - Hello M. Jones, Thank you for taking

Re: svn commit: r750799 - in /ofbiz/trunk/framework: common/data/CommonTypeData.xml webtools/webapp/webtools/WEB-INF/web.xml

2009-03-06 Thread Ashish Vijaywargiya
Hello Jacques, descriptionA unique ID used to look up the WebSite entity to get information about catalogs, etc./description Please change about catalogs to about webtools. Thanks ! -- Ashish Vijaywargiya On Fri, Mar 6, 2009 at 1:23 PM, jler...@apache.org wrote: Author: jleroux Date: Fri

Re: svn commit: r750799 - in /ofbiz/trunk/framework: common/data/CommonTypeData.xml webtools/webapp/webtools/WEB-INF/web.xml

2009-03-06 Thread Jacques Le Roux
Mmm, it seems that there is much more than that : 29 occurrences of the same string in OFBiz, not sure all are correct... descriptionA unique ID used to look up the WebSite entity to get information about catalogs, etc./description I will see... Any help appreciated of course... Jacques

Re: Cross-Site Request Forging (XSRF)

2009-03-06 Thread Al Byers
David, I am just thinking out loud here, but if there were no AJAX calls, then your original approach would work and if there were only AJAX calls then, as I described, all the requests could be run thru a common xhr object and it could handle the tokens. So what if we used a dual random token

Re: svn commit: r750878 - in /ofbiz/trunk: applications/product/webapp/catalog/WEB-INF/controller.xml applications/product/webapp/catalog/product/ProductForms.xml framework/webapp/src/org/ofbiz/webapp

2009-03-06 Thread David E Jones
Please revert this patch: 1. the ServiceVariantEventHandler is in the framework and is dependent on the applications/product component 2. creating an event handler for this is pure silliness in the first place and should simply be done with a custom event -David On Mar 6, 2009, at

Re: svn commit: r750799 - in /ofbiz/trunk/framework: common/data/CommonTypeData.xml webtools/webapp/webtools/WEB-INF/web.xml

2009-03-06 Thread David E Jones
I looks like it comes from the original one in the ecommerce web.xml file. -David On Mar 6, 2009, at 9:21 AM, Jacques Le Roux wrote: Mmm, it seems that there is much more than that : 29 occurrences of the same string in OFBiz, not sure all are correct... descriptionA unique ID used to

Re: svn commit: r750878 - in /ofbiz/trunk: applications/product/webapp/catalog/WEB-INF/controller.xml applications/product/webapp/catalog/product/ProductForms.xml framework/webapp/src/org/ofbiz/webapp

2009-03-06 Thread Jacques Le Roux
Oops, sorry reverted at revision: 751001. It looked a bit weird when I 1st reviewed it, but I finally found it a good idea and forgot the product dependency (actually I forgot that I was commiting in framework) I will explain to Eric in order to find a good solution Jacques From: David E

[jira] Commented: (OFBIZ-2228) When a virtual product is modified, its variants aren't modified

2009-03-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679691#action_12679691 ] Jacques Le Roux commented on OFBIZ-2228: Sorry Eric, I did not occur to me (I

[jira] Commented: (OFBIZ-2228) When a virtual product is modified, its variants aren't modified

2009-03-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679692#action_12679692 ] Jacques Le Roux commented on OFBIZ-2228: BTW I just discovered the XXX annotation

[jira] Created: (OFBIZ-2230) WidgetWorker outputting empty image tags

2009-03-06 Thread Stephen Rufle (JIRA)
WidgetWorker outputting empty image tags Key: OFBIZ-2230 URL: https://issues.apache.org/jira/browse/OFBIZ-2230 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN

[jira] Updated: (OFBIZ-2230) WidgetWorker outputting empty image tags

2009-03-06 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Rufle updated OFBIZ-2230: - Attachment: 2009-03-06_WidgetWorker.patch Changed from != null to UtilValidate.isNotEmpty

Re: how to write a test case

2009-03-06 Thread Adam Heath
Vikas Mayur wrote: How did it work? I reverted back to 660193, the last patch for OFBIZ-1790, and the accounting tests failed. If they worked in the past, I'd like to know when. If so, then that means something since then has caused them to break, and I will more than gladly track that

[jira] Closed: (OFBIZ-2230) WidgetWorker outputting empty image tags

2009-03-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2230. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks Stephen, Your patch is in trunk at

Re: svn commit: r750799 - in /ofbiz/trunk/framework: common/data/CommonTypeData.xml webtools/webapp/webtools/WEB-INF/web.xml

2009-03-06 Thread Bruno Busco
I think I have copy and paste it in a recent commit when WebSiteId setting has been added to all web applications. I would suggest to replace all with the simpler description: descriptionA unique ID used to look up the WebSite entity/description If you are OK I will update it. -Bruno

[jira] Created: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread Stephen Rufle (JIRA)
Escaped ampersands in xml import need to be reencoded -- Key: OFBIZ-2231 URL: https://issues.apache.org/jira/browse/OFBIZ-2231 Project: OFBiz Issue Type: Bug Components:

[jira] Updated: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Rufle updated OFBIZ-2231: - Attachment: (was: 2009-03-06_WidgetWorker.patch) Escaped ampersands in xml import need to

[jira] Updated: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Rufle updated OFBIZ-2231: - Attachment: 2009-03-06_WidgetWorker.patch Adds xmltext= StringUtil.replaceString(xmltext, ,

[jira] Updated: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Rufle updated OFBIZ-2231: - Attachment: 2009-03-06_WebToolsServices.patch Adds xmltext= StringUtil.replaceString(xmltext, ,

[jira] Commented: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679739#action_12679739 ] Jacques Le Roux commented on OFBIZ-2231: BTW, I think is not the sole concerned

[jira] Commented: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679741#action_12679741 ] Jacques Le Roux commented on OFBIZ-2231: Forget it, I just tried this not a good

[jira] Updated: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Rufle updated OFBIZ-2231: - Description: While trying to import {code:xml} PostalAddress toName=To stateProvinceGeoId=NJ

[jira] Commented: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679742#action_12679742 ] Jacques Le Roux commented on OFBIZ-2231: Or better if we could automatically encode

[jira] Commented: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679750#action_12679750 ] Stephen Rufle commented on OFBIZ-2231: -- The limiting factor seems to be that we have

Re: svn commit: r750799 - in /ofbiz/trunk/framework: common/data/CommonTypeData.xml webtools/webapp/webtools/WEB-INF/web.xml

2009-03-06 Thread David E Jones
Yes, sounds good. -David On Mar 6, 2009, at 2:07 PM, Bruno Busco wrote: I think I have copy and paste it in a recent commit when WebSiteId setting has been added to all web applications. I would suggest to replace all with the simpler description: descriptionA unique ID used to look up

[jira] Commented: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679756#action_12679756 ] David E. Jones commented on OFBIZ-2231: --- What does this have to do with encoding? It

[jira] Commented: (OFBIZ-2231) Escaped ampersands in xml import need to be reencoded

2009-03-06 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679766#action_12679766 ] Stephen Rufle commented on OFBIZ-2231: -- I think I must have miscopied the original

[jira] Commented: (OFBIZ-2227) If CC capture fails while packing order, Packer is notified and sets the package aside for CSR to handle.

2009-03-06 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679794#action_12679794 ] David E. Jones commented on OFBIZ-2227: --- When you're working on this make sure you

[jira] Commented: (OFBIZ-2227) If CC capture fails while packing order, Packer is notified and sets the package aside for CSR to handle.

2009-03-06 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679807#action_12679807 ] BJ Freeman commented on OFBIZ-2227: --- the flow we implemented that takes care of davids

[jira] Commented: (OFBIZ-2227) If CC capture fails while packing order, Packer is notified and sets the package aside for CSR to handle.

2009-03-06 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679816#action_12679816 ] BJ Freeman commented on OFBIZ-2227: --- to clarify I see 2 issues here 1) where in the

Re: svn commit: r750799 - in /ofbiz/trunk/framework: common/data/CommonTypeData.xml webtools/webapp/webtools/WEB-INF/web.xml

2009-03-06 Thread Ashish Vijaywargiya
+1 -- Ashish Vijaywargiya On Sat, Mar 7, 2009 at 2:37 AM, Bruno Busco bruno.bu...@gmail.com wrote: I think I have copy and paste it in a recent commit when WebSiteId setting has been added to all web applications. I would suggest to replace all with the simpler description:    descriptionA

Re: how to write a test case

2009-03-06 Thread Vikas Mayur
On Mar 7, 2009, at 2:01 AM, Adam Heath wrote: Vikas Mayur wrote: How did it work? I reverted back to 660193, the last patch for OFBIZ-1790, and the accounting tests failed. If they worked in the past, I'd like to know when. If so, then that means something since then has caused them to

[jira] Updated: (OFBIZ-2232) WebSiteId parameter description

2009-03-06 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-2232: --- Attachment: websiteid.patch WebSiteId parameter description ---

[jira] Created: (OFBIZ-2232) WebSiteId parameter description

2009-03-06 Thread Bruno Busco (JIRA)
WebSiteId parameter description --- Key: OFBIZ-2232 URL: https://issues.apache.org/jira/browse/OFBIZ-2232 Project: OFBiz Issue Type: Improvement Reporter: Bruno Busco Attachments: