[jira] [Commented] (OFBIZ-4331) trival update to EntityFieldValue.java in case the entityAlias is empty

2011-07-07 Thread Leon (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13061068#comment-13061068 ] Leon commented on OFBIZ-4331: - Agree with you. Redesign is better than patch on patch. So far,

[jira] [Created] (OFBIZ-4333) Refactoring send email engine

2011-07-07 Thread Nicolas Malin (JIRA)
Refactoring send email engine - Key: OFBIZ-4333 URL: https://issues.apache.org/jira/browse/OFBIZ-4333 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS, content, framework Affects

Re: EmailTemplateSetting vs ProductStoreEmailSetting

2011-07-07 Thread Nicolas Malin
Ok I create a jira issue. This refactoring isn't easier. I propose to advanced step by step. 1. refactoring entities 2. refactoring service 3. impact modification on exist code 4. create service data migration 5. update screen Nicolas Le 06/07/2011 00:58, Scott Gray a écrit : I'm sure there

[jira] [Updated] (OFBIZ-4333) Refactoring send email engine

2011-07-07 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4333: - Attachment: OFBIZ-4333.patch Oups, not load the good patch :) Refactoring send email engine

[jira] [Updated] (OFBIZ-4333) Refactoring send email engine

2011-07-07 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4333: - Attachment: (was: OFBIZ-4322.patch) Refactoring send email engine

Re: EmailTemplateSetting vs ProductStoreEmailSetting

2011-07-07 Thread Scott Gray
Found it: https://issues.apache.org/jira/browse/OFBIZ-3894 Regards Scott On 7/07/2011, at 8:33 PM, Nicolas Malin wrote: Ok I create a jira issue. This refactoring isn't easier. I propose to advanced step by step. 1. refactoring entities 2. refactoring service 3. impact modification on

[jira] [Commented] (OFBIZ-4333) Refactoring send email engine

2011-07-07 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13061241#comment-13061241 ] BJ Freeman commented on OFBIZ-4333: --- there is a Jira open already

Re: EmailTemplateSetting vs ProductStoreEmailSetting

2011-07-07 Thread Nicolas Malin
Oh Sorry Scott, I realize that I didn't understand your previous message :/ My purpose is to cover your dream ;) I check your analyze and modify my previous patch. What's your prefer ? I close OFBIZ-4333 or change it to OFBIZ-3894 sub-task Nicolas Le 07/07/2011 12:51, Scott Gray a écrit :

Re: svn commit: r1143835 - /ofbiz/trunk/rc.ofbiz.for.ubuntu

2011-07-07 Thread Hans Bakker
Thank you Jacques, Hans. On Thu, 2011-07-07 at 14:13 +, jler...@apache.org wrote: Author: jleroux Date: Thu Jul 7 14:13:07 2011 New Revision: 1143835 URL: http://svn.apache.org/viewvc?rev=1143835view=rev Log: Was missing the ASL2 header. I put also the comment for etc order

[jira] [Updated] (OFBIZ-4259) Add famfamfam icons has generic and add possibility to surchage

2011-07-07 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4259: - Attachment: OFBIZ-4259-POC.patch PurposePOC.png To continue on the icons

Re: FIX

2011-07-07 Thread Jacques Le Roux
From: Adam Heath doo...@brainfood.com On 07/01/2011 02:03 AM, Jacques Le Roux wrote: From: Jacques Le Roux jacques.le.r...@les7arts.com I don't think we need to show lines like 2011-07-01 08:15:32,484 (main) [ CatalinaContainer.java:510:INFO ]

Re: svn commit: r1142915 [1/28] - in /ofbiz/trunk/specialpurpose: ./ scrum/ scrum/config/ scrum/data/ scrum/data/helpdata/ scrum/data/hookscripts/ scrum/documents/ scrum/dtd/ scrum/entitydef/ scrum/li

2011-07-07 Thread Adam Heath
I have some comments in-line. On 07/05/2011 03:15 AM, hans...@apache.org wrote: Author: hansbak Date: Tue Jul 5 08:15:32 2011 New Revision: 1142915 URL: http://svn.apache.org/viewvc?rev=1142915view=rev Log: add support for the scrum framework donated by Antwebsystems Co.Ltd. more info

Re: svn commit: r1142915 [1/28] - in /ofbiz/trunk/specialpurpose: ./ scrum/ scrum/config/ scrum/data/ scrum/data/helpdata/ scrum/data/hookscripts/ scrum/documents/ scrum/dtd/ scrum/entitydef/ scrum/li

2011-07-07 Thread Hans Bakker
Thank you for your comments Adam, we will look into it. Regards, Hans On Thu, 2011-07-07 at 19:22 -0500, Adam Heath wrote: I have some comments in-line. On 07/05/2011 03:15 AM, hans...@apache.org wrote: Author: hansbak Date: Tue Jul 5 08:15:32 2011 New Revision: 1142915 URL: