Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
Thanks Jacques... are you sure it is happening at the same line (156) and not
in the next (157) that it is still using the hardcoded '\n'?
Jacopo
On Dec 17, 2011, at 8:22 AM, Jacques Le Roux wrote:
Hi Jacopo,
Unfortunately not: same error, pretty vicious thing, sorry no time to help
today :/
Jacques
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
Hi Jacques,
I suspect this is a problem with the end of line... are you running on
Windows? Could you please try if the patch below fixes the test?
Thanks,
Jacopo
Index: framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java
===
--- framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java (revision
1215052)
+++ framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java (working
copy)
@@ -39,6 +39,7 @@
@SourceMonitored
public class UtilIOTests extends GenericTestCaseBase {
+private String lineSeparator = System.getProperty(line.separator);
private static final byte[] trademarkBytes = new byte[] {
(byte) 0xE2, (byte) 0x84, (byte) 0xA2
};
@@ -152,7 +153,7 @@
}
public void testReadWriteObject() throws Exception {
-checkBasicReadWriteObject(Boolean.TRUE, java.lang.Boolean:true\n);
+checkBasicReadWriteObject(Boolean.TRUE, java.lang.Boolean:true +
lineSeparator);
checkBasicReadWriteObject(Byte.valueOf(1), java.lang.Byte:1\n);
checkBasicReadWriteObject(Double.valueOf(1.0),
java.lang.Double:1.0\n);
checkBasicReadWriteObject(Float.valueOf(1.0),
java.lang.Float:1.0\n);
On Dec 16, 2011, at 5:51 PM, Jacques Le Roux wrote:
Same Boolean issue as expected
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
OK Guys,
I will check that tonight...
Thanks for the effort!
Jacques
From: Adrian Crum adrian.c...@sandglass-software.com
I believe the base test failures are a timing issue, but I can't be sure
because I haven't looked into it thoroughly. I am
confident they have nothing to do with locale, however.
-Adrian
On 12/16/2011 2:25 PM, Jacopo Cappellato wrote:
Yes, right, a few minutes ago I have committed the fix you suggested.
I doubt it will fix the issue Jacques reported... but that may be
unrelated to locale Jacques, is there any chance that you
have some local modifications?
Jacopo
On Dec 16, 2011, at 3:17 PM, Adrian Crum wrote:
There is no need to investigate - I wrote that code and I can assure
you the locale and time zone is always set when OFBiz
starts. The problem is an incorrect (or missing) setting in one of the
properties files - see my previous reply to Jacques.
-Adrian
On 12/16/2011 1:43 PM, Jacopo Cappellato wrote:
No, I meant to say that I am pretty sure that the code that sets the
locale is not executed when the tests are run... I am
investigating into this now
Jacopo
On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote:
Huh? Start.java is not executed when run-tests is called??!!
-Adrian
On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
Adrian,
I doubt that that code is executed when run-tests is called.
Jacopo
On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
Jacopo,
Setting the language on the command line should not have any effect
because OFBiz sets the language when it starts up. See
the ofbiz.locale.default setting in start.properties.
I can duplicate the test failures by changing that setting to some
other locale. That is why I thought it is a local issue -
the tests are based on OOTB settings, and if you change the
settings the tests will fail.
-Adrian
On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
Jacques, Hans,
could you please try if with the below modifications the tests are
successful?
Thanks,
Jacopo
Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
Yes same line, ie now 156 indeed
junit.framework.ComparisonFailure: write builder java.lang.Boolean expected:...
... but was:..
at
org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
at
org.ofbiz.base.util.test.UtilIOTests.checkBasicReadWriteObject(UtilIOTests.java:152)
at
org.ofbiz.base.util.test.UtilIOTests.testReadWriteObject(UtilIOTests.java:156)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Jacques
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
Thanks Jacques... are you sure it is happening at the same line (156) and not in the next (157) that it is still using the
hardcoded '\n'?
Jacopo
On Dec 17, 2011, at 8:22 AM, Jacques Le Roux wrote:
Hi Jacopo,
Unfortunately not: same error, pretty vicious thing, sorry no time to help
today :/
Jacques
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
Hi Jacques,
I suspect this is a problem with the end of line... are you running on Windows? Could you please try if the patch below fixes
the test?
Thanks,
Jacopo
Index: framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java
===
--- framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java (revision
1215052)
+++ framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java (working copy)
@@ -39,6 +39,7 @@
@SourceMonitored
public class UtilIOTests extends GenericTestCaseBase {
+private String lineSeparator = System.getProperty(line.separator);
private static final byte[] trademarkBytes = new byte[] {
(byte) 0xE2, (byte) 0x84, (byte) 0xA2
};
@@ -152,7 +153,7 @@
}
public void testReadWriteObject() throws Exception {
-checkBasicReadWriteObject(Boolean.TRUE, java.lang.Boolean:true\n);
+checkBasicReadWriteObject(Boolean.TRUE, java.lang.Boolean:true +
lineSeparator);
checkBasicReadWriteObject(Byte.valueOf(1), java.lang.Byte:1\n);
checkBasicReadWriteObject(Double.valueOf(1.0),
java.lang.Double:1.0\n);
checkBasicReadWriteObject(Float.valueOf(1.0), java.lang.Float:1.0\n);
On Dec 16, 2011, at 5:51 PM, Jacques Le Roux wrote:
Same Boolean issue as expected
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
OK Guys,
I will check that tonight...
Thanks for the effort!
Jacques
From: Adrian Crum adrian.c...@sandglass-software.com
I believe the base test failures are a timing issue, but I can't be sure
because I haven't looked into it thoroughly. I am
confident they have nothing to do with locale, however.
-Adrian
On 12/16/2011 2:25 PM, Jacopo Cappellato wrote:
Yes, right, a few minutes ago I have committed the fix you suggested.
I doubt it will fix the issue Jacques reported... but that may be unrelated to locale Jacques, is there any chance that
you
have some local modifications?
Jacopo
On Dec 16, 2011, at 3:17 PM, Adrian Crum wrote:
There is no need to investigate - I wrote that code and I can assure you the
locale and time zone is always set when OFBiz
starts. The problem is an incorrect (or missing) setting in one of the
properties files - see my previous reply to Jacques.
-Adrian
On 12/16/2011 1:43 PM, Jacopo Cappellato wrote:
No, I meant to say that I am pretty sure that the code that sets the locale is
not executed when the tests are run... I am
investigating into this now
Jacopo
On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote:
Huh? Start.java is not executed when run-tests is called??!!
-Adrian
On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
Adrian,
I doubt that that code is executed when run-tests is called.
Jacopo
On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
Jacopo,
Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up.
See
the ofbiz.locale.default setting in start.properties.
I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local
issue -
the tests are based on OOTB settings, and if you change the settings the tests
will fail.
-Adrian
On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
Jacques, Hans,
could you please try if with the below modifications the tests are successful?
Thanks,
Jacopo
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171529#comment-13171529 ] Adrian Crum commented on OFBIZ-3774: I added abstract visitor classes in rev 1215462. They are empty for now, but I imagine they will accumulate functionality as the conversion progresses. The next step is to extend the abstract classes to rendering classes and copy existing rendering code over to them. The tree widget and menu widget are fairly simple, so we might want to convert those first. Then we can take the lessons learned from those and apply them to the screen and form widgets. We will leave the original model classes untouched from now on so we can keep them updated from the trunk. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OFBIZ-4618) Add the accept-method to the models
[ https://issues.apache.org/jira/browse/OFBIZ-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum resolved OFBIZ-4618. Resolution: Fixed Fix Version/s: Screen Widget Redesign Add the accept-method to the models --- Key: OFBIZ-4618 URL: https://issues.apache.org/jira/browse/OFBIZ-4618 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Dimitri Unruh Fix For: Screen Widget Redesign Attachments: OFBIZ-4618.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4618) Add the accept-method to the models
[ https://issues.apache.org/jira/browse/OFBIZ-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-4618. -- Add the accept-method to the models --- Key: OFBIZ-4618 URL: https://issues.apache.org/jira/browse/OFBIZ-4618 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Dimitri Unruh Fix For: Screen Widget Redesign Attachments: OFBIZ-4618.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4617) Create Visitor Interfaces
[ https://issues.apache.org/jira/browse/OFBIZ-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-4617. -- Resolution: Fixed Fix Version/s: Screen Widget Redesign Create Visitor Interfaces - Key: OFBIZ-4617 URL: https://issues.apache.org/jira/browse/OFBIZ-4617 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Screen Widget Redesign Reporter: Dimitri Unruh Fix For: Screen Widget Redesign Attachments: OFBIZ-4617.patch Visitor interfaces for - screens - menus - trees - forms -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4616) Screen Widget Redisign
[ https://issues.apache.org/jira/browse/OFBIZ-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-4616. -- Resolution: Fixed Fix Version/s: Screen Widget Redesign Screen Widget Redisign -- Key: OFBIZ-4616 URL: https://issues.apache.org/jira/browse/OFBIZ-4616 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Screen Widget Redesign Reporter: Dimitri Unruh Fix For: Screen Widget Redesign Main issue for the screen widget redisign tasks -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171532#comment-13171532 ] Hans Bakker commented on OFBIZ-3774: In this refactoring, may we also expect junit tests? Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171533#comment-13171533 ] Adrian Crum commented on OFBIZ-3774: Certainly! Would you be willing to contribute those? Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171537#comment-13171537 ] Hans Bakker commented on OFBIZ-3774: As with any refactoring i am concerned about the introduction of new errors. Junit tests will certainly help here. I appreciate your your input here however for me i do not see the actual need of doing this. I am just concerned about new errors creeping in. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes
[ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171546#comment-13171546 ] Adrian Crum commented on OFBIZ-3774: I agree that tests will help. Like any other effort in the OFBiz community, this is a voluntary one. The scope depends on the availability of volunteers. I appreciate your concerns and I believe those concerns have been addressed by creating a branch so development here will not interfere with the trunk. One thing I can assure, however (and my track record with this community bears this out) is that any issues caused by the redesign will not be left as-is with the excuse that I am too busy to fix them. The need for this change was covered thoroughly in the previous comments. Add The Visitor Pattern To Screen Widget Model Classes -- Key: OFBIZ-3774 URL: https://issues.apache.org/jira/browse/OFBIZ-3774 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Adrian Crum Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4487) enable definition for position on sortfield
[ https://issues.apache.org/jira/browse/OFBIZ-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES updated OFBIZ-4487: -- Assignee: Erwan de FERRIERES enable definition for position on sortfield --- Key: OFBIZ-4487 URL: https://issues.apache.org/jira/browse/OFBIZ-4487 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: youssef khaye Assignee: Erwan de FERRIERES Attachments: OFBIZ-4487-1.png, OFBIZ-4487-2.png, sortFieldPosition-exampleForms.patch, sortFieldPosition.patch, sortFieldPosition2.patch in some cases, form extending another one, it may be convenient to be able to define field position on the sort field element. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4610) Add support to save HS Code in Goods Identification
[ https://issues.apache.org/jira/browse/OFBIZ-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4610. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Thanks Sam, Your patch is in trunk at r1215536 Add support to save HS Code in Goods Identification --- Key: OFBIZ-4610 URL: https://issues.apache.org/jira/browse/OFBIZ-4610 Project: OFBiz Issue Type: Improvement Reporter: Sam Hamilton Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: OFBIZ-4610.patch Add support to save the HS Code ( http://en.wikipedia.org/wiki/Harmonized_System ) in the system. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4227) Adding product content of type Image - Detail (for example) causes an error in catalog manager.
[
https://issues.apache.org/jira/browse/OFBIZ-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-4227.
--
Resolution: Fixed
Assignee: Jacques Le Roux
Indeed, this works now. Thanks Mirko for report
Adding product content of type Image - Detail (for example) causes an error
in catalog manager.
-
Key: OFBIZ-4227
URL: https://issues.apache.org/jira/browse/OFBIZ-4227
Project: OFBiz
Issue Type: Bug
Components: product
Affects Versions: SVN trunk
Reporter: Andreas König
Assignee: Jacques Le Roux
Fix For: SVN trunk
Attachments: Screenshot.jpg
Please use the following path:
* Catalog
* Product
** Select a product like CPU intel 586 given by the Demo-Data.
* Content
** Find the header Create New Product Content
*** Select Product Content Type Id Image - Detail
*** Press Prepare Create
** Find the header Edit Product Content
*** Select the current from date
*** Select an image file
*** Press create
The following error will be prompted to the user:
{quote}
The Following Errors Occurred:
The following required parameter is missing: [createProductContent.contentId]
{quote}
The same error occures for the following Product Content Type Ids:
* Image - Detail
* Image - Large
* Image - Medium
* Image - Original
* Image - Small
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (OFBIZ-4227) Adding product content of type Image - Detail (for example) causes an error in catalog manager.
[
https://issues.apache.org/jira/browse/OFBIZ-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-4227:
In log this error still appears though
2011-12-17 22:38:59,468 (http-bio-/0.0.0.0-8443-exec-9) [
ControlServlet.java:141:INFO ]
[[[addAdditionalImageContentForProduct(Domain:https://localhost)] Request
Begun, encoding=[UTF-8]- total:0.0,since
last(Begin):0.0]]
2011-12-17 22:38:59,468 (http-bio-/0.0.0.0-8443-exec-9) [
ModelService.java:565:ERROR] [ModelService.validate] :
{addAdditionalViewForProduct} : (IN) Required test error:
org.ofbiz.service.ServiceValida
tionException: Le paramÞtre requis suivant manque : [IN]
[addAdditionalViewForProduct.productContentTypeId]Le paramÞtre requis suivant
manque : [IN] [addAdditionalViewForProduct.productId]
2011-12-17 22:38:59,468 (http-bio-/0.0.0.0-8443-exec-9) [
ServiceDispatcher.java:381:ERROR]
exception report --
Incoming context (in runSync : addAdditionalViewForProduct) does not match
expected requirements
Exception: org.ofbiz.service.ServiceValidationException
Message: Le paramÞtre requis suivant manque : [IN]
[addAdditionalViewForProduct.productContentTypeId]Le paramÞtre requis suivant
manque : [IN] [addAdditionalViewForProduct.productId]
stack trace ---
org.ofbiz.service.ServiceValidationException: Le paramÞtre requis suivant
manque : [IN] [addAdditionalViewForProduct.productContentTypeId]Le paramÞtre
requis suivant manque : [IN] [addAdditionalViewForProduct
.productId]
org.ofbiz.service.ModelService.validate(ModelService.java:626)
org.ofbiz.service.ModelService.validate(ModelService.java:562)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:379)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:226)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:337)
org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:647)
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:393)
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:224)
javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304)
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:337)
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:224)
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:169)
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168)
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:929)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:405)
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:964)
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515)
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:302)
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
java.lang.Thread.run(Thread.java:662)
2011-12-17 22:38:59,484 (http-bio-/0.0.0.0-8443-exec-9) [
ServiceDispatcher.java:515:INFO ] [[Sync service failed...- total:0.0,since
last(Begin):0.0]] - 'catalog / addAdditionalViewForProduct'
2011-12-17 22:38:59,484 (http-bio-/0.0.0.0-8443-exec-9) [
TransactionUtil.java:351:INFO ] [TransactionUtil.rollback] transaction rolled
back
2011-12-17 22:38:59,484 (http-bio-/0.0.0.0-8443-exec-9) [
TransactionUtil.java:276:WARN ] [TransactionUtil.commit] Not committing
transaction, status is No Transaction (6)
2011-12-17 22:38:59,484 (http-bio-/0.0.0.0-8443-exec-9) [
RequestHandler.java:648:INFO ] Ran Event [service:#addAdditionalViewForProduct]
from [request], result is [error]
2011-12-17 22:38:59,484 (http-bio-/0.0.0.0-8443-exec-9) [
RequestHandler.java:434:ERROR] Request addAdditionalImageContentForProduct
caused an error with the following message: {Le paramÞtre
[jira] [Closed] (OFBIZ-2800) Add methods to OrderReadHelper to retrieve attributes
[ https://issues.apache.org/jira/browse/OFBIZ-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2800. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks Joe, Your patch is in trunk at r1220283 We agreed to commit in trunk but not to backport to releases Add methods to OrderReadHelper to retrieve attributes - Key: OFBIZ-2800 URL: https://issues.apache.org/jira/browse/OFBIZ-2800 Project: OFBiz Issue Type: New Feature Components: order Affects Versions: SVN trunk Reporter: Joe Eckard Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: orh.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4623) layout for image management does not work under Flat Grey visual theme
[ https://issues.apache.org/jira/browse/OFBIZ-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4623: --- Priority: Trivial (was: Major) Issue Type: Improvement (was: Bug) layout for image management does not work under Flat Grey visual theme -- Key: OFBIZ-4623 URL: https://issues.apache.org/jira/browse/OFBIZ-4623 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Wai Priority: Trivial Image management screens do not look correct when using Flatgrey visual theme. https://demo-trunk.ofbiz.apache.org:8443/catalog/control/Imagemanagement -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-3517) Umbrella task for Tomahawk theme
[ https://issues.apache.org/jira/browse/OFBIZ-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3517. -- Resolution: Fixed This time I don't see anything missing here Umbrella task for Tomahawk theme - Key: OFBIZ-3517 URL: https://issues.apache.org/jira/browse/OFBIZ-3517 Project: OFBiz Issue Type: Task Components: themes Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: SVN trunk The tomahawk theme is really a huge enhancement, thanks Brainfood (Eric mostly I guess) and Bruno, really great! Here are some quirks found here and there. I suspect some are most the lack of consistency in OFBiz underneath (for instance do we really need 3 or more type of buttons, text links, etc.). We may though profit of the current effort to clean that all definitvely Jacques -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4609) Shipping group Instructions and gift messages can not be changed/set if there are several shipping groups
[ https://issues.apache.org/jira/browse/OFBIZ-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4609. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 11.04 Assignee: Jacques Le Roux Thanks Sergei, Your patch is in trunk r1220298 R11.04 r1220299 I began to work on R10.04 (it uses Prototype and not jQuery) but there are too much other conflicts (new things, etc.) than simply Prototype vs jQuery and I gave up Shipping group Instructions and gift messages can not be changed/set if there are several shipping groups - Key: OFBIZ-4609 URL: https://issues.apache.org/jira/browse/OFBIZ-4609 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release Branch 11.04 Reporter: Sergei Biletnikov Assignee: Jacques Le Roux Fix For: Release Branch 11.04, SVN trunk Attachments: OFBIZ-4609_ShippingGroupInstructionsAndGiftMessages.patch Just add more than 1 shipping group for an order, and you notice that it is not possible to set or edit the shipping instructions and gift messages, because the code ignores multiple shipping groups and the html have the same DOM id elements, so only first shipping group can be edited. Of course, it is just a development issue. Please, find the patch enclosed. I use the unique ids for each shipping group elements. The same problem is in OFBiz 10.04 (do not know about Trunk). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
Ha... there is also one '\n' in checkBasicReadWriteObject...
Actually, tomorrow, I will try to replace all EOLs in this file by platforms
independent ones!
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
Yes same line, ie now 156 indeed
junit.framework.ComparisonFailure: write builder java.lang.Boolean expected:...
... but was:..
at
org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
at
org.ofbiz.base.util.test.UtilIOTests.checkBasicReadWriteObject(UtilIOTests.java:152)
at
org.ofbiz.base.util.test.UtilIOTests.testReadWriteObject(UtilIOTests.java:156)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Jacques
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
Thanks Jacques... are you sure it is happening at the same line (156) and not in the next (157) that it is still using the
hardcoded '\n'?
Jacopo
On Dec 17, 2011, at 8:22 AM, Jacques Le Roux wrote:
Hi Jacopo,
Unfortunately not: same error, pretty vicious thing, sorry no time to help
today :/
Jacques
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
Hi Jacques,
I suspect this is a problem with the end of line... are you running on Windows? Could you please try if the patch below fixes
the test?
Thanks,
Jacopo
Index: framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java
===
--- framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java (revision
1215052)
+++ framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java (working copy)
@@ -39,6 +39,7 @@
@SourceMonitored
public class UtilIOTests extends GenericTestCaseBase {
+private String lineSeparator = System.getProperty(line.separator);
private static final byte[] trademarkBytes = new byte[] {
(byte) 0xE2, (byte) 0x84, (byte) 0xA2
};
@@ -152,7 +153,7 @@
}
public void testReadWriteObject() throws Exception {
-checkBasicReadWriteObject(Boolean.TRUE, java.lang.Boolean:true\n);
+checkBasicReadWriteObject(Boolean.TRUE, java.lang.Boolean:true +
lineSeparator);
checkBasicReadWriteObject(Byte.valueOf(1), java.lang.Byte:1\n);
checkBasicReadWriteObject(Double.valueOf(1.0),
java.lang.Double:1.0\n);
checkBasicReadWriteObject(Float.valueOf(1.0), java.lang.Float:1.0\n);
On Dec 16, 2011, at 5:51 PM, Jacques Le Roux wrote:
Same Boolean issue as expected
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
OK Guys,
I will check that tonight...
Thanks for the effort!
Jacques
From: Adrian Crum adrian.c...@sandglass-software.com
I believe the base test failures are a timing issue, but I can't be sure
because I haven't looked into it thoroughly. I am
confident they have nothing to do with locale, however.
-Adrian
On 12/16/2011 2:25 PM, Jacopo Cappellato wrote:
Yes, right, a few minutes ago I have committed the fix you suggested.
I doubt it will fix the issue Jacques reported... but that may be unrelated to locale Jacques, is there any chance that
you
have some local modifications?
Jacopo
On Dec 16, 2011, at 3:17 PM, Adrian Crum wrote:
There is no need to investigate - I wrote that code and I can assure you the
locale and time zone is always set when OFBiz
starts. The problem is an incorrect (or missing) setting in one of the properties files - see my previous reply to
Jacques.
-Adrian
On 12/16/2011 1:43 PM, Jacopo Cappellato wrote:
No, I meant to say that I am pretty sure that the code that sets the locale is not executed when the tests are run... I
am
investigating into this now
Jacopo
On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote:
Huh? Start.java is not executed when run-tests is called??!!
-Adrian
On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
Adrian,
I doubt that that code is executed when run-tests is called.
Jacopo
On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
Jacopo,
Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up.
See
the ofbiz.locale.default setting in start.properties.
I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local
issue -
the tests are based on OOTB settings, and if you change the settings the tests
will fail.
-Adrian
On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
Jacques, Hans,
could you please try if with the below modifications the tests are successful?
Thanks,
Jacopo
[jira] [Created] (OFBIZ-4626) Help screen/navigation do not take into account content expiration
Help screen/navigation do not take into account content expiration -- Key: OFBIZ-4626 URL: https://issues.apache.org/jira/browse/OFBIZ-4626 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 11.04, SVN trunk Reporter: andrewzn Priority: Minor Fix For: Release Branch 11.04, SVN trunk Help screens use entity-and to retrieve ContentAssoc without fromDate/truDate conditions while help content expiration still may be useful. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4626) Help screen/navigation do not take into account content expiration
[ https://issues.apache.org/jira/browse/OFBIZ-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] andrewzn updated OFBIZ-4626: Attachment: helpscrs.diff Help screen/navigation do not take into account content expiration -- Key: OFBIZ-4626 URL: https://issues.apache.org/jira/browse/OFBIZ-4626 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 11.04, SVN trunk Reporter: andrewzn Priority: Minor Fix For: Release Branch 11.04, SVN trunk Attachments: helpscrs.diff Help screens use entity-and to retrieve ContentAssoc without fromDate/truDate conditions while help content expiration still may be useful. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
