Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Adrian Crum
This commit is throwing a lot of exceptions during data loading. See the 
buildbot report.


-Adrian

On 12/19/2011 6:40 AM, hans...@apache.org wrote:

Author: hansbak
Date: Mon Dec 19 06:40:18 2011
New Revision: 1220622

URL: http://svn.apache.org/viewvc?rev=1220622view=rev
Log:
new producttype: configurable product service, using inventory

Modified:
 ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml
 ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java
 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
 
ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/Product.groovy
 
ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl
 ofbiz/trunk/applications/product/data/ProductTypeData.xml
 
ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml
 
ofbiz/trunk/applications/product/script/org/ofbiz/shipment/receipt/ShipmentReceiptServices.xml
 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java
 
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java
 ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml

Modified: 
ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml?rev=1220622r1=1220621r2=1220622view=diff
==
--- ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml 
(original)
+++ ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml 
Mon Dec 19 06:40:18 2011
@@ -45,6 +45,11 @@ under the License.
  FixedAsset fixedAssetId=DEMO_PROD_EQUIPMT_2 fixedAssetName=Demo Production Equipment Two fixedAssetTypeId=PRODUCTION_EQUIPMENT 
dateAcquired=2005-01-01 00:01:00.0 expectedEndOfLife=2010-01-01 calendarId=DEMO_CALENDAR salvageValue=50 
purchaseCost=1000 purchaseCostUomId=USD/
  FixedAssetGeoPoint fixedAssetId=DEMO_PROD_EQUIPMT_2 geoPointId=9000 
fromDate=2009-01-09 00:00:00.000/

+FixedAsset fixedAssetId=DEMO_BOOK_GROUP fixedAssetTypeId=GROUP_EQUIPMENT 
fixedAssetName=Demo Book Group/
+FixedAssetGeoPoint fixedAssetId=DEMO_BOOK_GROUP geoPointId=9000 
fromDate=2011-08-02 00:00:00.000/
+FixedAsset fixedAssetId=DEMO_BOOK fixedAssetName=Demo Book fixedAssetTypeId=PRODUCTION_EQUIPMENT 
parentFixedAssetId=DEMO_BOOK_GROUP calendarId=DEMO_CALENDAR purchaseCost=200 purchaseCostUomId=USD/
+FixedAssetGeoPoint fixedAssetId=DEMO_BOOK geoPointId=9000 fromDate=2011-08-02 
00:00:00.000/
+
  FixedAssetDepMethod depreciationCustomMethodId=STR_LINE_DEP_FORMULA 
fixedAssetId=DEMO_PROD_EQUIPMT_1/
  FixedAssetDepMethod depreciationCustomMethodId=DBL_DECL_DEP_FORMULA 
fixedAssetId=DEMO_PROD_EQUIPMT_2/
  /entity-engine-xml

Modified: 
ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=1220622r1=1220621r2=1220622view=diff
==
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java 
(original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java 
Mon Dec 19 06:40:18 2011
@@ -1138,7 +1138,7 @@ public class OrderServices {
  String productId = (String) orderItem.get(productId);
  GenericValue product = delegator.getRelatedOne(Product, 
orderItem);

-if(SERVICE_PRODUCT.equals(product.get(productTypeId))){
+if(SERVICE_PRODUCT.equals(product.get(productTypeId)) || 
AGGREGATEDSERV_CONF.equals(product.get(productTypeId))){
  String inventoryFacilityId = null;
  if 
(Y.equals(productStore.getString(oneInventoryFacility))) {
  inventoryFacilityId = 
productStore.getString(inventoryFacilityId);

Modified: 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java?rev=1220622r1=1220621r2=1220622view=diff
==
--- 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java
 (original)
+++ 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java
 Mon Dec 19 06:40:18 2011
@@ -644,7 +644,7 @@ public class CheckOutHelper {
  GenericValue permUserLogin = delegator.findByPrimaryKeyCache(UserLogin, 
UtilMisc.toMap(userLoginId, system));
 

[jira] [Assigned] (OFBIZ-4627) contribute Ofbiz Vietnamese tranlasting to community from HaNoi

2011-12-19 Thread Jacques Le Roux (Assigned) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-4627:
--

Assignee: Jacques Le Roux

 contribute Ofbiz Vietnamese tranlasting to community from HaNoi
 ---

 Key: OFBIZ-4627
 URL: https://issues.apache.org/jira/browse/OFBIZ-4627
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Affects Versions: SVN trunk
Reporter: Tri Duc Vo
Assignee: Jacques Le Roux
  Labels: features
 Fix For: SVN trunk

 Attachments: EcommerceUiLabels.xml, ProductUiLabels.xml

   Original Estimate: 1,344h
  Remaining Estimate: 1,344h

Dear Ofbiz community
I'm Tri, from HaNoi, VietNam, and now our team build ERP based on Ofbiz 
 opensource. 
Now we're completed translating 80% Ecommerce , 50% Catalog of Ofbiz. And 
 we're going to complete 100% Vietnamese Ofbiz tranlasting and contribute them 
 to community.
We'll attach files soon
Thank you

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (OFBIZ-3913) Automated action triggered by event

2011-12-19 Thread Nicolas Malin (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172094#comment-13172094
 ] 

Nicolas Malin commented on OFBIZ-3913:
--

Jacques, do you uncomment seca ?

Index: framework/example/servicedef/secas.xml
===
--- framework/example/servicedef/secas.xml  (révision 1207784)
+++ framework/example/servicedef/secas.xml  (copie de travail)
@@ -27,4 +27,13 @@
 condition-field field-name=statusId operator=not-equals 
to-field-name=oldStatusId/
 action service=createExampleStatus mode=sync/
 /eca
+!-- Active this seca to use externalDevice with demo data -
+eca service=createExample event=return
+set field-name=userLoginId env-name=userLogin.userLoginId/
+set field-name=screenLocation 
value=component://example/widget/example/ExampleScreens.xml#ExampleReport/
+set field-name=content-type value=application/pdf/
+set field-name=screenContext.exampleId env-name=exampleId/
+action service=sendPrintFromScreenByUserAction mode=sync/
+/eca
+--
 /service-eca



 Automated action triggered by event
 ---

 Key: OFBIZ-3913
 URL: https://issues.apache.org/jira/browse/OFBIZ-3913
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: SVN trunk
Reporter: Nicolas Malin
Assignee: Jacques Le Roux
 Attachments: ExternalDevice.patch, ExternalDevice.patch, 
 ExternalDevice.patch, ExternalDevice.png, OFBIZ-3913.ogv, OFBIZ-3913.patch, 
 OFBIZ-3913.patch, PDFCreator.png, What I did with PDFCreator.jpg


 Following a thread on the dev list, related to a printer automated selection, 
 by an user and an event, here is a first draft.
 I added a new entity, ExternalDevice, which list all devices OFBiz can reach 
 (and the associated command). This entity is related to an ExternalDeviceType 
 and each record has a status, so we know if the device is available, out of 
 order, in maintenance, waiting, etc...
 Then I added another entity, ExternalDeviceUserAction, which defines a device 
 for an user, and/or an action through Enumeration. Finally, I added a service 
 which find the commnand to execute based on an action and/or an user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Jacopo Cappellato
Yep,

the problem was the line:

 -ProductFeatureCategory productFeatureCategoryId=IMAGE 
 description=Image/
 +ProductFeatureCategory productFeatureCategoryI=IMAGE 
 description=Image/

I have fixed it.
Even without reviewing this big commit, this kind of errors (that imply that 
very few tests were done) makes me feel nervous about the quality of the code 
committed.

Jacopo


On Dec 19, 2011, at 9:24 AM, Adrian Crum wrote:

 This commit is throwing a lot of exceptions during data loading. See the 
 buildbot report.
 
 -Adrian
 
 On 12/19/2011 6:40 AM, hans...@apache.org wrote:
 Author: hansbak
 Date: Mon Dec 19 06:40:18 2011
 New Revision: 1220622
 
 URL: http://svn.apache.org/viewvc?rev=1220622view=rev
 Log:
 new producttype: configurable product service, using inventory
 
 Modified:
 ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml
 
 ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
 
 ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java
 
 ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
 
 ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/Product.groovy
 
 ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl
 ofbiz/trunk/applications/product/data/ProductTypeData.xml
 
 ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml
 
 ofbiz/trunk/applications/product/script/org/ofbiz/shipment/receipt/ShipmentReceiptServices.xml
 
 ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java
 
 ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java
 ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml
 
 Modified: 
 ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml?rev=1220622r1=1220621r2=1220622view=diff
 ==
 --- ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml 
 (original)
 +++ ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml 
 Mon Dec 19 06:40:18 2011
 @@ -45,6 +45,11 @@ under the License.
  FixedAsset fixedAssetId=DEMO_PROD_EQUIPMT_2 fixedAssetName=Demo 
 Production Equipment Two fixedAssetTypeId=PRODUCTION_EQUIPMENT 
 dateAcquired=2005-01-01 00:01:00.0 expectedEndOfLife=2010-01-01 
 calendarId=DEMO_CALENDAR salvageValue=50 purchaseCost=1000 
 purchaseCostUomId=USD/
  FixedAssetGeoPoint fixedAssetId=DEMO_PROD_EQUIPMT_2 
 geoPointId=9000 fromDate=2009-01-09 00:00:00.000/
 
 +FixedAsset fixedAssetId=DEMO_BOOK_GROUP 
 fixedAssetTypeId=GROUP_EQUIPMENT fixedAssetName=Demo Book Group/
 +FixedAssetGeoPoint fixedAssetId=DEMO_BOOK_GROUP geoPointId=9000 
 fromDate=2011-08-02 00:00:00.000/
 +FixedAsset fixedAssetId=DEMO_BOOK fixedAssetName=Demo Book 
 fixedAssetTypeId=PRODUCTION_EQUIPMENT parentFixedAssetId=DEMO_BOOK_GROUP 
 calendarId=DEMO_CALENDAR purchaseCost=200 purchaseCostUomId=USD/
 +FixedAssetGeoPoint fixedAssetId=DEMO_BOOK geoPointId=9000 
 fromDate=2011-08-02 00:00:00.000/
 +
  FixedAssetDepMethod depreciationCustomMethodId=STR_LINE_DEP_FORMULA 
 fixedAssetId=DEMO_PROD_EQUIPMT_1/
  FixedAssetDepMethod depreciationCustomMethodId=DBL_DECL_DEP_FORMULA 
 fixedAssetId=DEMO_PROD_EQUIPMT_2/
  /entity-engine-xml
 
 Modified: 
 ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=1220622r1=1220621r2=1220622view=diff
 ==
 --- 
 ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java 
 (original)
 +++ 
 ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java 
 Mon Dec 19 06:40:18 2011
 @@ -1138,7 +1138,7 @@ public class OrderServices {
  String productId = (String) orderItem.get(productId);
  GenericValue product = 
 delegator.getRelatedOne(Product, orderItem);
 
 -
 if(SERVICE_PRODUCT.equals(product.get(productTypeId))){
 +
 if(SERVICE_PRODUCT.equals(product.get(productTypeId)) || 
 AGGREGATEDSERV_CONF.equals(product.get(productTypeId))){
  String inventoryFacilityId = null;
  if 
 (Y.equals(productStore.getString(oneInventoryFacility))) {
  inventoryFacilityId = 
 productStore.getString(inventoryFacilityId);
 
 Modified: 
 ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java
 URL: 
 

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Adrian Crum

I agree that it is troubling. The designs are questionable as well.

-Adrian

On 12/19/2011 8:38 AM, Jacopo Cappellato wrote:

Yep,

the problem was the line:


-ProductFeatureCategory productFeatureCategoryId=IMAGE description=Image/
+ProductFeatureCategory productFeatureCategoryI=IMAGE description=Image/

I have fixed it.
Even without reviewing this big commit, this kind of errors (that imply that 
very few tests were done) makes me feel nervous about the quality of the code 
committed.

Jacopo


On Dec 19, 2011, at 9:24 AM, Adrian Crum wrote:


This commit is throwing a lot of exceptions during data loading. See the 
buildbot report.

-Adrian

On 12/19/2011 6:40 AM, hans...@apache.org wrote:

Author: hansbak
Date: Mon Dec 19 06:40:18 2011
New Revision: 1220622

URL: http://svn.apache.org/viewvc?rev=1220622view=rev
Log:
new producttype: configurable product service, using inventory

Modified:
 ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml
 ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java
 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
 
ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/Product.groovy
 
ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl
 ofbiz/trunk/applications/product/data/ProductTypeData.xml
 
ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml
 
ofbiz/trunk/applications/product/script/org/ofbiz/shipment/receipt/ShipmentReceiptServices.xml
 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java
 
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java
 ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml

Modified: 
ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml?rev=1220622r1=1220621r2=1220622view=diff
==
--- ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml 
(original)
+++ ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml 
Mon Dec 19 06:40:18 2011
@@ -45,6 +45,11 @@ under the License.
  FixedAsset fixedAssetId=DEMO_PROD_EQUIPMT_2 fixedAssetName=Demo Production Equipment Two fixedAssetTypeId=PRODUCTION_EQUIPMENT 
dateAcquired=2005-01-01 00:01:00.0 expectedEndOfLife=2010-01-01 calendarId=DEMO_CALENDAR salvageValue=50 
purchaseCost=1000 purchaseCostUomId=USD/
  FixedAssetGeoPoint fixedAssetId=DEMO_PROD_EQUIPMT_2 geoPointId=9000 
fromDate=2009-01-09 00:00:00.000/

+FixedAsset fixedAssetId=DEMO_BOOK_GROUP fixedAssetTypeId=GROUP_EQUIPMENT 
fixedAssetName=Demo Book Group/
+FixedAssetGeoPoint fixedAssetId=DEMO_BOOK_GROUP geoPointId=9000 
fromDate=2011-08-02 00:00:00.000/
+FixedAsset fixedAssetId=DEMO_BOOK fixedAssetName=Demo Book fixedAssetTypeId=PRODUCTION_EQUIPMENT 
parentFixedAssetId=DEMO_BOOK_GROUP calendarId=DEMO_CALENDAR purchaseCost=200 purchaseCostUomId=USD/
+FixedAssetGeoPoint fixedAssetId=DEMO_BOOK geoPointId=9000 fromDate=2011-08-02 
00:00:00.000/
+
  FixedAssetDepMethod depreciationCustomMethodId=STR_LINE_DEP_FORMULA 
fixedAssetId=DEMO_PROD_EQUIPMT_1/
  FixedAssetDepMethod depreciationCustomMethodId=DBL_DECL_DEP_FORMULA 
fixedAssetId=DEMO_PROD_EQUIPMT_2/
  /entity-engine-xml

Modified: 
ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=1220622r1=1220621r2=1220622view=diff
==
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java 
(original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java 
Mon Dec 19 06:40:18 2011
@@ -1138,7 +1138,7 @@ public class OrderServices {
  String productId = (String) orderItem.get(productId);
  GenericValue product = delegator.getRelatedOne(Product, 
orderItem);

-if(SERVICE_PRODUCT.equals(product.get(productTypeId))){
+if(SERVICE_PRODUCT.equals(product.get(productTypeId)) || 
AGGREGATEDSERV_CONF.equals(product.get(productTypeId))){
  String inventoryFacilityId = null;
  if 
(Y.equals(productStore.getString(oneInventoryFacility))) {
  inventoryFacilityId = 
productStore.getString(inventoryFacilityId);

Modified: 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java
URL: 

buildbot success in ASF Buildbot on ofbiz-trunk

2011-12-19 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/ofbiz-trunk/builds/2415

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: isis_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch ofbiz/trunk] 1220649
Blamelist: jacopoc

Build succeeded!

sincerely,
 -The Buildbot





[jira] [Commented] (OFBIZ-4627) contribute Ofbiz Vietnamese tranlasting to community from HaNoi

2011-12-19 Thread Jacques Le Roux (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172138#comment-13172138
 ] 

Jacques Le Roux commented on OFBIZ-4627:


Sorry Tri, 
* These are not patches files, please read 
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices
 thoroughly
* When attaching patches, don't forget to check the Grant license to ASF for 
inclusion in ASF works (as per the Apache License §5) for license granting
* In future (I did it for you this time) after attaching files push the 
Provide Patch button in order to set the new Jira issue status

 contribute Ofbiz Vietnamese tranlasting to community from HaNoi
 ---

 Key: OFBIZ-4627
 URL: https://issues.apache.org/jira/browse/OFBIZ-4627
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Affects Versions: SVN trunk
Reporter: Tri Duc Vo
Assignee: Jacques Le Roux
  Labels: features
 Fix For: SVN trunk

 Attachments: EcommerceUiLabels.xml, ProductUiLabels.xml

   Original Estimate: 1,344h
  Remaining Estimate: 1,344h

Dear Ofbiz community
I'm Tri, from HaNoi, VietNam, and now our team build ERP based on Ofbiz 
 opensource. 
Now we're completed translating 80% Ecommerce , 50% Catalog of Ofbiz. And 
 we're going to complete 100% Vietnamese Ofbiz tranlasting and contribute them 
 to community.
We'll attach files soon
Thank you

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (OFBIZ-3913) Automated action triggered by event

2011-12-19 Thread Jacques Le Roux (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172230#comment-13172230
 ] 

Jacques Le Roux commented on OFBIZ-3913:


Hi Nicolas,

Thanks, yes I tried since, but got another issue with the name. I 1st created a 
PDF resource and did not remove it. After removing the PDF line, the PDFCreator 
item did not appear in the dropdown where you assign the login (admin). Also 
when you remove a line from External Device orExternal Device User Action 
screens, it does not update the list correctly (when more than one lines), this 
is confusing


I will double check all that by creating from new, but clearly it's a bit 
fragile at the moment ;)

 Automated action triggered by event
 ---

 Key: OFBIZ-3913
 URL: https://issues.apache.org/jira/browse/OFBIZ-3913
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: SVN trunk
Reporter: Nicolas Malin
Assignee: Jacques Le Roux
 Attachments: ExternalDevice.patch, ExternalDevice.patch, 
 ExternalDevice.patch, ExternalDevice.png, OFBIZ-3913.ogv, OFBIZ-3913.patch, 
 OFBIZ-3913.patch, PDFCreator.png, What I did with PDFCreator.jpg


 Following a thread on the dev list, related to a printer automated selection, 
 by an user and an event, here is a first draft.
 I added a new entity, ExternalDevice, which list all devices OFBiz can reach 
 (and the associated command). This entity is related to an ExternalDeviceType 
 and each record has a status, so we know if the device is available, out of 
 order, in maintenance, waiting, etc...
 Then I added another entity, ExternalDeviceUserAction, which defines a device 
 for an user, and/or an action through Enumeration. Finally, I added a service 
 which find the commnand to execute based on an action and/or an user.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Hans Bakker

Hi Jacopo,

thanks for helping me, it is good try to work together instead of 
personally accusing people. With the amount of commits we produce here 
at Antwebsystems, it can once in a while go wrong and have errors. I am 
setting up a Jenkins automated test system in our company to improve on 
the situation.


I join other committers that we also worry about the amount of changes 
that go into the system which could introduce errors. On the other hand 
without them, it will quickly kill the OFBiz system.  Perhaps in the 
future we should insist on having junit tests for new functions and 
enhancements to existing functions.


Thanks again for your help,

Regards,
Hans

On 12/19/2011 03:38 PM, Jacopo Cappellato wrote:

Yep,

the problem was the line:


-ProductFeatureCategory productFeatureCategoryId=IMAGE description=Image/
+ProductFeatureCategory productFeatureCategoryI=IMAGE description=Image/

I have fixed it.
Even without reviewing this big commit, this kind of errors (that imply that 
very few tests were done) makes me feel nervous about the quality of the code 
committed.

Jacopo


On Dec 19, 2011, at 9:24 AM, Adrian Crum wrote:


This commit is throwing a lot of exceptions during data loading. See the 
buildbot report.

-Adrian

On 12/19/2011 6:40 AM, hans...@apache.org wrote:

Author: hansbak
Date: Mon Dec 19 06:40:18 2011
New Revision: 1220622

URL: http://svn.apache.org/viewvc?rev=1220622view=rev
Log:
new producttype: configurable product service, using inventory

Modified:
 ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml
 ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java
 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
 
ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/Product.groovy
 
ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl
 ofbiz/trunk/applications/product/data/ProductTypeData.xml
 
ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml
 
ofbiz/trunk/applications/product/script/org/ofbiz/shipment/receipt/ShipmentReceiptServices.xml
 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java
 
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java
 ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml

Modified: 
ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml?rev=1220622r1=1220621r2=1220622view=diff
==
--- ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml 
(original)
+++ ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml 
Mon Dec 19 06:40:18 2011
@@ -45,6 +45,11 @@ under the License.
  FixedAsset fixedAssetId=DEMO_PROD_EQUIPMT_2 fixedAssetName=Demo Production Equipment Two fixedAssetTypeId=PRODUCTION_EQUIPMENT 
dateAcquired=2005-01-01 00:01:00.0 expectedEndOfLife=2010-01-01 calendarId=DEMO_CALENDAR salvageValue=50 
purchaseCost=1000 purchaseCostUomId=USD/
  FixedAssetGeoPoint fixedAssetId=DEMO_PROD_EQUIPMT_2 geoPointId=9000 
fromDate=2009-01-09 00:00:00.000/

+FixedAsset fixedAssetId=DEMO_BOOK_GROUP fixedAssetTypeId=GROUP_EQUIPMENT 
fixedAssetName=Demo Book Group/
+FixedAssetGeoPoint fixedAssetId=DEMO_BOOK_GROUP geoPointId=9000 
fromDate=2011-08-02 00:00:00.000/
+FixedAsset fixedAssetId=DEMO_BOOK fixedAssetName=Demo Book fixedAssetTypeId=PRODUCTION_EQUIPMENT 
parentFixedAssetId=DEMO_BOOK_GROUP calendarId=DEMO_CALENDAR purchaseCost=200 purchaseCostUomId=USD/
+FixedAssetGeoPoint fixedAssetId=DEMO_BOOK geoPointId=9000 fromDate=2011-08-02 
00:00:00.000/
+
  FixedAssetDepMethod depreciationCustomMethodId=STR_LINE_DEP_FORMULA 
fixedAssetId=DEMO_PROD_EQUIPMT_1/
  FixedAssetDepMethod depreciationCustomMethodId=DBL_DECL_DEP_FORMULA 
fixedAssetId=DEMO_PROD_EQUIPMT_2/
  /entity-engine-xml

Modified: 
ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=1220622r1=1220621r2=1220622view=diff
==
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java 
(original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java 
Mon Dec 19 06:40:18 2011
@@ -1138,7 +1138,7 @@ public class OrderServices {
  String productId = (String) orderItem.get(productId);
  GenericValue product = delegator.getRelatedOne(Product, 
orderItem);

-

[jira] [Commented] (OFBIZ-4487) enable definition for position on sortfield

2011-12-19 Thread Erwan de FERRIERES (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172575#comment-13172575
 ] 

Erwan de FERRIERES commented on OFBIZ-4487:
---

Done at r1220927
Thanks Youssef and Olivier

 enable definition for position on sortfield
 ---

 Key: OFBIZ-4487
 URL: https://issues.apache.org/jira/browse/OFBIZ-4487
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: youssef khaye
Assignee: Erwan de FERRIERES
 Fix For: SVN trunk

 Attachments: OFBIZ-4487-1.png, OFBIZ-4487-2.png, 
 sortFieldPosition-exampleForms.patch, sortFieldPosition.patch, 
 sortFieldPosition2.patch


 in some cases, form extending another one, it may be convenient to be able to 
 define field position on the sort field element.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Closed] (OFBIZ-4487) enable definition for position on sortfield

2011-12-19 Thread Erwan de FERRIERES (Closed) (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erwan de FERRIERES closed OFBIZ-4487.
-

   Resolution: Fixed
Fix Version/s: SVN trunk

 enable definition for position on sortfield
 ---

 Key: OFBIZ-4487
 URL: https://issues.apache.org/jira/browse/OFBIZ-4487
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: youssef khaye
Assignee: Erwan de FERRIERES
 Fix For: SVN trunk

 Attachments: OFBIZ-4487-1.png, OFBIZ-4487-2.png, 
 sortFieldPosition-exampleForms.patch, sortFieldPosition.patch, 
 sortFieldPosition2.patch


 in some cases, form extending another one, it may be convenient to be able to 
 define field position on the sort field element.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Bilgin Ibryam
On 19 December 2011 14:14, Hans Bakker mailingl...@antwebsystems.com wrote:
 Hi Jacopo,

Hello Hans,


 thanks for helping me, it is good try to work together instead of personally
 accusing people. With the amount of commits we produce here at
 Antwebsystems, it can once in a while go wrong and have errors.

The amount of code can be an explanation for the amount of errors, but
not for its quality

 I am setting
 up a Jenkins automated test system in our company to improve on the
 situation.

CI without self testing code doesn't mean anything (except that the
code compiles). On the hand having something like Sonar (and paying
attention to what it says) may help to improve the code quality.


 I join other committers that we also worry about the amount of changes that
 go into the system which could introduce errors. On the other hand without
 them, it will quickly kill the OFBiz system.  Perhaps in the future we
 should insist on having junit tests for new functions and enhancements to
 existing functions.


I totally agree with you here (about having test coverage for any new
feature in the system)

Cheers,
Bilgin

 Thanks again for your help,

 Regards,
 Hans


 On 12/19/2011 03:38 PM, Jacopo Cappellato wrote:

 Yep,

 the problem was the line:

 -ProductFeatureCategory productFeatureCategoryId=IMAGE
 description=Image/
 +ProductFeatureCategory productFeatureCategoryI=IMAGE
 description=Image/

 I have fixed it.
 Even without reviewing this big commit, this kind of errors (that imply
 that very few tests were done) makes me feel nervous about the quality of
 the code committed.

 Jacopo


 On Dec 19, 2011, at 9:24 AM, Adrian Crum wrote:

 This commit is throwing a lot of exceptions during data loading. See the
 buildbot report.

 -Adrian

 On 12/19/2011 6:40 AM, hans...@apache.org wrote:

 Author: hansbak
 Date: Mon Dec 19 06:40:18 2011
 New Revision: 1220622

 URL: http://svn.apache.org/viewvc?rev=1220622view=rev
 Log:
 new producttype: configurable product service, using inventory

 Modified:

 ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml

 ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java

 ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java

 ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java

 ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/Product.groovy

 ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/productsummary.ftl
     ofbiz/trunk/applications/product/data/ProductTypeData.xml

 ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml

 ofbiz/trunk/applications/product/script/org/ofbiz/shipment/receipt/ShipmentReceiptServices.xml

 ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java

 ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java
     ofbiz/trunk/specialpurpose/ecommerce/data/DemoProduct.xml

 Modified:
 ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml
 URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml?rev=1220622r1=1220621r2=1220622view=diff

 ==
 ---
 ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml
 (original)
 +++
 ofbiz/trunk/applications/manufacturing/data/ManufacturingExampleData.xml 
 Mon
 Dec 19 06:40:18 2011
 @@ -45,6 +45,11 @@ under the License.
      FixedAsset fixedAssetId=DEMO_PROD_EQUIPMT_2 fixedAssetName=Demo
 Production Equipment Two fixedAssetTypeId=PRODUCTION_EQUIPMENT
 dateAcquired=2005-01-01 00:01:00.0 expectedEndOfLife=2010-01-01
 calendarId=DEMO_CALENDAR salvageValue=50 purchaseCost=1000
 purchaseCostUomId=USD/
      FixedAssetGeoPoint fixedAssetId=DEMO_PROD_EQUIPMT_2
 geoPointId=9000 fromDate=2009-01-09 00:00:00.000/

 +FixedAsset fixedAssetId=DEMO_BOOK_GROUP
 fixedAssetTypeId=GROUP_EQUIPMENT fixedAssetName=Demo Book Group/
 +FixedAssetGeoPoint fixedAssetId=DEMO_BOOK_GROUP geoPointId=9000
 fromDate=2011-08-02 00:00:00.000/
 +FixedAsset fixedAssetId=DEMO_BOOK fixedAssetName=Demo Book
 fixedAssetTypeId=PRODUCTION_EQUIPMENT 
 parentFixedAssetId=DEMO_BOOK_GROUP
 calendarId=DEMO_CALENDAR purchaseCost=200 purchaseCostUomId=USD/
 +FixedAssetGeoPoint fixedAssetId=DEMO_BOOK geoPointId=9000
 fromDate=2011-08-02 00:00:00.000/
 +
      FixedAssetDepMethod
 depreciationCustomMethodId=STR_LINE_DEP_FORMULA
 fixedAssetId=DEMO_PROD_EQUIPMT_1/
      FixedAssetDepMethod
 depreciationCustomMethodId=DBL_DECL_DEP_FORMULA
 fixedAssetId=DEMO_PROD_EQUIPMT_2/
  /entity-engine-xml

 Modified:
 ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
 URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=1220622r1=1220621r2=1220622view=diff

 

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Scott Gray
On 19/12/2011, at 7:14 AM, Hans Bakker wrote:

 Hi Jacopo,
 
 thanks for helping me, it is good try to work together instead of personally 
 accusing people. With the amount of commits we produce here at Antwebsystems, 
 it can once in a while go wrong and have errors. I am setting up a Jenkins 
 automated test system in our company to improve on the situation.
 
 I join other committers that we also worry about the amount of changes that 
 go into the system which could introduce errors. On the other hand without 
 them, it will quickly kill the OFBiz system.  

Personally I believe it is poor design and code quality that will ultimately 
kill OFBiz.  IMO the codebase could see nothing but bug fixes and still be a 
useful platform 5-10 years into the future unless something equally as flexible 
and robust comes along.  It is the volume of core existing business processes 
and the speed at which new ones can be implemented into custom deployments that 
keeps it alive.  The more difficult those implementations become because of 
poor OOTB design is what will see OFBiz usership decline. 

 Perhaps in the future we should insist on having junit tests for new 
 functions and enhancements to existing functions.
 
 Thanks again for your help,
 
 Regards,
 Hans
 
 On 12/19/2011 03:38 PM, Jacopo Cappellato wrote:
 Yep,
 
 the problem was the line:
 
 -ProductFeatureCategory productFeatureCategoryId=IMAGE 
 description=Image/
 +ProductFeatureCategory productFeatureCategoryI=IMAGE 
 description=Image/
 I have fixed it.
 Even without reviewing this big commit, this kind of errors (that imply that 
 very few tests were done) makes me feel nervous about the quality of the 
 code committed.
 
 Jacopo
 
 
 On Dec 19, 2011, at 9:24 AM, Adrian Crum wrote:
 
 This commit is throwing a lot of exceptions during data loading. See the 
 buildbot report.
 
 -Adrian
 
 On 12/19/2011 6:40 AM, hans...@apache.org wrote:
 Author: hansbak
 Date: Mon Dec 19 06:40:18 2011
 New Revision: 1220622
 
 URL: http://svn.apache.org/viewvc?rev=1220622view=rev
 Log:
 new producttype: configurable product service, using inventory



Becoming a contributor

2011-12-19 Thread Jeff Prickett


Hi,

I have followed Ofbiz for a number of years and am wanting to become a 
contributor. I previously worked on the Jetspeed and Turbine projects 
many years ago. I have a Bachelor degree in Electrical Engineering and 
am pursuing a second Bachelor degree in Accounting.


I have many ideas and would like to streamline the UI and setup process 
so that it is less daunting.


I have never deployed Ofbiz in production as I myself do not have a 
business.


Ideally, I would like to work fulltime with Ofbiz and become a business 
consultant or work for a company that uses Ofbiz.


I look forward to becoming part of the team.


Becoming a contributor

2011-12-19 Thread Jeff Prickett


Hi,

I have followed Ofbiz for a number of years and am wanting to become a 
contributor. I previously worked on the Jetspeed and Turbine projects 
many years ago. I have a Bachelor degree in Electrical Engineering and 
am pursuing a second Bachelor degree in Accounting.


I have many ideas and would like to streamline the UI and setup process 
so that it is less daunting.


I have never deployed Ofbiz in production as I myself do not have a 
business.


Ideally, I would like to work fulltime with Ofbiz and become a business 
consultant or work for a company that uses Ofbiz.


Thanks for your work on Ofbiz

Jeff Prickett