date:20160204


[ 
https://issues.apache.org/jira/browse/OFBIZ-6843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132084#comment-15132084
 ] 

Jacques Le Roux commented on OFBIZ-6843:


OK it worked, too much local changes in the instance I tried 1st I guess :)

> New theme Rainbow Stone
> ---
>
> Key: OFBIZ-6843
> URL: https://issues.apache.org/jira/browse/OFBIZ-6843
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Minor
>  Labels: features, theme
> Fix For: Trunk
>
> Attachments: patch3rainbowstone.patch, rainbowstone.tar.gz, 
> screenshot-1.png
>
>
> I create a new theme based on Flat Grey.
> It's the beginning but already functional, my goal is to provide a new style 
> for OFBiz.
> This is my tastes, so don't hesitate to criticize :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: sessionId in logs

2016-02-04 Thread gil portenseigne


Hi,

I never used/looked for sessionId in log, and i don't see the benefit 
yet. So i'm more for commenting out.


Do someone ever used this info ? In which case ?

Gil

On 04/02/2016 11:30, Jacques Le Roux wrote:

Hi,

As I wrote at https://issues.apache.org/jira/browse/OFBIZ-6867

>


Note: UtilHttp.getSessionId() is only used in RequestHandler.java

Despite we secured the log access at r1489461, I'm more for commenting 
out. We could also make this dependent of a properties to quickly 
allow to see these information in logs.


What are your opinions?

Jacques

Re: Release 14.12.01 and Dedication for Adrian

2016-02-04 Thread Nicolas Malin


Totally approve ! +1

Le 04/02/2016 09:53, Sharan-F a écrit :

Hi Everyone

Looking at our tentative release schedule we have said that this month we
would look at releasing 14.12.01. It has been maturing for over a year so
are we ready to begin preparing for its release this month ?

Also we talked about dedicating a release to Adrian so I think we could use
this one (or even the whole 14.12 series..). We could add a special
dedication on the Downloads page as part of the release description.

What do people think ?


Thanks
Sharan





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Release-14-12-01-and-Dedication-for-Adrian-tp4676835.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: svn commit: r1728411 - /ofbiz/trunk/.classpath

2016-02-04 Thread Christian Geisert

Taher,

you beat me to it ;-)
Will you commit this to the release15.12 branch too or shall I do it?

Thanks,
Christian

Am 04.02.2016 07:57, schrieb ta...@apache.org:
> Author: taher
> Date: Thu Feb  4 06:57:52 2016
> New Revision: 1728411
>
> URL: http://svn.apache.org/viewvc?rev=1728411=rev
> Log:
> fix the classpath file for updated tomcat libraries
>
> The tomcat libraries that were updated in the framework
> changed their names slightly. This commit updates the
> names for the IDE to work correctly
>
> Modified:
> ofbiz/trunk/.classpath
>
> Modified: ofbiz/trunk/.classpath
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=1728411=1728410=1728411=diff
> ==
> --- ofbiz/trunk/.classpath (original)
> +++ ofbiz/trunk/.classpath Thu Feb  4 06:57:52 2016
> @@ -98,9 +98,9 @@
>path="framework/catalina/lib/tomcat-7.0.65-jasper.jar"/>
>path="framework/catalina/lib/tomcat-7.0.65-tomcat-api.jar"/>
>path="framework/catalina/lib/tomcat-7.0.65-tomcat-coyote.jar"/>
> -  path="framework/catalina/lib/tomcat-7.0.65-tomcat-util.jar"/>
> +  path="framework/catalina/lib/tomcat-7.0.65-tomcat-juli-adapters.jar"/>
>path="framework/catalina/lib/tomcat-extras-7.0.65-tomcat-juli.jar"/>
> -  path="framework/catalina/lib/tomcat-extras-7.0.65-tomcat-juli-adapters.jar"/>
> +  path="framework/catalina/lib/tomcat-extras-7.0.65-tomcat-util.jar"/>
>path="framework/entity/lib/commons-dbcp2-2.1.jar"/>
>path="framework/geronimo/lib/geronimo-transaction-3.1.1.jar"/>
>path="framework/service/lib/axiom-api-1.2.14.jar"/>
>
>
>

sessionId in logs


Hi,

As I wrote at https://issues.apache.org/jira/browse/OFBIZ-6867

>

Note: UtilHttp.getSessionId() is only used in RequestHandler.java

Despite we secured the log access at r1489461, I'm more for commenting out. We could also make this dependent of a properties to quickly allow to see 
these information in logs.


What are your opinions?

Jacques

Re: Release 14.12.01 and Dedication for Adrian

2016-02-04 Thread Christian Geisert

+1

Both for trying to do the release and dedicating this to Adrian.

Christian

Am 04.02.2016 09:53, schrieb Sharan-F:
> Hi Everyone
>
> Looking at our tentative release schedule we have said that this month we
> would look at releasing 14.12.01. It has been maturing for over a year so
> are we ready to begin preparing for its release this month ?
>
> Also we talked about dedicating a release to Adrian so I think we could use
> this one (or even the whole 14.12 series..). We could add a special
> dedication on the Downloads page as part of the release description.
>
> What do people think ?
>
>
> Thanks
> Sharan
>
>
>
>
>
> --
> View this message in context: 
> http://ofbiz.135035.n4.nabble.com/Release-14-12-01-and-Dedication-for-Adrian-tp4676835.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>

[jira] [Commented] (OFBIZ-6843) New theme Rainbow Stone


[ 
https://issues.apache.org/jira/browse/OFBIZ-6843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132085#comment-15132085
 ] 

Julien NICOLAS commented on OFBIZ-6843:
---

Good news! Tanks for your feedback Jacques :)

> New theme Rainbow Stone
> ---
>
> Key: OFBIZ-6843
> URL: https://issues.apache.org/jira/browse/OFBIZ-6843
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Minor
>  Labels: features, theme
> Fix For: Trunk
>
> Attachments: patch3rainbowstone.patch, rainbowstone.tar.gz, 
> screenshot-1.png
>
>
> I create a new theme based on Flat Grey.
> It's the beginning but already functional, my goal is to provide a new style 
> for OFBiz.
> This is my tastes, so don't hesitate to criticize :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Release 14.12.01 and Dedication for Adrian

2016-02-04 Thread gil portenseigne


+1

On 04/02/2016 11:33, Jacques Le Roux wrote:
That's quite a good idea Sharan, the whole series would not be too 
much in my opinion


Jacques

Le 04/02/2016 09:53, Sharan-F a écrit :

Hi Everyone

Looking at our tentative release schedule we have said that this 
month we
would look at releasing 14.12.01. It has been maturing for over a 
year so

are we ready to begin preparing for its release this month ?

Also we talked about dedicating a release to Adrian so I think we 
could use

this one (or even the whole 14.12 series..). We could add a special
dedication on the Downloads page as part of the release description.

What do people think ?


Thanks
Sharan





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Release-14-12-01-and-Dedication-for-Adrian-tp4676835.html

Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: Release 14.12.01 and Dedication for Adrian

2016-02-04 Thread Heidi Dehaes - Olagos

+1

Olagos bvba
Heidi Dehaes
Kerkstraat 34
2570 Duffel
Belgium
Tel. : 015/31 53 04
GSM :0485/22 35 80
E-mail : info.ola...@gmail.com
http://www.olagos.eu
http://www.olagos.com
http://www.olagos.be
http://www.olagos.nl



2016-02-04 13:17 GMT+01:00 Christian Geisert 
:

> +1
>
> Both for trying to do the release and dedicating this to Adrian.
>
> Christian
>
> Am 04.02.2016 09:53, schrieb Sharan-F:
> > Hi Everyone
> >
> > Looking at our tentative release schedule we have said that this month we
> > would look at releasing 14.12.01. It has been maturing for over a year so
> > are we ready to begin preparing for its release this month ?
> >
> > Also we talked about dedicating a release to Adrian so I think we could
> use
> > this one (or even the whole 14.12 series..). We could add a special
> > dedication on the Downloads page as part of the release description.
> >
> > What do people think ?
> >
> >
> > Thanks
> > Sharan
> >
> >
> >
> >
> >
> > --
> > View this message in context:
> http://ofbiz.135035.n4.nabble.com/Release-14-12-01-and-Dedication-for-Adrian-tp4676835.html
> > Sent from the OFBiz - Dev mailing list archive at Nabble.com.
> >
>
>

Re: Release 14.12.01 and Dedication for Adrian


That's quite a good idea Sharan, the whole series would not be too much in my 
opinion

Jacques

Le 04/02/2016 09:53, Sharan-F a écrit :

Hi Everyone

Looking at our tentative release schedule we have said that this month we
would look at releasing 14.12.01. It has been maturing for over a year so
are we ready to begin preparing for its release this month ?

Also we talked about dedicating a release to Adrian so I think we could use
this one (or even the whole 14.12 series..). We could add a special
dedication on the Downloads page as part of the release description.

What do people think ?


Thanks
Sharan





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Release-14-12-01-and-Dedication-for-Adrian-tp4676835.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: Release 14.12.01 and Dedication for Adrian

2016-02-04 Thread Taher Alkhateeb

+1

We miss you!

On Thu, Feb 4, 2016 at 1:37 PM, gil portenseigne <
gil.portensei...@nereide.fr> wrote:

> +1
>
> On 04/02/2016 11:33, Jacques Le Roux wrote:
>
> That's quite a good idea Sharan, the whole series would not be too much in
> my opinion
>
> Jacques
>
> Le 04/02/2016 09:53, Sharan-F a écrit :
>
> Hi Everyone
>
> Looking at our tentative release schedule we have said that this month we
> would look at releasing 14.12.01. It has been maturing for over a year so
> are we ready to begin preparing for its release this month ?
>
> Also we talked about dedicating a release to Adrian so I think we could
> use
> this one (or even the whole 14.12 series..). We could add a special
> dedication on the Downloads page as part of the release description.
>
> What do people think ?
>
>
> Thanks
> Sharan
>
>
>
>
>
> --
> View this message in context:
> http://ofbiz.135035.n4.nabble.com/Release-14-12-01-and-Dedication-for-Adrian-tp4676835.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>
>
>
>

Re: Release 14.12.01 and Dedication for Adrian

2016-02-04 Thread Julien NICOLAS


+1!!!

Le 04/02/2016 11:33, Jacques Le Roux a écrit :
That's quite a good idea Sharan, the whole series would not be too 
much in my opinion


Jacques

Le 04/02/2016 09:53, Sharan-F a écrit :

Hi Everyone

Looking at our tentative release schedule we have said that this 
month we
would look at releasing 14.12.01. It has been maturing for over a 
year so

are we ready to begin preparing for its release this month ?

Also we talked about dedicating a release to Adrian so I think we 
could use

this one (or even the whole 14.12 series..). We could add a special
dedication on the Downloads page as part of the release description.

What do people think ?


Thanks
Sharan





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Release-14-12-01-and-Dedication-for-Adrian-tp4676835.html

Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: sessionId in logs


I must say I relied on it while working on issues with load-balancing. Apart 
that I can't see any other use.
So that's why I finally suggest a properties to opt in, false by default

Jacques

Le 04/02/2016 11:45, gil portenseigne a écrit :

Hi,

I never used/looked for sessionId in log, and i don't see the benefit yet. So 
i'm more for commenting out.

Do someone ever used this info ? In which case ?

Gil

On 04/02/2016 11:30, Jacques Le Roux wrote:

Hi,

As I wrote at https://issues.apache.org/jira/browse/OFBIZ-6867

>

Note: UtilHttp.getSessionId() is only used in RequestHandler.java

Despite we secured the log access at r1489461, I'm more for commenting out. We could also make this dependent of a properties to quickly allow to 
see these information in logs.


What are your opinions?

Jacques

Re: svn commit: r1728411 - /ofbiz/trunk/.classpath

2016-02-04 Thread slidingfilaments

Hi Christian,

go ahead, I just fixed it in trunk for the IDE to work.

Regards,
--

Taher Alkhateeb

> On Feb 4, 2016, at 3:12 PM, Christian Geisert  
> wrote:
> 
> Taher,
> 
> you beat me to it ;-)
> Will you commit this to the release15.12 branch too or shall I do it?
> 
> Thanks,
> Christian
> 
> Am 04.02.2016 07:57, schrieb ta...@apache.org:
>> Author: taher
>> Date: Thu Feb  4 06:57:52 2016
>> New Revision: 1728411
>> 
>> URL: http://svn.apache.org/viewvc?rev=1728411=rev
>> Log:
>> fix the classpath file for updated tomcat libraries
>> 
>> The tomcat libraries that were updated in the framework
>> changed their names slightly. This commit updates the
>> names for the IDE to work correctly
>> 
>> Modified:
>>ofbiz/trunk/.classpath
>> 
>> Modified: ofbiz/trunk/.classpath
>> URL: 
>> http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=1728411=1728410=1728411=diff
>> ==
>> --- ofbiz/trunk/.classpath (original)
>> +++ ofbiz/trunk/.classpath Thu Feb  4 06:57:52 2016
>> @@ -98,9 +98,9 @@
>>> path="framework/catalina/lib/tomcat-7.0.65-jasper.jar"/>
>>> path="framework/catalina/lib/tomcat-7.0.65-tomcat-api.jar"/>
>>> path="framework/catalina/lib/tomcat-7.0.65-tomcat-coyote.jar"/>
>> -> path="framework/catalina/lib/tomcat-7.0.65-tomcat-util.jar"/>
>> +> path="framework/catalina/lib/tomcat-7.0.65-tomcat-juli-adapters.jar"/>
>>> path="framework/catalina/lib/tomcat-extras-7.0.65-tomcat-juli.jar"/>
>> -> path="framework/catalina/lib/tomcat-extras-7.0.65-tomcat-juli-adapters.jar"/>
>> +> path="framework/catalina/lib/tomcat-extras-7.0.65-tomcat-util.jar"/>
>>> path="framework/entity/lib/commons-dbcp2-2.1.jar"/>
>>> path="framework/geronimo/lib/geronimo-transaction-3.1.1.jar"/>
>>> path="framework/service/lib/axiom-api-1.2.14.jar"/>
>

[jira] [Commented] (OFBIZ-5840) Create bootstrap theme


[ 
https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133033#comment-15133033
 ] 

Jacques Le Roux commented on OFBIZ-5840:


I mean both versions, but do we really need 2 versions? 

I particularly like how the menus are handled!

I remember Julien talked about theme colorization, that would be great: 1 theme 
several possible colors, with anyone you want even better.


> Create bootstrap theme
> --
>
> Key: OFBIZ-5840
> URL: https://issues.apache.org/jira/browse/OFBIZ-5840
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework, themes
>Affects Versions: Bootstrap theme
>Reporter: Julien NICOLAS
>  Labels: bootstrap, theme
> Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, 
> GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, 
> OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, 
> appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, 
> bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, 
> calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, 
> htmlMenuMacroLibrary.patch, lookupField_patch.patch, 
> pagination_htmlFormMacroLibrary.patch, 
> panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, 
> preferences.png, styling_issue_1.png, styling_issue_2.png, 
> styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, 
> styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, 
> styling_issue_9.png, tab-bar.png, workeffort.PNG
>
>
> 1- create a sub-directory called bootstrap under the image webapp to put
> the resources over there (js, css and fonts) as indicated earlier by Gavin.
> (Julien : not sure about location)
> 2- check to make sure that the current version of jQuery is compatible with
> the installed version or upgrade it accordingly
> 3- Create a new theme based on one of the existing themes as suggested by
> Julien and Gavin
> 4- Test the theme by switching to it and handle major bugs / issues.
> 5- Start to make a few test screens utilizing Bootstrap



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-6881) Rainbow Stone theme improvements

Jacques Le Roux created OFBIZ-6881:
--

 Summary: Rainbow Stone theme improvements
 Key: OFBIZ-6881
 URL: https://issues.apache.org/jira/browse/OFBIZ-6881
 Project: OFBiz
  Issue Type: Improvement
  Components: themes
Affects Versions: Trunk
Reporter: Jacques Le Roux
Priority: Minor
 Fix For: Upcoming Branch


These are some points I think are worth to be reported even if they will not 
all  be taken in account.

# theme colorization to avoid theme duplication (this also applies to Bootstrap 
themes)
# Where are shown the "Last system notes"
#  remove Julien's avatar from the theme images provided.  Is
there a way for users to set their own?
#  how can contributors from countries with missing flags propose their 
countries flag? Note: for some languages nothing appears (like ES or NL).
# I like how menus are handled in Boostrap theme, could we use the same in  
Rainbow?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-5840) Create bootstrap theme


[ 
https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133024#comment-15133024
 ] 

Jacques Le Roux commented on OFBIZ-5840:


I think we need 1st to understand what happened with OFBIZ-6880. Maybe it's 
only a quirk, so if we can't reproduce and we all agree, then maybe we can 
merge. There is another (minor) thing waiting though: OFBIZ-6326, FF again :/

> Create bootstrap theme
> --
>
> Key: OFBIZ-5840
> URL: https://issues.apache.org/jira/browse/OFBIZ-5840
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework, themes
>Affects Versions: Bootstrap theme
>Reporter: Julien NICOLAS
>  Labels: bootstrap, theme
> Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, 
> GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, 
> OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, 
> appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, 
> bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, 
> calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, 
> htmlMenuMacroLibrary.patch, lookupField_patch.patch, 
> pagination_htmlFormMacroLibrary.patch, 
> panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, 
> preferences.png, styling_issue_1.png, styling_issue_2.png, 
> styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, 
> styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, 
> styling_issue_9.png, tab-bar.png, workeffort.PNG
>
>
> 1- create a sub-directory called bootstrap under the image webapp to put
> the resources over there (js, css and fonts) as indicated earlier by Gavin.
> (Julien : not sure about location)
> 2- check to make sure that the current version of jQuery is compatible with
> the installed version or upgrade it accordingly
> 3- Create a new theme based on one of the existing themes as suggested by
> Julien and Gavin
> 4- Test the theme by switching to it and handle major bugs / issues.
> 5- Start to make a few test screens utilizing Bootstrap



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6880) Boostrap Basic Theme freezed FireFox 44


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6880:
---
Summary: Boostrap Basic Theme freezed FireFox 44  (was: Boostrap Basic 
Theme frezzed FireFox 44)

> Boostrap Basic Theme freezed FireFox 44
> ---
>
> Key: OFBIZ-6880
> URL: https://issues.apache.org/jira/browse/OFBIZ-6880
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Bootstrap theme
>Reporter: Jacques Le Roux
>Priority: Blocker
> Attachments: Image 089.png, Image 090.png
>
>
> On my momentum after trying Rainbow Stone, I just tried Boostrap themes, and 
> got FF 44 freezed. I could not stop the failing script, nor stop FF, but 
> debuging it stopped the freeze. I stopped there and I will attach the 
> screenshoots which will, I hope, explain better than me what happened
> I was wondering why we did not merge this branch. This is clearly a blocker
> !Image 089.png!
> !Image 090.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6881) Rainbow Stone theme improvements


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6881:
---
Description: 
These are some points I think are worth to be reported even if they will not 
all  be taken in account.

# Theme colorization to avoid themes duplication (this also applies to 
Bootstrap themes)
# Where are shown the "Last system notes"?
# Remove Julien's avatar from the theme images provided (in the list of themes 
to choose).  
# Is there a way for users to set their own avatar?
#  how can contributors from countries with missing flags propose their 
countries flag? Note: for some languages nothing appears (like ES or NL).
# I like how menus are handled in Boostrap theme, could we use the same in  
Rainbow?

  was:
These are some points I think are worth to be reported even if they will not 
all  be taken in account.

# theme colorization to avoid theme duplication (this also applies to Bootstrap 
themes)
# Where are shown the "Last system notes"
#  remove Julien's avatar from the theme images provided.  Is
there a way for users to set their own?
#  how can contributors from countries with missing flags propose their 
countries flag? Note: for some languages nothing appears (like ES or NL).
# I like how menus are handled in Boostrap theme, could we use the same in  
Rainbow?


> Rainbow Stone theme improvements
> 
>
> Key: OFBIZ-6881
> URL: https://issues.apache.org/jira/browse/OFBIZ-6881
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> These are some points I think are worth to be reported even if they will not 
> all  be taken in account.
> # Theme colorization to avoid themes duplication (this also applies to 
> Bootstrap themes)
> # Where are shown the "Last system notes"?
> # Remove Julien's avatar from the theme images provided (in the list of 
> themes to choose).  
> # Is there a way for users to set their own avatar?
> #  how can contributors from countries with missing flags propose their 
> countries flag? Note: for some languages nothing appears (like ES or NL).
> # I like how menus are handled in Boostrap theme, could we use the same in  
> Rainbow?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6881) Rainbow Stone theme improvements


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julien NICOLAS updated OFBIZ-6881:
--
Description: 
These are some points I think are worth to be reported even if they will not 
all  be taken in account.

# Theme colorization to avoid themes duplication (this also applies to 
Bootstrap themes)
# Where are shown the "Last system notes"?
-# Remove Julien's avatar from the theme images provided (in the list of themes 
to choose).-
# Is there a way for users to set their own avatar?
#  how can contributors from countries with missing flags propose their 
countries flag? Note: for some languages nothing appears (like ES or NL).
# I like how menus are handled in Boostrap theme, could we use the same in  
Rainbow?

  was:
These are some points I think are worth to be reported even if they will not 
all  be taken in account.

# Theme colorization to avoid themes duplication (this also applies to 
Bootstrap themes)
# Where are shown the "Last system notes"?
--# Remove Julien's avatar from the theme images provided (in the list of 
themes to choose).  
# Is there a way for users to set their own avatar?
#  how can contributors from countries with missing flags propose their 
countries flag? Note: for some languages nothing appears (like ES or NL).
# I like how menus are handled in Boostrap theme, could we use the same in  
Rainbow?


> Rainbow Stone theme improvements
> 
>
> Key: OFBIZ-6881
> URL: https://issues.apache.org/jira/browse/OFBIZ-6881
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> These are some points I think are worth to be reported even if they will not 
> all  be taken in account.
> # Theme colorization to avoid themes duplication (this also applies to 
> Bootstrap themes)
> # Where are shown the "Last system notes"?
> -# Remove Julien's avatar from the theme images provided (in the list of 
> themes to choose).-
> # Is there a way for users to set their own avatar?
> #  how can contributors from countries with missing flags propose their 
> countries flag? Note: for some languages nothing appears (like ES or NL).
> # I like how menus are handled in Boostrap theme, could we use the same in  
> Rainbow?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6881) Rainbow Stone theme improvements


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julien NICOLAS updated OFBIZ-6881:
--
Description: 
These are some points I think are worth to be reported even if they will not 
all  be taken in account.

# Theme colorization to avoid themes duplication (this also applies to 
Bootstrap themes)
# Where are shown the "Last system notes"?
# -Remove Julien's avatar from the theme images provided (in the list of themes 
to choose).-
# Is there a way for users to set their own avatar?
#  how can contributors from countries with missing flags propose their 
countries flag? Note: for some languages nothing appears (like ES or NL).
# I like how menus are handled in Boostrap theme, could we use the same in  
Rainbow?

  was:
These are some points I think are worth to be reported even if they will not 
all  be taken in account.

# Theme colorization to avoid themes duplication (this also applies to 
Bootstrap themes)
# Where are shown the "Last system notes"?
-# Remove Julien's avatar from the theme images provided (in the list of themes 
to choose).-
# Is there a way for users to set their own avatar?
#  how can contributors from countries with missing flags propose their 
countries flag? Note: for some languages nothing appears (like ES or NL).
# I like how menus are handled in Boostrap theme, could we use the same in  
Rainbow?


> Rainbow Stone theme improvements
> 
>
> Key: OFBIZ-6881
> URL: https://issues.apache.org/jira/browse/OFBIZ-6881
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> These are some points I think are worth to be reported even if they will not 
> all  be taken in account.
> # Theme colorization to avoid themes duplication (this also applies to 
> Bootstrap themes)
> # Where are shown the "Last system notes"?
> # -Remove Julien's avatar from the theme images provided (in the list of 
> themes to choose).-
> # Is there a way for users to set their own avatar?
> #  how can contributors from countries with missing flags propose their 
> countries flag? Note: for some languages nothing appears (like ES or NL).
> # I like how menus are handled in Boostrap theme, could we use the same in  
> Rainbow?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-5840) Create bootstrap theme


[ 
https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133028#comment-15133028
 ] 

Jacques Le Roux commented on OFBIZ-5840:


Ha, just got this one too on Chrome while looking for theme change
{code}
Error rendering included template at location 
[component://bootstrap/includes/lookup.ftl]: java.io.FileNotFoundException: 
C:\projectsASF\boostrap_theme\themes\bootstrap\includes\lookup.ftl (Le fichier 
spécifié est introuvable)
{code}

> Create bootstrap theme
> --
>
> Key: OFBIZ-5840
> URL: https://issues.apache.org/jira/browse/OFBIZ-5840
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework, themes
>Affects Versions: Bootstrap theme
>Reporter: Julien NICOLAS
>  Labels: bootstrap, theme
> Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, 
> GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, 
> OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, 
> appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, 
> bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, 
> calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, 
> htmlMenuMacroLibrary.patch, lookupField_patch.patch, 
> pagination_htmlFormMacroLibrary.patch, 
> panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, 
> preferences.png, styling_issue_1.png, styling_issue_2.png, 
> styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, 
> styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, 
> styling_issue_9.png, tab-bar.png, workeffort.PNG
>
>
> 1- create a sub-directory called bootstrap under the image webapp to put
> the resources over there (js, css and fonts) as indicated earlier by Gavin.
> (Julien : not sure about location)
> 2- check to make sure that the current version of jQuery is compatible with
> the installed version or upgrade it accordingly
> 3- Create a new theme based on one of the existing themes as suggested by
> Julien and Gavin
> 4- Test the theme by switching to it and handle major bugs / issues.
> 5- Start to make a few test screens utilizing Bootstrap



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6881) Rainbow Stone theme improvements


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julien NICOLAS updated OFBIZ-6881:
--
Description: 
These are some points I think are worth to be reported even if they will not 
all  be taken in account.

# Theme colorization to avoid themes duplication (this also applies to 
Bootstrap themes)
# Where are shown the "Last system notes"?
--# Remove Julien's avatar from the theme images provided (in the list of 
themes to choose).  
# Is there a way for users to set their own avatar?
#  how can contributors from countries with missing flags propose their 
countries flag? Note: for some languages nothing appears (like ES or NL).
# I like how menus are handled in Boostrap theme, could we use the same in  
Rainbow?

  was:
These are some points I think are worth to be reported even if they will not 
all  be taken in account.

# Theme colorization to avoid themes duplication (this also applies to 
Bootstrap themes)
# Where are shown the "Last system notes"?
# Remove Julien's avatar from the theme images provided (in the list of themes 
to choose).  
# Is there a way for users to set their own avatar?
#  how can contributors from countries with missing flags propose their 
countries flag? Note: for some languages nothing appears (like ES or NL).
# I like how menus are handled in Boostrap theme, could we use the same in  
Rainbow?


> Rainbow Stone theme improvements
> 
>
> Key: OFBIZ-6881
> URL: https://issues.apache.org/jira/browse/OFBIZ-6881
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> These are some points I think are worth to be reported even if they will not 
> all  be taken in account.
> # Theme colorization to avoid themes duplication (this also applies to 
> Bootstrap themes)
> # Where are shown the "Last system notes"?
> --# Remove Julien's avatar from the theme images provided (in the list of 
> themes to choose).  
> # Is there a way for users to set their own avatar?
> #  how can contributors from countries with missing flags propose their 
> countries flag? Note: for some languages nothing appears (like ES or NL).
> # I like how menus are handled in Boostrap theme, could we use the same in  
> Rainbow?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6881) Rainbow Stone theme improvements


[ 
https://issues.apache.org/jira/browse/OFBIZ-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133185#comment-15133185
 ] 

Jacques Le Roux commented on OFBIZ-6881:


It's fun to be an user, thanks Julien :)

> Rainbow Stone theme improvements
> 
>
> Key: OFBIZ-6881
> URL: https://issues.apache.org/jira/browse/OFBIZ-6881
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> These are some points I think are worth to be reported even if they will not 
> all  be taken in account.
> # Theme colorization to avoid themes duplication (this also applies to 
> Bootstrap themes)
> # Where are shown the "Last system notes"?
> # Remove Julien's avatar from the theme images provided (in the list of 
> themes to choose).  
> # Is there a way for users to set their own avatar?
> #  how can contributors from countries with missing flags propose their 
> countries flag? Note: for some languages nothing appears (like ES or NL).
> # I like how menus are handled in Boostrap theme, could we use the same in  
> Rainbow?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6880) Boostrap Basic Theme frezzed FireFox 44


[ 
https://issues.apache.org/jira/browse/OFBIZ-6880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133021#comment-15133021
 ] 

Jacques Le Roux commented on OFBIZ-6880:


This was in the order view page

> Boostrap Basic Theme frezzed FireFox 44
> ---
>
> Key: OFBIZ-6880
> URL: https://issues.apache.org/jira/browse/OFBIZ-6880
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Bootstrap theme
>Reporter: Jacques Le Roux
>Priority: Blocker
> Attachments: Image 089.png, Image 090.png
>
>
> On my momentum after trying Rainbow Stone, I just tried Boostrap themes, and 
> got FF 44 freezed. I could not stop the failing script, nor stop FF, but 
> debuging it stopped the freeze. I stopped there and I will attach the 
> screenshoots which will, I hope, explain better than me what happened
> I was wondering why we did not merge this branch. This is clearly a blocker
> !Image 089.png!
> !Image 090.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-5840) Create bootstrap theme


[ 
https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133031#comment-15133031
 ] 

Jacques Le Roux commented on OFBIZ-5840:


Sincerely this theme is cool!

> Create bootstrap theme
> --
>
> Key: OFBIZ-5840
> URL: https://issues.apache.org/jira/browse/OFBIZ-5840
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework, themes
>Affects Versions: Bootstrap theme
>Reporter: Julien NICOLAS
>  Labels: bootstrap, theme
> Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, 
> GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, 
> OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, 
> appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, 
> bootstrap-theme.zip, bootstrap.zip, bootstrapThemeToTrunk.patch, 
> calendar.PNG, catalog.png, glyphicons-halflings-regular.zip, 
> htmlMenuMacroLibrary.patch, lookupField_patch.patch, 
> pagination_htmlFormMacroLibrary.patch, 
> panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, 
> preferences.png, styling_issue_1.png, styling_issue_2.png, 
> styling_issue_3.png, styling_issue_4.png, styling_issue_5.png, 
> styling_issue_6.png, styling_issue_7.png, styling_issue_8.png, 
> styling_issue_9.png, tab-bar.png, workeffort.PNG
>
>
> 1- create a sub-directory called bootstrap under the image webapp to put
> the resources over there (js, css and fonts) as indicated earlier by Gavin.
> (Julien : not sure about location)
> 2- check to make sure that the current version of jQuery is compatible with
> the installed version or upgrade it accordingly
> 3- Create a new theme based on one of the existing themes as suggested by
> Julien and Gavin
> 4- Test the theme by switching to it and handle major bugs / issues.
> 5- Start to make a few test screens utilizing Bootstrap



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6881) Rainbow Stone theme improvements


[ 
https://issues.apache.org/jira/browse/OFBIZ-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133175#comment-15133175
 ] 

Julien NICOLAS commented on OFBIZ-6881:
---

1 - You can see that the theme duplication is only on data. The really 
difference is the .less file.
And in the less file, it's only colour variable that change.
But yes, I want to imagine a theme setting to let user change color.
2 - I remove it, but I'll add it soon :)
3 - Hummm, it's embarrassing... Yes, I'll do it
4 - Yes, just add your personal avatar in party content define as "logo image 
url". A square image is better, I'am using 180x180px
5 - Because flag is define like EN-gb or FR-fr. Try NL-be or ES-ar for example. 
I can define specific default flag but don't know all default language in all 
countries.
6 - For that and more other options, it could be interesting to have a theme 
tweak tools screen with preference. Then we may change menu style, colours and 
more.

> Rainbow Stone theme improvements
> 
>
> Key: OFBIZ-6881
> URL: https://issues.apache.org/jira/browse/OFBIZ-6881
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> These are some points I think are worth to be reported even if they will not 
> all  be taken in account.
> # Theme colorization to avoid themes duplication (this also applies to 
> Bootstrap themes)
> # Where are shown the "Last system notes"?
> # Remove Julien's avatar from the theme images provided (in the list of 
> themes to choose).  
> # Is there a way for users to set their own avatar?
> #  how can contributors from countries with missing flags propose their 
> countries flag? Note: for some languages nothing appears (like ES or NL).
> # I like how menus are handled in Boostrap theme, could we use the same in  
> Rainbow?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, so other companent can change it too.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6802:
---
Summary: be able to set accounting company in the header, so other 
companent can change it too.  (was: be able to set accounting company in the 
header, remove from accounting, so other companent can change it too.)

> be able to set accounting company in the header, so other companent can 
> change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other companent can change it too.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6802:
---
Summary: be able to set accounting company in the header, remove from 
accounting, so other companent can change it too.  (was: be able to set 
accounting company in the header, so other components can change it too.)

> be able to set accounting company in the header, remove from accounting, so 
> other companent can change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-6802) be able to set accounting company in the header, so other companent can change it too.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker closed OFBIZ-6802.
--
Resolution: Fixed

Committed revision 1728584. Thank you Parinya Wongjina for the patch.

> be able to set accounting company in the header, so other companent can 
> change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, so other components can change it too.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6802:
---
Summary: be able to set accounting company in the header, so other 
components can change it too.  (was: be able to set accounting company in the 
header, remove from accounting, so other components can change it too.)

> be able to set accounting company in the header, so other components can 
> change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6802:
---
Attachment: (was: OFBIZ-6802.patch)

> be able to set accounting company in the header, remove from accounting, so 
> other components can change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Framework Cleanup Options - Tidy Up & Refactor?

2016-02-04 Thread Ron Wheeler

I think JIRAs are essential if you expect others to help out.

I don't think that it would be a bad thing to create the JIRA after you
fix something and attach a patch to the JIRA showing all the little
changes that you made as part of the JIRA rather than writing a
description that is longer than the code being fixed.

Ron

On 04/02/2016 1:19 AM, Taher Alkhateeb wrote:

Hi Sharan and Everyone,

When we lost Adrian in the beginning of the rewrite project I really felt
lost. His feedback made things simple and I miss having him around for
mentoring and feedback. I think deferring the rewrite project is a good
idea for now.

I shifted my energy into just playing with the code and dabbling here and
there and I got surprised by the many problems that exist pretty much
everywhere. This would be things like:

- Extending classes from external libraries into the core APIs
- Writing to implementations instead of interfaces
- Files too long
- Different levels of abstractions mixed together
- Poor test coverage, lack of TDD
- Implicit (hidden) dependencies (I dislike this the most)

I think the above issues indicate that we really do need less energy on new
features, and much more on refactoring. We should refactor everything
including core API interfaces. Some examples of work we can do:

- EntitySaxReader implements javolution interfaces and looks hideous
- HtmlFormRenderer is 3000 lines of code and the interfaces it implements
are also huge
- XmlFormRenderer does not implement more than half of the methods
- Lots of dependencies on deprecated classes / constructors (e.g.
HtmlScreenRenderer, FoScreenRenderer)
- Start.java has some problems which I'm trying to tackle in JIRA:
OFBIZ-6783
- Lots of non-parameterized and non type checked declarations.
- Implementations with no interfaces (e.g. TemporalExpression, GroupModel,
Cache, etc ...)

The list goes on and on. Every one of the SOLID principles for Bob Martin
is violated in many places and most of the code smells in his book also
exist.

I started a thread a while back suggesting that I would like to start
refactoring without too many JIRAs because it would slow us down. However,
the feedback from the community I got is that JIRA creation is preferred.
This, however, would slow down progress especially if I'm just making minor
one-line changes. We need an efficient way to make continuous daily
improvements to the code base.

Also, we need to document our design philosophy for others to consider when
writing code. I don't mean just formatting conventions but also things like
writing to interfaces, TDD, design rules specific to OFBiz, and so on.

To summarize:
- We have a LOT of refactoring work, it's everywhere
- We need a more efficient workflow for continuous daily refactoring, the
current workflow is too bureaucratic
- We need help from everyone
- We need to expand the coding guidelines to introduce some design
concepts, not just formatting.

Those are my very long 2 cents.

Taher Alkhateeb

On Wed, Feb 3, 2016 at 8:19 PM, Sharan-F wrote:

Hi Everyone

A few months ago we started looking at a proposed framework re-write sub
project with Adrian as our mentor.

https://cwiki.apache.org/confluence/display/OFBIZ/Potential+Framework+Project+for+the+Foundation+Sub+Component

With Adrian gone it makes it hard for us to continue so have decided to
abandon this effort.

We don't want to give up on having a better framework and know that another
option is to tidy up our existing framework. (So yes – this means
refactoring, and yes it will be a lot of work)

In general we do sometimes tidy up or refactor as we go along and some work
has already started with movement of entity definitions into a separate
datamodel component. If we really do want to tidy up our framework then we
will need as many people from the community as possible to help out.

Now here comes the big question – is the community interested in really
doing this and are there people out there willing to help out?

Thanks
Sharan

--
View this message in context:
http://ofbiz.135035.n4.nabble.com/Framework-Cleanup-Options-Tidy-Up-Refactor-tp4676797.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102

Re: Framework Cleanup Options - Tidy Up & Refactor?

Inline... only when I feel needed...

Le 04/02/2016 09:45, Nicolas Malin a écrit :

Le 04/02/2016 07:19, Taher Alkhateeb a écrit :

Hi Sharan and Everyone,

[...]

One jira per purpose don't wast some time for us and help to follow all commit

To summarize:
- We have a LOT of refactoring work, it's everywhere

Open a master issue with macro sub-task, linked to wiki for each conception
detail

+1
One thing you can also do is opening a single Jira and put trivial things in comments. Beware though that when problems arise (expect them) it's then
difficult to follow things.

Fortunately the "recent" introduction of the "reply feature" by comment allows
more of this but should not be abused.
One thing you need to avoid as much as possible is commits bursts. I remember being unable to follow the flow (review) when Adam did that, even when
splitting commits done in his git repo.

- We need a more efficient workflow for continuous daily refactoring, the
current workflow is too bureaucratic

it's not a pb, we will not close a jira at each commit but only when the
improvement is completed after 10 - 20 or more commit

- We need help from everyone
Nereide's commiter are available ! :) (enfin je crois Gil, Julien ?) we just need some code orientation to realize because we aren't high technical
developer.

- We need to expand the coding guidelines to introduce some design
concepts, not just formatting.

Adrian started with the thread safe design, feel free to load your mind on the
wiki :)

Do you mean this
https://cwiki.apache.org/confluence/display/OFBIZ/A+New+Application+Framework+Design
Nicolas?

Jacques

Nicolas

Those are my very long 2 cents.

Taher Alkhateeb

On Wed, Feb 3, 2016 at 8:19 PM, Sharan-F wrote:

Hi Everyone

A few months ago we started looking at a proposed framework re-write sub
project with Adrian as our mentor.

https://cwiki.apache.org/confluence/display/OFBIZ/Potential+Framework+Project+for+the+Foundation+Sub+Component

With Adrian gone it makes it hard for us to continue so have decided to
abandon this effort.

We don't want to give up on having a better framework and know that another
option is to tidy up our existing framework. (So yes – this means
refactoring, and yes it will be a lot of work)

Now here comes the big question – is the community interested in really
doing this and are there people out there willing to help out?

Thanks
Sharan

--
View this message in context:
http://ofbiz.135035.n4.nabble.com/Framework-Cleanup-Options-Tidy-Up-Refactor-tp4676797.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Release 14.12.01 and Dedication for Adrian

2016-02-04 Thread Sharan-F

Hi Everyone

Looking at our tentative release schedule we have said that this month we
would look at releasing 14.12.01. It has been maturing for over a year so
are we ready to begin preparing for its release this month ?

Also we talked about dedicating a release to Adrian so I think we could use
this one (or even the whole 14.12 series..). We could add a special
dedication on the Downloads page as part of the release description.

What do people think ?


Thanks
Sharan





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Release-14-12-01-and-Dedication-for-Adrian-tp4676835.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Re: Framework Cleanup Options - Tidy Up & Refactor?

2016-02-04 Thread gil portenseigne

I'm ready to help on these matters ! Nicolas guess it right !

Gil

On 04/02/2016 09:45, Nicolas Malin wrote:

Le 04/02/2016 07:19, Taher Alkhateeb a écrit :

Hi Sharan and Everyone,

When we lost Adrian in the beginning of the rewrite project I really
felt

lost. His feedback made things simple and I miss having him around for
mentoring and feedback. I think deferring the rewrite project is a good
idea for now.

I agree and in line

I shifted my energy into just playing with the code and dabbling here
and

there and I got surprised by the many problems that exist pretty much
everywhere. This would be things like:

I think the above issues indicate that we really do need less energy
on new

features, and much more on refactoring. We should refactor everything
including core API interfaces. Some examples of work we can do:

- EntitySaxReader implements javolution interfaces and looks hideous
- HtmlFormRenderer is 3000 lines of code and the interfaces it
implements

are also huge
- XmlFormRenderer does not implement more than half of the methods
- Lots of dependencies on deprecated classes / constructors (e.g.
HtmlScreenRenderer, FoScreenRenderer)
- Start.java has some problems which I'm trying to tackle in JIRA:
OFBIZ-6783
- Lots of non-parameterized and non type checked declarations.
- Implementations with no interfaces (e.g. TemporalExpression,
GroupModel,

Cache, etc ...)
Yes I started some improvement and we need to continue. Step by step,
slim, clean, increase solidity (a nice speech)

The list goes on and on. Every one of the SOLID principles for Bob
Martin

is violated in many places and most of the code smells in his book also
exist.

one-line changes. We need an efficient way to make continuous daily
improvements to the code base.
One jira per purpose don't wast some time for us and help to follow
all commit

Also, we need to document our design philosophy for others to
consider when
writing code. I don't mean just formatting conventions but also
things like

writing to interfaces, TDD, design rules specific to OFBiz, and so on.

To summarize:
- We have a LOT of refactoring work, it's everywhere
Open a master issue with macro sub-task, linked to wiki for each
conception detail
- We need a more efficient workflow for continuous daily refactoring,
the

current workflow is too bureaucratic
it's not a pb, we will not close a jira at each commit but only when
the improvement is completed after 10 - 20 or more commit

- We need help from everyone
Nereide's commiter are available ! :) (enfin je crois Gil, Julien ?)
we just need some code orientation to realize because we aren't high
technical developer.

- We need to expand the coding guidelines to introduce some design
concepts, not just formatting.
Adrian started with the thread safe design, feel free to load your
mind on the wiki :)

Nicolas

Those are my very long 2 cents.

Taher Alkhateeb

On Wed, Feb 3, 2016 at 8:19 PM, Sharan-F wrote:

Hi Everyone

A few months ago we started looking at a proposed framework re-write
sub

project with Adrian as our mentor.

https://cwiki.apache.org/confluence/display/OFBIZ/Potential+Framework+Project+for+the+Foundation+Sub+Component

With Adrian gone it makes it hard for us to continue so have decided to
abandon this effort.

We don't want to give up on having a better framework and know that
another

option is to tidy up our existing framework. (So yes – this means
refactoring, and yes it will be a lot of work)

In general we do sometimes tidy up or refactor as we go along and
some work

has already started with movement of entity definitions into a separate
datamodel component. If we really do want to tidy up our framework
then we

will need as many people from the community as possible to help out.

Now here comes the big question – is the community interested in really
doing this and are there people out there willing to help out?

Thanks
Sharan

--
View this message in context:
http://ofbiz.135035.n4.nabble.com/Framework-Cleanup-Options-Tidy-Up-Refactor-tp4676797.html

Sent from the OFBiz - Dev mailing list archive at Nabble.com.

[jira] [Commented] (OFBIZ-6843) New theme Rainbow Stone


[ 
https://issues.apache.org/jira/browse/OFBIZ-6843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132008#comment-15132008
 ] 

Jacques Le Roux commented on OFBIZ-6843:


Sorry but that what after a "svn up && ant clean-all load-demo start"

> New theme Rainbow Stone
> ---
>
> Key: OFBIZ-6843
> URL: https://issues.apache.org/jira/browse/OFBIZ-6843
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Minor
>  Labels: features, theme
> Fix For: Trunk
>
> Attachments: patch3rainbowstone.patch, rainbowstone.tar.gz, 
> screenshot-1.png
>
>
> I create a new theme based on Flat Grey.
> It's the beginning but already functional, my goal is to provide a new style 
> for OFBiz.
> This is my tastes, so don't hesitate to criticize :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6843) New theme Rainbow Stone


[ 
https://issues.apache.org/jira/browse/OFBIZ-6843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132009#comment-15132009
 ] 

Jacques Le Roux commented on OFBIZ-6843:


OK let me try with another (totally clean) instance...

> New theme Rainbow Stone
> ---
>
> Key: OFBIZ-6843
> URL: https://issues.apache.org/jira/browse/OFBIZ-6843
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Minor
>  Labels: features, theme
> Fix For: Trunk
>
> Attachments: patch3rainbowstone.patch, rainbowstone.tar.gz, 
> screenshot-1.png
>
>
> I create a new theme based on Flat Grey.
> It's the beginning but already functional, my goal is to provide a new style 
> for OFBiz.
> This is my tastes, so don't hesitate to criticize :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6843) New theme Rainbow Stone


[ 
https://issues.apache.org/jira/browse/OFBIZ-6843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132012#comment-15132012
 ] 

Julien NICOLAS commented on OFBIZ-6843:
---

Yes, could be better.
I try on clean one again but it works fine :)

> New theme Rainbow Stone
> ---
>
> Key: OFBIZ-6843
> URL: https://issues.apache.org/jira/browse/OFBIZ-6843
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Minor
>  Labels: features, theme
> Fix For: Trunk
>
> Attachments: patch3rainbowstone.patch, rainbowstone.tar.gz, 
> screenshot-1.png
>
>
> I create a new theme based on Flat Grey.
> It's the beginning but already functional, my goal is to provide a new style 
> for OFBiz.
> This is my tastes, so don't hesitate to criticize :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Framework Cleanup Options - Tidy Up & Refactor?

2016-02-04 Thread Sharan-F

Hi All

Thanks for the feedback so far. It sounds like we need to have a clear
vision of what needs to be done and also organise things so it's easy for
people to know what they can work on.  I'll see if I can summarise the main
points onto a wiki page.

Thanks
Sharan





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Framework-Cleanup-Options-Tidy-Up-Refactor-tp4676797p4676841.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

[jira] [Created] (OFBIZ-6880) Boostrap Basic Theme frezzed FireFox 44

Jacques Le Roux created OFBIZ-6880:
--

 Summary: Boostrap Basic Theme frezzed FireFox 44
 Key: OFBIZ-6880
 URL: https://issues.apache.org/jira/browse/OFBIZ-6880
 Project: OFBiz
  Issue Type: Sub-task
  Components: themes
Affects Versions: Bootstrap theme
Reporter: Jacques Le Roux
Priority: Blocker
 Attachments: Image 089.png, Image 090.png

On my momentum after trying Rainbow Stone, I just tried Boostrap themes, and 
got FF 44 freezed. I could not stop the failing script, nor stop FF, but 
debuging it stopped the freeze. I stopped there and I will attach the 
screenshoots which will, I hope, explain better than me what happened

I was wondering why we did not merge this branch. This is clearly a blocker



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6880) Boostrap Basic Theme frezzed FireFox 44


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6880:
---
Description: 
On my momentum after trying Rainbow Stone, I just tried Boostrap themes, and 
got FF 44 freezed. I could not stop the failing script, nor stop FF, but 
debuging it stopped the freeze. I stopped there and I will attach the 
screenshoots which will, I hope, explain better than me what happened

I was wondering why we did not merge this branch. This is clearly a blocker

!

  was:
On my momentum after trying Rainbow Stone, I just tried Boostrap themes, and 
got FF 44 freezed. I could not stop the failing script, nor stop FF, but 
debuging it stopped the freeze. I stopped there and I will attach the 
screenshoots which will, I hope, explain better than me what happened

I was wondering why we did not merge this branch. This is clearly a blocker


> Boostrap Basic Theme frezzed FireFox 44
> ---
>
> Key: OFBIZ-6880
> URL: https://issues.apache.org/jira/browse/OFBIZ-6880
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Bootstrap theme
>Reporter: Jacques Le Roux
>Priority: Blocker
> Attachments: Image 089.png, Image 090.png
>
>
> On my momentum after trying Rainbow Stone, I just tried Boostrap themes, and 
> got FF 44 freezed. I could not stop the failing script, nor stop FF, but 
> debuging it stopped the freeze. I stopped there and I will attach the 
> screenshoots which will, I hope, explain better than me what happened
> I was wondering why we did not merge this branch. This is clearly a blocker
> !



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6880) Boostrap Basic Theme frezzed FireFox 44


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6880:
---
Attachment: Image 090.png
Image 089.png

> Boostrap Basic Theme frezzed FireFox 44
> ---
>
> Key: OFBIZ-6880
> URL: https://issues.apache.org/jira/browse/OFBIZ-6880
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Bootstrap theme
>Reporter: Jacques Le Roux
>Priority: Blocker
> Attachments: Image 089.png, Image 090.png
>
>
> On my momentum after trying Rainbow Stone, I just tried Boostrap themes, and 
> got FF 44 freezed. I could not stop the failing script, nor stop FF, but 
> debuging it stopped the freeze. I stopped there and I will attach the 
> screenshoots which will, I hope, explain better than me what happened
> I was wondering why we did not merge this branch. This is clearly a blocker



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6880) Boostrap Basic Theme frezzed FireFox 44


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6880:
---
Description: 
On my momentum after trying Rainbow Stone, I just tried Boostrap themes, and 
got FF 44 freezed. I could not stop the failing script, nor stop FF, but 
debuging it stopped the freeze. I stopped there and I will attach the 
screenshoots which will, I hope, explain better than me what happened

I was wondering why we did not merge this branch. This is clearly a blocker

!Image 089.png!

!Image 090.png!

  was:
On my momentum after trying Rainbow Stone, I just tried Boostrap themes, and 
got FF 44 freezed. I could not stop the failing script, nor stop FF, but 
debuging it stopped the freeze. I stopped there and I will attach the 
screenshoots which will, I hope, explain better than me what happened

I was wondering why we did not merge this branch. This is clearly a blocker

!


> Boostrap Basic Theme frezzed FireFox 44
> ---
>
> Key: OFBIZ-6880
> URL: https://issues.apache.org/jira/browse/OFBIZ-6880
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Bootstrap theme
>Reporter: Jacques Le Roux
>Priority: Blocker
> Attachments: Image 089.png, Image 090.png
>
>
> On my momentum after trying Rainbow Stone, I just tried Boostrap themes, and 
> got FF 44 freezed. I could not stop the failing script, nor stop FF, but 
> debuging it stopped the freeze. I stopped there and I will attach the 
> screenshoots which will, I hope, explain better than me what happened
> I was wondering why we did not merge this branch. This is clearly a blocker
> !Image 089.png!
> !Image 090.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6875) Update various accounting labels regarding the dutch locale

2016-02-04 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131904#comment-15131904
 ] 

Pierre Smits commented on OFBIZ-6875:
-

My guidelines for correct dutch come from the following:
* De Taalunie (the Dutch Language Union), see http://taalunie.org
* De Taalunie - woordenlijst, see http://woordenlijst.org/ for correct spelling
* NedTerm - terminology referencees, see 
http://taalunieversum.org/sectie/nedterm

These are just starting points.

> Update various accounting labels regarding the dutch locale
> ---
>
> Key: OFBIZ-6875
> URL: https://issues.apache.org/jira/browse/OFBIZ-6875
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Hans Bakker
>  Labels: Nederlands
> Fix For: Trunk
>
> Attachments: OFBIZ-6875-AccountingLabels-v2.patch, 
> OFBIZ-6875-AccountingLabels.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6843) New theme Rainbow Stone


[ 
https://issues.apache.org/jira/browse/OFBIZ-6843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131971#comment-15131971
 ] 

Julien NICOLAS commented on OFBIZ-6843:
---

I think I catch it!

your error is linked to :
INSERT on table 'VISUAL_THEME_RESOURCE' caused a violation of foreign key 
constraint 'VT_RES_TYPE_ENUM' for key (VT_CHPWD_TMPLT_LOC

where 'VT_CHPWD_TMPLT_LOC' is a new feature contained in the r1728026 (see 
previous comment : "The patch is compatible with the release 1728026.")

I think that you try the compressed folder in a previous trunk release.

I commited the theme last night so just try an svn up, ant load-seed and it 
must work.

friendly,

Julien.

> New theme Rainbow Stone
> ---
>
> Key: OFBIZ-6843
> URL: https://issues.apache.org/jira/browse/OFBIZ-6843
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Minor
>  Labels: features, theme
> Fix For: Trunk
>
> Attachments: patch3rainbowstone.patch, rainbowstone.tar.gz, 
> screenshot-1.png
>
>
> I create a new theme based on Flat Grey.
> It's the beginning but already functional, my goal is to provide a new style 
> for OFBiz.
> This is my tastes, so don't hesitate to criticize :)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6843) New theme Rainbow Stone