[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[ https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347752#comment-15347752 ] Swapnil M Mane commented on OFBIZ-7061: --- Dear [~jacques.le.roux], Preferences screen under in 'My Portal' component is broken (https://localhost:8443/myportal/control/ManagePortalPages?parentPortalPageId=MYPORTAL_EMPLOYEE), it is because of missing {code} xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; {code} in framework/common/widget/PortalPageForms.xml Might be it is missed under the commit at rev #1749634 :) http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/PortalPageForms.xml?limit_changes=0=1749634=1749633=1749634 Thanks! > Autocompletion for Compound Widget > -- > > Key: OFBIZ-7061 > URL: https://issues.apache.org/jira/browse/OFBIZ-7061 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: james yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch > > > I am trying to enable auto-completion when coding compound widget. > My plan as follows: > 1. The following xsd will be modified to use namespace > site-conf.xsd > widget-form.xsd > widget-screen.xsd > widget-menu.xsd > simple-methods.xsd > For example, in site-conf.xsd, we add the following document level attribute > {code} > xmlns="http://ofbiz.apache.org/sc; > targetNamespace="http://ofbiz.apache.org/sc; > {code} > 2. Import the above schema into compound-widgets.xsd so that compound widgets > use only one consolidated schema. > 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For > example > {code} > http://www.w3.org/2001/XMLSchema-instance; > xmlns:sc="http://ofbiz.apache.org/sc; > xmlns:m="http://ofbiz.apache.org/m; > xmlns:s="http://ofbiz.apache.org/s; > xmlns:f="http://ofbiz.apache.org/f; > xmlns:sm="http://ofbiz.apache.org/sm; > > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;> > > > > path="component://example/widget/example/ExampleCompoundWidgets.xml"/> > > > auth="true"/> value="CompoundWidgets2"/> > > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/> > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/> > > .. the rest > {code} > 4. Change java code to support reading xml with namespace (i.e. xml for > compound widgets) > 5. Update the attributes at document level for rest of the controllers, > menus, forms, simple methods and screens. Current setting will not work for > schema with a namespace. For example, in controller.xml, we will change > {code} > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd” > {code} > to > {code} > xmlns="http://ofbiz.apache.org/sc” > xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”> > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7208) Refactor XML shared dependencies between accounting and HR
[ https://issues.apache.org/jira/browse/OFBIZ-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chandan Khandelwal updated OFBIZ-7208: -- Description: Many shared dependencies exist bi-directionally between accounting and HR including screens, entities and other items. All such XML should propagate down to the commonext component. List of dependencies of HR on Accounting : # UI Label # Lookup # Screens # Requests # Forms was: Many shared dependencies exist bi-directionally between accounting and HR including screens, entities and other items. All such XML should propagate down to the commonext component. List of > Refactor XML shared dependencies between accounting and HR > -- > > Key: OFBIZ-7208 > URL: https://issues.apache.org/jira/browse/OFBIZ-7208 > Project: OFBiz > Issue Type: Improvement > Components: accounting, commonext/setup, humanres >Reporter: Pranay Pandey >Assignee: Pranay Pandey > > Many shared dependencies exist bi-directionally between accounting and HR > including screens, entities and other items. All such XML should propagate > down to the commonext component. > List of dependencies of HR on Accounting : > # UI Label > # Lookup > # Screens > # Requests > # Forms -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7208) Refactor XML shared dependencies between accounting and HR
[ https://issues.apache.org/jira/browse/OFBIZ-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chandan Khandelwal updated OFBIZ-7208: -- Description: Many shared dependencies exist bi-directionally between accounting and HR including screens, entities and other items. All such XML should propagate down to the commonext component. List of was:Many shared dependencies exist bi-directionally between accounting and HR including screens, entities and other items. All such XML should propagate down to the commonext component. > Refactor XML shared dependencies between accounting and HR > -- > > Key: OFBIZ-7208 > URL: https://issues.apache.org/jira/browse/OFBIZ-7208 > Project: OFBiz > Issue Type: Improvement > Components: accounting, commonext/setup, humanres >Reporter: Pranay Pandey >Assignee: Pranay Pandey > > Many shared dependencies exist bi-directionally between accounting and HR > including screens, entities and other items. All such XML should propagate > down to the commonext component. > List of -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7586) Error in Create Billing Account From HR
[ https://issues.apache.org/jira/browse/OFBIZ-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347735#comment-15347735 ] Chandan Khandelwal commented on OFBIZ-7586: --- Thanks Pranay for the feedback, makes sense to me. I am looking on other dependencies which we need to figure out and list the same on OFBIZ-7208. > Error in Create Billing Account From HR > --- > > Key: OFBIZ-7586 > URL: https://issues.apache.org/jira/browse/OFBIZ-7586 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Chandan Khandelwal >Assignee: Pranay Pandey > > # Go To HR > # Select Comapny > # Create Billing Account > # Save > URL : > https://ofbiz-vm.apache.org:8443/humanres/control/EditBillingAccount?partyId=MARKETING > getting error "org.ofbiz.webapp.control.RequestHandlerException: Unknown > request [createBillingAccountAndRole]; this request does not exist or cannot > be called directly." -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7586) Error in Create Billing Account From HR
[ https://issues.apache.org/jira/browse/OFBIZ-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey updated OFBIZ-7586: - Issue Type: Sub-task (was: Bug) Parent: OFBIZ-7208 > Error in Create Billing Account From HR > --- > > Key: OFBIZ-7586 > URL: https://issues.apache.org/jira/browse/OFBIZ-7586 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Chandan Khandelwal >Assignee: Pranay Pandey > > # Go To HR > # Select Comapny > # Create Billing Account > # Save > URL : > https://ofbiz-vm.apache.org:8443/humanres/control/EditBillingAccount?partyId=MARKETING > getting error "org.ofbiz.webapp.control.RequestHandlerException: Unknown > request [createBillingAccountAndRole]; this request does not exist or cannot > be called directly." -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7586) Error in Create Billing Account From HR
[ https://issues.apache.org/jira/browse/OFBIZ-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347723#comment-15347723 ] Pranay Pandey edited comment on OFBIZ-7586 at 6/24/16 5:13 AM: --- Hi [~chandan.khandelwal], This is an example of shared dependency between Accounting and HR component and should be resolved the way we are willing to do under [OFBIZ-7208]. Converting this issue to a subtask of [OFBIZ-7208]. Should be corrected that way. was (Author: pandeypranay): Hi [~chandan.khandelwal], This is an example of shared dependency between Accounting and HR component and should be resolved the way we are willing to do under [OFBIZ-7208]. Making this a subtask of [OFBIZ-7208]. Should be corrected that way. > Error in Create Billing Account From HR > --- > > Key: OFBIZ-7586 > URL: https://issues.apache.org/jira/browse/OFBIZ-7586 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Chandan Khandelwal >Assignee: Pranay Pandey > > # Go To HR > # Select Comapny > # Create Billing Account > # Save > URL : > https://ofbiz-vm.apache.org:8443/humanres/control/EditBillingAccount?partyId=MARKETING > getting error "org.ofbiz.webapp.control.RequestHandlerException: Unknown > request [createBillingAccountAndRole]; this request does not exist or cannot > be called directly." -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7540) Enforce noninstantiability to FileUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-7540: - Description: - Make class as final. - Add a private constructor. - Make following public static class as private and move it to the top of the class. {code} public static class SearchTextFilesFilter implements FilenameFilter {code} was: - Make class as final. - Add a private constructor. No variables needs to be change. > Enforce noninstantiability to FileUtil class > > > Key: OFBIZ-7540 > URL: https://issues.apache.org/jira/browse/OFBIZ-7540 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > > - Make class as final. > - Add a private constructor. > - Make following public static class as private and move it to the top of the > class. > {code} > public static class SearchTextFilesFilter implements FilenameFilter > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7586) Error in Create Billing Account From HR
[ https://issues.apache.org/jira/browse/OFBIZ-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347723#comment-15347723 ] Pranay Pandey commented on OFBIZ-7586: -- Hi [~chandan.khandelwal], This is an example of shared dependency between Accounting and HR component and should be resolved the way we are willing to do under [OFBIZ-7208]. Making this a subtask of [OFBIZ-7208]. Should be corrected that way. > Error in Create Billing Account From HR > --- > > Key: OFBIZ-7586 > URL: https://issues.apache.org/jira/browse/OFBIZ-7586 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Chandan Khandelwal >Assignee: Chandan Khandelwal > > # Go To HR > # Select Comapny > # Create Billing Account > # Save > URL : > https://ofbiz-vm.apache.org:8443/humanres/control/EditBillingAccount?partyId=MARKETING > getting error "org.ofbiz.webapp.control.RequestHandlerException: Unknown > request [createBillingAccountAndRole]; this request does not exist or cannot > be called directly." -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7586) Error in Create Billing Account From HR
[ https://issues.apache.org/jira/browse/OFBIZ-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey reassigned OFBIZ-7586: Assignee: Pranay Pandey (was: Chandan Khandelwal) > Error in Create Billing Account From HR > --- > > Key: OFBIZ-7586 > URL: https://issues.apache.org/jira/browse/OFBIZ-7586 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Chandan Khandelwal >Assignee: Pranay Pandey > > # Go To HR > # Select Comapny > # Create Billing Account > # Save > URL : > https://ofbiz-vm.apache.org:8443/humanres/control/EditBillingAccount?partyId=MARKETING > getting error "org.ofbiz.webapp.control.RequestHandlerException: Unknown > request [createBillingAccountAndRole]; this request does not exist or cannot > be called directly." -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7524) Error on clicking Content Page button over Edit Product Config Item Content screen
[ https://issues.apache.org/jira/browse/OFBIZ-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-7524: -- Assignee: Ashish Vijaywargiya (was: Ravi Lodhi) > Error on clicking Content Page button over Edit Product Config Item Content > screen > -- > > Key: OFBIZ-7524 > URL: https://issues.apache.org/jira/browse/OFBIZ-7524 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, 13.07.04 >Reporter: Ravi Lodhi >Assignee: Ashish Vijaywargiya > Attachments: OFBIZ-7524_trunk.patch > > > Steps to regenerate: > 1) Go to Catalog -> Configuration > 2) Search Config item and go to detail page of that item. > 3) Now got to Content screen > 4) Go to edit ant Product Config Item Content from the list. Create New > Product Config Item Content if not available. > 5) In this page Click on "Content Page" button. > It will throw error: > Unknown request [gotoContent]; this request does not exist or cannot be > called directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7556) Error occurred when making notes private/public from project screen
[ https://issues.apache.org/jira/browse/OFBIZ-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-7556: -- Assignee: Ashish Vijaywargiya (was: Pritam Kute) > Error occurred when making notes private/public from project screen > --- > > Key: OFBIZ-7556 > URL: https://issues.apache.org/jira/browse/OFBIZ-7556 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/projectmgr >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Ashish Vijaywargiya > Attachments: OFBIZ-7556-Trunk.patch > > > Steps to regenerate :- > 1. Login into project component and select any created project from the > projects list. > 2. Add note from note section and make it public/private. > 3. See the notes in the project summary. > 4. Try to make it public/private then error comes with below message > {code} > Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL > parameter [workEffortId] passed to secure (https) request-map with uri > [updateProjectNote] with an event that calls service [updateWorkEffortNote]; > this is not allowed for security reasons! The data should be encrypted by > making it part of the request body (a form field) instead of the request URL. > Moreover it would be kind if you could create a Jira sub-task of > https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task > for this error does not exist). If you are not sure how to create a Jira > issue please have a look before at http://cwiki.apache.org/confluence/x/JIB2 > Thank you in advance for your help. > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7558) Any update made for 'Qty to produce' in a newly created production run not saved
[ https://issues.apache.org/jira/browse/OFBIZ-7558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divesh Dutta reassigned OFBIZ-7558: --- Assignee: Divesh Dutta (was: Swapnil Shah) > Any update made for 'Qty to produce' in a newly created production run not > saved > - > > Key: OFBIZ-7558 > URL: https://issues.apache.org/jira/browse/OFBIZ-7558 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12 >Reporter: Swapnil Shah >Assignee: Divesh Dutta >Priority: Critical > Attachments: OFBIZ-7558.patch, PR1.png, PR2.png, PR3.png > > > Whenever quantity to produce is revised for any production run (in created > status) the material requirement at WEGS (per BoM) gets readjusted > accordingly but the same is not saved correctly (under > WorkEffort.quantityToProduce) > Now when production run is confirmed, the quantity to produce is original > quantity but all material requirements at WEGS level are projected and > readjusted. > Expected Behavior: > Any changes made to Quantity to Produce for production run should be saved > correctly > Please refer to attached screenshot > !https://issues.apache.org/jira/secure/attachment/12812780/PR1.png|width=800px! > !https://issues.apache.org/jira/secure/attachment/12812779/PR2.png|width=800px! > !https://issues.apache.org/jira/secure/attachment/12812778/PR3.png|width=800px! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7522) Hide user inputs for Location/Lot# for fully issued components against production run task
[ https://issues.apache.org/jira/browse/OFBIZ-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divesh Dutta reassigned OFBIZ-7522: --- Assignee: Divesh Dutta (was: Swapnil Shah) > Hide user inputs for Location/Lot# for fully issued components against > production run task > -- > > Key: OFBIZ-7522 > URL: https://issues.apache.org/jira/browse/OFBIZ-7522 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: 14.12.01, 15.12.01 >Reporter: Swapnil Shah >Assignee: Divesh Dutta >Priority: Minor > Attachments: OFBIZ-7522.patch, PR_1.png > > > Once any component item gets fully issued then also we allow user to enter > the location/lot# etc. under 'Materials Required By The Running Task' panel, > like we do for un-issued or partially issued components. > We can possible hide user selection and text entry against such fully issued > items and show it only if remaining to be issued qty > 0 > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7586) Error in Create Billing Account From HR
Chandan Khandelwal created OFBIZ-7586: - Summary: Error in Create Billing Account From HR Key: OFBIZ-7586 URL: https://issues.apache.org/jira/browse/OFBIZ-7586 Project: OFBiz Issue Type: Bug Components: humanres Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12, Release Branch 13.07 Reporter: Chandan Khandelwal Assignee: Chandan Khandelwal # Go To HR # Select Comapny # Create Billing Account # Save URL : https://ofbiz-vm.apache.org:8443/humanres/control/EditBillingAccount?partyId=MARKETING getting error "org.ofbiz.webapp.control.RequestHandlerException: Unknown request [createBillingAccountAndRole]; this request does not exist or cannot be called directly." -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7557) Unable to set thru date for Product Promo Stores if promotion is associated with multiple stores.
[ https://issues.apache.org/jira/browse/OFBIZ-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-7557: --- Attachment: OFBIZ-7557.patch Attaching patch for this bug. Thanks [~suraj.khurana] for your help. > Unable to set thru date for Product Promo Stores if promotion is associated > with multiple stores. > - > > Key: OFBIZ-7557 > URL: https://issues.apache.org/jira/browse/OFBIZ-7557 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Pawan Verma >Priority: Minor > Attachments: OFBIZ-7557.patch, capture image.png > > > Steps to regenerate : > 1) Login into catalog application, > 2) Navigate to promotion screen. > 3) Select any promotion. > 4) Click on Stores tab. > 5) Associate promotion with more than one store. > 6) See calendar icon is missing from thru date field.(See in attachment.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7578) Content: Correct all the checkboxes and radio buttons in all the content FTLs.
[ https://issues.apache.org/jira/browse/OFBIZ-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Kathawala updated OFBIZ-7578: -- Component/s: (was: ALL APPLICATIONS) content > Content: Correct all the checkboxes and radio buttons in all the content FTLs. > -- > > Key: OFBIZ-7578 > URL: https://issues.apache.org/jira/browse/OFBIZ-7578 > Project: OFBiz > Issue Type: Sub-task > Components: content >Reporter: Mohammad Kathawala >Assignee: Mohammad Kathawala >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7579) Marketing: Correct all the checkboxes and radio buttons in all the marketing FTLs.
[ https://issues.apache.org/jira/browse/OFBIZ-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Kathawala updated OFBIZ-7579: -- Component/s: (was: ALL APPLICATIONS) marketing > Marketing: Correct all the checkboxes and radio buttons in all the marketing > FTLs. > -- > > Key: OFBIZ-7579 > URL: https://issues.apache.org/jira/browse/OFBIZ-7579 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Reporter: Mohammad Kathawala >Assignee: Mohammad Kathawala >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7585) Humanares: Correct all the checkboxes and radio buttons in all the humanares FTLs.
Mohammad Kathawala created OFBIZ-7585: - Summary: Humanares: Correct all the checkboxes and radio buttons in all the humanares FTLs. Key: OFBIZ-7585 URL: https://issues.apache.org/jira/browse/OFBIZ-7585 Project: OFBiz Issue Type: Sub-task Components: humanres Reporter: Mohammad Kathawala Assignee: Mohammad Kathawala Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7577) Accounting: Correct all the checkboxes and radio buttons in all the accounting FTLs.
Mohammad Kathawala created OFBIZ-7577: - Summary: Accounting: Correct all the checkboxes and radio buttons in all the accounting FTLs. Key: OFBIZ-7577 URL: https://issues.apache.org/jira/browse/OFBIZ-7577 Project: OFBiz Issue Type: Sub-task Components: accounting Reporter: Mohammad Kathawala Assignee: Mohammad Kathawala Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7582) Catalog: Correct all the checkboxes and radio buttons in all the catalog FTLs.
Mohammad Kathawala created OFBIZ-7582: - Summary: Catalog: Correct all the checkboxes and radio buttons in all the catalog FTLs. Key: OFBIZ-7582 URL: https://issues.apache.org/jira/browse/OFBIZ-7582 Project: OFBiz Issue Type: Sub-task Components: product Reporter: Mohammad Kathawala Assignee: Mohammad Kathawala Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7584) Workeffort: Correct all the checkboxes and radio buttons in all the workeffort FTLs.
Mohammad Kathawala created OFBIZ-7584: - Summary: Workeffort: Correct all the checkboxes and radio buttons in all the workeffort FTLs. Key: OFBIZ-7584 URL: https://issues.apache.org/jira/browse/OFBIZ-7584 Project: OFBiz Issue Type: Sub-task Components: workeffort Reporter: Mohammad Kathawala Assignee: Mohammad Kathawala Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7583) Facility: Correct all the checkboxes and radio buttons in all the facility FTLs.
Mohammad Kathawala created OFBIZ-7583: - Summary: Facility: Correct all the checkboxes and radio buttons in all the facility FTLs. Key: OFBIZ-7583 URL: https://issues.apache.org/jira/browse/OFBIZ-7583 Project: OFBiz Issue Type: Sub-task Components: product Reporter: Mohammad Kathawala Assignee: Mohammad Kathawala Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7580) Order: Correct all the checkboxes and radio buttons in all the order FTLs.
[ https://issues.apache.org/jira/browse/OFBIZ-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Kathawala reassigned OFBIZ-7580: - Assignee: Mohammad Kathawala > Order: Correct all the checkboxes and radio buttons in all the order FTLs. > -- > > Key: OFBIZ-7580 > URL: https://issues.apache.org/jira/browse/OFBIZ-7580 > Project: OFBiz > Issue Type: Sub-task > Components: order >Reporter: Mohammad Kathawala >Assignee: Mohammad Kathawala >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7581) Party: Correct all the checkboxes and radio buttons in all the party FTLs.
Mohammad Kathawala created OFBIZ-7581: - Summary: Party: Correct all the checkboxes and radio buttons in all the party FTLs. Key: OFBIZ-7581 URL: https://issues.apache.org/jira/browse/OFBIZ-7581 Project: OFBiz Issue Type: Sub-task Components: party Reporter: Mohammad Kathawala Assignee: Mohammad Kathawala Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7579) Marketing: Correct all the checkboxes and radio buttons in all the marketing FTLs.
Mohammad Kathawala created OFBIZ-7579: - Summary: Marketing: Correct all the checkboxes and radio buttons in all the marketing FTLs. Key: OFBIZ-7579 URL: https://issues.apache.org/jira/browse/OFBIZ-7579 Project: OFBiz Issue Type: Sub-task Reporter: Mohammad Kathawala Assignee: Mohammad Kathawala Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7580) Order: Correct all the checkboxes and radio buttons in all the order FTLs.
Mohammad Kathawala created OFBIZ-7580: - Summary: Order: Correct all the checkboxes and radio buttons in all the order FTLs. Key: OFBIZ-7580 URL: https://issues.apache.org/jira/browse/OFBIZ-7580 Project: OFBiz Issue Type: Sub-task Components: order Reporter: Mohammad Kathawala Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7578) Content: Correct all the checkboxes and radio buttons in all the content FTLs.
Mohammad Kathawala created OFBIZ-7578: - Summary: Content: Correct all the checkboxes and radio buttons in all the content FTLs. Key: OFBIZ-7578 URL: https://issues.apache.org/jira/browse/OFBIZ-7578 Project: OFBiz Issue Type: Sub-task Reporter: Mohammad Kathawala Assignee: Mohammad Kathawala Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7541) Enforce noninstantiability to KeyStoreUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pratik Kulshreshth updated OFBIZ-7541: -- Attachment: OFBIZ-7541.patch Here is the patch for this task. Thanks [~rishisolankii] for the description. > Enforce noninstantiability to KeyStoreUtil class > > > Key: OFBIZ-7541 > URL: https://issues.apache.org/jira/browse/OFBIZ-7541 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Minor > Attachments: OFBIZ-7541.patch > > > - Make class as final. > - Add a private constructor. > No variables needs to be change for this class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
[ https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347540#comment-15347540 ] Ankush Upadhyay commented on OFBIZ-7576: Thanks [~jacques.le.roux] for patch review and suggesting improvements. I have updated my patch and yes we can do similar changes at other places throughout the application in new improvement ticket. > auto-completer does not work to search Contact Party Id > --- > > Key: OFBIZ-7576 > URL: https://issues.apache.org/jira/browse/OFBIZ-7576 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay >Assignee: Divesh Dutta > Attachments: OFBIZ-7576.patch > > > Steps to reproduce: > 1. Login to party manager. > 2. Search Company party and navigate to profile. > 3. Click on create new link of List Related Contacts screenlet. > 4. Search any contact party using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
[ https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay updated OFBIZ-7576: --- Attachment: OFBIZ-7576.patch > auto-completer does not work to search Contact Party Id > --- > > Key: OFBIZ-7576 > URL: https://issues.apache.org/jira/browse/OFBIZ-7576 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay >Assignee: Divesh Dutta > Attachments: OFBIZ-7576.patch > > > Steps to reproduce: > 1. Login to party manager. > 2. Search Company party and navigate to profile. > 3. Click on create new link of List Related Contacts screenlet. > 4. Search any contact party using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
[ https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay updated OFBIZ-7576: --- Attachment: (was: OFBIZ-7576.patch) > auto-completer does not work to search Contact Party Id > --- > > Key: OFBIZ-7576 > URL: https://issues.apache.org/jira/browse/OFBIZ-7576 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay >Assignee: Divesh Dutta > > Steps to reproduce: > 1. Login to party manager. > 2. Search Company party and navigate to profile. > 3. Click on create new link of List Related Contacts screenlet. > 4. Search any contact party using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347109#comment-15347109 ] Peter Arnold edited comment on OFBIZ-6576 at 6/23/16 8:52 PM: -- Dear Ankush and Divesh; thank you for the suggestions and the patch. I think your solution is correct since the variant should inherit information from its corresponding virtual product, if not specified directly on the variant. I have tested the patch and it works fine up to the "Final Check-Out Review" where still some strange values are indicateed: Formating unfortunately is messed up Order Items Product Qty Ordered Unit Price Adjustments Subtotal DA-DA163 - DecoArt Americana Honey Brown 2Oz 1CLP1,690 CLP0 CLP2,011.1 Adjustment: VAT Tax (not added to totals) CLP321.1 DA-DA01 - DecoArt Americana Snow White Titanium 2Oz 1CLP1,690 CLP0 CLP1,690 Adjustment: VAT Tax (not added to totals) CLP0 Subtotal CLP3,380 Shipping and Handling CLP0 Sales Tax CLP0 Grand Total CLP3,380 The first Product has the price inherited from its corresponding Virtual product. The second product has the price defined directly in the variant. Difference is that for the product which inherits price information from its virtual product still a Sales Tax is calculated which is rather confusing, even though it is not added to the Grand Total amount which is fine. This screen still needs further improvement. I will investigate this problem but it will take me some time. was (Author: peter arnold): Dear Ankush and Divesh; thank you for the suggestions and the patch. I think your solution is correct since the variant should inherit information from its corresponding virtual product, if not specified directly on the variant. I have tested the patch and it works fine up to the "Final Check-Out Review" where still some strange values are indicateed: Decrease zoom in order to see proper format. Order Items Product Qty Ordered Unit Price Adjustments Subtotal DA-DA163 - DecoArt Americana Honey Brown 2Oz 1CLP1,690 CLP0 CLP2,011.1 Adjustment: VAT Tax (not added to totals) CLP321.1 DA-DA01 - DecoArt Americana Snow White Titanium 2Oz 1CLP1,690 CLP0 CLP1,690 Adjustment: VAT Tax (not added to totals) CLP0 Subtotal CLP3,380 Shipping and Handling CLP0 Sales Tax CLP0 Grand Total CLP3,380 The first Product has the price inherited from its corresponding Virtual product. The second product has the price defined directly in the variant. Difference is that for the product which inherits price information from its virtual product still a Sales Tax is calculated which is rather confusing, even though it is not added to the Grand Total amount which is fine. This screen still needs further improvement. I will investigate this problem but it will take me some time. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347151#comment-15347151 ] Peter Arnold commented on OFBIZ-6576: - Dear Paul and Divesh, I agree with Pauls explanation of the difference between Sales Tax and VAT TAX. Sales tax is applied as a percentage of the sales amount. VAT is as the name says (Value Added Tax) only applied as a percentage on the added value. For example: You buy something for 1USD and sell it for 2USD. The added value is calculated as Sales Price minus Cost, i.e. 2USD-1USD= 1USD. Finally the VAT is paid only on the added value even though you declare tax for the sales amount and for your cost separately. Divesh, When you say that both, Sales Tax and VAT are the same you are commiting a big error from an accounting point of view since you are not considering that for VAT declaration you also declare the VAT for your cost, not just for your sales. So in my opinion VAT and Sales tax certainly need to be treated in a different way. Therefore the if and else statements should not be removed. If Sales-Tax treatment works correctly through all OFBiz modules, (Accounting included) then we simply should try to get to the same level with VAT-Tax Treatment. Accounting wise the treatment should be different since for Vat-taxed sales you also have vat-credits which are originated by taxes paid on your purchases. Maybe an option would be to configure the system via a flag which is set in tax setup, that defines which one is to be used, either VAT-Tax or Sales-Tax as probably in no country both tax systems exist in parallel. However I don't know what such a change would mean in terms of coding. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347109#comment-15347109 ] Peter Arnold commented on OFBIZ-6576: - Dear Ankush and Divesh; thank you for the suggestions and the patch. I think your solution is correct since the variant should inherit information from its corresponding virtual product, if not specified directly on the variant. I have tested the patch and it works fine up to the "Final Check-Out Review" where still some strange values are indicateed: Decrease zoom in order to see proper format. Order Items Product Qty Ordered Unit Price Adjustments Subtotal DA-DA163 - DecoArt Americana Honey Brown 2Oz 1CLP1,690 CLP0 CLP2,011.1 Adjustment: VAT Tax (not added to totals) CLP321.1 DA-DA01 - DecoArt Americana Snow White Titanium 2Oz 1CLP1,690 CLP0 CLP1,690 Adjustment: VAT Tax (not added to totals) CLP0 Subtotal CLP3,380 Shipping and Handling CLP0 Sales Tax CLP0 Grand Total CLP3,380 The first Product has the price inherited from its corresponding Virtual product. The second product has the price defined directly in the variant. Difference is that for the product which inherits price information from its virtual product still a Sales Tax is calculated which is rather confusing, even though it is not added to the Grand Total amount which is fine. This screen still needs further improvement. I will investigate this problem but it will take me some time. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create
Re: svn commit: r1632793 - in /ofbiz/trunk/framework: common/widget/HelpScreens.xml resources/templates/CommonScreens.xml
Did someone check this possible issue Adrian raised? Thanks Jacques Le 08/06/2015 à 14:55, Jacques Le Roux a écrit : Hi Ashish, Has this been addressed and I did not see? Thanks Jacques Le 23/10/2014 21:11, Ashish Vijaywargiya a écrit : Thanks Jacques. :-) Happy Diwali...!!! -- Ashish - Jacques Le Rouxwrote: | Yes sure Ashish, I understand, have a good Diwali :) | | Thanks to care | | Jacques | | Le 23/10/2014 20:27, Ashish Vijaywargiya a écrit : | > Please give us some time. We will get back to this conversation in next week. Thanks! | > | > -- | > Ashish | > | > | > - Jacques Le Roux wrote: | > | Is somebody taking care of that? Is it a real issue? | > | | > | Jacques | > | | > | Le 18/10/2014 16:32, Adrian Crum a écrit : | > | > I don't think we need to change the component templates. This is a regression - components created with the ant target will not function properly. | > | > | > | > Adrian Crum | > | > Sandglass Software | > | > www.sandglass-software.com | > | > | > | > On 10/18/2014 3:11 PM, apa...@apache.org wrote: | > | >> Author: apatel | > | >> Date: Sat Oct 18 14:11:50 2014 | > | >> New Revision: 1632793 | > | >> | > | >> URL: http://svn.apache.org/r1632793 | > | >> Log: | > | >> [OFBIZ-3329] Removing framework code on resources in commonext. | > | >> Thanks Divesh and Mridul for helping with resuluation. | > | >> Thanks Adrian for reporting it. | > | >> Thanks Chris Snow for reporting the issue | > | >> | > | >> Modified: | > | >> ofbiz/trunk/framework/common/widget/HelpScreens.xml | > | >> ofbiz/trunk/framework/resources/templates/CommonScreens.xml | > | >> | > | >> Modified: ofbiz/trunk/framework/common/widget/HelpScreens.xml | > | >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/HelpScreens.xml?rev=1632793=1632792=1632793=diff | > | >> == | > | >> --- ofbiz/trunk/framework/common/widget/HelpScreens.xml (original) | > | >> +++ ofbiz/trunk/framework/common/widget/HelpScreens.xml Sat Oct 18 14:11:50 2014 | > | >> @@ -25,7 +25,6 @@ under the License. | > | >> | > | >> | > | >> | > | >> - | > | >> | > | >> | > | >> | > | >> | > | >> Modified: ofbiz/trunk/framework/resources/templates/CommonScreens.xml | > | >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/resources/templates/CommonScreens.xml?rev=1632793=1632792=1632793=diff | > | >> == | > | >> --- ofbiz/trunk/framework/resources/templates/CommonScreens.xml (original) | > | >> +++ ofbiz/trunk/framework/resources/templates/CommonScreens.xml Sat Oct 18 14:11:50 2014 | > | >> @@ -17,7 +17,7 @@ | > | >> | > | >> | > | >> | > | >> - | > | >> + | > | >> | > | >> | > | >> | > | >> | > | >> | > | > | > | > | >
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347031#comment-15347031 ] Jacques Le Roux commented on OFBIZ-7534: Thanks for the explanation, it's clear. We will see for bq. windows: start gradlew.bat 'ofbiz --start' (I think we might need a flag) I rarely use that on my machine I must say. On VM demo it might need to adapt a bit but nothing big, eg http://svn.apache.org/viewvc/ofbiz/trunk/tools/demo-backup/all-manual-nicely.sh?view=markup I don't need nothing else for now > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, build.gradle > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Affects Version/s: (was: Trunk) Upcoming Branch > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, build.gradle > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: build.gradle This file is not complete, and the classpath issue needs a major change, please do not use this file now, I am just attaching it to show my work so far and to keep a backup copy on JIRA and for you to get a clue what is it that I'm doing. Enjoy! > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, build.gradle > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346992#comment-15346992 ] Taher Alkhateeb commented on OFBIZ-7534: Hi Jacques, Thank you for the feedback. To note: - I think the start-batch and start-batch-secure should simply be replaced as follows: linux: ./gradlew 'ofbiz --start' & windows: start gradlew.bat 'ofbiz --start' (I think we might need a flag) - No need for shell scripts, I can make "shortcut tasks" but then are there any default values for these parameters? If yes, tell me their values and I will create a task for it. - Please note there are two types of tasks as I designed it. The first is OFBiz server tasks, they always start with 'ofbiz' or 'ofbizDebug' or 'ofbizSecure' They are really just a replacement to java -jar ofbiz.jar with the correct JVM arguments. The other set of tasks are called directly by name. I designed it this way so people talk to the server directly. Again, it is very easy to create shortcut tasks, but I just prefer minimalism. If you want shortcut or convenience tasks, I will add them. For example, loadDemo and testInteg are shortcut tasks. loadDemo translates to 'ofbiz --load-data' Again, thank you for your feedback, and feel free to pitch in anything else you want. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346950#comment-15346950 ] Jacques Le Roux commented on OFBIZ-7534: You mean it should be deprecated, right? > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346947#comment-15346947 ] Jacques Le Roux commented on OFBIZ-7534: Tasks with a lot of parameters like below will need to be covered by scripts (.sh & . bat), not a big deal {code} ./ant create-component-> ./gradlew createComponent -PcomponentName=custom -PcomponentResourceName=custom -PwebappName=customweb -PbasePermission=OFBTOOLS,CUSTOM_SECURITY ./ant create-tenant -> ./gradlew -PtenantId=DEMO1 -PtenantName=Demo1 -PdomainName=localhost -PdbPlatform=D -PdbIP=127.0.0.1 -PdbUser=someUser -PdbPassword=somePassword {code} Why do we need the 'ofbiz' parameter in data loading tasks? I maybe missed something but how will the "batch" Ant targets be replaced? {code} ./ant start-batch Not implemented ./ant start-batch-secure Not implemented {code} I particularly like {code} ./gradlew cleanAll loadDemo testInteg {code} I have just learnt that "ant -p" is "gradle tasks" in Gradle, nice. I did no see anything missing Thanks! > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
[ https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346731#comment-15346731 ] Jacques Le Roux edited comment on OFBIZ-7576 at 6/23/16 4:49 PM: - Hi Ankush, You can use a simple quote (') instead of {noformat}{noformat} So your patch would be {code} Index: applications/party/widget/partymgr/LookupScreens.xml === --- applications/party/widget/partymgr/LookupScreens.xml(revision 1749889) +++ applications/party/widget/partymgr/LookupScreens.xml(working copy) @@ -101,7 +101,7 @@ - + @@ -178,6 +178,10 @@ + + + @@ -411,7 +415,7 @@ + org.ofbiz.entity.condition.EntityCondition.makeCondition('roleTypeId', 'INTERNAL_ORGANIZATIO')])}"/> Index: applications/party/widget/partymgr/LookupScreens.xml === --- applications/party/widget/partymgr/LookupScreens.xml(revision 1749889) +++ applications/party/widget/partymgr/LookupScreens.xml(working copy) @@ -101,7 +101,7 @@ - + @@ -178,6 +178,10 @@ + + + @@ -411,7 +415,7 @@ + org.ofbiz.entity.condition.EntityCondition.makeCondition('roleTypeId', 'INTERNAL_ORGANIZATIO')])}"/> {code} Thanks! was (Author: jacques.le.roux): Hi Ankush, You can use a simple quote (') instead of So your patch would be {code} Index: applications/party/widget/partymgr/LookupScreens.xml === --- applications/party/widget/partymgr/LookupScreens.xml(revision 1749889) +++ applications/party/widget/partymgr/LookupScreens.xml(working copy) @@ -101,7 +101,7 @@ - + @@ -178,6 +178,10 @@ + + + @@ -411,7 +415,7 @@ + org.ofbiz.entity.condition.EntityCondition.makeCondition('roleTypeId', 'INTERNAL_ORGANIZATIO')])}"/> Index: applications/party/widget/partymgr/LookupScreens.xml === --- applications/party/widget/partymgr/LookupScreens.xml(revision 1749889) +++ applications/party/widget/partymgr/LookupScreens.xml(working copy) @@ -101,7 +101,7 @@ - + @@ -178,6 +178,10 @@ + + + @@ -411,7 +415,7 @@ + org.ofbiz.entity.condition.EntityCondition.makeCondition('roleTypeId', 'INTERNAL_ORGANIZATIO')])}"/> {code} Thanks! > auto-completer does not work to search Contact Party Id > --- > > Key: OFBIZ-7576 > URL: https://issues.apache.org/jira/browse/OFBIZ-7576 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay >Assignee: Divesh Dutta > Attachments: OFBIZ-7576.patch > > > Steps to reproduce: > 1. Login to party manager. > 2. Search Company party and navigate to profile. > 3. Click on create new link of List Related Contacts screenlet. > 4. Search any contact party using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
[ https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346731#comment-15346731 ] Jacques Le Roux commented on OFBIZ-7576: Hi Ankush, You can use a simple quote (') instead of So your patch would be {code} Index: applications/party/widget/partymgr/LookupScreens.xml === --- applications/party/widget/partymgr/LookupScreens.xml(revision 1749889) +++ applications/party/widget/partymgr/LookupScreens.xml(working copy) @@ -101,7 +101,7 @@ - + @@ -178,6 +178,10 @@ + + + @@ -411,7 +415,7 @@ + org.ofbiz.entity.condition.EntityCondition.makeCondition('roleTypeId', 'INTERNAL_ORGANIZATIO')])}"/> Index: applications/party/widget/partymgr/LookupScreens.xml === --- applications/party/widget/partymgr/LookupScreens.xml(revision 1749889) +++ applications/party/widget/partymgr/LookupScreens.xml(working copy) @@ -101,7 +101,7 @@ - + @@ -178,6 +178,10 @@ + + + @@ -411,7 +415,7 @@ + org.ofbiz.entity.condition.EntityCondition.makeCondition('roleTypeId', 'INTERNAL_ORGANIZATIO')])}"/> {code} Thanks! > auto-completer does not work to search Contact Party Id > --- > > Key: OFBIZ-7576 > URL: https://issues.apache.org/jira/browse/OFBIZ-7576 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay >Assignee: Divesh Dutta > Attachments: OFBIZ-7576.patch > > > Steps to reproduce: > 1. Login to party manager. > 2. Search Company party and navigate to profile. > 3. Click on create new link of List Related Contacts screenlet. > 4. Search any contact party using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[ https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346722#comment-15346722 ] Jacques Le Roux commented on OFBIZ-7061: Done at revision: 1749938 For myself: when we will do the 3rd more elegant option (no schema duplication), have been changed also: minilang-catalog.xml compound-widgets.xsd > Autocompletion for Compound Widget > -- > > Key: OFBIZ-7061 > URL: https://issues.apache.org/jira/browse/OFBIZ-7061 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: james yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch > > > I am trying to enable auto-completion when coding compound widget. > My plan as follows: > 1. The following xsd will be modified to use namespace > site-conf.xsd > widget-form.xsd > widget-screen.xsd > widget-menu.xsd > simple-methods.xsd > For example, in site-conf.xsd, we add the following document level attribute > {code} > xmlns="http://ofbiz.apache.org/sc; > targetNamespace="http://ofbiz.apache.org/sc; > {code} > 2. Import the above schema into compound-widgets.xsd so that compound widgets > use only one consolidated schema. > 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For > example > {code} > http://www.w3.org/2001/XMLSchema-instance; > xmlns:sc="http://ofbiz.apache.org/sc; > xmlns:m="http://ofbiz.apache.org/m; > xmlns:s="http://ofbiz.apache.org/s; > xmlns:f="http://ofbiz.apache.org/f; > xmlns:sm="http://ofbiz.apache.org/sm; > > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;> > > > > path="component://example/widget/example/ExampleCompoundWidgets.xml"/> > > > auth="true"/> value="CompoundWidgets2"/> > > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/> > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/> > > .. the rest > {code} > 4. Change java code to support reading xml with namespace (i.e. xml for > compound widgets) > 5. Update the attributes at document level for rest of the controllers, > menus, forms, simple methods and screens. Current setting will not work for > schema with a namespace. For example, in controller.xml, we will change > {code} > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd” > {code} > to > {code} > xmlns="http://ofbiz.apache.org/sc” > xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”> > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
[ https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346702#comment-15346702 ] Ankush Upadhyay commented on OFBIZ-7576: Assigning ticket to [~diveshdut] for patch review and further action on it. > auto-completer does not work to search Contact Party Id > --- > > Key: OFBIZ-7576 > URL: https://issues.apache.org/jira/browse/OFBIZ-7576 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay >Assignee: Divesh Dutta > Attachments: OFBIZ-7576.patch > > > Steps to reproduce: > 1. Login to party manager. > 2. Search Company party and navigate to profile. > 3. Click on create new link of List Related Contacts screenlet. > 4. Search any contact party using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
[ https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay updated OFBIZ-7576: --- Assignee: Divesh Dutta (was: Ankush Upadhyay) > auto-completer does not work to search Contact Party Id > --- > > Key: OFBIZ-7576 > URL: https://issues.apache.org/jira/browse/OFBIZ-7576 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay >Assignee: Divesh Dutta > Attachments: OFBIZ-7576.patch > > > Steps to reproduce: > 1. Login to party manager. > 2. Search Company party and navigate to profile. > 3. Click on create new link of List Related Contacts screenlet. > 4. Search any contact party using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
[ https://issues.apache.org/jira/browse/OFBIZ-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay updated OFBIZ-7576: --- Attachment: OFBIZ-7576.patch Attached patch to fix the reported issue and now auto-completer is working as expected. > auto-completer does not work to search Contact Party Id > --- > > Key: OFBIZ-7576 > URL: https://issues.apache.org/jira/browse/OFBIZ-7576 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Upcoming Branch >Reporter: Ankush Upadhyay >Assignee: Ankush Upadhyay > Attachments: OFBIZ-7576.patch > > > Steps to reproduce: > 1. Login to party manager. > 2. Search Company party and navigate to profile. > 3. Click on create new link of List Related Contacts screenlet. > 4. Search any contact party using auto-completer. > Expected behavior: auto-completer should work and return results like lookup > does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7576) auto-completer does not work to search Contact Party Id
Ankush Upadhyay created OFBIZ-7576: -- Summary: auto-completer does not work to search Contact Party Id Key: OFBIZ-7576 URL: https://issues.apache.org/jira/browse/OFBIZ-7576 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Upcoming Branch Reporter: Ankush Upadhyay Assignee: Ankush Upadhyay Steps to reproduce: 1. Login to party manager. 2. Search Company party and navigate to profile. 3. Click on create new link of List Related Contacts screenlet. 4. Search any contact party using auto-completer. Expected behavior: auto-completer should work and return results like lookup does. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346694#comment-15346694 ] Pierre Smits commented on OFBIZ-7534: - ./ant load-all-tenants-> ./gradlew loadAllTenants -Preader=seed,ext,demo Is also deprecated. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[ https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346659#comment-15346659 ] Jacques Le Roux commented on OFBIZ-7061: Thanks James, I have anyway decided to go with 2nd in the meantime, I'll certainly do it today... > Autocompletion for Compound Widget > -- > > Key: OFBIZ-7061 > URL: https://issues.apache.org/jira/browse/OFBIZ-7061 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: james yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch > > > I am trying to enable auto-completion when coding compound widget. > My plan as follows: > 1. The following xsd will be modified to use namespace > site-conf.xsd > widget-form.xsd > widget-screen.xsd > widget-menu.xsd > simple-methods.xsd > For example, in site-conf.xsd, we add the following document level attribute > {code} > xmlns="http://ofbiz.apache.org/sc; > targetNamespace="http://ofbiz.apache.org/sc; > {code} > 2. Import the above schema into compound-widgets.xsd so that compound widgets > use only one consolidated schema. > 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For > example > {code} > http://www.w3.org/2001/XMLSchema-instance; > xmlns:sc="http://ofbiz.apache.org/sc; > xmlns:m="http://ofbiz.apache.org/m; > xmlns:s="http://ofbiz.apache.org/s; > xmlns:f="http://ofbiz.apache.org/f; > xmlns:sm="http://ofbiz.apache.org/sm; > > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;> > > > > path="component://example/widget/example/ExampleCompoundWidgets.xml"/> > > > auth="true"/> value="CompoundWidgets2"/> > > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/> > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/> > > .. the rest > {code} > 4. Change java code to support reading xml with namespace (i.e. xml for > compound widgets) > 5. Update the attributes at document level for rest of the controllers, > menus, forms, simple methods and screens. Current setting will not work for > schema with a namespace. For example, in controller.xml, we will change > {code} > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd” > {code} > to > {code} > xmlns="http://ofbiz.apache.org/sc” > xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”> > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7564) Remove HtmlFormWrapper(depricated) and its dependencies
[ https://issues.apache.org/jira/browse/OFBIZ-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346644#comment-15346644 ] Jacques Le Roux commented on OFBIZ-7564: +1, thanks for the effort! > Remove HtmlFormWrapper(depricated) and its dependencies > --- > > Key: OFBIZ-7564 > URL: https://issues.apache.org/jira/browse/OFBIZ-7564 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > > This is an umbrella task to remove all the dependencies related to depricated > HtmlFormWrapper. > Added sub-task to divide changes in chucks to avoid any mistake. This will > also helpful in review process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7566) Remove HtmlFormWrapper dependencies from Production Run Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7566: -- Attachment: OFBIZ-7566_trunk.patch > Remove HtmlFormWrapper dependencies from Production Run Screen > -- > > Key: OFBIZ-7566 > URL: https://issues.apache.org/jira/browse/OFBIZ-7566 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7566_trunk.patch > > > Location: > 1) Log on to manufacturing component. > 2) Under JobShop screen, search any production run and go to the detail page. > 3) Here Materials/Actual Materials and Fixed Assets screen using > HtmlFormWrapper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget
[ https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346615#comment-15346615 ] james yong commented on OFBIZ-7061: --- I am in favor of the 3rd one too, but can only look into it this weekend. > Autocompletion for Compound Widget > -- > > Key: OFBIZ-7061 > URL: https://issues.apache.org/jira/browse/OFBIZ-7061 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: james yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch > > > I am trying to enable auto-completion when coding compound widget. > My plan as follows: > 1. The following xsd will be modified to use namespace > site-conf.xsd > widget-form.xsd > widget-screen.xsd > widget-menu.xsd > simple-methods.xsd > For example, in site-conf.xsd, we add the following document level attribute > {code} > xmlns="http://ofbiz.apache.org/sc; > targetNamespace="http://ofbiz.apache.org/sc; > {code} > 2. Import the above schema into compound-widgets.xsd so that compound widgets > use only one consolidated schema. > 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For > example > {code} > http://www.w3.org/2001/XMLSchema-instance; > xmlns:sc="http://ofbiz.apache.org/sc; > xmlns:m="http://ofbiz.apache.org/m; > xmlns:s="http://ofbiz.apache.org/s; > xmlns:f="http://ofbiz.apache.org/f; > xmlns:sm="http://ofbiz.apache.org/sm; > > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;> > > > > path="component://example/widget/example/ExampleCompoundWidgets.xml"/> > > > auth="true"/> value="CompoundWidgets2"/> > > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/> > page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/> > > .. the rest > {code} > 4. Change java code to support reading xml with namespace (i.e. xml for > compound widgets) > 5. Update the attributes at document level for rest of the controllers, > menus, forms, simple methods and screens. Current setting will not work for > schema with a namespace. For example, in controller.xml, we will change > {code} > xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd” > {code} > to > {code} > xmlns="http://ofbiz.apache.org/sc” > xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”> > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: ANT_GRADLE_COMPARISON.txt This is a file that shows the old ant commands in comparison with their gradle counterparts. I need feedback to make sure I'm doing things correctly. > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7574) Remove HtmlFormWrapper Class after removing all its dependencies
[ https://issues.apache.org/jira/browse/OFBIZ-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7574: -- Attachment: OFBIZ-7574_trunk.patch > Remove HtmlFormWrapper Class after removing all its dependencies > > > Key: OFBIZ-7574 > URL: https://issues.apache.org/jira/browse/OFBIZ-7574 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7574_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Important Changes to Trunk and Use of Ant & Gradle
Hey Guys, I've attached a text file in https://issues.apache.org/jira/browse/OFBIZ-7534 This text file shows the old ant commands and how I implemented them (most of them anyway) in Gradle. Please review it and provide your feedback: - Does it look correct? - Are the parameters corrects? - Are there any important missing tasks? - Do you want to provide shorter versions for some of the tasks? Note, I only created two real short commands for OFBiz server commands: loadDemo and testInteg. These exist because the most common command in OFBiz would be ./gradlew cleanAll loadDemo testInteg I look forward to your feedback. Taher Alkhateeb On Wed, Jun 22, 2016 at 11:12 PM, Taher Alkhateeb < slidingfilame...@gmail.com> wrote: > Hi Jacques, > > Thank you for the explanation. OK, between your feedback and the votes > from other members, I'll keep them. Working on integration in gradle ... > > Cheers > > Taher Alkhateeb > > On Wed, Jun 22, 2016 at 11:08 PM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> Hi Taher, >> >> Inline... >> >> Le 22/06/2016 à 16:23, Taher Alkhateeb a écrit : >> >>> Hi Michael Jacques and everyone, >>> >>> So I also want to confirm that you really need the following tasks: >>> >>> - build-dev >>> - build-production >>> - build-qa >>> - build-test >>> - revert-dev >>> >> >> I introduced those for a custom project and improved it in the following >> project I worked on. So yes I use these targets. BTW I documented it at >> >> https://cwiki.apache.org/confluence/display/OFBIZ/Addressing+Custom+Requirements+In+OFBiz#AddressingCustomRequirementsInOFBiz-Therearealso4deploymenttargetsavailableinthemainbuild.xml >> . >> >> Are you using them yourselves? Here are the reasons why I suggest to >>> remove >>> them: >>> - First, you must have the patch command existing in your environment, >>> thus >>> making the build script brittle >>> >> >> Actually it's a bit more complicated than that, see the comment above the >> calculate-svn-patch-available target: >> >> and then >> >> >> - Second, it has this weird naming convention for patches and how they >>> should be applied. I would imagine that every team and every company has >>> its own style and methodology for patching and keeping track of files and >>> changes. They use their own version control system and even different >>> kinds >>> of patches >>> - It is dependent on a specific format of diff which you must generate >>> either with svn diff or diff -Naur. >>> >> >> This is useful even if you are using Git for your project. Why? Because >> if, instead of relying on a released package, you decide to rely on the >> trunk or a release branch you need to connect your project to the ASF svn >> repo. >> And yes it's possible to have both, I did it, used those targets and was >> quite happy with them. I can agree it's a bit complicated, but not that >> much when you look into details: they make sense. >> >> It seems like it does not make a lot of sense to keep something like that >>> when companies might completely ignore it and choose their own >>> implementation strategies. Do you agree? Feedback? >>> >> >> You got mine :) >> >> Jacques >> >> >> >>> Taher Alkhateeb >>> >>> On Wed, Jun 22, 2016 at 4:01 PM, Jacques Le Roux < >>> jacques.le.r...@les7arts.com> wrote: >>> >>> I wonder though why this was introduced. If we have no feedback from any member of the community I think we can drop it. I don't see how to use it. Jacques Le 22/06/2016 à 14:43, Michael Brohl a écrit : Hi Taher, > > no, I don't use it myself. This was just a guess by looking what the > task > does and it seemed to me this should be preserved. > No problem to drop it from my side. > > Regards, > > Michael Brohl > ecomify GmbH > www.ecomify.de > > > Am 22.06.16 um 14:37 schrieb Taher Alkhateeb: > > Hi Michael, >> >> Are you sure you are using "run-test-list"? This is an old task using >> a >> target on the server called --testlist which essentially creates an >> ant >> file of all the suites in OFBiz and runs them one-by-one stopping >> OFBiz >> in >> between each run. >> >> To me it seems like run-tests is doing the same thing but faster. Is >> this a >> typo by you or are you actually using this target? The reason I ask is >> because I actually wanted to delete the entire TestListContainer.java >> and >> related files in the future. But now of course I hesitate. >> >> Thanks in advance for your feedback. >> >> Regards, >> >> Taher Alkhateeb >> >> On Wed, Jun 22, 2016 at 12:00 AM, Michael Brohl < >> michael.br...@ecomify.de> >> wrote: >> >> Hi Taher, >> >>> First question: >>> >>> Don't drop: >>> >>> - build-dev >>> - build-production >>> - build-qa >>> - build-test >>> - refresh >>> - revert-dev
[jira] [Updated] (OFBIZ-7564) Remove HtmlFormWrapper(depricated) and its dependencies
[ https://issues.apache.org/jira/browse/OFBIZ-7564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7564: -- Description: This is an umbrella task to remove all the dependencies related to depricated HtmlFormWrapper. Added sub-task to divide changes in chucks to avoid any mistake. This will also helpful in review process. was:This is an umbrella task to remove all the dependencies related to depricated HtmlFormWrapper. > Remove HtmlFormWrapper(depricated) and its dependencies > --- > > Key: OFBIZ-7564 > URL: https://issues.apache.org/jira/browse/OFBIZ-7564 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > > This is an umbrella task to remove all the dependencies related to depricated > HtmlFormWrapper. > Added sub-task to divide changes in chucks to avoid any mistake. This will > also helpful in review process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7566) Remove HtmlFormWrapper dependencies from Production Run Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7566: -- Description: Location: 1) Log on to manufacturing component. 2) Under JobShop screen, search any production run and go to the detail page. 3) Here Materials/Actual Materials and Fixed Assets screen using HtmlFormWrapper. > Remove HtmlFormWrapper dependencies from Production Run Screen > -- > > Key: OFBIZ-7566 > URL: https://issues.apache.org/jira/browse/OFBIZ-7566 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > > Location: > 1) Log on to manufacturing component. > 2) Under JobShop screen, search any production run and go to the detail page. > 3) Here Materials/Actual Materials and Fixed Assets screen using > HtmlFormWrapper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7573) Remove unused import related to HtmlFormWrapper and unused file using it
[ https://issues.apache.org/jira/browse/OFBIZ-7573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7573: -- Attachment: OFBIZ-7573_trunk.patch > Remove unused import related to HtmlFormWrapper and unused file using it > > > Key: OFBIZ-7573 > URL: https://issues.apache.org/jira/browse/OFBIZ-7573 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7573_trunk.patch > > > There are various groovy script with unused HtmlFormWrapper class import. > There are two unused files- > 1) EditProductConfigOptions.groovy > 2) FormPrep.groovy > using HtmlFormWrapper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7573) Remove unused import related to HtmlFormWrapper and unused file using it
[ https://issues.apache.org/jira/browse/OFBIZ-7573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7573: -- Description: There are various groovy script with unused HtmlFormWrapper class import. There are two unused files- 1) EditProductConfigOptions.groovy 2) FormPrep.groovy using HtmlFormWrapper. > Remove unused import related to HtmlFormWrapper and unused file using it > > > Key: OFBIZ-7573 > URL: https://issues.apache.org/jira/browse/OFBIZ-7573 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7573_trunk.patch > > > There are various groovy script with unused HtmlFormWrapper class import. > There are two unused files- > 1) EditProductConfigOptions.groovy > 2) FormPrep.groovy > using HtmlFormWrapper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7571) Remove HtmlFormWrapper dependencies from Product Config Item Content screen
[ https://issues.apache.org/jira/browse/OFBIZ-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7571: -- Attachment: OFBIZ-7571_trunk.patch > Remove HtmlFormWrapper dependencies from Product Config Item Content screen > --- > > Key: OFBIZ-7571 > URL: https://issues.apache.org/jira/browse/OFBIZ-7571 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7571_trunk.patch > > > Location: > 1) Log on to Catalog component. > 2) Go to Configurations screen. > 3) Find any config item and go to the detail of page of that config item. > 4) Go to Content page. > 5) This is the screen where HtmlFormWrapper is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7572) Remove HtmlFormWrapper dependencies from Content Search screen
[ https://issues.apache.org/jira/browse/OFBIZ-7572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7572: -- Attachment: OFBIZ-7572_trunk.patch > Remove HtmlFormWrapper dependencies from Content Search screen > -- > > Key: OFBIZ-7572 > URL: https://issues.apache.org/jira/browse/OFBIZ-7572 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7572_trunk.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7571) Remove HtmlFormWrapper dependencies from Product Config Item Content screen
[ https://issues.apache.org/jira/browse/OFBIZ-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7571: -- Description: Location: 1) Log on to Catalog component. 2) Go to Configurations screen. 3) Find any config item and go to the detail of page of that config item. 4) Go to Content page. 5) This is the screen where HtmlFormWrapper is used. > Remove HtmlFormWrapper dependencies from Product Config Item Content screen > --- > > Key: OFBIZ-7571 > URL: https://issues.apache.org/jira/browse/OFBIZ-7571 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7571_trunk.patch > > > Location: > 1) Log on to Catalog component. > 2) Go to Configurations screen. > 3) Find any config item and go to the detail of page of that config item. > 4) Go to Content page. > 5) This is the screen where HtmlFormWrapper is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7569) Remove HtmlFormWrapper dependencies from Calendar Exception Week screen
[ https://issues.apache.org/jira/browse/OFBIZ-7569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7569: -- Attachment: OFBIZ-7569_trunk.patch > Remove HtmlFormWrapper dependencies from Calendar Exception Week screen > --- > > Key: OFBIZ-7569 > URL: https://issues.apache.org/jira/browse/OFBIZ-7569 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7569_trunk.patch > > > Location: > 1) Log on to manufacturing component. > 2) Go to Calendar screen. From the listed calendar go to update any calendar. > 3) Now go to Exception Week screen where HtmlFormWrapper is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7568) Remove HtmlFormWrapper dependencies from Calendar Exception Day screen
[ https://issues.apache.org/jira/browse/OFBIZ-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7568: -- Attachment: OFBIZ-7568_trunk.patch > Remove HtmlFormWrapper dependencies from Calendar Exception Day screen > -- > > Key: OFBIZ-7568 > URL: https://issues.apache.org/jira/browse/OFBIZ-7568 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7568_trunk.patch > > > Location: > 1) Log on to manufacturing component. > 2) Go to Calendar screen. From the listed calendar go to update any calendar. > 3) Now go to Exception Day screen where HtmlFormWrapper is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7568) Remove HtmlFormWrapper dependencies from Calendar Exception Day screen
[ https://issues.apache.org/jira/browse/OFBIZ-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7568: -- Description: Location: 1) Log on to manufacturing component. 2) Go to Calendar screen. From the listed calendar go to update any calendar. 3) Now go to Exception Day screen where HtmlFormWrapper is used. > Remove HtmlFormWrapper dependencies from Calendar Exception Day screen > -- > > Key: OFBIZ-7568 > URL: https://issues.apache.org/jira/browse/OFBIZ-7568 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > > Location: > 1) Log on to manufacturing component. > 2) Go to Calendar screen. From the listed calendar go to update any calendar. > 3) Now go to Exception Day screen where HtmlFormWrapper is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7570) Remove HtmlFormWrapper dependencies from Order Delivery Schedule Info screen
[ https://issues.apache.org/jira/browse/OFBIZ-7570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7570: -- Attachment: OFBIZ-7570_trunk.patch > Remove HtmlFormWrapper dependencies from Order Delivery Schedule Info screen > > > Key: OFBIZ-7570 > URL: https://issues.apache.org/jira/browse/OFBIZ-7570 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7570_trunk.patch > > > Location: > 1) Log on to order component. > 2) Go to Order List screen and then order detail page. > 3) On order detail page, under the section "Actions", click on View/Edit > Delivery Schedule Info. > 4) This is the screen where HtmlFormWrapper is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7570) Remove HtmlFormWrapper dependencies from Order Delivery Schedule Info screen
[ https://issues.apache.org/jira/browse/OFBIZ-7570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7570: -- Description: Location: 1) Log on to order component. 2) Go to Order List screen and then order detail page. 3) On order detail page, under the section "Actions", click on View/Edit Delivery Schedule Info. 4) This is the screen where HtmlFormWrapper is used. > Remove HtmlFormWrapper dependencies from Order Delivery Schedule Info screen > > > Key: OFBIZ-7570 > URL: https://issues.apache.org/jira/browse/OFBIZ-7570 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7570_trunk.patch > > > Location: > 1) Log on to order component. > 2) Go to Order List screen and then order detail page. > 3) On order detail page, under the section "Actions", click on View/Edit > Delivery Schedule Info. > 4) This is the screen where HtmlFormWrapper is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7569) Remove HtmlFormWrapper dependencies from Calendar Exception Week screen
[ https://issues.apache.org/jira/browse/OFBIZ-7569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7569: -- Description: Location: 1) Log on to manufacturing component. 2) Go to Calendar screen. From the listed calendar go to update any calendar. 3) Now go to Exception Week screen where HtmlFormWrapper is used. > Remove HtmlFormWrapper dependencies from Calendar Exception Week screen > --- > > Key: OFBIZ-7569 > URL: https://issues.apache.org/jira/browse/OFBIZ-7569 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > > Location: > 1) Log on to manufacturing component. > 2) Go to Calendar screen. From the listed calendar go to update any calendar. > 3) Now go to Exception Week screen where HtmlFormWrapper is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices
[ https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346561#comment-15346561 ] Swapnil M Mane commented on OFBIZ-7311: --- Thanks [~wt], [~pfm.smits] and [~pranaypa] for the discussion. I will have the look into the remaining references of maincss.css and mainrtl.css in source code and will update them accordingly. > Formatting and renaming of the CSS files as per best practices > -- > > Key: OFBIZ-7311 > URL: https://issues.apache.org/jira/browse/OFBIZ-7311 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Swapnil M Mane >Assignee: Pranay Pandey >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7311-bizznesstime.patch, > OFBIZ-7311-bluelight.patch, OFBIZ-7311-droppingcrumbs.patch, > OFBIZ-7311-flatgrey.patch, OFBIZ-7311-multiflex.patch, > OFBIZ-7311-rainbowstone.patch, OFBIZ-7311-renamed-maincss-to-style.patch, > OFBIZ-7311-tomahawk.patch > > > In CSS files, we are having various inconsistency in the formatting of the > code for e.g. we have following types of code formatting > // No space > {code} > ul#preferences-menu a:hover { > text-decoration: none; > } > {code} > // Space of 2 > {code} > div.autocomplete ul { > list-style-type:none; > margin:0; > padding:0; > } > {code} > // Space of 4 > {code} > .control-area a { > font-size: 1.1em; > color: #5CA3D7; > } > {code} > For better readability we should format the existing files with space of 4. > Also for some theme, we named CSS files as *maincss.css* and for some, we > named it as *style.css*. We can rename these file as per best practices for > consistency. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7567) Remove HtmlFormWrapper dependencies from Production Run Cost screen
[ https://issues.apache.org/jira/browse/OFBIZ-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7567: -- Description: Location: 1) Log on to manufacturing component. 2) Under JobShop screen, search any production run and go to the detail page. 3) Here Actual Cost screen using HtmlFormWrapper. > Remove HtmlFormWrapper dependencies from Production Run Cost screen > --- > > Key: OFBIZ-7567 > URL: https://issues.apache.org/jira/browse/OFBIZ-7567 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7567_trunk.patch > > > Location: > 1) Log on to manufacturing component. > 2) Under JobShop screen, search any production run and go to the detail page. > 3) Here Actual Cost screen using HtmlFormWrapper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7567) Remove HtmlFormWrapper dependencies from Production Run Cost screen
[ https://issues.apache.org/jira/browse/OFBIZ-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7567: -- Attachment: OFBIZ-7567_trunk.patch > Remove HtmlFormWrapper dependencies from Production Run Cost screen > --- > > Key: OFBIZ-7567 > URL: https://issues.apache.org/jira/browse/OFBIZ-7567 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7567_trunk.patch > > > Location: > 1) Log on to manufacturing component. > 2) Under JobShop screen, search any production run and go to the detail page. > 3) Here Actual Cost screen using HtmlFormWrapper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7311) Formatting and renaming of the CSS files as per best practices
[ https://issues.apache.org/jira/browse/OFBIZ-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346554#comment-15346554 ] Swapnil M Mane commented on OFBIZ-7311: --- Thanks so much [~pandeypranay] :-) > Formatting and renaming of the CSS files as per best practices > -- > > Key: OFBIZ-7311 > URL: https://issues.apache.org/jira/browse/OFBIZ-7311 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Swapnil M Mane >Assignee: Pranay Pandey >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7311-bizznesstime.patch, > OFBIZ-7311-bluelight.patch, OFBIZ-7311-droppingcrumbs.patch, > OFBIZ-7311-flatgrey.patch, OFBIZ-7311-multiflex.patch, > OFBIZ-7311-rainbowstone.patch, OFBIZ-7311-renamed-maincss-to-style.patch, > OFBIZ-7311-tomahawk.patch > > > In CSS files, we are having various inconsistency in the formatting of the > code for e.g. we have following types of code formatting > // No space > {code} > ul#preferences-menu a:hover { > text-decoration: none; > } > {code} > // Space of 2 > {code} > div.autocomplete ul { > list-style-type:none; > margin:0; > padding:0; > } > {code} > // Space of 4 > {code} > .control-area a { > font-size: 1.1em; > color: #5CA3D7; > } > {code} > For better readability we should format the existing files with space of 4. > Also for some theme, we named CSS files as *maincss.css* and for some, we > named it as *style.css*. We can rename these file as per best practices for > consistency. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7565) Remove HtmlFormWrapper dependencies from Survey Question Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7565: -- Description: Location: 1) Log on to content component. 2) Go to Survey screen. 3) Find any survey and go to the detail page of that survey. 4) Go to Questions screen. 5) This is the screen where various form are used using HtmlFormWrapper. was: Location: 1) Log on to content component. 2) > Remove HtmlFormWrapper dependencies from Survey Question Screen > --- > > Key: OFBIZ-7565 > URL: https://issues.apache.org/jira/browse/OFBIZ-7565 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > > Location: > 1) Log on to content component. > 2) Go to Survey screen. > 3) Find any survey and go to the detail page of that survey. > 4) Go to Questions screen. > 5) This is the screen where various form are used using HtmlFormWrapper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7575) Styling is not applied on Logs in LogView screen
[ https://issues.apache.org/jira/browse/OFBIZ-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-7575: -- Attachment: OFBIZ-7575-after.png OFBIZ-7575-before.png OFBIZ-7575.patch Attaching the patch, as per updated code, * INFO will be shown in Green color * WARNING will be in bold Blue color * ERROR will be in Red color along with border * DEBUG will be in Grey color Please refer attached screenshots for more details. > Styling is not applied on Logs in LogView screen > > > Key: OFBIZ-7575 > URL: https://issues.apache.org/jira/browse/OFBIZ-7575 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Swapnil M Mane >Assignee: Pranay Pandey > Attachments: OFBIZ-7575-after.png, OFBIZ-7575-before.png, > OFBIZ-7575.patch > > > In LogView screen (https://localhost:8443/webtools/control/LogView) the > styling on logs should be applied on the basis of its type. > for e.g. the error should be shown in red, the warning should be in blue etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7565) Remove HtmlFormWrapper dependencies from Survey Question Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7565: -- Attachment: OFBIZ-7565_trunk.patch > Remove HtmlFormWrapper dependencies from Survey Question Screen > --- > > Key: OFBIZ-7565 > URL: https://issues.apache.org/jira/browse/OFBIZ-7565 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > Attachments: OFBIZ-7565_trunk.patch > > > Location: > 1) Log on to content component. > 2) Go to Survey screen. > 3) Find any survey and go to the detail page of that survey. > 4) Go to Questions screen. > 5) This is the screen where various forms are used using HtmlFormWrapper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7565) Remove HtmlFormWrapper dependencies from Survey Question Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7565: -- Description: Location: 1) Log on to content component. 2) Go to Survey screen. 3) Find any survey and go to the detail page of that survey. 4) Go to Questions screen. 5) This is the screen where various forms are used using HtmlFormWrapper. was: Location: 1) Log on to content component. 2) Go to Survey screen. 3) Find any survey and go to the detail page of that survey. 4) Go to Questions screen. 5) This is the screen where various form are used using HtmlFormWrapper. > Remove HtmlFormWrapper dependencies from Survey Question Screen > --- > > Key: OFBIZ-7565 > URL: https://issues.apache.org/jira/browse/OFBIZ-7565 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > > Location: > 1) Log on to content component. > 2) Go to Survey screen. > 3) Find any survey and go to the detail page of that survey. > 4) Go to Questions screen. > 5) This is the screen where various forms are used using HtmlFormWrapper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7575) Styling is not applied on Logs in LogView screen
[ https://issues.apache.org/jira/browse/OFBIZ-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey reassigned OFBIZ-7575: Assignee: Pranay Pandey (was: Swapnil M Mane) > Styling is not applied on Logs in LogView screen > > > Key: OFBIZ-7575 > URL: https://issues.apache.org/jira/browse/OFBIZ-7575 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Swapnil M Mane >Assignee: Pranay Pandey > > In LogView screen (https://localhost:8443/webtools/control/LogView) the > styling on logs should be applied on the basis of its type. > for e.g. the error should be shown in red, the warning should be in blue etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7572) Remove HtmlFormWrapper dependencies from Content Search screen
Ravi Lodhi created OFBIZ-7572: - Summary: Remove HtmlFormWrapper dependencies from Content Search screen Key: OFBIZ-7572 URL: https://issues.apache.org/jira/browse/OFBIZ-7572 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7565) Remove HtmlFormWrapper dependencies from Survey Question Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-7565: -- Description: Location: 1) Log on to content component. 2) > Remove HtmlFormWrapper dependencies from Survey Question Screen > --- > > Key: OFBIZ-7565 > URL: https://issues.apache.org/jira/browse/OFBIZ-7565 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi > > Location: > 1) Log on to content component. > 2) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7333) Correct location of New Requirement button on Requirements view
[ https://issues.apache.org/jira/browse/OFBIZ-7333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346537#comment-15346537 ] Pranay Pandey commented on OFBIZ-7333: -- Hi [~vaibhav.jain], Thanks for providing the patch for fixing the issue. One way it's fixing the UI issue reported in this ticket but not looking convincing as it is violating the concept of the decorator. One common UI element amongst 4 screens is being removed from decorator and moved to all these 4 screens individually. > Correct location of New Requirement button on Requirements view > --- > > Key: OFBIZ-7333 > URL: https://issues.apache.org/jira/browse/OFBIZ-7333 > Project: OFBiz > Issue Type: Improvement > Components: order >Reporter: Vaibhav Jain >Assignee: Pranay Pandey >Priority: Minor > Attachments: OFBIZ-7333.patch, after.png, before.png > > > Steps to regenerate the issue: > 1. Go to order manager. > 2. Go to sub-menu "Requirements" > 3. Find Requirements view is having New Requirement button placed at wrong > position. > Please refer screenshots for more detail. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7571) Remove HtmlFormWrapper dependencies from Product Config Item Content screen
Ravi Lodhi created OFBIZ-7571: - Summary: Remove HtmlFormWrapper dependencies from Product Config Item Content screen Key: OFBIZ-7571 URL: https://issues.apache.org/jira/browse/OFBIZ-7571 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7575) Styling is not applied on Logs in LogView screen
Swapnil M Mane created OFBIZ-7575: - Summary: Styling is not applied on Logs in LogView screen Key: OFBIZ-7575 URL: https://issues.apache.org/jira/browse/OFBIZ-7575 Project: OFBiz Issue Type: Bug Components: framework/webtools Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12, Release Branch 13.07 Reporter: Swapnil M Mane Assignee: Swapnil M Mane In LogView screen (https://localhost:8443/webtools/control/LogView) the styling on logs should be applied on the basis of its type. for e.g. the error should be shown in red, the warning should be in blue etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7574) Remove HtmlFormWrapper Class after removing all its dependencies
Ravi Lodhi created OFBIZ-7574: - Summary: Remove HtmlFormWrapper Class after removing all its dependencies Key: OFBIZ-7574 URL: https://issues.apache.org/jira/browse/OFBIZ-7574 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7573) Remove unused import related to HtmlFormWrapper and unused file using it
Ravi Lodhi created OFBIZ-7573: - Summary: Remove unused import related to HtmlFormWrapper and unused file using it Key: OFBIZ-7573 URL: https://issues.apache.org/jira/browse/OFBIZ-7573 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7570) Remove HtmlFormWrapper dependencies from Order Delivery Schedule Info screen
Ravi Lodhi created OFBIZ-7570: - Summary: Remove HtmlFormWrapper dependencies from Order Delivery Schedule Info screen Key: OFBIZ-7570 URL: https://issues.apache.org/jira/browse/OFBIZ-7570 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7569) Remove HtmlFormWrapper dependencies from Calendar Exception Week screen
Ravi Lodhi created OFBIZ-7569: - Summary: Remove HtmlFormWrapper dependencies from Calendar Exception Week screen Key: OFBIZ-7569 URL: https://issues.apache.org/jira/browse/OFBIZ-7569 Project: OFBiz Issue Type: Sub-task Components: manufacturing Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7568) Remove HtmlFormWrapper dependencies from Calendar Exception Day screen
Ravi Lodhi created OFBIZ-7568: - Summary: Remove HtmlFormWrapper dependencies from Calendar Exception Day screen Key: OFBIZ-7568 URL: https://issues.apache.org/jira/browse/OFBIZ-7568 Project: OFBiz Issue Type: Sub-task Components: manufacturing Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Use of utility method for checking null GenericValue
Thanks everyone for your valuable inputs on it. I'll create logical sub tickets to establish this practice in OFBiz. Regards, Ratnesh Upadhyay HotWax Systems | www.hotwaxsystems.com On Mon, Jun 20, 2016 at 3:04 PM, Scott Graywrote: > +1, good idea thanks Ratnesh > > Regards > Scott > > On 18 June 2016 at 02:30, Ratnesh Upadhyay > wrote: > > > Hello community, > > > > There are lots of places in code where we have used > > UtilValidate.isNotEmpty() or UtilValidate.isEmpty() for GenericValue > object > > . GenericValue is never empty. Its always null or not null. So should we > > use directly null or not null check instead of UtilValidate.isNotEmpty() > > and UtilValidate.isEmpty() for GenericValue objects ? > > > > Basically these validation methods should preferably be used on Strings > or > > Lists and normal Maps. > > > > Thanks!! > > > > Regards, > > Ratnesh Upadhyay > > HotWax Systems | www.hotwaxsystems.com > > >
[jira] [Created] (OFBIZ-7567) Remove HtmlFormWrapper dependencies from Production Run Cost screen
Ravi Lodhi created OFBIZ-7567: - Summary: Remove HtmlFormWrapper dependencies from Production Run Cost screen Key: OFBIZ-7567 URL: https://issues.apache.org/jira/browse/OFBIZ-7567 Project: OFBiz Issue Type: Sub-task Components: manufacturing Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7566) Remove HtmlFormWrapper dependencies from Production Run Screen
Ravi Lodhi created OFBIZ-7566: - Summary: Remove HtmlFormWrapper dependencies from Production Run Screen Key: OFBIZ-7566 URL: https://issues.apache.org/jira/browse/OFBIZ-7566 Project: OFBiz Issue Type: Sub-task Components: manufacturing Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7565) Remove HtmlFormWrapper dependencies from Survey Question Screen
Ravi Lodhi created OFBIZ-7565: - Summary: Remove HtmlFormWrapper dependencies from Survey Question Screen Key: OFBIZ-7565 URL: https://issues.apache.org/jira/browse/OFBIZ-7565 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7383) Enforce noninstantiability to ContentManagementWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-7383. --- Resolution: Fixed Fix Version/s: Upcoming Branch Committed changes in trunk at rev: 1749896 Thanks [~rishisolankii] and [~anurag.chan...@hotwaxsystems.com] for your contribution. > Enforce noninstantiability to ContentManagementWorker class > --- > > Key: OFBIZ-7383 > URL: https://issues.apache.org/jira/browse/OFBIZ-7383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7383.patch > > > - Make class as final. > - Add a private constructor. > - Make the following public static variables as private > {code} > public static MapcachedWebSitePublishPoints = new > HashMap (); > public static Map > cachedStaticValues = new > HashMap >(); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7564) Remove HtmlFormWrapper(depricated) and its dependencies
Ravi Lodhi created OFBIZ-7564: - Summary: Remove HtmlFormWrapper(depricated) and its dependencies Key: OFBIZ-7564 URL: https://issues.apache.org/jira/browse/OFBIZ-7564 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi This is an umbrella task to remove all the dependencies related to depricated HtmlFormWrapper. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7383) Enforce noninstantiability to ContentManagementWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-7383: --- Assignee: Arun Patidar (was: Anurag Chandak) > Enforce noninstantiability to ContentManagementWorker class > --- > > Key: OFBIZ-7383 > URL: https://issues.apache.org/jira/browse/OFBIZ-7383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7383.patch > > > - Make class as final. > - Add a private constructor. > - Make the following public static variables as private > {code} > public static MapcachedWebSitePublishPoints = new > HashMap (); > public static Map > cachedStaticValues = new > HashMap >(); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7382) Enforce noninstantiability to UtilAccounting Class
[ https://issues.apache.org/jira/browse/OFBIZ-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-7382. --- Resolution: Fixed Fix Version/s: Upcoming Branch Committed changes in trunk at rev: 1749895 Thanks [~rishisolankii] and [~aman.mishra] for your contribution. > Enforce noninstantiability to UtilAccounting Class > -- > > Key: OFBIZ-7382 > URL: https://issues.apache.org/jira/browse/OFBIZ-7382 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar > Fix For: Upcoming Branch > > Attachments: OFBIZ-7382.patch > > > - Make class as final. > - Add a private constructor. > - Make the following public varialbles as final > {code} > public static String module = UtilAccounting.class.getName(); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7382) Enforce noninstantiability to UtilAccounting Class
[ https://issues.apache.org/jira/browse/OFBIZ-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-7382: --- Assignee: Arun Patidar > Enforce noninstantiability to UtilAccounting Class > -- > > Key: OFBIZ-7382 > URL: https://issues.apache.org/jira/browse/OFBIZ-7382 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar > Attachments: OFBIZ-7382.patch > > > - Make class as final. > - Add a private constructor. > - Make the following public varialbles as final > {code} > public static String module = UtilAccounting.class.getName(); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-7380) Enforce noninstantiability to SagePayUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-7380. --- Resolution: Fixed Fix Version/s: Upcoming Branch Committed changes in trunk at rev: 1749894 Thanks [~rishisolankii] and [~chinmay.patidar] for your contribution. > Enforce noninstantiability to SagePayUtil class > --- > > Key: OFBIZ-7380 > URL: https://issues.apache.org/jira/browse/OFBIZ-7380 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7380.patch > > > - Make class as final. > - Add a private constructor. > No variables exists in the class so nothing to change here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7379) Enforce noninstantiability to PaymentWorker class
[ https://issues.apache.org/jira/browse/OFBIZ-7379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-7379: --- Assignee: Arun Patidar > Enforce noninstantiability to PaymentWorker class > - > > Key: OFBIZ-7379 > URL: https://issues.apache.org/jira/browse/OFBIZ-7379 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7379.patch > > > - Make class as final. > - Add a private constructor. > - Make the following private static variable as final. > {code} > private static int decimals = > UtilNumber.getBigDecimalScale("invoice.decimals"); > private static int rounding = > UtilNumber.getBigDecimalRoundingMode("invoice.rounding"); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7380) Enforce noninstantiability to SagePayUtil class
[ https://issues.apache.org/jira/browse/OFBIZ-7380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-7380: --- Assignee: Arun Patidar (was: Chinmay Patidar) > Enforce noninstantiability to SagePayUtil class > --- > > Key: OFBIZ-7380 > URL: https://issues.apache.org/jira/browse/OFBIZ-7380 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7380.patch > > > - Make class as final. > - Add a private constructor. > No variables exists in the class so nothing to change here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)