[jira] [Commented] (OFBIZ-7073) Add websocket support in OFBiz

[Pranay Pandey (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354606#comment-15354606
 ] 

Pranay Pandey commented on OFBIZ-7073:
--

+1, well done Amardeep, thanks for your contribution.

> Add websocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7073.patch, tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7263) Price rule created with product specific quantity condition not applied to the order when adding the product to cart with less quantity than mentioned in condition

[Aditi Patidar (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354602#comment-15354602
 ] 

Aditi Patidar commented on OFBIZ-7263:
--

Here are some findings on the issue:

"updatePrice" method of "ShoppingCartItem" class run service 
"calculateProductPrice" which in turn executes the methods to match the price 
rule conditions on the cart item and if the conditions meet it executes 
corresponding actions mentioned in the price rule. But in the "updatePrice" it 
checks for the following condition before running "calculateProductPrice":

{code}
 public void updatePrice(LocalDispatcher dispatcher, ShoppingCart cart) 
throws CartItemModifyException {
// set basePrice using the calculateProductPrice service
if (_product != null && isModifiedPrice == false) {
{code} 

When we update the item added to cart and recalculate the order it executes 
method "modifyCart" of "ShoppingCartHelper" class where this line of code gets 
executed:
{code}
if (item != null) {
item.setBasePrice(quantity); // this is quantity because the parsed number 
variable is the same as quantity
item.setDisplayPrice(quantity); // or the amount shown the cart items page 
won't be right
item.setIsModifiedPrice(true); // flag as a modified price
}   
{code}
 
Here "item.setIsModifiedPrice(true)" set the flag "isModifiedPrice" "true" and 
the condition mentioned in "updatePrice" become false and the 
"calculateProductPrice" not gets executed. When I comment out the line 

{code}
//item.setIsModifiedPrice(true);
{code}

It works as expected and price rule gets apply. I am not sure what the purpose 
of this line of code "item.setIsModifiedPrice(true)" inside "modifyCart" 
because it contradict the condition written in "updatePrice".

> Price rule created with product specific quantity condition not applied to 
> the order when adding the product to cart with less quantity than mentioned 
> in condition
> ---
>
> Key: OFBIZ-7263
> URL: https://issues.apache.org/jira/browse/OFBIZ-7263
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Aditi Patidar
>Assignee: Aditi Patidar
>
> Steps to regenerate the issue:
> 1. Create a price rule.
> 2. Add a condition, select input 'Quantity', operator 'Is' and add the value 
> '2' or any quantity more than 1.
> 3. Add an action, select action type 'Flat Amount Override'  and add it's 
> value.  
> 4. Create a sale order:
> i. Add product with quantity one to the order.
> ii. Update the quantity to 2 or to the value entered in condition for 
> quantity in price rule.
>iii. Recalculate the order.
> Expected result: Unit price should override to the amount added in action.
> Actual result: It's not getting overridden to the amount added in action.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7581) Party: Correct all the checkboxes and radio buttons in all the party FTLs.

[Mohammad Kathawala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala closed OFBIZ-7581.
-
Resolution: Not A Problem

It seems that we do not have anything to change in FTLs of party component.
So closing the ticket

> Party: Correct all the checkboxes and radio buttons in all the party FTLs.
> --
>
> Key: OFBIZ-7581
> URL: https://issues.apache.org/jira/browse/OFBIZ-7581
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7579) Marketing: Correct all the checkboxes and radio buttons in all the marketing FTLs.

[Mohammad Kathawala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala closed OFBIZ-7579.
-
Resolution: Not A Problem

> Marketing: Correct all the checkboxes and radio buttons in all the marketing 
> FTLs.
> --
>
> Key: OFBIZ-7579
> URL: https://issues.apache.org/jira/browse/OFBIZ-7579
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7579) Marketing: Correct all the checkboxes and radio buttons in all the marketing FTLs.

[Mohammad Kathawala (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354586#comment-15354586
 ] 

Mohammad Kathawala commented on OFBIZ-7579:
---

It seems that we do not have anything to change in the FTLs of marketing 
component.
So closing the ticket.

> Marketing: Correct all the checkboxes and radio buttons in all the marketing 
> FTLs.
> --
>
> Key: OFBIZ-7579
> URL: https://issues.apache.org/jira/browse/OFBIZ-7579
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7603) There should be a demo data set for the PartyStatus entity

[Suraj Khurana (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354547#comment-15354547
 ] 

Suraj Khurana commented on OFBIZ-7603:
--

I have checked and there are approx 150 parties in the system currently, 
created two child task for this ticket so that it will be easy from 
verification perspective. 

> There should be a demo data set for the PartyStatus entity
> --
>
> Key: OFBIZ-7603
> URL: https://issues.apache.org/jira/browse/OFBIZ-7603
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>
> Currently there is no demo data for the PartyStatus entity. This complicates 
> tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7673) Create demo PartyStatus data for existing parties for applications component

[Suraj Khurana (JIRA)]

Suraj Khurana created OFBIZ-7673:


 Summary: Create demo PartyStatus data for existing parties for 
applications component
 Key: OFBIZ-7673
 URL: https://issues.apache.org/jira/browse/OFBIZ-7673
 Project: OFBiz
  Issue Type: Sub-task
  Components: ALL APPLICATIONS
Reporter: Suraj Khurana
Assignee: Suraj Khurana






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7672) Create demo PartyStatus data for existing parties for special purpose component

[Suraj Khurana (JIRA)]

Suraj Khurana created OFBIZ-7672:


 Summary: Create demo PartyStatus data for existing parties for 
special purpose component
 Key: OFBIZ-7672
 URL: https://issues.apache.org/jira/browse/OFBIZ-7672
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/ebaystore, specialpurpose/ecommerce, 
specialpurpose/projectmgr, specialpurpose/scrum, specialpurpose/webpos
Reporter: Suraj Khurana
Assignee: Suraj Khurana






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7671) SpecialPurpose/googlebase: Correct all the checkboxes and radio buttons in all the googlebase FTLs.

[Mohammad Kathawala (JIRA)]

Mohammad Kathawala created OFBIZ-7671:
-

 Summary: SpecialPurpose/googlebase: Correct all the checkboxes and 
radio buttons in all the googlebase FTLs.
 Key: OFBIZ-7671
 URL: https://issues.apache.org/jira/browse/OFBIZ-7671
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: Upcoming Branch
Reporter: Mohammad Kathawala
Assignee: Mohammad Kathawala
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7426) Enforce noninstantiability to SeoConfigUtil class

[Anurag Chandak (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354535#comment-15354535
 ] 

Anurag Chandak commented on OFBIZ-7426:
---

Thanks [~arunpati]!

> Enforce noninstantiability to SeoConfigUtil class
> -
>
> Key: OFBIZ-7426
> URL: https://issues.apache.org/jira/browse/OFBIZ-7426
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7426.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public variables as final
> {code}
> public static String module = UtilAccounting.class.getName();
> {code}
> - Make the following public static variables as private
> {code}
> public static final String DEFAULT_REGEXP = "^.*/.*$";
> public static final String ELEMENT_REGEXPIFMATCH = "regexpifmatch";
> public static final String ELEMENT_URL_CONFIG = "url-config";
> public static final String ELEMENT_DESCRIPTION = "description";
> public static final String ELEMENT_FORWARD = "forward";
> public static final String ELEMENT_SEO = "seo";
> public static final String ELEMENT_URLPATTERN = "url-pattern";
> public static final String ELEMENT_REPLACEMENT = "replacement";
> public static final String ELEMENT_RESPONSECODE = "responsecode";
> public static final String ELEMENT_JSESSIONID = "jsessionid";
> public static final String ELEMENT_ANONYMOUS = "anonymous";
> public static final String ELEMENT_VALUE = "value";
> public static final String ELEMENT_USER = "user";
> public static final String ELEMENT_EXCEPTIONS = "exceptions";
> public static final String ELEMENT_CHAR_FILTERS = "char-filters";
> public static final String ELEMENT_CHAR_FILTER = "char-filter";
> public static final String ELEMENT_CHARACTER_PATTERN = 
> "character-pattern";
> public static final String ELEMENT_CATEGORY_URL = "category-url";
> public static final String ELEMENT_ALLOWED_CONTEXT_PATHS = 
> "allowed-context-paths";
> public static final String ELEMENT_CATEGORY_NAME = "category-name";
> public static final String ELEMENT_CATEGORY_URL_SUFFIX = 
> "category-url-suffix";
> public static final String SEO_CONFIG_FILENAME = "SeoConfig.xml";
> public static final int DEFAULT_RESPONSECODE = 
> HttpServletResponse.SC_MOVED_PERMANENTLY;
> public static final String DEFAULT_ANONYMOUS_VALUE = "disable";
> public static final String DEFAULT_USER_VALUE = "disable";
> public static final String DEFAULT_CATEGORY_URL_VALUE = "enable";
> public static final String DEFAULT_CATEGORY_NAME_VALUE = "disable";
> public static final String ALLOWED_CONTEXT_PATHS_SEPERATOR = ":";
> {code}
> - Also add getDefaultResponseCode() method for following variable after 
> making it private and use it in UrlRegexpTransform.java, 
> SeoContextFilter.java and UrlRegexpContextFilter.java
> {code}
> public static final int DEFAULT_RESPONSECODE = 
> HttpServletResponse.SC_MOVED_PERMANENTLY;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7460) Enforce noninstantiability to ProductStoreWorker class

[Anurag Chandak (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354534#comment-15354534
 ] 

Anurag Chandak commented on OFBIZ-7460:
---

Thanks [~arunpati]!

> Enforce noninstantiability to ProductStoreWorker class
> --
>
> Key: OFBIZ-7460
> URL: https://issues.apache.org/jira/browse/OFBIZ-7460
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7460.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following protected static variables as private and move it and 
> static block at the top of class.
> {code}
> protected static Map 
> defaultProductStoreEmailScreenLocation = new HashMap();
> static {
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CONFIRM", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_COMPLETE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderCompleteNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_BACKORDER", 
> "component://ecommerce/widget/EmailOrderScreens.xml#BackorderNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CHANGE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderChangeNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_PAYRETRY", 
> "component://ecommerce/widget/EmailOrderScreens.xml#PaymentRetryNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_ACCEPT", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnAccept");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_COMPLETE", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnComplete");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_CANCEL", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnCancel");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_PURCHASE", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardPurchase");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_RELOAD", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardReload");
> defaultProductStoreEmailScreenLocation.put("PRDS_QUO_CONFIRM", 
> "component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple");
> defaultProductStoreEmailScreenLocation.put("PRDS_PWD_RETRIEVE", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> defaultProductStoreEmailScreenLocation.put("PRDS_TELL_FRIEND", 
> "component://ecommerce/widget/EmailProductScreens.xml#TellFriend");
> defaultProductStoreEmailScreenLocation.put("PRDS_CUST_REGISTER", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> }
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7417) Enforce noninstantiability to TaskWorker class

[Anurag Chandak (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354537#comment-15354537
 ] 

Anurag Chandak commented on OFBIZ-7417:
---

Thanks [~arunpati]!

> Enforce noninstantiability to TaskWorker class
> --
>
> Key: OFBIZ-7417
> URL: https://issues.apache.org/jira/browse/OFBIZ-7417
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7417.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static variable as  private static final. And move the 
> variable at top of the class.
> {code}
> static Map statusMapping
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7670) SpecialPurpose/ecommerce: Correct all the checkboxes and radio buttons in all the ecommerce FTLs.

[Mohammad Kathawala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala reassigned OFBIZ-7670:
-

Assignee: Mohammad Kathawala

> SpecialPurpose/ecommerce: Correct all the checkboxes and radio buttons in all 
> the ecommerce FTLs.
> -
>
> Key: OFBIZ-7670
> URL: https://issues.apache.org/jira/browse/OFBIZ-7670
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7669) SpecialPurpose/ebaystore: Correct all the checkboxes and radio buttons in all the ebaystore FTLs.

[Mohammad Kathawala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala reassigned OFBIZ-7669:
-

Assignee: Mohammad Kathawala

> SpecialPurpose/ebaystore: Correct all the checkboxes and radio buttons in all 
> the ebaystore FTLs.
> -
>
> Key: OFBIZ-7669
> URL: https://issues.apache.org/jira/browse/OFBIZ-7669
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7670) SpecialPurpose/ecommerce: Correct all the checkboxes and radio buttons in all the ecommerce FTLs.

[Mohammad Kathawala (JIRA)]

Mohammad Kathawala created OFBIZ-7670:
-

 Summary: SpecialPurpose/ecommerce: Correct all the checkboxes and 
radio buttons in all the ecommerce FTLs.
 Key: OFBIZ-7670
 URL: https://issues.apache.org/jira/browse/OFBIZ-7670
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: Upcoming Branch
Reporter: Mohammad Kathawala
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7668) SpecialPurpose/ebay: Correct all the checkboxes and radio buttons in all the ebay FTLs.

[Mohammad Kathawala (JIRA)]

Mohammad Kathawala created OFBIZ-7668:
-

 Summary: SpecialPurpose/ebay: Correct all the checkboxes and radio 
buttons in all the ebay FTLs.
 Key: OFBIZ-7668
 URL: https://issues.apache.org/jira/browse/OFBIZ-7668
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: Upcoming Branch
Reporter: Mohammad Kathawala
Assignee: Mohammad Kathawala
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7661) Create Menu inconsistent in decorators throughout the application

[Avnindra Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Avnindra Sharma updated OFBIZ-7661:
---
Summary: Create Menu inconsistent in decorators throughout the application  
(was: Create Menu inconsistent in decorators throughout the application (All 
component))

> Create Menu inconsistent in decorators throughout the application
> -
>
> Key: OFBIZ-7661
> URL: https://issues.apache.org/jira/browse/OFBIZ-7661
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Avnindra Sharma
> Fix For: Trunk
>
>
> Create Menu is inconsistent throughout the application.
> When we navigate to any component, Create Menu button is not consistent. The 
> button should be accessible via any sub menu.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7667) Webtools: Correct all the checkboxes and radio buttons in all the webtools FTLs.

[Mohammad Kathawala (JIRA)]

Mohammad Kathawala created OFBIZ-7667:
-

 Summary: Webtools: Correct all the checkboxes and radio buttons in 
all the webtools FTLs.
 Key: OFBIZ-7667
 URL: https://issues.apache.org/jira/browse/OFBIZ-7667
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: Upcoming Branch
Reporter: Mohammad Kathawala
Assignee: Mohammad Kathawala
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7667) Framework/Webtools: Correct all the checkboxes and radio buttons in all the webtools FTLs.

[Mohammad Kathawala (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala updated OFBIZ-7667:
--
Summary: Framework/Webtools: Correct all the checkboxes and radio buttons 
in all the webtools FTLs.  (was: Webtools: Correct all the checkboxes and radio 
buttons in all the webtools FTLs.)

> Framework/Webtools: Correct all the checkboxes and radio buttons in all the 
> webtools FTLs.
> --
>
> Key: OFBIZ-7667
> URL: https://issues.apache.org/jira/browse/OFBIZ-7667
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Mohammad Kathawala
>Assignee: Mohammad Kathawala
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6986) Simplify getChildHRCategoryTree

[Kulwant (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354494#comment-15354494
 ] 

Kulwant commented on OFBIZ-6986:


Hi All,

I apologise for not responding. 
I am quite occupied by work from my employer.

Thanks

> Simplify getChildHRCategoryTree
> ---
>
> Key: OFBIZ-6986
> URL: https://issues.apache.org/jira/browse/OFBIZ-6986
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, humanres
>Reporter: Kulwant
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6986.patch, OFBIZ-6986.patch, OFBIZ-6986.patch
>
>
> breaking the single long method to multiple private functions with improved 
> exception handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7266) Auto-complete on lookup field should be able to support filter by date.

[Kongrath Suankaewmanee (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354474#comment-15354474
 ] 

Kongrath Suankaewmanee commented on OFBIZ-7266:
---

Yes, I agree with the new code update.

> Auto-complete on lookup field should be able to support filter by date.
> ---
>
> Key: OFBIZ-7266
> URL: https://issues.apache.org/jira/browse/OFBIZ-7266
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-7266-NMA.patch, OFBIZ-7266-NMA.patch, 
> OFBIZ-7266.patch
>
>
> Hi,
> For the general reason, if the lookup popup (like as performFind service 
> work) able to filter the result from date. so, in the auto complete for 
> lookup filed should be also able too.
> Simple :
> add this tag in action tag before call LookupDecorator
> and filter on field "fromDate", "thruDate" as default.
> {code:xml}
> 
> {code}
> Advance :
> you can customize "fromDate" and "thruDate" field names by do follow below
> {code:xml}
> 
> 
> 
> {code}
> Best Regards,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7385) Allow user to select multiple options in "Sales By Store" report from basic search criteria while generating report

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353801#comment-15353801
 ] 

Jacques Le Roux commented on OFBIZ-7385:


Should this not be reopened?

> Allow user to select multiple options in "Sales By Store" report from basic 
> search criteria while generating report
> ---
>
> Key: OFBIZ-7385
> URL: https://issues.apache.org/jira/browse/OFBIZ-7385
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Swapnil Shah
>Assignee: Mohammad Kathawala
> Attachments: OFBIZ-7385.patch, Salebystore.png
>
>
> Currently system allow user to select any specific search criteria link and 
> hence report is generated only based on any one given selected criteria. 
> We can add the feature for generating single report based on multiple values 
> (possibly via checkbox?) within basic search criteria in this report namely:
> 1) Product Store
> 2) Order Status
> and show the results based on all the selected values. Please refer attached 
> screenshot



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7617) Add "changeByUserLoginId" field for InvoiceStatus

[Nicolas Malin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-7617:


Assignee: Nicolas Malin

> Add "changeByUserLoginId" field for InvoiceStatus
> -
>
> Key: OFBIZ-7617
> URL: https://issues.apache.org/jira/browse/OFBIZ-7617
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Nicolas Malin
> Attachments: OFBIZ-7617.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7618) Add "changeByUserLoginId" field for ShipmentStatus

[Nicolas Malin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-7618:


Assignee: Nicolas Malin

> Add "changeByUserLoginId" field for ShipmentStatus
> --
>
> Key: OFBIZ-7618
> URL: https://issues.apache.org/jira/browse/OFBIZ-7618
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Nicolas Malin
> Attachments: OFBIZ-7618.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7616) Add "changeByUserLoginId" field for PartyStatus

[Nicolas Malin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-7616:


Assignee: Nicolas Malin

> Add "changeByUserLoginId" field for PartyStatus
> ---
>
> Key: OFBIZ-7616
> URL: https://issues.apache.org/jira/browse/OFBIZ-7616
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Nicolas Malin
> Attachments: OFBIZ-7616.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7266) Auto-complete on lookup field should be able to support filter by date.

[Nicolas Malin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-7266:
-
Attachment: OFBIZ-7266-NMA.patch

Ok I review the patch and do some test.

I have a second proposal with these changes :
 * We check only if conditionDates is present on context
 ** if yes analyse from/thruDateName and the date value
 ** if both from/thruDateName are empty, use default fromDate, thruDate
 
Advantage : 
 * quick to activate by default the filter
 * possibility to realize a filter only on the fromDateName (or thruDateName)

example : 
default with fromDate thruDate
{code}
 
{code}
only on salesDiscontinuationDate
{code}

{code}

only on fromDate
{code}

{code}

What do you thinks about this last version ?

> Auto-complete on lookup field should be able to support filter by date.
> ---
>
> Key: OFBIZ-7266
> URL: https://issues.apache.org/jira/browse/OFBIZ-7266
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-7266-NMA.patch, OFBIZ-7266-NMA.patch, 
> OFBIZ-7266.patch
>
>
> Hi,
> For the general reason, if the lookup popup (like as performFind service 
> work) able to filter the result from date. so, in the auto complete for 
> lookup filed should be also able too.
> Simple :
> add this tag in action tag before call LookupDecorator
> and filter on field "fromDate", "thruDate" as default.
> {code:xml}
> 
> {code}
> Advance :
> you can customize "fromDate" and "thruDate" field names by do follow below
> {code:xml}
> 
> 
> 
> {code}
> Best Regards,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7350) Manage filters in lookup auto completion

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353546#comment-15353546
 ] 

Jacques Le Roux commented on OFBIZ-7350:


[~pfm.smits] proposed to not release 14.12 and directly release 15.12. I think 
it makes some sense. So I'd wait before backporting ;)

> Manage filters in lookup auto completion
> 
>
> Key: OFBIZ-7350
> URL: https://issues.apache.org/jira/browse/OFBIZ-7350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Charles STELTZLEN
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 15.12.01
>
> Attachments: OFBIZ-7350.13.07.patch, OFBIZ-7350.patch
>
>
> On form lookup, we can specify target parameters to pass them to the lookup 
> screen and do filtered searches with these parameters. It works fine when you 
> click on lookup button. But when you start to write something in lookup 
> input, these parameters are not passed to the ajax auto-complete system. So, 
> the results are not filtered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7073) Add websocket support in OFBiz

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353536#comment-15353536
 ] 

Jacques Le Roux commented on OFBIZ-7073:


I trust you will not forget OFBIZ-7538 ;)

> Add websocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7073.patch, tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7073) Add websocket support in OFBiz

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353531#comment-15353531
 ] 

Jacques Le Roux commented on OFBIZ-7073:


Thanks again Amardeep Singh Jhajj, this is a very good example of a 
collaborative work done on a not so trivial issue!

> Add websocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7073.patch, tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7483) Do end to end verification of WebSocket Example- Push Notifications

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7483.
--
   Resolution: Done
Fix Version/s: Upcoming Branch

> Do end to end verification of WebSocket Example- Push Notifications
> ---
>
> Key: OFBIZ-7483
> URL: https://issues.apache.org/jira/browse/OFBIZ-7483
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/example
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7483-Screen-Shot.png
>
>
> This is task to verify the WebSocket Example- Push Notifications provided 
> over OFBIZ-7467



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7467) WebSocket Example - Push Notifications

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7467.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch

Thanks Amardeep Singh Jhajj,

Your slightly modified patch is committed at revision: 1750557 with the patch 
for OFBIZ-7073

I committed the 2 patches at the same time because the changes in .classpath 
and the LICENSE files were in the OFBIZ-7467 example patch.

I also slightly modified the example patch in order to provide an example where 
no sync issues are possible by using a Collections.synchronizedSet for the 
javax.websocket.Session Set. I also used synchronized loops as it's requested 
for synchronizedSet where it's used. I know it rather symbolic in the example 
component but it will remember developers about the possible sync issue.

> WebSocket Example - Push Notifications
> --
>
> Key: OFBIZ-7467
> URL: https://issues.apache.org/jira/browse/OFBIZ-7467
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/example
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7467.patch, OFBIZ-7483-Screen-Shot.png
>
>
> This is a ticket for adding working example (in example application) of 
> WebSocket support that has been done in OFBIZ-7073



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7073) Add websocket support in OFBiz

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7073.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch

Thanks Amardeep Singh Jhajj,

Your patch and the slightly modified OFBIZ-7467 patch are committed at 
revision: 1750557 

I committed the 2 patches at the same time because the changes in .classpath 
and the LICENSE files were in the OFBIZ-7467 example patch.

I also slightly modified the example patch in order to provide an example where 
no sync issues are possible by using a Collections.synchronizedSet for the 
javax.websocket.Session Set. I also used synchronized loops as it's requested 
for synchronizedSet where it's used. I know it rather symbolic in the example 
component but it will remember developers about the possible sync issue.


> Add websocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7073.patch, tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7324) From facility location should be product based in stock move form.

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353519#comment-15353519
 ] 

Deepak Dixit commented on OFBIZ-7324:
-

I'll check this tomorrow and let you know my thoughts. 

> From facility location should be product based in stock move form.
> --
>
> Key: OFBIZ-7324
> URL: https://issues.apache.org/jira/browse/OFBIZ-7324
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Attachments: OFBIZ-7324_try.patch, OFBIZ-7324_tryV2.patch
>
>
> From facility location should be product based in stock move form.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7350) Manage filters in lookup auto completion

[Deepak Dixit (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-7350.
---
   Resolution: Resolved
Fix Version/s: 15.12.01

> Manage filters in lookup auto completion
> 
>
> Key: OFBIZ-7350
> URL: https://issues.apache.org/jira/browse/OFBIZ-7350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Charles STELTZLEN
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 15.12.01
>
> Attachments: OFBIZ-7350.13.07.patch, OFBIZ-7350.patch
>
>
> On form lookup, we can specify target parameters to pass them to the lookup 
> screen and do filtered searches with these parameters. It works fine when you 
> click on lookup button. But when you start to write something in lookup 
> input, these parameters are not passed to the ajax auto-complete system. So, 
> the results are not filtered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7350) Manage filters in lookup auto completion

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353515#comment-15353515
 ] 

Deepak Dixit commented on OFBIZ-7350:
-

I think this is nice improvement, and we can backport this to 14.12 as well.

> Manage filters in lookup auto completion
> 
>
> Key: OFBIZ-7350
> URL: https://issues.apache.org/jira/browse/OFBIZ-7350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Charles STELTZLEN
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 15.12.01
>
> Attachments: OFBIZ-7350.13.07.patch, OFBIZ-7350.patch
>
>
> On form lookup, we can specify target parameters to pass them to the lookup 
> screen and do filtered searches with these parameters. It works fine when you 
> click on lookup button. But when you start to write something in lookup 
> input, these parameters are not passed to the ajax auto-complete system. So, 
> the results are not filtered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7350) Manage filters in lookup auto completion

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353514#comment-15353514
 ] 

Deepak Dixit commented on OFBIZ-7350:
-

This has been committed at 
Trunk at r#1750555
15.12 at r#1750556
Thanks [~charles steltzlen] for your contribution

> Manage filters in lookup auto completion
> 
>
> Key: OFBIZ-7350
> URL: https://issues.apache.org/jira/browse/OFBIZ-7350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Charles STELTZLEN
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-7350.13.07.patch, OFBIZ-7350.patch
>
>
> On form lookup, we can specify target parameters to pass them to the lookup 
> screen and do filtered searches with these parameters. It works fine when you 
> click on lookup button. But when you start to write something in lookup 
> input, these parameters are not passed to the ajax auto-complete system. So, 
> the results are not filtered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7666) OFBIZ-7649: Display From date with default now() on all screens under Project Application

[Swapnil Shah (JIRA)]

Swapnil Shah created OFBIZ-7666:
---

 Summary: OFBIZ-7649: Display From date with default now() on all 
screens under Project Application
 Key: OFBIZ-7666
 URL: https://issues.apache.org/jira/browse/OFBIZ-7666
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: 14.12.01, 15.12.01
Reporter: Swapnil Shah
Assignee: Swapnil Shah


To begin with can start fixing it under
# 
https://ofbiz-vm.apache.org:8443/projectmgr/control/ListWorkEffortPartyAssigns?projectId=9000
# 
https://ofbiz-vm.apache.org:8443/projectmgr/control/EditTaskPartyAssigns?workEffortId=9106
# 
https://ofbiz-vm.apache.org:8443/projectmgr/control/EditWorkEffortSurveyAppls?workEffortId=9106
# 
https://ofbiz-vm.apache.org:8443/projectmgr/control/listResourcesProject?partyId=admin
# 
https://ofbiz-vm.apache.org:8443/projectmgr/control/listResourcesTask?partyId=admin




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7665) OFBIZ-7649: Display From date with default now() on all screens under Content Application

[Swapnil Shah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7665:

Description: 
To begin with can start fixing it under 
# 
https://ofbiz-vm.apache.org:8443/content/control/ListWebSiteContent?webSiteId=WebStore
# https://ofbiz-vm.apache.org:8443/content/control/createWebSiteContactList
# 
https://ofbiz-vm.apache.org:8443/content/control/findForums?forumGroupId=WebStoreFORUM
# 
https://ofbiz-vm.apache.org:8443/content/control/forumGroupRoles?forumGroupId=WebStoreFORUM
# 
https://ofbiz-vm.apache.org:8443/content/control/EditContentRole?contentId=BLOGROOTBIGAL
# 
https://ofbiz-vm.apache.org:8443/content/control/EditContentAssoc?contentId=BLOGROOTBIGAL
# 
https://ofbiz-vm.apache.org:8443/content/control/EditContentWorkEfforts?contentId=BLOGROOTBIGAL
# 
https://ofbiz-vm.apache.org:8443/content/control/EditDataResourceRole?dataResourceId=STDWRAP001
# https://ofbiz-vm.apache.org:8443/content/control/EditAddContenta

  was:
To begin with can start fixing it under 
# 
https://ofbiz-vm.apache.org:18443/content/control/ListWebSiteContent?webSiteId=WebStore
# https://ofbiz-vm.apache.org:18443/content/control/createWebSiteContactList
# 
https://ofbiz-vm.apache.org:18443/content/control/findForums?forumGroupId=WebStoreFORUM
# 
https://ofbiz-vm.apache.org:18443/content/control/forumGroupRoles?forumGroupId=WebStoreFORUM
# 
https://ofbiz-vm.apache.org:18443/content/control/EditContentRole?contentId=BLOGROOTBIGAL
# 
https://ofbiz-vm.apache.org:18443/content/control/EditContentAssoc?contentId=BLOGROOTBIGAL
# 
https://ofbiz-vm.apache.org:18443/content/control/EditContentWorkEfforts?contentId=BLOGROOTBIGAL
# 
https://ofbiz-vm.apache.org:18443/content/control/EditDataResourceRole?dataResourceId=STDWRAP001
# https://ofbiz-vm.apache.org:18443/content/control/EditAddContenta


> OFBIZ-7649: Display From date with default now() on all screens under Content 
> Application
> -
>
> Key: OFBIZ-7665
> URL: https://issues.apache.org/jira/browse/OFBIZ-7665
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>
> To begin with can start fixing it under 
> # 
> https://ofbiz-vm.apache.org:8443/content/control/ListWebSiteContent?webSiteId=WebStore
> # https://ofbiz-vm.apache.org:8443/content/control/createWebSiteContactList
> # 
> https://ofbiz-vm.apache.org:8443/content/control/findForums?forumGroupId=WebStoreFORUM
> # 
> https://ofbiz-vm.apache.org:8443/content/control/forumGroupRoles?forumGroupId=WebStoreFORUM
> # 
> https://ofbiz-vm.apache.org:8443/content/control/EditContentRole?contentId=BLOGROOTBIGAL
> # 
> https://ofbiz-vm.apache.org:8443/content/control/EditContentAssoc?contentId=BLOGROOTBIGAL
> # 
> https://ofbiz-vm.apache.org:8443/content/control/EditContentWorkEfforts?contentId=BLOGROOTBIGAL
> # 
> https://ofbiz-vm.apache.org:8443/content/control/EditDataResourceRole?dataResourceId=STDWRAP001
> # https://ofbiz-vm.apache.org:8443/content/control/EditAddContenta



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7665) OFBIZ-7649: Display From date with default now() on all screens under Content Application

[Swapnil Shah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7665:

Description: 
To begin with can start fixing it under 
# 
https://ofbiz-vm.apache.org:18443/content/control/ListWebSiteContent?webSiteId=WebStore
# https://ofbiz-vm.apache.org:18443/content/control/createWebSiteContactList
# 
https://ofbiz-vm.apache.org:18443/content/control/findForums?forumGroupId=WebStoreFORUM
# 
https://ofbiz-vm.apache.org:18443/content/control/forumGroupRoles?forumGroupId=WebStoreFORUM
# 
https://ofbiz-vm.apache.org:18443/content/control/EditContentRole?contentId=BLOGROOTBIGAL
# 
https://ofbiz-vm.apache.org:18443/content/control/EditContentAssoc?contentId=BLOGROOTBIGAL
# 
https://ofbiz-vm.apache.org:18443/content/control/EditContentWorkEfforts?contentId=BLOGROOTBIGAL
# 
https://ofbiz-vm.apache.org:18443/content/control/EditDataResourceRole?dataResourceId=STDWRAP001
# https://ofbiz-vm.apache.org:18443/content/control/EditAddContenta

  was:To begin with can start fixing it under 


> OFBIZ-7649: Display From date with default now() on all screens under Content 
> Application
> -
>
> Key: OFBIZ-7665
> URL: https://issues.apache.org/jira/browse/OFBIZ-7665
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>
> To begin with can start fixing it under 
> # 
> https://ofbiz-vm.apache.org:18443/content/control/ListWebSiteContent?webSiteId=WebStore
> # https://ofbiz-vm.apache.org:18443/content/control/createWebSiteContactList
> # 
> https://ofbiz-vm.apache.org:18443/content/control/findForums?forumGroupId=WebStoreFORUM
> # 
> https://ofbiz-vm.apache.org:18443/content/control/forumGroupRoles?forumGroupId=WebStoreFORUM
> # 
> https://ofbiz-vm.apache.org:18443/content/control/EditContentRole?contentId=BLOGROOTBIGAL
> # 
> https://ofbiz-vm.apache.org:18443/content/control/EditContentAssoc?contentId=BLOGROOTBIGAL
> # 
> https://ofbiz-vm.apache.org:18443/content/control/EditContentWorkEfforts?contentId=BLOGROOTBIGAL
> # 
> https://ofbiz-vm.apache.org:18443/content/control/EditDataResourceRole?dataResourceId=STDWRAP001
> # https://ofbiz-vm.apache.org:18443/content/control/EditAddContenta



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7665) OFBIZ-7649: Display From date with default now() on all screens under Content Application

[Swapnil Shah (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-7665:

Affects Version/s: 15.12.01
   14.12.01

> OFBIZ-7649: Display From date with default now() on all screens under Content 
> Application
> -
>
> Key: OFBIZ-7665
> URL: https://issues.apache.org/jira/browse/OFBIZ-7665
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>
> To begin with can start fixing it under 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7665) OFBIZ-7649: Display From date with default now() on all screens under Content Application

[Swapnil Shah (JIRA)]

Swapnil Shah created OFBIZ-7665:
---

 Summary: OFBIZ-7649: Display From date with default now() on all 
screens under Content Application
 Key: OFBIZ-7665
 URL: https://issues.apache.org/jira/browse/OFBIZ-7665
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Reporter: Swapnil Shah


To begin with can start fixing it under 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7618) Add "changeByUserLoginId" field for ShipmentStatus

[Nameet Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nameet Jain updated OFBIZ-7618:
---
Attachment: OFBIZ-7618.patch

> Add "changeByUserLoginId" field for ShipmentStatus
> --
>
> Key: OFBIZ-7618
> URL: https://issues.apache.org/jira/browse/OFBIZ-7618
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nameet Jain
> Attachments: OFBIZ-7618.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7617) Add "changeByUserLoginId" field for InvoiceStatus

[Nameet Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nameet Jain updated OFBIZ-7617:
---
Attachment: OFBIZ-7617.patch

> Add "changeByUserLoginId" field for InvoiceStatus
> -
>
> Key: OFBIZ-7617
> URL: https://issues.apache.org/jira/browse/OFBIZ-7617
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Nameet Jain
> Attachments: OFBIZ-7617.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7616) Add "changeByUserLoginId" field for PartyStatus

[Nameet Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nameet Jain updated OFBIZ-7616:
---
Attachment: OFBIZ-7616.patch

> Add "changeByUserLoginId" field for PartyStatus
> ---
>
> Key: OFBIZ-7616
> URL: https://issues.apache.org/jira/browse/OFBIZ-7616
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Nameet Jain
> Attachments: OFBIZ-7616.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: OFBiz Increased Activity

[Pierre Smits]

Yup. Kudos to all participating in moving this project forward.

I see a lot of potentials to become privileged contributors.

Best regards,


Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Tue, Jun 28, 2016 at 1:43 PM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> Big +1 Sharan.
>
> Thanks everyone who helping directly or indirectly to make it even better.
>
> Best regards,
>
> Pranay Pandey
> HotWax Systems
> http://www.hotwaxsystems.com/
>
> On Tue, Jun 28, 2016 at 4:10 PM, Ashish Vijaywargiya <
> ashish.vijaywarg...@hotwaxsystems.com> wrote:
>
> > Thanks Sharan for the note, same feeling here. Amazing contribution
> > everyone. Thanks so much! :-)
> >
> > Kind Regards
> > Ashish Vijaywargiya
> > HotWax Systems - est. 1997
> >
> > On Tue, Jun 28, 2016 at 2:44 PM, Sharan Foga 
> > wrote:
> >
> > > Hi Everyone
> > >
> > > A quick note to say thank you to everyone that is working on helping us
> > > improve OFBiz. Over the last few weeks OFBiz is consistently in the
> top 5
> > > most active SVN projects. (At the moment of writing this we are number
> 1
> > > with 23 commits so far today).
> > >
> > > Our dev mailing list is also consistently in the top 5 most active
> > mailing
> > > lists – so shows that we are busy discussing things too. I've included
> > the
> > > link the status monitor below.
> > >
> > > https://status.apache.org/
> > >
> > > It's not only about the number of commits, but also the interactions
> and
> > > discussions we are all having. I really like the community vibe and
> > > enthusiasm we have at the moment. Thanks everyone for contributing to
> it
> > > and continuing to making it happen!
> > >
> > > Thanks
> > > Sharan
> > >
> >
>

[jira] [Closed] (OFBIZ-7655) Use 'conditionFields' instead of 'andCondition' in Lookup screen

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7655.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks All,

Completed: At revision: 1750543  

I found 2 remaining occurrences, this fixes them in one shoot, as I suggested

> Use 'conditionFields' instead of 'andCondition' in Lookup screen
> 
>
> Key: OFBIZ-7655
> URL: https://issues.apache.org/jira/browse/OFBIZ-7655
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: andCondition, autocompletion, conditionFields, lookup
> Fix For: Upcoming Branch
>
>
> In order to improve a little the readibility, we can replace the use of 
> direct call of groovy in Lookup screen for the autocompletion parameters. 
> Instead, we can use the field 'conditionFields', which is a map key/value, to 
> declare those parameters.
> This is a main task and a sub task will be created for each lookup involved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7460) Enforce noninstantiability to ProductStoreWorker class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7460.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750535.

Thanks [~rishisolankii] and [~anurag.chan...@hotwaxsystems.com] for your 
contribution.

> Enforce noninstantiability to ProductStoreWorker class
> --
>
> Key: OFBIZ-7460
> URL: https://issues.apache.org/jira/browse/OFBIZ-7460
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7460.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following protected static variables as private and move it and 
> static block at the top of class.
> {code}
> protected static Map 
> defaultProductStoreEmailScreenLocation = new HashMap();
> static {
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CONFIRM", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_COMPLETE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderCompleteNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_BACKORDER", 
> "component://ecommerce/widget/EmailOrderScreens.xml#BackorderNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CHANGE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderChangeNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_PAYRETRY", 
> "component://ecommerce/widget/EmailOrderScreens.xml#PaymentRetryNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_ACCEPT", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnAccept");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_COMPLETE", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnComplete");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_CANCEL", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnCancel");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_PURCHASE", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardPurchase");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_RELOAD", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardReload");
> defaultProductStoreEmailScreenLocation.put("PRDS_QUO_CONFIRM", 
> "component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple");
> defaultProductStoreEmailScreenLocation.put("PRDS_PWD_RETRIEVE", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> defaultProductStoreEmailScreenLocation.put("PRDS_TELL_FRIEND", 
> "component://ecommerce/widget/EmailProductScreens.xml#TellFriend");
> defaultProductStoreEmailScreenLocation.put("PRDS_CUST_REGISTER", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> }
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7460) Enforce noninstantiability to ProductStoreWorker class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7460:
---

Assignee: Arun Patidar  (was: Anurag Chandak)

> Enforce noninstantiability to ProductStoreWorker class
> --
>
> Key: OFBIZ-7460
> URL: https://issues.apache.org/jira/browse/OFBIZ-7460
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7460.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following protected static variables as private and move it and 
> static block at the top of class.
> {code}
> protected static Map 
> defaultProductStoreEmailScreenLocation = new HashMap();
> static {
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CONFIRM", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_COMPLETE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderCompleteNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_BACKORDER", 
> "component://ecommerce/widget/EmailOrderScreens.xml#BackorderNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CHANGE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderChangeNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_PAYRETRY", 
> "component://ecommerce/widget/EmailOrderScreens.xml#PaymentRetryNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_ACCEPT", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnAccept");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_COMPLETE", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnComplete");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_CANCEL", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnCancel");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_PURCHASE", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardPurchase");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_RELOAD", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardReload");
> defaultProductStoreEmailScreenLocation.put("PRDS_QUO_CONFIRM", 
> "component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple");
> defaultProductStoreEmailScreenLocation.put("PRDS_PWD_RETRIEVE", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> defaultProductStoreEmailScreenLocation.put("PRDS_TELL_FRIEND", 
> "component://ecommerce/widget/EmailProductScreens.xml#TellFriend");
> defaultProductStoreEmailScreenLocation.put("PRDS_CUST_REGISTER", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> }
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7459) Enforce noninstantiability to ApacheFopWorker Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7459.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750534.

Thanks [~rishisolankii] and [~rohit.koushal] for your contribution.

> Enforce noninstantiability to ApacheFopWorker Class
> ---
>
> Key: OFBIZ-7459
> URL: https://issues.apache.org/jira/browse/OFBIZ-7459
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7459.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following protected variable as private
> {code}
> protected static FopFactory fopFactory = null;
> {code}
> - Make the following public variable as private
> {code}
> public static final String tempFilePrefix = 
> "org.ofbiz.webapp.view.ApacheFopWorker-";
> public static final int encryptionLengthBitsDefault = 128;
> 
> public static final String encryptionLengthDefault = 
> UtilProperties.getPropertyValue("fop", "fop.encryption-length.default", 
> String.valueOf(encryptionLengthBitsDefault));
> public static final String userPasswordDefault = 
> UtilProperties.getPropertyValue("fop", "fop.userPassword.default");
> public static final String ownerPasswordDefault = 
> UtilProperties.getPropertyValue("fop", "fop.ownerPassword.default");
> public static final String allowPrintDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowPrint.default", "true");
> public static final String allowCopyContentDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowCopyContent.default", 
> "true");
> public static final String allowEditContentDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowEditContent.default", 
> "true");
> public static final String allowEditAnnotationsDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowEditAnnotations.default", 
> "true");
> public static final String allowFillInFormsDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowFillInForms.default", 
> "true");
> public static final String allowAccessContentDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowAccessContent.default", 
> "true");
> public static final String allowAssembleDocumentDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowAssembleDocument.default", 
> "true");
> public static final String allowPrintHqDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowPrintHq.default", "true");
> public static final String encryptMetadataDefault = 
> UtilProperties.getPropertyValue("fop", "fop.encrypt-metadata.default", 
> "true");
> 
> public static final String fopPath = 
> UtilProperties.getPropertyValue("fop", "fop.path", 
> "/framework/webapp/config");
> 
> public static final String fopFontBaseProperty = 
> UtilProperties.getPropertyValue("fop", "fop.font.base.url", 
> "/framework/webapp/config/");
> {code}
> - Make getter methods for all above converted private variables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7459) Enforce noninstantiability to ApacheFopWorker Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7459:
---

Assignee: Arun Patidar  (was: Rohit Koushal)

> Enforce noninstantiability to ApacheFopWorker Class
> ---
>
> Key: OFBIZ-7459
> URL: https://issues.apache.org/jira/browse/OFBIZ-7459
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7459.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following protected variable as private
> {code}
> protected static FopFactory fopFactory = null;
> {code}
> - Make the following public variable as private
> {code}
> public static final String tempFilePrefix = 
> "org.ofbiz.webapp.view.ApacheFopWorker-";
> public static final int encryptionLengthBitsDefault = 128;
> 
> public static final String encryptionLengthDefault = 
> UtilProperties.getPropertyValue("fop", "fop.encryption-length.default", 
> String.valueOf(encryptionLengthBitsDefault));
> public static final String userPasswordDefault = 
> UtilProperties.getPropertyValue("fop", "fop.userPassword.default");
> public static final String ownerPasswordDefault = 
> UtilProperties.getPropertyValue("fop", "fop.ownerPassword.default");
> public static final String allowPrintDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowPrint.default", "true");
> public static final String allowCopyContentDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowCopyContent.default", 
> "true");
> public static final String allowEditContentDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowEditContent.default", 
> "true");
> public static final String allowEditAnnotationsDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowEditAnnotations.default", 
> "true");
> public static final String allowFillInFormsDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowFillInForms.default", 
> "true");
> public static final String allowAccessContentDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowAccessContent.default", 
> "true");
> public static final String allowAssembleDocumentDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowAssembleDocument.default", 
> "true");
> public static final String allowPrintHqDefault = 
> UtilProperties.getPropertyValue("fop", "fop.allowPrintHq.default", "true");
> public static final String encryptMetadataDefault = 
> UtilProperties.getPropertyValue("fop", "fop.encrypt-metadata.default", 
> "true");
> 
> public static final String fopPath = 
> UtilProperties.getPropertyValue("fop", "fop.path", 
> "/framework/webapp/config");
> 
> public static final String fopFontBaseProperty = 
> UtilProperties.getPropertyValue("fop", "fop.font.base.url", 
> "/framework/webapp/config/");
> {code}
> - Make getter methods for all above converted private variables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7455) Enforce noninstantiability to ImportProductHelper class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7455.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750533.

Thanks [~rishisolankii] and [~chinmay.patidar] for your contribution.

> Enforce noninstantiability to ImportProductHelper class
> ---
>
> Key: OFBIZ-7455
> URL: https://issues.apache.org/jira/browse/OFBIZ-7455
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7455.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static variable as public static final.
> {code}
>   static String module = ImportProductHelper.class.getName();
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7455) Enforce noninstantiability to ImportProductHelper class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7455:
---

Assignee: Arun Patidar  (was: Chinmay Patidar)

> Enforce noninstantiability to ImportProductHelper class
> ---
>
> Key: OFBIZ-7455
> URL: https://issues.apache.org/jira/browse/OFBIZ-7455
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7455.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static variable as public static final.
> {code}
>   static String module = ImportProductHelper.class.getName();
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7453) Enforce noninstantiability to WebDavUtil Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7453.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750532.

Thanks [~rishisolankii] and [~rohit.koushal] for your contribution.

> Enforce noninstantiability to WebDavUtil Class
> --
>
> Key: OFBIZ-7453
> URL: https://issues.apache.org/jira/browse/OFBIZ-7453
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7453.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final TimeZone GMT_TIMEZONE = TimeZone.getTimeZone("GMT");
> public static final String RFC1123_DATE_FORMAT = "EEE, dd MMM  
> HH:mm:ss zzz";
> {code}
> - Add getRFC1123DateFormat() and replace use of 
> WebDavUtil.RFC1123_DATE_FORMAT from class 'ICalWorker'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7453) Enforce noninstantiability to WebDavUtil Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7453:
---

Assignee: Arun Patidar  (was: Rohit Koushal)

> Enforce noninstantiability to WebDavUtil Class
> --
>
> Key: OFBIZ-7453
> URL: https://issues.apache.org/jira/browse/OFBIZ-7453
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7453.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final TimeZone GMT_TIMEZONE = TimeZone.getTimeZone("GMT");
> public static final String RFC1123_DATE_FORMAT = "EEE, dd MMM  
> HH:mm:ss zzz";
> {code}
> - Add getRFC1123DateFormat() and replace use of 
> WebDavUtil.RFC1123_DATE_FORMAT from class 'ICalWorker'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7450) Enforce noninstantiability to ProductUtilServices class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7450.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750531.

Thanks [~rishisolankii] and [~pratik.kulshreshth] for your contribution.

> Enforce noninstantiability to ProductUtilServices class
> ---
>
> Key: OFBIZ-7450
> URL: https://issues.apache.org/jira/browse/OFBIZ-7450
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7450.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String resource = "ProductUiLabels";
> public static final String resourceError = "ProductErrorUiLabels";
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7448) Enforce noninstantiability to InventoryWorker class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7448:
---

Assignee: Arun Patidar

> Enforce noninstantiability to InventoryWorker class
> ---
>
> Key: OFBIZ-7448
> URL: https://issues.apache.org/jira/browse/OFBIZ-7448
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7448.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7448) Enforce noninstantiability to InventoryWorker class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7448.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750530.

Thanks [~rishisolankii] and [~aman.mishra] for your contribution.

> Enforce noninstantiability to InventoryWorker class
> ---
>
> Key: OFBIZ-7448
> URL: https://issues.apache.org/jira/browse/OFBIZ-7448
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7448.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7450) Enforce noninstantiability to ProductUtilServices class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7450:
---

Assignee: Arun Patidar

> Enforce noninstantiability to ProductUtilServices class
> ---
>
> Key: OFBIZ-7450
> URL: https://issues.apache.org/jira/browse/OFBIZ-7450
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7450.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String resource = "ProductUiLabels";
> public static final String resourceError = "ProductErrorUiLabels";
> {code}
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7447) Enforce noninstantiability to ImageManagementHelper class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7447.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750529.

Thanks [~rishisolankii] and [~chinmay.patidar] for your contribution.

> Enforce noninstantiability to ImageManagementHelper class
> -
>
> Key: OFBIZ-7447
> URL: https://issues.apache.org/jira/browse/OFBIZ-7447
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7447.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7447) Enforce noninstantiability to ImageManagementHelper class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7447:
---

Assignee: Arun Patidar  (was: Chinmay Patidar)

> Enforce noninstantiability to ImageManagementHelper class
> -
>
> Key: OFBIZ-7447
> URL: https://issues.apache.org/jira/browse/OFBIZ-7447
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7447.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7446) Enforce noninstantiability to WebSiteWorker Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7446.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750527.

Thanks [~rishisolankii] and [~rohit.koushal] for your contribution.

> Enforce noninstantiability to WebSiteWorker Class
> -
>
> Key: OFBIZ-7446
> URL: https://issues.apache.org/jira/browse/OFBIZ-7446
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7446.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7446) Enforce noninstantiability to WebSiteWorker Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7446:
---

Assignee: Arun Patidar  (was: Rohit Koushal)

> Enforce noninstantiability to WebSiteWorker Class
> -
>
> Key: OFBIZ-7446
> URL: https://issues.apache.org/jira/browse/OFBIZ-7446
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7446.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7445) Enforce noninstantiability to ProductConfigWorker class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7445.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750526.

Thanks [~rishisolankii] and [~amit.gadaley] for your contribution.

> Enforce noninstantiability to ProductConfigWorker class
> ---
>
> Key: OFBIZ-7445
> URL: https://issues.apache.org/jira/browse/OFBIZ-7445
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7445.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String SEPARATOR = "::";
> {code}
> - Remove the following public static variables as it is not in use.
> {code}
> public static final String resource = "ProductUiLabels";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7651) OFBIZ-7649: Display From date with default now() on all screens under Party Application

[Ratnesh Upadhyay (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ratnesh Upadhyay updated OFBIZ-7651:

Attachment: OFBIZ-7651.patch

Thanks [~swash78] for reporting the issue. Attaching patch to fix reported 
issue for party application.

> OFBIZ-7649: Display From date with default now() on all screens under Party 
> Application
> ---
>
> Key: OFBIZ-7651
> URL: https://issues.apache.org/jira/browse/OFBIZ-7651
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Priority: Minor
> Attachments: OFBIZ-7651.patch
>
>
> To begin with let's start fixing it under
> # "Add Party Content" form on 
> https://ofbiz-vm.apache.org:18443/partymgr/control/EditPartyContents?partyId=DemoCustCompany
> # "Edit Product Store Roles" from on 
> https://ofbiz-vm.apache.org:18443/partymgr/control/ViewProductStoreRoles?partyId=DemoCustCompany



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7445) Enforce noninstantiability to ProductConfigWorker class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7445:
---

Assignee: Arun Patidar

> Enforce noninstantiability to ProductConfigWorker class
> ---
>
> Key: OFBIZ-7445
> URL: https://issues.apache.org/jira/browse/OFBIZ-7445
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7445.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String SEPARATOR = "::";
> {code}
> - Remove the following public static variables as it is not in use.
> {code}
> public static final String resource = "ProductUiLabels";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7433) Enforce noninstantiability to UtilCacheEvents Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7433.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750525.

Thanks [~rishisolankii] and [~rahul.kushwah] for your contribution.

> Enforce noninstantiability to UtilCacheEvents Class
> ---
>
> Key: OFBIZ-7433
> URL: https://issues.apache.org/jira/browse/OFBIZ-7433
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7433.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String err_resource = "WebtoolsErrorUiLabels";
> {code}
> Also, use 'err_resource' instead of UtilCacheEvents.err_resource in same class



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7433) Enforce noninstantiability to UtilCacheEvents Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7433:
---

Assignee: Arun Patidar

> Enforce noninstantiability to UtilCacheEvents Class
> ---
>
> Key: OFBIZ-7433
> URL: https://issues.apache.org/jira/browse/OFBIZ-7433
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7433.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static final String err_resource = "WebtoolsErrorUiLabels";
> {code}
> Also, use 'err_resource' instead of UtilCacheEvents.err_resource in same class



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7431) Enforce noninstantiability to SeoUrlUtil class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7431.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750524.

Thanks [~rishisolankii] and [~chinmay.patidar] for your contribution.

> Enforce noninstantiability to SeoUrlUtil class
> --
>
> Key: OFBIZ-7431
> URL: https://issues.apache.org/jira/browse/OFBIZ-7431
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7431.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7428) Enforce noninstantiability to WidgetContentWorker Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7428:
---

Assignee: Arun Patidar

> Enforce noninstantiability to WidgetContentWorker Class
> ---
>
> Key: OFBIZ-7428
> URL: https://issues.apache.org/jira/browse/OFBIZ-7428
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7428.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static ContentWorkerInterface contentWorker = null;
> {code}
> - Add a static getContentWorker() and replace use of 
> WidgetContentWorker.contentWorker in classes 'MenuWrapTransform', 
> 'MacroScreenRenderer' 'HtmlScreenRenderer', 'HtmlMenuRendererImage',  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7431) Enforce noninstantiability to SeoUrlUtil class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7431:
---

Assignee: Arun Patidar  (was: Chinmay Patidar)

> Enforce noninstantiability to SeoUrlUtil class
> --
>
> Key: OFBIZ-7431
> URL: https://issues.apache.org/jira/browse/OFBIZ-7431
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7431.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7428) Enforce noninstantiability to WidgetContentWorker Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7428.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750521.

Thanks [~rishisolankii] and [~pratik.kulshreshth] for your contribution.

> Enforce noninstantiability to WidgetContentWorker Class
> ---
>
> Key: OFBIZ-7428
> URL: https://issues.apache.org/jira/browse/OFBIZ-7428
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7428.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static ContentWorkerInterface contentWorker = null;
> {code}
> - Add a static getContentWorker() and replace use of 
> WidgetContentWorker.contentWorker in classes 'MenuWrapTransform', 
> 'MacroScreenRenderer' 'HtmlScreenRenderer', 'HtmlMenuRendererImage',  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7426) Enforce noninstantiability to SeoConfigUtil class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7426.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750520.

Thanks [~rishisolankii] and [~anurag.chan...@hotwaxsystems.com] for your 
contribution.

> Enforce noninstantiability to SeoConfigUtil class
> -
>
> Key: OFBIZ-7426
> URL: https://issues.apache.org/jira/browse/OFBIZ-7426
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7426.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public variables as final
> {code}
> public static String module = UtilAccounting.class.getName();
> {code}
> - Make the following public static variables as private
> {code}
> public static final String DEFAULT_REGEXP = "^.*/.*$";
> public static final String ELEMENT_REGEXPIFMATCH = "regexpifmatch";
> public static final String ELEMENT_URL_CONFIG = "url-config";
> public static final String ELEMENT_DESCRIPTION = "description";
> public static final String ELEMENT_FORWARD = "forward";
> public static final String ELEMENT_SEO = "seo";
> public static final String ELEMENT_URLPATTERN = "url-pattern";
> public static final String ELEMENT_REPLACEMENT = "replacement";
> public static final String ELEMENT_RESPONSECODE = "responsecode";
> public static final String ELEMENT_JSESSIONID = "jsessionid";
> public static final String ELEMENT_ANONYMOUS = "anonymous";
> public static final String ELEMENT_VALUE = "value";
> public static final String ELEMENT_USER = "user";
> public static final String ELEMENT_EXCEPTIONS = "exceptions";
> public static final String ELEMENT_CHAR_FILTERS = "char-filters";
> public static final String ELEMENT_CHAR_FILTER = "char-filter";
> public static final String ELEMENT_CHARACTER_PATTERN = 
> "character-pattern";
> public static final String ELEMENT_CATEGORY_URL = "category-url";
> public static final String ELEMENT_ALLOWED_CONTEXT_PATHS = 
> "allowed-context-paths";
> public static final String ELEMENT_CATEGORY_NAME = "category-name";
> public static final String ELEMENT_CATEGORY_URL_SUFFIX = 
> "category-url-suffix";
> public static final String SEO_CONFIG_FILENAME = "SeoConfig.xml";
> public static final int DEFAULT_RESPONSECODE = 
> HttpServletResponse.SC_MOVED_PERMANENTLY;
> public static final String DEFAULT_ANONYMOUS_VALUE = "disable";
> public static final String DEFAULT_USER_VALUE = "disable";
> public static final String DEFAULT_CATEGORY_URL_VALUE = "enable";
> public static final String DEFAULT_CATEGORY_NAME_VALUE = "disable";
> public static final String ALLOWED_CONTEXT_PATHS_SEPERATOR = ":";
> {code}
> - Also add getDefaultResponseCode() method for following variable after 
> making it private and use it in UrlRegexpTransform.java, 
> SeoContextFilter.java and UrlRegexpContextFilter.java
> {code}
> public static final int DEFAULT_RESPONSECODE = 
> HttpServletResponse.SC_MOVED_PERMANENTLY;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7426) Enforce noninstantiability to SeoConfigUtil class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7426:
---

Assignee: Arun Patidar  (was: Anurag Chandak)

> Enforce noninstantiability to SeoConfigUtil class
> -
>
> Key: OFBIZ-7426
> URL: https://issues.apache.org/jira/browse/OFBIZ-7426
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7426.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public variables as final
> {code}
> public static String module = UtilAccounting.class.getName();
> {code}
> - Make the following public static variables as private
> {code}
> public static final String DEFAULT_REGEXP = "^.*/.*$";
> public static final String ELEMENT_REGEXPIFMATCH = "regexpifmatch";
> public static final String ELEMENT_URL_CONFIG = "url-config";
> public static final String ELEMENT_DESCRIPTION = "description";
> public static final String ELEMENT_FORWARD = "forward";
> public static final String ELEMENT_SEO = "seo";
> public static final String ELEMENT_URLPATTERN = "url-pattern";
> public static final String ELEMENT_REPLACEMENT = "replacement";
> public static final String ELEMENT_RESPONSECODE = "responsecode";
> public static final String ELEMENT_JSESSIONID = "jsessionid";
> public static final String ELEMENT_ANONYMOUS = "anonymous";
> public static final String ELEMENT_VALUE = "value";
> public static final String ELEMENT_USER = "user";
> public static final String ELEMENT_EXCEPTIONS = "exceptions";
> public static final String ELEMENT_CHAR_FILTERS = "char-filters";
> public static final String ELEMENT_CHAR_FILTER = "char-filter";
> public static final String ELEMENT_CHARACTER_PATTERN = 
> "character-pattern";
> public static final String ELEMENT_CATEGORY_URL = "category-url";
> public static final String ELEMENT_ALLOWED_CONTEXT_PATHS = 
> "allowed-context-paths";
> public static final String ELEMENT_CATEGORY_NAME = "category-name";
> public static final String ELEMENT_CATEGORY_URL_SUFFIX = 
> "category-url-suffix";
> public static final String SEO_CONFIG_FILENAME = "SeoConfig.xml";
> public static final int DEFAULT_RESPONSECODE = 
> HttpServletResponse.SC_MOVED_PERMANENTLY;
> public static final String DEFAULT_ANONYMOUS_VALUE = "disable";
> public static final String DEFAULT_USER_VALUE = "disable";
> public static final String DEFAULT_CATEGORY_URL_VALUE = "enable";
> public static final String DEFAULT_CATEGORY_NAME_VALUE = "disable";
> public static final String ALLOWED_CONTEXT_PATHS_SEPERATOR = ":";
> {code}
> - Also add getDefaultResponseCode() method for following variable after 
> making it private and use it in UrlRegexpTransform.java, 
> SeoContextFilter.java and UrlRegexpContextFilter.java
> {code}
> public static final int DEFAULT_RESPONSECODE = 
> HttpServletResponse.SC_MOVED_PERMANENTLY;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7423) Enforce noninstantiability to PartyTypeHelper class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7423.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750516.

Thanks [~rishisolankii] and [~amit.gadaley] for your contribution.

> Enforce noninstantiability to PartyTypeHelper class
> ---
>
> Key: OFBIZ-7423
> URL: https://issues.apache.org/jira/browse/OFBIZ-7423
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7423.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7422) Enforce noninstantiability to WidgetDataResourceWorker Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7422:
---

Assignee: Arun Patidar  (was: Rohit Koushal)

> Enforce noninstantiability to WidgetDataResourceWorker Class
> 
>
> Key: OFBIZ-7422
> URL: https://issues.apache.org/jira/browse/OFBIZ-7422
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7422.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static DataResourceWorkerInterface dataresourceWorker = null;
> {code}
> - Add a getDataresourceWorker() method and replace use of 
> DataResourceWorkerInterface.dataresourceWorker from  classes 
> 'HtmlScreenRenderer' and 'MacroScreenRenderer'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7423) Enforce noninstantiability to PartyTypeHelper class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7423:
---

Assignee: Arun Patidar

> Enforce noninstantiability to PartyTypeHelper class
> ---
>
> Key: OFBIZ-7423
> URL: https://issues.apache.org/jira/browse/OFBIZ-7423
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7423.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7422) Enforce noninstantiability to WidgetDataResourceWorker Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7422.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750515.

Thanks [~rishisolankii] and [~rohit.koushal] for your contribution.

> Enforce noninstantiability to WidgetDataResourceWorker Class
> 
>
> Key: OFBIZ-7422
> URL: https://issues.apache.org/jira/browse/OFBIZ-7422
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7422.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static DataResourceWorkerInterface dataresourceWorker = null;
> {code}
> - Add a getDataresourceWorker() method and replace use of 
> DataResourceWorkerInterface.dataresourceWorker from  classes 
> 'HtmlScreenRenderer' and 'MacroScreenRenderer'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7420) Enforce noninstantiability to WidgetPortalPageWorker Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7420:
---

Assignee: Arun Patidar

> Enforce noninstantiability to WidgetPortalPageWorker Class
> --
>
> Key: OFBIZ-7420
> URL: https://issues.apache.org/jira/browse/OFBIZ-7420
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7420.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static PortalPageWorkerInterface portalPageWorker = null;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7420) Enforce noninstantiability to WidgetPortalPageWorker Class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7420.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750513.

Thanks [~rahul.kushwah] for your contribution.

> Enforce noninstantiability to WidgetPortalPageWorker Class
> --
>
> Key: OFBIZ-7420
> URL: https://issues.apache.org/jira/browse/OFBIZ-7420
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7420.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following public static variables as private
> {code}
> public static PortalPageWorkerInterface portalPageWorker = null;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7419) Enforce noninstantiability to PartyRelationshipHelper class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7419.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750511.

Thanks [~rishisolankii] and [~chinmay.patidar] for your contribution.

> Enforce noninstantiability to PartyRelationshipHelper class
> ---
>
> Key: OFBIZ-7419
> URL: https://issues.apache.org/jira/browse/OFBIZ-7419
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7419.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7419) Enforce noninstantiability to PartyRelationshipHelper class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7419:
---

Assignee: Arun Patidar  (was: Chinmay Patidar)

> Enforce noninstantiability to PartyRelationshipHelper class
> ---
>
> Key: OFBIZ-7419
> URL: https://issues.apache.org/jira/browse/OFBIZ-7419
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7419.patch
>
>
> - Make class as final.
> - Add a private constructor.
> No variables needs to be change for this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-7417) Enforce noninstantiability to TaskWorker class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7417.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed changes in trunk at rev: 1750510.

Thanks [~rishisolankii] and [~anurag.chan...@hotwaxsystems.com] for your 
contribution.

> Enforce noninstantiability to TaskWorker class
> --
>
> Key: OFBIZ-7417
> URL: https://issues.apache.org/jira/browse/OFBIZ-7417
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7417.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static variable as  private static final. And move the 
> variable at top of the class.
> {code}
> static Map statusMapping
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7625) Add "changeByUserLoginId" field for ExampleStatus

[Renuka Srishti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-7625:
--
Assignee: Renuka Srishti

> Add "changeByUserLoginId" field for ExampleStatus
> -
>
> Key: OFBIZ-7625
> URL: https://issues.apache.org/jira/browse/OFBIZ-7625
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Renuka Srishti
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7417) Enforce noninstantiability to TaskWorker class

[Arun Patidar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7417:
---

Assignee: Arun Patidar  (was: Anurag Chandak)

> Enforce noninstantiability to TaskWorker class
> --
>
> Key: OFBIZ-7417
> URL: https://issues.apache.org/jira/browse/OFBIZ-7417
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7417.patch
>
>
> - Make class as final.
> - Add a private constructor.
> - Make the following static variable as  private static final. And move the 
> variable at top of the class.
> {code}
> static Map statusMapping
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7611) Track userlogin for status change

[Nameet Jain (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352981#comment-15352981
 ] 

Nameet Jain commented on OFBIZ-7611:


I have started on this task and will upload the patches soon in the child task.

> Track userlogin for status change
> -
>
> Key: OFBIZ-7611
> URL: https://issues.apache.org/jira/browse/OFBIZ-7611
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Nicolas Malin
>
> Currently in OFBiz, 'changedByUserLoginId' field is missing from status 
> entities (like: ShipmentStatus). Using this field we can maintain the history 
> for each status change made by user.
> Update all respective service and events to ensure this field gets updated.
> Here is the list of entities with missing this field.
> 1. BudgetStatus
> 2. ContactListCommStatus
> 3. CustRequestStatus
> 4. ExampleStatus
> 5. FinAccountStatus
> 6. InventoryItemStatus
> 7. InvoiceStatus
> 8. PartyStatus
> 9. RequirementStatus
> 10. ShipmentStatus



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7664) Inconsistencies on the title and the label on button of create forms.

[Rahul bhammarker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul bhammarker updated OFBIZ-7664:

Priority: Minor  (was: Major)

> Inconsistencies on the title and the label on button of create forms.
> -
>
> Key: OFBIZ-7664
> URL: https://issues.apache.org/jira/browse/OFBIZ-7664
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Rahul bhammarker
>Assignee: Rahul bhammarker
>Priority: Minor
>
> There are inconsistencies in the form title and the action label on the the 
> button of create forms such as Catalog > Products > New Product
> the form title is "Edit Product" and the button label is "Create Product". 
> There are various fomrs like this in other components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7663) FromDate and ThruDate shows empty for WorkEffort Children

[Ankit Joshi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Joshi updated OFBIZ-7663:
---
Assignee: (was: Ankit Joshi)

> FromDate and ThruDate shows empty for WorkEffort Children 
> --
>
> Key: OFBIZ-7663
> URL: https://issues.apache.org/jira/browse/OFBIZ-7663
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Ankit Joshi
>Priority: Minor
> Attachments: OFBIZ-7663.patch
>
>
> Steps to regenerate -
> 1) Navigate to workeffort -> workeffort
> 2) Go to workeffort Details Page.
> 3) Select Children tab and  click on Add existing Workeffort Child.
> 4)Add workeffort child with FromDate, thruDate and other required details.
> 5) Now, again select Children tab to view all associated workeffort children.
> 6) Workeffort children listed in tree structure. Select recently created 
> workeffort child.
> Issue - FromDate and thruDate shows empty value when we navigate to child 
> details page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7664) Inconsistencies on the title and the label on button of create forms.

[Rahul bhammarker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul bhammarker updated OFBIZ-7664:

Summary: Inconsistencies on the title and the label on button of create 
forms.  (was: Inconsistency on the title and the label on button of create 
forms.)

> Inconsistencies on the title and the label on button of create forms.
> -
>
> Key: OFBIZ-7664
> URL: https://issues.apache.org/jira/browse/OFBIZ-7664
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Rahul bhammarker
>Assignee: Rahul bhammarker
>
> There are inconsistencies in the form title and the action label on the the 
> button of create forms such as Catalog > Products > New Product
> the form title is "Edit Product" and the button label is "Create Product". 
> There are various fomrs like this in other components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7664) Inconsistency on the title and the label on button of create forms.

[Rahul bhammarker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul bhammarker updated OFBIZ-7664:

Description: 
There are inconsistencies in the form title and the action label on the the 
button of create forms such as Catalog > Products > New Product
the form title is "Edit Product" and the button label is "Create Product". 
There are various fomrs like this in other components.

  was:
There are inconsistency on the form title and the action label on the the 
button of create forms such as Catalog > Products > New Product
the form title is "Edit Product" and the button label is "Create Product". 
There are various fomrs like this in other components.


> Inconsistency on the title and the label on button of create forms.
> ---
>
> Key: OFBIZ-7664
> URL: https://issues.apache.org/jira/browse/OFBIZ-7664
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Rahul bhammarker
>Assignee: Rahul bhammarker
>
> There are inconsistencies in the form title and the action label on the the 
> button of create forms such as Catalog > Products > New Product
> the form title is "Edit Product" and the button label is "Create Product". 
> There are various fomrs like this in other components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7664) Inconsistency on the title and the label on button of create forms.

[Rahul bhammarker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul bhammarker updated OFBIZ-7664:

Description: 
There are inconsistency on the form title and the action label on the the 
button of create forms such as Catalog > Products > New Product
the form title is "Edit Product" and the button label is "Create Product". 
There are various fomrs like this in other components.

  was:There are inconsistency on the form title and the action label on the the 
button of create forms such as 


> Inconsistency on the title and the label on button of create forms.
> ---
>
> Key: OFBIZ-7664
> URL: https://issues.apache.org/jira/browse/OFBIZ-7664
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Rahul bhammarker
>Assignee: Rahul bhammarker
>
> There are inconsistency on the form title and the action label on the the 
> button of create forms such as Catalog > Products > New Product
> the form title is "Edit Product" and the button label is "Create Product". 
> There are various fomrs like this in other components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7663) FromDate and ThruDate shows empty for WorkEffort Children

[Ankit Joshi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Joshi updated OFBIZ-7663:
---
Attachment: OFBIZ-7663.patch

The issue was because of missing fromDate while navigating through workeffort 
children screen to the child detail page which was required in entity-one 
operation on detail page to get workeffort assoc details.

Here is the patch with proper fix.

> FromDate and ThruDate shows empty for WorkEffort Children 
> --
>
> Key: OFBIZ-7663
> URL: https://issues.apache.org/jira/browse/OFBIZ-7663
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Ankit Joshi
>Assignee: Ankit Joshi
>Priority: Minor
> Attachments: OFBIZ-7663.patch
>
>
> Steps to regenerate -
> 1) Navigate to workeffort -> workeffort
> 2) Go to workeffort Details Page.
> 3) Select Children tab and  click on Add existing Workeffort Child.
> 4)Add workeffort child with FromDate, thruDate and other required details.
> 5) Now, again select Children tab to view all associated workeffort children.
> 6) Workeffort children listed in tree structure. Select recently created 
> workeffort child.
> Issue - FromDate and thruDate shows empty value when we navigate to child 
> details page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7664) Inconsistency on the title and the label on button of create forms.

[Rahul bhammarker (JIRA)]

Rahul bhammarker created OFBIZ-7664:
---

 Summary: Inconsistency on the title and the label on button of 
create forms.
 Key: OFBIZ-7664
 URL: https://issues.apache.org/jira/browse/OFBIZ-7664
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Rahul bhammarker
Assignee: Rahul bhammarker


There are inconsistency on the form title and the action label on the the 
button of create forms such as 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-7663) FromDate and ThruDate shows empty for WorkEffort Children

[Ankit Joshi (JIRA)]

Ankit Joshi created OFBIZ-7663:
--

 Summary: FromDate and ThruDate shows empty for WorkEffort Children 
 Key: OFBIZ-7663
 URL: https://issues.apache.org/jira/browse/OFBIZ-7663
 Project: OFBiz
  Issue Type: Bug
  Components: workeffort
Affects Versions: Trunk, Release Branch 14.12, Release Branch 13.07
Reporter: Ankit Joshi
Assignee: Ankit Joshi
Priority: Minor


Steps to regenerate -
1) Navigate to workeffort -> workeffort
2) Go to workeffort Details Page.
3) Select Children tab and  click on Add existing Workeffort Child.
4)Add workeffort child with FromDate, thruDate and other required details.
5) Now, again select Children tab to view all associated workeffort children.
6) Workeffort children listed in tree structure. Select recently created 
workeffort child.

Issue - FromDate and thruDate shows empty value when we navigate to child 
details page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: svn commit: r1750491 - /ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml

[Nicolas Malin]

Le 28/06/2016 14:48, Jacques Le Roux a écrit :

Hi Nicolas,

Hi Jacques


I see some tabs here ;)
OMG , I control the patch only with nano ! thanks for spoting Jacques I 
will fix it


BTW there is another occurrence at line 213

Ok I will fix it also on the same way.

Nicolas


Jacques


Le 28/06/2016 à 14:02, nma...@apache.org a écrit :

Author: nmalin
Date: Tue Jun 28 12:02:57 2016
New Revision: 1750491

URL: http://svn.apache.org/viewvc?rev=1750491=rev
Log:
Change 'andCondition' (which uses groovy as a value) to 
'conditionFields' in the lookup 
applications/product/widget/catalog/LookupScreens#LookupVirtualProduct. 
Related issue OFBIZ-7659, thanks to Florian Montalbano for this.


Modified:
ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml

Modified: 
ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml?rev=1750491=1750490=1750491=diff
== 

--- ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml 
(original)
+++ ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml 
Tue Jun 28 12:02:57 2016

@@ -55,7 +55,7 @@ under the License.
  from-field="result.queryString"/>

  
  
-

+ 
  
  
  location="component://common/widget/CommonScreens.xml">

[jira] [Created] (OFBIZ-7662) OFBIZ-7649: Display From date with default now() on all screens under WorkEffort Application

[Swapnil Shah (JIRA)]

Swapnil Shah created OFBIZ-7662:
---

 Summary: OFBIZ-7649: Display From date with default now() on all 
screens under WorkEffort Application
 Key: OFBIZ-7662
 URL: https://issues.apache.org/jira/browse/OFBIZ-7662
 Project: OFBiz
  Issue Type: Sub-task
  Components: workeffort
Affects Versions: 14.12.01, 15.12.01
Reporter: Swapnil Shah
Assignee: Swapnil Shah


To begin with we can start fixing it under
# 
https://ofbiz-vm.apache.org:8443/workeffort/control/ListWorkEffortPartyAssigns?workEffortId=10001
# 
https://ofbiz-vm.apache.org:8443/workeffort/control/EditWorkEffortContents?workEffortId=10001
# 
https://ofbiz-vm.apache.org:8443/workeffort/control/EditWorkEffortGoodStandards?workEffortId=10001
# 
https://ofbiz-vm.apache.org:8443/workeffort/control/ListWorkEffortFixedAssetAssigns?workEffortId=10001
# https://ofbiz-vm.apache.org:8443/workeffort/control/EditICalendar
# 
https://ofbiz-vm.apache.org:8443/workeffort/control/ICalendarParties?workEffortId=1
# 
https://ofbiz-vm.apache.org:8443/workeffort/control/ICalendarFixedAssets?workEffortId=1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-7554) Delete buttons are not showing and working on forum screens

[Pranay Pandey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey reassigned OFBIZ-7554:


Assignee: Pranay Pandey  (was: Mohammed Rehan Khan)

> Delete buttons are not showing and working on forum screens
> ---
>
> Key: OFBIZ-7554
> URL: https://issues.apache.org/jira/browse/OFBIZ-7554
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Mohammed Rehan Khan
>Assignee: Pranay Pandey
> Attachments: OFBIZ-7554-Release-13.07.patch, 
> OFBIZ-7554-Release-13.07.patch, OFBIZ-7554-Release-14.12.patch, 
> OFBIZ-7554-Release-14.12.patch, OFBIZ-7554.patch, OFBIZ-7554.patch, 
> screenshot-1.png, screenshot-2.png, screenshot-3.png
>
>
> Here are the following screen:
> 1) Forum list for forum group : 
> https://ofbiz-vm.apache.org:8443/content/control/findForums?forumGroupId=WebStoreFORUM
> 2) Forum group roles screen : 
> https://ofbiz-vm.apache.org:8443/content/control/forumGroupRoles?forumGroupId=WebStoreFORUM
> 3) Click on this link and add message title and message text :
> https://ofbiz-vm.apache.org:8443/content/control/findForumMessages?forumGroupId=WebStoreFORUM=ASK



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: svn commit: r1750491 - /ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml

[Jacques Le Roux]

Hi Nicolas,

I see some tabs here ;)

BTW there is another occurrence at line 213

Jacques


Le 28/06/2016 à 14:02, nma...@apache.org a écrit :

Author: nmalin
Date: Tue Jun 28 12:02:57 2016
New Revision: 1750491

URL: http://svn.apache.org/viewvc?rev=1750491=rev
Log:
Change 'andCondition' (which uses groovy as a value) to 'conditionFields' in 
the lookup 
applications/product/widget/catalog/LookupScreens#LookupVirtualProduct. Related 
issue OFBIZ-7659, thanks to Florian Montalbano for this.

Modified:
 ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml

Modified: ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml?rev=1750491=1750490=1750491=diff
==
--- ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml (original)
+++ ofbiz/trunk/applications/product/widget/catalog/LookupScreens.xml Tue Jun 
28 12:02:57 2016
@@ -55,7 +55,7 @@ under the License.
  
  
  
-
+
  
  
  

[jira] [Created] (OFBIZ-7661) Create Menu inconsistent in decorators throughout the application (All component)

[Avnindra Sharma (JIRA)]

Avnindra Sharma created OFBIZ-7661:
--

 Summary: Create Menu inconsistent in decorators throughout the 
application (All component)
 Key: OFBIZ-7661
 URL: https://issues.apache.org/jira/browse/OFBIZ-7661
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Reporter: Avnindra Sharma
 Fix For: Trunk


Create Menu is inconsistent throughout the application.
When we navigate to any component, Create Menu button is not consistent. The 
button should be accessible via any sub menu.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-7554) Delete buttons are not showing and working on forum screens

[Mohammed Rehan Khan (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352893#comment-15352893
 ] 

Mohammed Rehan Khan edited comment on OFBIZ-7554 at 6/28/16 12:21 PM:
--

Here are the updated patches for this issue.

# Added description attribute on  tag.
# Corrected service IN parameters field name in form widget.
# Used 'contentAssocExisting' instead of 'contentAssoc' map in model service.


was (Author: rehan.khan):
Here are the updated patches for this issue.

# Added description attribute on  tag.
# Corrected service IN parameters filed name in form widget.
# Used 'contentAssocExisting' instead of 'contentAssoc' map in model service.

> Delete buttons are not showing and working on forum screens
> ---
>
> Key: OFBIZ-7554
> URL: https://issues.apache.org/jira/browse/OFBIZ-7554
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Mohammed Rehan Khan
>Assignee: Mohammed Rehan Khan
> Attachments: OFBIZ-7554-Release-13.07.patch, 
> OFBIZ-7554-Release-13.07.patch, OFBIZ-7554-Release-14.12.patch, 
> OFBIZ-7554-Release-14.12.patch, OFBIZ-7554.patch, OFBIZ-7554.patch, 
> screenshot-1.png, screenshot-2.png, screenshot-3.png
>
>
> Here are the following screen:
> 1) Forum list for forum group : 
> https://ofbiz-vm.apache.org:8443/content/control/findForums?forumGroupId=WebStoreFORUM
> 2) Forum group roles screen : 
> https://ofbiz-vm.apache.org:8443/content/control/forumGroupRoles?forumGroupId=WebStoreFORUM
> 3) Click on this link and add message title and message text :
> https://ofbiz-vm.apache.org:8443/content/control/findForumMessages?forumGroupId=WebStoreFORUM=ASK



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-7554) Delete buttons are not showing and working on forum screens

[Mohammed Rehan Khan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammed Rehan Khan updated OFBIZ-7554:
---
Summary: Delete buttons are not showing and working on forum screens  (was: 
Delete buttons are not showing on forum screens)

> Delete buttons are not showing and working on forum screens
> ---
>
> Key: OFBIZ-7554
> URL: https://issues.apache.org/jira/browse/OFBIZ-7554
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Mohammed Rehan Khan
>Assignee: Mohammed Rehan Khan
> Attachments: OFBIZ-7554-Release-13.07.patch, 
> OFBIZ-7554-Release-13.07.patch, OFBIZ-7554-Release-14.12.patch, 
> OFBIZ-7554-Release-14.12.patch, OFBIZ-7554.patch, OFBIZ-7554.patch, 
> screenshot-1.png, screenshot-2.png, screenshot-3.png
>
>
> Here are the following screen:
> 1) Forum list for forum group : 
> https://ofbiz-vm.apache.org:8443/content/control/findForums?forumGroupId=WebStoreFORUM
> 2) Forum group roles screen : 
> https://ofbiz-vm.apache.org:8443/content/control/forumGroupRoles?forumGroupId=WebStoreFORUM
> 3) Click on this link and add message title and message text :
> https://ofbiz-vm.apache.org:8443/content/control/findForumMessages?forumGroupId=WebStoreFORUM=ASK



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)