Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

I was thinking that: 1. We need a means for the tracking code logic to be able to access the cookie data in the request without needing to add any logic to the order component 2. We need a means for the order tracking code logic to be able to create TrackingCodeOrder records when the order is

Re: Jars in LICENCE?

A reminder: we should review in a similar way the LICENSE and NOTICE files under specialpurpose. Jacopo On Thu, Aug 25, 2016 at 6:37 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 24/08/2016 à 15:04, Jacques Le Roux a écrit : > >> 2 things I still wonder about are: >> >> 1. Why

Re: Jars in LICENCE?

Thanks for the research, Jacques: your conclusions are inline with mine. Jacopo On Thu, Aug 25, 2016 at 6:37 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 24/08/2016 à 15:04, Jacques Le Roux a écrit : > >> 2 things I still wonder about are: >> >> 1. Why Ant does not document

Re: Should we do binary releases?

A couple of comments: 1) a "release" at the ASF is a "source release". It would be better, to avoid any confusion in the future, if we name "binary packages" the (optional) files that we could produce from a release 2) my preference would be to not issue binary packages: focusing on publishing

Re: Jars in LICENCE?

Le 24/08/2016 à 15:04, Jacques Le Roux a écrit : 2 things I still wonder about are: 1. Why Ant does not document the libs referenced in their lib/libraries.properties file. It could be that they are not used OOTB (ie optional) I did not check that yet 2. If we need to document all the

Re: Should we do binary releases?

Le 24/08/2016 à 23:15, Taher Alkhateeb a écrit : Hi Jacques, I'm not sure how am I supposed to understand it? To me it seems clear .. You cannot add binaries unless they are the result of compiling the source code of the release you are preparing, it's written so very clearly. It also makes

Re: Jars in LICENCE?

At r1757579 I have removed obsolete information: LICENSE file jars have no longer paths files Ant is no longer present the Version 1.1 of the ASL can be removed NOTICE file Ant is no longer present its notice can be removed Log4J is no longer present its notice can be removed (log4j2 has

Thanks page rather than sponsor links in wiki

Hi, I think we should rather have a "Thanks" wiki page rather than sponsor links in wiki This has been already discussed at https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+Technical+Production+Setup+Guide?focusedCommentId=50234709#comment-50234709 So this post is more a

Re: Should we do binary releases?

Hi Jacques, I'm not sure how am I supposed to understand it? To me it seems clear .. You cannot add binaries unless they are the result of compiling the source code of the release you are preparing, it's written so very clearly. It also makes sense as it is saying that you can provide binary

Re: Should we do binary releases?

Taher, Wait, either Tomcat, Ant and JMeter are doing it wrong or we don't understand this sentence (I agree with you) or it's incomplete. Because if you download each of their binary releases you will find in them "binary/bytecode files" which are not the "result of compiling that version of

Re: Should we do binary releases?

Hi Jacques, The discussion we had in OFBIZ-7783 was basically around whether or not we should have a task to copy the gradle dependencies into a certain directory. We went through many discussions, the last one being that this task might be needed for binary releases. However, if you look at the

Should we do binary releases?

Hi, At https://issues.apache.org/jira/browse/OFBIZ-7783 we recently had a discussion with Taher about doing or not binary releases. This is how the ASF defines a binary release (http://www.apache.org/dev/release.html#what)

Re: Jars in LICENCE?

Also forgot to report that Ant has lib\optional folder with 3 not documented jars there. So as long as it's optional you don't need to reference it in the LICENSE file. We use OPTIONAL_LIBRARIES for that as a convenience to users. Jacques Le 24/08/2016 à 15:04, Jacques Le Roux a écrit : OK, I

Re: Jars in LICENCE?

OK, I did my homework and here is what I found. I looked at 3 TLPs: Tomcat, Ant & JMeter last releases. Globally they all document in their LICENSE files the external libs they use in their source releases; but don't to so in their binary LICENSE files. For instance Tomcat uses

OFBIZ-7918

Hi committers, Can someone please follow up on https://issues.apache.org/jira/browse/OFBIZ-7918. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/

Re: Feedback on Committer Mentoring and HipChat

Hi All All good points Taher- thanks for detailing them in a clear way. I don't think HipChat should be a restricted to be opened on certain occasions - it is a tool, so should be available whenever anyone wants to use it. Not everyone can collaborate only on our Community Days. I really

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Scott, Thank you for the feedback. This is something I can work with. What I see now is the following: 1. compile-time dependency from order on marketing regarding the makeTrackingCodeOrders function 2. run-time dependencies from cmssite, ecommerce and webpos several other

Re: svn commit: r1757462 [1/4] - in /ofbiz/trunk/themes: flatgrey/webapp/flatgrey/ rainbowstone/webapp/rainbowstone/

On 24/08/2016 09:41, Jacques Le Roux wrote: Le 24/08/2016 à 09:23, Julien NICOLAS a écrit : Hi Jacques, I don't understand what to do if we had a new file type. I understand that something is wrong with the svn config but I don't know what. Simple, just add it, like I did for *.less at

Re: svn commit: r1757130 - in /ofbiz/trunk/applications: marketing/servicedef/ marketing/src/main/java/org/apache/ofbiz/marketing/tracking/ order/data/ order/src/main/java/org/apache/ofbiz/order/shopp

Hi Pierre, Jacopo, Jacques, Sticking specifically to the commit being discussed, the beauty of the tracking code logic is that it effectively does nothing if you aren't using it. Granted TrackingCodeEvents.makeTrackingCodeOrders() could do with being improved so that it exits earlier if no

Re: Feedback on Committer Mentoring and HipChat

I agree Taher, from so far feedbacks it seems it more the manner to use it which needs to be addressed. What about "opening it" only for 1. together working days 2. when we agree about quickly exchanging on a subject previously roughly explained on dev ML By "opening it" I mean we would have

Re: notsoserial on jcenter repo?

I agree with Taher: it better to push this library yourself (if no support is coming from the original providers) to the external repo and pull from there, than adding additional complexities in the build for just 1 library. The latter will have bigger consequences down the line. Having pushed

Re: svn commit: r1757462 [1/4] - in /ofbiz/trunk/themes: flatgrey/webapp/flatgrey/ rainbowstone/webapp/rainbowstone/

Thanks Pierre for the explanation, I never used it so thought it also provided storage. Jacques Le 24/08/2016 à 09:32, Pierre Smits a écrit : Please keep in mind that the OEM (https://oem.ofbizci.net/oci-2) is just a place to promote the components. That is why it lists both OFBiz controlled

Re: svn commit: r1757462 [1/4] - in /ofbiz/trunk/themes: flatgrey/webapp/flatgrey/ rainbowstone/webapp/rainbowstone/

Le 24/08/2016 à 09:23, Julien NICOLAS a écrit : Hi Jacques, I don't understand what to do if we had a new file type. I understand that something is wrong with the svn config but I don't know what. Simple, just add it, like I did for *.less at http://svn.apache.org/viewvc?rev=1757468=rev

Re: notsoserial on jcenter repo?

Hi Jacques, I would consider this to be the worst case scenario and no other solutions available. I would much rather pull this library from some remote location. So let's try to find a solution there first because adding the library this way adds a lot of complexity to both the build script,

Re: svn commit: r1757468 - /ofbiz/site/svn/config

Hi Committers, Please remember to update your svn config file Thanks Jacques Le 24/08/2016 à 09:27, jler...@apache.org a écrit : Author: jleroux Date: Wed Aug 24 07:27:38 2016 New Revision: 1757468 URL: http://svn.apache.org/viewvc?rev=1757468=rev Log: Adds the *.less type Generalizes

Re: svn commit: r1757462 [1/4] - in /ofbiz/trunk/themes: flatgrey/webapp/flatgrey/ rainbowstone/webapp/rainbowstone/

Please keep in mind that the OEM (https://oem.ofbizci.net/oci-2) is just a place to promote the components. That is why it lists both OFBiz controlled components and themes (in ASF SVN) and products that are controlled by others (and elsewhere, e.g. GitHub). It links through to the actual

Re: Feedback on Committer Mentoring and HipChat

Hello everyone, To put some context into this discussion please note the reason why we started hipchat in the first place is because of communication barriers. As we started the refactoring project many people were overwhelmed with the complexity of some of the tasks, and people needed to

Re: svn commit: r1757462 [1/4] - in /ofbiz/trunk/themes: flatgrey/webapp/flatgrey/ rainbowstone/webapp/rainbowstone/

Hi Jacques, I don't understand what to do if we had a new file type. I understand that something is wrong with the svn config but I don't know what. For the 4 colors, it is only because my customer order included 4 theme colors and when I push the theme in trunk, I keep them. I like the 4

Re: notsoserial on jcenter repo?

We did not get an answer yet, but Taher suggested another possibility: gradle-repositories-plugin on GitHub. It's not yet evaluated but could be a workaround, my only concern is stability in time... Jacques Le 22/08/2016 à 22:09, Jacques Le Roux a écrit : Hi Eirik, We have decided to use

Re: Feedback on Committer Mentoring and HipChat

Le 23/08/2016 à 11:16, Jacques Le Roux a écrit : I read recently that the infra team, which uses HipChat a lot for valuable reasons, was questioned about that by the board, because HipChat is delivered by Atlassian (only the free, minor version) and history is a concern. Sorry, I incorrectly